6 Commits (39f238431aab261baa3e6e2ea90389ee2f4f2994)

Author	SHA1	Message	Date
Alexander Lutay	567318c578	TT#106202 Add tty check for ngcpcfg 'read' calls ... On a Carrier cluster setup the command 'ngcpcfg clean --all' can be executed on several nodes in parallel (e.g. using ngcp-parallel-ssh). Which can get stuck on the yes/no question if the operator forgot to use '--force'. In practice it causes 100% CPU usage after several days due to logs rotation (reason is not 100% clear). Strace for such case: > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 The idea here is to check tty invocation and skip questions if no tty found. JFYI, there is no tty when running scripts under ngcp-parallel-ssh. Change-Id: Ia8ded3ada4d48ecb374f36859161645776381c31	5 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes ... shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: | not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] | not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] | not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: | # shellcheck source=etc/ngcp-config/ngcpcfg.cfg | # shellcheck source=functions/init | # shellcheck source=functions/logs | # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	6 years ago
Alexander Lutay	9b7ce2abf2	TT#44969 Extract git status check to common function (for further refactoring) ... 'git status' output has been changed in 2.9 which causes some troubles for us (we didn't change all the places, we missed ngcpcfg-ha.git repo, better to use common code in all the places). Change-Id: Ie664af89ee6d6b31fb3011e763107c41bf4cf00f	7 years ago
Michael Prokop	66f4772ec6	TT#37391 Fix minor typos ... s/successfuly/successfully/ s/retreive/retrieve/ Change-Id: I839a9c9c00b47f91b35e188c54b06ccd3cc3636c	8 years ago
Michael Prokop	a42248419e	TT#22411 Fix spelling mistakes/typos ... s/Syncronizes/Synchronizes/ s/Wheras/Whereas/ s/configuation/configuration/ s/exisiting/existing/ s/explicitely/explicitly/ s/files files/files/ s/has has/has/ s/initialise initialise/initialise/ s/mulitple/multiple/ s/ouput/output/ s/propogates/propagates/ s/successfull/successful/ s/syncronizes/synchronizes/ s/the the/the/ s/uncommited/uncommitted/ Change-Id: Id13ec889c5de620b675e357d99066688cfc97617	9 years ago
Alexander Lutay	7800af7b22	TT#12952 Add 'ngcpcfg clean' action to simplify cleanups ... It is hard to clean ngcpcfg framework for users with limited git knowledge, lets introduce action 'clean'. It should allows users easily reset to 'previous safe state' in the case 'if something went wrong'. Also remove old and unreliable error handling hint from manuals, as we have switched to fast-forward rebase long time ago. Change-Id: I961e681d55cac15ba8d772b9345c668218313bf4	9 years ago