158 Commits (241040ec7f1a8900b969b46d7cb3329cdf5f4928)

Author	SHA1	Message	Date
Michael Prokop	241040ec7f	TT#102912 Provide invocation name of ngcpcfg to subprocesses ... Instead of having to identify the parent process name (ngcpcfg vs. ngcp-config) inside subprocesses (like "status"), let's provide the invocation name through the main ngcpcfg binary via variable NGCPCFG_NAME. Thanks to Guillem Jover for the suggestion. Change-Id: Iafbac535bedb9cc9dc73f3d95861a5bc735cc739	4 years ago
ngcp-config	664ad7ddfe	TT#154852 build: inject instance_info to templates ... will provide a new instance_info variable with the all the content defined at network.yml for the instance removed intance_name since instance_info.name has the same value Change-Id: I349d0b430b59280bc383d46d5ba6a61f5d1f9046	4 years ago
Michael Prokop	3abb63eaac	TT#102912 status: report the name of the invoked binary ... When invoking `ngcp-config status`, we reported "ngcpcfg": | [sipwise-lab-trunk] sipwise@sp1:~$ sudo ngcpcfg status | 2021-12-09 17:30:08 sp1: Checking state of ngcpcfg: | 2021-12-09 17:30:08 sp1: OK: has been initialised already | [...] While what we should report instead is "ngcpcfg-config", like: | [sipwise-lab-trunk] sipwise@sp1:~$ sudo ngcp-config status | 2021-12-09 17:31:31 sp1: Checking state of ngcp-config: | 2021-12-09 17:31:31 sp1: OK: has been initialised already | [...] Change-Id: If8fc8076fdf1d214baea3c7388ab208947d66a05	4 years ago
Alexander Lutay	6dabc7a42c	TT#154105 Improve error output for 'ngcpcfg get' ... The previous error message was really confusing: > root@spce:~# ngcpcfg get /asdf > 2021-12-06 18:48:12 sp1: Error: Cannot process template '/tmp/tmp.RBRJg02PEz': > > file error - parse error - input file handle line 1: unexpected token (/asdf) > [% /asdf %] > 2021-12-06 18:48:12 sp1: Error: Generating /tmp/tmp.NKfB8BtJXv based on /tmp/tmp.RBRJg02PEz: FAILED It happens due to the way ngcpcfg using TT2 template which is trying to include the file it the string looks like a PATH. The new error message is more user friendly (and generates proper/non-zero exit code): > root@spce:~# ngcpcfg get /asdf > 2021-12-07 12:42:50 spce: Error: cannot process request for '/asdf'! > root@spce:~# echo $? > 1 > root@spce:~# Change-Id: Ifaf56dec07adf8600bd9d7cf2e733769d6d82a4f	4 years ago
ngcp-config	36c2cd5742	TT#139455 script/services: fix generate_list_to_process ... * expects values from CONFIG_POOL * append OUTPUT_DIRECTORY just when changing directory added at 83003649e3 Change-Id: I9c22bff70b58d4cfb49c3dab45330bccb898011e	4 years ago
ngcp-config	6ad43764ea	TT#139455 etckeeper: obey NGCPCTL_BASE ... Change-Id: I82fdde1f03a25409c330c83abe769dbd64149f04	4 years ago
Guillem Jover	e875197950	TT#142950 scripts: Fix options parsing ... Switch all code to use a loop to parse options so that these can parse multiple options (currently some scripts would simply parse one or another but not several), and to make them easier to extend. Change-Id: I5e902f2d7d8db78e66e48db1237924fa7d8fdda1	4 years ago
Victor Seva	83003649e3	TT#139455 support instances build ... we need to produce different output for each instance defined from the same source * helper/instances-info, produces the needed output to feed helper/tt2-process with the proper arguments to build instances files. We inject ``instance_name`` with the proper value to templates and INSTANCE_NAME to hooks environment * ${NGCPCTL_MAIN}/ngcpcfg.instances is where we define the supported instance templates and where the output path is * helper/tt2-process, add -r --replace <path:path> option in order to allow generation of different output from the same source Change-Id: I067266b5226485ea0d6c3bc3436275c5553a8177	4 years ago
ngcp-config	f7d9d812a4	TT#139455 don't chown configs if NGCP_TESTSUITE is set ... * create chown_config function and remove duplicate code Change-Id: I4996c1931cb53ec8120fa715ab0067b71ab8d5a8	4 years ago
Michael Prokop	3e8814205a	TT#82051 Shellcheck v0.8 fixes ... shellcheck v0.8 has new check, known as SC2295 ("Warn about "${x#$y}" treating $y as a pattern when not quoted"). Fixes: | In scripts/build line 117: | build_file="${build_file%%.${host}}" | ^-----^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns. | In scripts/encrypt line 24: | x=${file##${NGCPCTL_MAIN}/templates/} # drop leading /etc/ngcp-config | ^-------------^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns. ... as reported by our Github actions at https://github.com/sipwise/ngcpcfg Change-Id: I3371388ecf445905cca0bc4681276151aceb43ae	4 years ago
Alexander Lutay	d550799c1c	TT#139455 Improve patchtt error for missing tt2 template ... The previous error message was confusing: > root@web01a:~# ngcpcfg patch > 2021-10-20 14:21:29 web01a: Validating patch '/etc/ngcp-config/templates/etc/kamailio/lb_A/proxy/kamailio.conf.patchtt.tt2' > 2021-10-20 14:21:29 web01a: Error: Missing template for patch '/etc/ngcp-config/templates/etc/kamailio/lb_A/proxy/kamailio.conf.patchtt.tt2' > 2021-10-20 14:21:29 web01a: Error: Some operations above finished with an error for the file(s): > /etc/ngcp-config/templates/etc/kamailio/lb_A/proxy/kamailio.conf.patchtt.tt2 > root@web01a:~# The new version is: > root@web01a:~# ngcpcfg patch > 2021-10-20 14:26:45 web01a: Validating patch '/etc/ngcp-config/templates/etc/kamailio/lb_A/proxy/kamailio.conf.patchtt.tt2' > 2021-10-20 14:26:45 web01a: Error: Missing template '/etc/ngcp-config/templates/etc/kamailio/lb_A/proxy/kamailio.conf.tt2' > 2021-10-20 14:26:45 web01a: Error: for patch '/etc/ngcp-config/templates/etc/kamailio/lb_A/proxy/kamailio.conf.patchtt.tt2' > 2021-10-20 14:26:45 web01a: Error: Some operations above finished with an error for the file(s): > /etc/ngcp-config/templates/etc/kamailio/lb_A/proxy/kamailio.conf.patchtt.tt2 > root@web01a:~# Change-Id: I8979dc9dc545f8129ec69de71eef8cceab5fc337	4 years ago
Guillem Jover	6997e5a612	TT#146104 services: Always flush queues even when not running .services ... We need to flush the queues unconditionally regardless on whether we have executed .services files, otherwise the enqueued services during package upgrades might be left unattended for long periods of time in case no .services files got triggered due to modified configuration files. We flush all queues in case some enqueued service was left behind in the default queue. Change-Id: Iea8ab11fcb7e580cb8e160b8674e2dff3c9c85a0	4 years ago
Guillem Jover	ff5b523483	TT#142950 ngcpcfg: Make commit action update config file permissions ... We need to make sure the permissions for any config file are set correctly, otherwise on the next build action these will be updated, which might cause spurious commits just for these updates, that can end up generating rebase conflicts. Change-Id: I7c0f4cf13593da0d696ba25097b202e0b7a33674	4 years ago
Guillem Jover	93e84e054f	TT#142950 Centralize YAML file metadata initialization ... Instead of checking for the user, group and mode configuration knobs in various scripts (currently «build» and «set»), just make sure the variables have sane defaults when loading the «ngcpcfg.cfg» file. This also makes it possible to simplify the chown/chgrp calls into single chown calls. Change-Id: I1fcc06a7d311e4ebc4a96cc84ffae333be243c53	4 years ago
Guillem Jover	79ed4aa594	TT#142950 ngcpcfg: Use proper file metadata when creating config with set ... When we are creating a new file with set, for a known config.yml variation, we need to apply the correct owner/group and mode or the next build will modify them and that will change spurious commits that have no relation to the action being taken at the time. Change-Id: I93017cdcdcf22fa1c5ef8e103d215aa7bc110b9a	4 years ago
Mykola Malkov	589dedb674	TT#139151 Switch to use ngcp_hostname ... Use ngcp-hostname instead of using real hostname. Change-Id: Ia818f50e300e0f66762370eab331c7b7f1288d26	4 years ago
Victor Seva	cb2fe7406a	TT#126250 apply: fix error when called with no arguments ... introduced at commit eff9d4ae07 > ngcp-service: info: Action restart skipped, service kamailio-proxy is not for this role > 2021-08-17 14:59:18 lb01a: Synchronizing current with expected services state > /usr/share/ngcp-ngcpcfg/scripts//apply: line 56: $1: unbound variable Change-Id: I75a551327ecb42b7ff6a14a5206b85fb35e5f608	5 years ago
Guillem Jover	2e8c2833e3	TT#79100 services: Special case corosync/pacemaker handling ... Like we were doing with heartbeat-2 we need to special case corosync/pacemaker and force their services first thing, so that the HA system is ready by the time the rest of the services are handled. Change-Id: I3215aed2172436e61b6b33c4a4159c1c3f89bc24 Reported-by: Alex Lutay <alutay@sipwise.com>	5 years ago
Victor Seva	eff9d4ae07	TT#126250 Bypass 'apply' options into 'build' script ... It is necessary to allow bypassing '--ignore-shared-storage-check': > ngcpcfg apply --ignore-shared-storage-check Previously 'apply' options were not passing to 'build' script. * docs: - add all supported options in *apply* - move '--force-all-services' description to *services* and add it in the list of options Change-Id: I091142d1f74b7b9e09ce94b963ff4bf9dfaa8db7	5 years ago
Alexander Lutay	1b339d2717	Revert "TT#126250 Bypass 'apply' options into 'build' script" ... It brakes trunk, we have to reconsider implementation here. This reverts commit 41c722a183. Change-Id: I319c9a9568e250d939864a4c2b9c2a3cdec145e7	5 years ago
Alexander Lutay	41c722a183	TT#126250 Bypass 'apply' options into 'build' script ... It is necessary to allow bypassing '--ignore-shared-storage-check': > ngcpcfg apply --ignore-shared-storage-check Previously 'apply' options were not passing to 'build' script. Change-Id: Ia01558b05920e6aec10c8206a3747c828b237fc9	5 years ago
Mykola Malkov	eb4eca2e2c	TT#123200 Simplify check of remote origin of ngcp-config ... Previously we had quite complicated schema of origin urls on Pro/Carrier mgmt/Carrier non-mgmt nodes: Pro, both sp1 and sp2 - local /mnt/glusterfs/ngcpcfg-share directory. Carrier mgmt nodes, web01a/web01b - local /mnt/glusterfs/ngcpcfg-share directory. Carrier other nodes - web01:/mnt/glusterfs/ngcpcfg-share. There is no sense in such a complication so it was changed to use ${mgmt}:/mnt/glusterfs/ngcpcfg-share for all installation types and nodes. Change-Id: If84f70da51739a89763fb54091faaab9e15ffc9c	5 years ago
Victor Seva	24098da128	TT#83358 status: add test ... * bin/ngcpcfg: SKIP_RESTORE_PERMS so we can skip that on tests * scripts/status: use NGCPCTL_BASE and NGCPCTL_MAIN so it would work in test environment Change-Id: I8ba80bbb2ea3adf1b8cc2a4229568a87f9508cbd	5 years ago
Michael Prokop	0ce3b7b110	TT#120901 Support ShellCheck v7.0.2 with new SC2260 check ... SC2259/SC2260 were added in ShellCheck v7.0.2 ("Warn when redirections override pipes") Fixes: | In scripts/commit line 91: | ngcp-sync-constants >/dev/null | sed "s/^/$timestamp_replacementchars/" | ^-- SC2260: This redirection overrides the output pipe. Use 'tee' to output to both. While at it, fix incomplete log_debug regarding no-db-sync, thanks Alexander Lutay <alutay@sipwise.com> for spotting. Change-Id: I92e5ce73dc000a52fa7c5c79f710d87cec292908	5 years ago
Alexander Lutay	567318c578	TT#106202 Add tty check for ngcpcfg 'read' calls ... On a Carrier cluster setup the command 'ngcpcfg clean --all' can be executed on several nodes in parallel (e.g. using ngcp-parallel-ssh). Which can get stuck on the yes/no question if the operator forgot to use '--force'. In practice it causes 100% CPU usage after several days due to logs rotation (reason is not 100% clear). Strace for such case: > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 > select(1, [0], NULL, [0], {tv_sec=0, tv_usec=0}) = 1 (in [0], left {tv_sec=0, tv_usec=0}) > rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0 > rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0 > ioctl(0, TCGETS, 0x7fff317e39a0) = -1 ENOTTY (Inappropriate ioctl for device) > lseek(0, 0, SEEK_CUR) = -1 ESPIPE (Illegal seek) > read(0, "", 1) = 0 The idea here is to check tty invocation and skip questions if no tty found. JFYI, there is no tty when running scripts under ngcp-parallel-ssh. Change-Id: Ia8ded3ada4d48ecb374f36859161645776381c31	5 years ago
Alexander Lutay	45de0f4e8a	TT#120752 Fix b821e00: allow 'ngcpcfg edit /path/real_file.yml' ... The commit addresses those issues: > root@spce:~# ngcpcfg edit /etc/ngcp-config/config.yml > Error: Unknown choice '/etc/ngcp-config/config.yml'. Aborting. > > root@spce:~# ngcpcfg edit /etc/ngcp-config/config.yml.factory_default > Error: Unknown choice '/etc/ngcp-config/config.yml.factory_default'. Aborting. > > root@spce:~# Also fixed typo in error message. Change-Id: I2dbf1667ace5eb481b47cf63224a53b5586b4bf0	5 years ago
Alexander Lutay	6a733861b0	TT#120752 Fix b821e00: move main function load close to validation ... It produces no functional changes but align code better with Sipwise/ngcpcfg style. We normally check the file availability and load the file the next line. Change-Id: Ifebddc452f7701fd02a85a8d3273edc89b7fd21a	5 years ago
Alexander Lutay	b821e0052b	TT#120752 Add 'ngcpcfg edit' to speedup YML editing ... Normally it is necessary to press TAB multiple times, e.g: > vim /etc/ngcp-conf<TAB>/con<TAB>f<TAB>... For new NGCP users it is even longer. In the same time we have a nice usability experience for ngcp-ppa, where users are just pressing "ngcp-ppa<ENTER>1<ENTER>1<ENTER>". Let's add the same concept here as the order of the main files is static: > 1) /etc/ngcp-config/config.yml > 2) /etc/ngcp-config/network.yml > 3) /etc/ngcp-config/constants.yml if I need to edit network.yml I will type: > ngcpc<TAB> e<TAB><ENTER>2<ENTER> or even: > ngcpc<TAB> e<TAB>2<ENTER> Change-Id: Id20fec8c931c15c73a73689a3f8b552a72ef11f7	5 years ago
Michael Prokop	fbbe998e98	TT#119602 Properly handle trap also in case of errors in functions ... Quoting from "man bash" about `-E` (AKA errtrace): | If set, any trap on ERR is inherited by shell functions, command | substitutions, and commands executed in a subshell environment. | The ERR trap is normally not inherited in such cases. To demonstrate the problem see this short shell script: | % cat foo | set -eu -o pipefail | | bailout() { | echo "Bailing out because of error" >&2 | exit 1 | } | trap bailout 1 2 3 6 9 14 15 ERR | | foo() { | echo "Executing magic" | magic | } | | foo | echo end If "magic" can't be executed, then this fails as follows: | % bash ./foo | Executing magic | ./foo: line 11: magic: command not found But it doesn't invoke the bailout function via trap. When using `set -eE` (AKA errexit + errtrace), instead of only `set -e` (errexit), then it behaves as expected though: | % bash ./foo | Executing magic | ./foo: line 11: magic: command not found | Bailing out because of error Change-Id: I9f05355716551cd8fc8f22bd2fa16bbc9d0b7247	5 years ago
Manuel Montecelo	5bc669a61e	TT#80164 Remove extra '}' at the end of debug message ... Change-Id: I0c09d5ea02220d352629842df92ea13cca6a73b1	5 years ago
Michael Prokop	090e42210b	TT#111254 Fix typo in docs + patch usage information (cusomtt->customtt) ... Change-Id: Iad9081d9e3bd257fc7617ad2982aa98203ba5e29	5 years ago
Alexander Lutay	cdfb5a8f3d	TT#106202 Update Shell code style for scripts/decrypt ... Change-Id: Iaf5f071919a5e181ac34182fd10bf9668dc10279	5 years ago
Alexander Lutay	eee0a9c18c	TT#106202 Remove shellcheck mute for warning [SC2086] in 'scripts/encrypt' ... > warning shellcheck:note Double quote to prevent globbing and word splitting. [SC2086] Also tuned Shell Code Style. Change-Id: I3a726938f67b2c7f96b1de97b1eabd5b7043e52a	5 years ago
Alexander Lutay	055ec2f767	TT#106202 Remove unused variable $RC ... Change-Id: I9865a014cbbc9cb8b7e87ef9a1ce3376cf5504c6	5 years ago
Guillem Jover	4e67890f1f	TT#81050 Fix precedence of HA_CONFIG and PAIR_CONFIG config.yml variants ... To get uniform and unexpected behavior we should use the exact same precedence used with the tt2 files. Fixes: commit 354e7578c5 Change-Id: I86281f3bd236687baec58b3a2e29cf80550176da	6 years ago
Michael Prokop	2088c32977	TT#82051 shellcheck fix for console_output() to expand escape sequences ... We are using console_output() from within log_info(), which is invoking `console_output "$*\n"`, so we need to expand the escape sequences (without interpreting other format specifiers), which is exactly what "%b" provides in bash. This is a fixup for previous commit 0dda93ad97 Change-Id: I16f354eb35e13568331e5107aff0d1c80dafb822	6 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes ... shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: | not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] | not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] | not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: | # shellcheck source=etc/ngcp-config/ngcpcfg.cfg | # shellcheck source=functions/init | # shellcheck source=functions/logs | # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	6 years ago
Guillem Jover	354e7578c5	TT#81050 Add HA_CONFIG and PAIR_CONFIG support ... This makes it possible to use more specific config.yml files either for a pair of nodes, for settings that will always affect both, or for the HA names, for settings that might affect all A or B nodes. This matches the support in the template files. We need to move sourcing the ha_features and carrier_features before sourcing init, as now the ngcpcfg.cfg file can use these variables if set. Change-Id: Ic6b32acceb8f020f48c3afa09d9e84252b3531e7	6 years ago
Guillem Jover	4bdc9f57df	TT#81051 Use environment variables instead of absolute pathnames ... We should use the environment variables, so that we can support the configured pathnames. Change-Id: Ifc94e83a74c0edfeaaeac0f2d16c55d3dfca179e	6 years ago
Alexander Lutay	35f0be2284	TT#78170 Fix option/value parsing for 'ngcpcfg set' in case if value has sign = ... We have to separate option/value using the first equal sign. Change-Id: I87a6fc11a1edd6beb3ec0ee819828557aa06ea17	6 years ago
Guillem Jover	18edbf9718	TT#71950 Fix typos ... Change-Id: Ia42bc5d06992097ab077bc908837b3f04516ce62	6 years ago
Guillem Jover	ec70d8e387	TT#71952 tt2-process: Add new option to expect <input> <output> argument pairs ... This is needed for the get command, so that we can exactly control where to output to, and avoid all the file generation heuristics based on the input files. Change-Id: Iace05d1093342722553ec0bbb8ff0e817f77857c	6 years ago
Guillem Jover	011ce33f32	TT#71952 Rewrite template file list generation in perl ... The current shell code is very inefficient, as it uses files to track the file lists, and grep to traverse them NxM times per N files. Change-Id: I8396b4ee232157cea8ef599cba0618be3dd93536	6 years ago
Guillem Jover	f03f5c7b9f	TT#71952 Run tt2-process under nice + ionice ... As we now run the processing in parallel, we should not take CPU time from other more important tasks in the system. Change-Id: Ifcfdbc6838a377c00025b4ddb30d4ccfbd1dc548	6 years ago
Guillem Jover	a9166843c2	TT#71952 Parallelize templated output generation ... Switch away from the old daemon/wrapper architecture, which complicates things and requires more scaffolding code. We turn the daemon/wrapper and build_config into a single perl process that will load all YAML files, and then process each input/output pair on a parallel child, to try to speed up the processing as much as possible. For whole rebuilds, it might speed up the generation by at least a factor of x2, x4 or more, depending on the number of active processors. Change-Id: I51aa2f90336e34a20983d8733f45b64d9b6fea0b	6 years ago
Guillem Jover	2665215e64	TT#51701 Switch from deprecated /var/run to /run ... Change-Id: I657b18e6f064d93eeb53d8ab28976b4f647b95d7	6 years ago
Alexander Lutay	36a11888d6	TT#68710 Rename 'ngcpcfg values' to 'ngcpcfg get' ... It was a widely popular question from users. As the common sense pushes them to use 'get' when they use 'set/del'. Let's follow the common logic here. We still support old 'ngcpcfg values' syntax. Change-Id: I40a210b7c13d21a4bff4b6988535c39091f53280	6 years ago
Alexander Lutay	ead10ac2ad	TT#65907 Speedup 'ngcpcfg apply' on 1.5 seconds (re-use the same tmp file) ... In the past helper/build_config generated new tmp file for every call and we called it for hundred+ times. Let's generate it once and pass to helper/build_config to be reused every time. Command: time ngcpcfg apply "test" Old code: real 0m17.194s New code: real 0m15.477s Change-Id: Ic1c35ccb5c5f92ddee6328502194a5301123bd9d	6 years ago
Alexander Lutay	e9b980fada	TT#65907 Remove confusing 'RC' variable from scripts/build ('set -e' in use) ... We do abort building on the first broken file due to 'set -e' above. Having $RC variable here which collects exit code is very confusing. Change-Id: I415bc77d8becf317c1be6b5ac493be2583479e00	6 years ago
Alexander Lutay	f4e5c0b645	TT#65907 Write ngcpcfg PID into ngcpcfg.log file ... It should simplify debug when two ngcpcfg executed in parallel. Change-Id: I5fa77bfe9419c3cff798eaefbdb02f159b7b63c9	6 years ago