ngcpcfg

Commit Graph

Author	SHA1	Message	Date
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... \|\| exit' or 'cd ... \|\| return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: \| not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] \| not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] \| not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: \| # shellcheck source=etc/ngcp-config/ngcpcfg.cfg \| # shellcheck source=functions/init \| # shellcheck source=functions/logs \| # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	6 years ago
Guillem Jover	b789568b73	MT#17219 Use $@ instead of $* when we need to preserve argument grouping Using $* in some of these places implies losing data about what constituted a single argument. Change-Id: Ic072e68320d65ac86392c31d7665529b913232fd	10 years ago
Alexander Lutay	e8f7ce894e	MT#15803 Add ngcpcfg log/show scripts to improve usability Change-Id: I56f3c6d6cb5187ac471e0ae05ff313f24803fc1c	10 years ago

Author

SHA1

Message

Date

Michael Prokop

0dda93ad97

TT#82051 Shellcheck fixes

shellcheck v0.7.1 complains about a bunch of issues:

SC1083: This { is literal. Check expression (missing ;/\n?) or quote it.
SC1083: This } is literal. Check expression (missing ;/\n?) or quote it.
SC1090: Can't follow non-constant source. Use a directive to specify location.
SC2034: foo appears unused. Verify it or export it.
SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo".
SC2128: Expanding an array without an index only gives the first element.
SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
SC2155: Declare and assign separately to avoid masking return values.
SC2162: read without -r will mangle backslashes.
SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
SC2237: Use [ -z .. ] instead of ! [ -n .. ].

We're still bound to support shellcheck v0.3.4 and sadly this version
fails hard when using the modern "shellcheck source=" directives to
address SC1090 and SC1091. It's failing like:

| not ok 1        source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009]
| not ok 2        source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073]
| not ok 3        source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072]

So until we can get rid of supporting this ancient shellcheck version,
instead of using:

| # shellcheck source=etc/ngcp-config/ngcpcfg.cfg
| # shellcheck source=functions/init
| # shellcheck source=functions/logs
| # shellcheck source=functions/main

we need to place disable=SC1090 and disable=SC1091 accordingly.

Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e

Guillem Jover

b789568b73

MT#17219 Use $@ instead of $* when we need to preserve argument grouping

Using $* in some of these places implies losing data about what
constituted a single argument.

Change-Id: Ic072e68320d65ac86392c31d7665529b913232fd

Alexander Lutay

e8f7ce894e

MT#15803 Add ngcpcfg log/show scripts to improve usability

Change-Id: I56f3c6d6cb5187ac471e0ae05ff313f24803fc1c

3 Commits (240b32ef0b085b284ed6e258564994d73ecdfdfe)