ngcpcfg

Commit Graph

Author	SHA1	Message	Date
ngcp-config	6ad43764ea	TT#139455 etckeeper: obey NGCPCTL_BASE Change-Id: I82fdde1f03a25409c330c83abe769dbd64149f04	4 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... \|\| exit' or 'cd ... \|\| return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: \| not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] \| not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] \| not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: \| # shellcheck source=etc/ngcp-config/ngcpcfg.cfg \| # shellcheck source=functions/init \| # shellcheck source=functions/logs \| # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	6 years ago
Alexander Lutay	9b7ce2abf2	TT#44969 Extract git status check to common function (for further refactoring) 'git status' output has been changed in 2.9 which causes some troubles for us (we didn't change all the places, we missed ngcpcfg-ha.git repo, better to use common code in all the places). Change-Id: Ie664af89ee6d6b31fb3011e763107c41bf4cf00f	7 years ago
Michael Prokop	bd9bf75e4a	TT#11776 Support git v2.9.3 and newer When installing Debian/stretch we fail at this stage: \| ngcpcfg --no-db-sync commit On first glance it looks like a mariadb issue, though actually it's the git status check inside ngcpcfg that's failing. The reason is that starting with git v2.9.3 there's a different output in its "status" output: \| commit 2a0e6cdedab306eccbd297c051035c13d0266343 \| Author: Lars Vogel <lars.vogel@gmail.com> \| Date: Thu Jun 9 20:19:30 2016 +0200 \| \| Use "working tree" instead of "working directory" for git status \| \| Working directory can be easily confused with the current directory. \| In one of my patches I already updated the usage of working directory \| with working tree for the man page but I noticed that git status also \| uses this incorrect term. \| \| Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> \| Signed-off-by: Junio C Hamano <gitster@pobox.com> In Debian/stretch we've 2.11.0-2 and are affected by this change. Adjust the `git status` checks accordingly to support git in all its versions. NOTE: we should consider switching to `git status --porcelain` (see git commit `fc5af3bbb2` for some history about it) once we've the testsuite in place. Change-Id: If4223a35083d279e746dce5a80bcb86b52f64025	9 years ago
Victor Seva	eac494cb42	MT#14229 clean shellcheck warnings While at it spread support for testsuite Change-Id: I60c4dae5479827b0d28ffa135105d9dbdf603825	10 years ago
Michael Prokop	2deea0fb39	MT#9557 Provide timestamps in console output Change-Id: I5be915fa876014cbb9c792b03be325d6595daac9	11 years ago
Michael Prokop	3436c08361	Initial checkin	13 years ago

7 Commits (240b32ef0b085b284ed6e258564994d73ecdfdfe)