5 Commits (240b32ef0b085b284ed6e258564994d73ecdfdfe)

Author	SHA1	Message	Date
Guillem Jover	55d8353873	TT#177600 Move ngcpcfg specific configuration under /etc/ngcp-ngcpcfg ... The configuration files specific to the ngcpcfg tool should not be mixed with the site specific configuration, as that's rather confusing, more so when the actual ngcpcfg configuration contains references to the location of the ngcp-config dir itself, which makes it self-referential. Change-Id: I93f59e2ce3441c2c315956f68e22e4b2e9c839ac	4 years ago
Guillem Jover	93e84e054f	TT#142950 Centralize YAML file metadata initialization ... Instead of checking for the user, group and mode configuration knobs in various scripts (currently «build» and «set»), just make sure the variables have sane defaults when loading the «ngcpcfg.cfg» file. This also makes it possible to simplify the chown/chgrp calls into single chown calls. Change-Id: I1fcc06a7d311e4ebc4a96cc84ffae333be243c53	4 years ago
Mykola Malkov	589dedb674	TT#139151 Switch to use ngcp_hostname ... Use ngcp-hostname instead of using real hostname. Change-Id: Ia818f50e300e0f66762370eab331c7b7f1288d26	4 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes ... shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: | not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] | not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] | not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: | # shellcheck source=etc/ngcp-config/ngcpcfg.cfg | # shellcheck source=functions/init | # shellcheck source=functions/logs | # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	6 years ago
Alexander Lutay	8209a5a136	TT#65907 Speedup 'ngcpcfg build' on 20% percent (when we build all files) ... About 50% of previous helper/build_config execution was loading 'functions/main' and we were performing it again and again for every tt2 files we build and we have more then hundred files in ngcpcfg. In fact we need two env variables and logging functions. Let's extract them into the separate function file and load them only. Command: time ngcpcfg build Original results: real 0m27.766s Current results: real 0m19.976s Change-Id: I6896ac437b1548888db7702de92b0ec79ed9d03f	6 years ago