10 Commits (1a9d71268d22348239fd4ce542ac8a4eff00583d)

Author	SHA1	Message	Date
Guillem Jover	0bc0550138	TT#47373 Cleanups for global permissions fix ... - Remove a spurious trailing ';'. - Make the hook directory reaction conditional on whether we are running from within a testsuite, to restore its otherwise fatal treatment. Change-Id: I3f8a5364d7b2f0ac82bfdc132b94641603225f85 Fixes: commit 505d6566d8	8 years ago
Guillem Jover	b2c87aa4a9	TT#47373 Remove path hardcoding for hooks handling ... When running the test suite, in case we need to cover the code paths that are handling the hooks, we should not assume the files are installed in the system directories. Change-Id: I1cd09eaf186d28093eb03ad5e9fc096fe7d63a3e	8 years ago
Manuel Montecelo	f6596cc9cf	TT#47255 Add comprehensive test of network config for /etc/network/interfaces ... Since we manage this as a template, the configuration is getting more and more complex and it's important to have comprehensive tests that help us to detect problems when we add options and change templates. Change-Id: Ieff8449f3d6d1cd74a9b44d49e1642a1bf02efc2	8 years ago
Manuel Montecelo	a529f8e0b0	TT#46601 Detect and report errors parsing tt2 templates ... Due to the code in tt2-wrapper, the only errors reported were failures to connect to the socket to use the back-end performing the parsing. But there was no attempt to detect errors in the parsing at all. Since we are only able to use the output stream and not for example exit codes of the parser at the back-end (libtemplate-perl), we can only rely on finding some kind of error string, which can change in future versions of libtemplate-perl but hopefully not very often, and at most it should only change when we move base to newer Debian releases. In the case of the original problem reported we could rely on "parse error", but since there are two such strings ("file error" and "parse error") the first is more general and also covers cases like "permission denied to read file" or other errors that might happen. So the implementation of error checking is basically grepping for "^file error", the string at the beginning of a line, to limit possible false positives. With the new checks and an example of an invalid syntax already in the first line, "ngcpcfg build" detects the error correctly and stops processing, and shows information about the source of the problem, e.g.: root@spce:~# ngcpcfg build /etc/test 2018-10-29 11:37:01 spce: yml configs were validated successfuly 2018-10-29 11:37:01 spce: configs were checked successfuly 2018-10-29 11:37:01 spce: No patchtt files found, nothing to patch. Loading /etc/ngcp-config/config.yml in memory: OK Loading /etc/ngcp-config/network.yml in memory: OK Loading /etc/ngcp-config/constants.yml in memory: OK 2018-10-29 11:37:02 spce: Error: Generating /etc/test based on /etc/ngcp-config/templates//etc/test.customtt.tt2: FAILED 2018-10-29 11:37:02 spce: Error: from generated file: 2018-10-29 11:37:02 spce: Error: file error - parse error - input file handle line 1: unexpected end of directive 2018-10-29 11:37:02 spce: NOTE: Check those files for valid syntax and encoding: 2018-10-29 11:37:02 spce: /etc/ngcp-config/templates//etc/test.customtt.tt2 2018-10-29 11:37:02 spce: /etc/ngcp-config/config.yml 2018-10-29 11:37:02 spce: /etc/ngcp-config/network.yml 2018-10-29 11:37:02 spce: /etc/ngcp-config/constants.yml 2018-10-29 11:37:02 spce: Running /usr/share/ngcp-ngcpcfg/helper/tt2-wrapper <file> 2018-10-29 11:37:02 spce: or inspecting temporary /tmp/ngcpcfg.test.PwGvShIm9G 2018-10-29 11:37:02 spce: should provide more details. Change-Id: Ic305bdab20a6ce15eca13f19586a2572a90b4e13	8 years ago
Guillem Jover	696ac4c247	TT#38200 Add support for new NGCP::Template perl module ... The perl Template::Toolkit is very rich, but its "function" support is a bit poor. The ways to do it are either via MACRO directives, or by simulating them with one function per file and then using PROCESS on these. The problem is that this is very clunky, does not support nesting, as we'd need different "argument" names for each "function", and it's quite cumbersome to use, need to assign aguments passed beforehand, and then assign back a designated return value from another variable. This is also one of the reasons some of the functions are not encapsulated, and have been inlined in various loops, because it was not possible to cleanly PROCESS them from those call sites. Instead we should use its native support for perl objects and perl subroutines, which exposes these as proper methods of a designated variable, and have none of the above mentioned problems. So we'll switch from constructs such as: argv.arg-a = variable; argv.arg-b = 'value'; PROCESS 'path-to-library-dir/function' result = out into: result = ngcp.function(variable, 'value'); In addition this might actually be faster, as it does not require processing additional files, and it's all just native perl code. This will be exposed within the NGCP templates as the ngcp object, and new member functions will start replacing our old and clunky native Template PROCESS-style library. Change-Id: Id2f0d181c695a9dd074646881b7d9de3478570af	8 years ago
Guillem Jover	50ecc15441	TT#37401 Use Unix sockets to avoid relying on hostnames for localhost/loopback ... If the file /etc/hosts gets handled by templates, as ongoing changes attempt to do, there's a problem because /etc/hosts gets truncated to create a new file when it's needed to generate itself, to resolve the "localhost" string as hostname, so the generation fails and /etc/hosts gets empty at that point, affecting the system until restored. The simplest way to break that cycle is to switch to Unix sockets. Change-Id: I1e33ead6a134625346b9cf1beb09a7bdbfdfc8d2	8 years ago
Michael Prokop	1b65ad2072	TT#26206 Provide tests for 'ngcpcfg patch' action ... By setting variables like CONFIG_POOL and TEMPLATE_POOL_BASE we can generate templates on-the-fly, without having to provide any static files as fixtures. Modify t/fixtures/*.cfg accordingly, by checking if a variable is set already (via any tests) and only if it's unset set a default. Change-Id: Ia156447bca368b19e62e94eee81c3949f00aa39a	8 years ago
Victor Seva	e4f08fb0bc	TT#16316 lib: add status param ... * ['online', 'inactive'] as default * introduced in order to be able to filter values at templates so we have the ability to install new nodes without impacting the working system Change-Id: I78739f66f80da310347861e86b682fcf72745080	9 years ago
Victor Seva	e0e63ac6e5	TT#17653 helper/tt2-daemon: support NGCP_BASE_TT2 env config ... * allows to test lib/ in a fake environment * add test for lib/lib_get_all_ips Change-Id: I872dcd835b73206070298a821201502c0cf7f82f	9 years ago
Michael Prokop	acfa825767	MT#16391 Initial tests using pytest ... The old testsuite wasn't updated for way too long and since ngcpcfg receives more and more features we need a decent test coverage. pytest seems to provide the right level of abstraction, excellent fixtures and junit-xml reporting as needed. Inspired by Vincent Bernat's https://github.com/vincentbernat/lldpd/tree/master/tests/integration Thanks Victor Seva <vseva@sipwise.com>, Vincent Bernat <vincent@bernat.im>, Christian Hofstaedtler <christian@hofstaedtler.name> and Lukas Prokop <admin@lukas-prokop.at> for feedback, inspiration and help Change-Id: Iffed87e8cc540169bed89c00967a03e80859179e	9 years ago