6 Commits (1054cb4d74dfd43912a4fe7fc64c7e19f0253069)

Author	SHA1	Message	Date
Alexander Lutay	3b3c4a1f1a	TT#63758 TT#55162 Fix tests after migration to group 'ngcp-admin' ... The commit 92dccb4b10 introduced new group 'ngcp-admin' and forced ngcpcfg to set proper perms every time we call ngcpcfg. One of the tests starts failing right after the commit above, but we didn't notice it until we add error message (the following commit). Wihtout the fix here ngcpcfg doesn't pass tests: > test_ngcpcfg_build_network_interfaces.py::test_network_interfaces FAILED > ... > stderr: > b"../scripts//build: line 174: CONFIG_GROUP: unbound variable > 2019-10-01 15:41:35 b22fa4d1cbb9: Error: Failed to call action 'build' on 'b22fa4d1cbb9' (see logs on 'b22fa4d1cbb9') Change-Id: Ia514a7e275aef25d01bdaedf71ef7879e84dd8ba	7 years ago
Guillem Jover	0bc0550138	TT#47373 Cleanups for global permissions fix ... - Remove a spurious trailing ';'. - Make the hook directory reaction conditional on whether we are running from within a testsuite, to restore its otherwise fatal treatment. Change-Id: I3f8a5364d7b2f0ac82bfdc132b94641603225f85 Fixes: commit 505d6566d8	8 years ago
Guillem Jover	b2c87aa4a9	TT#47373 Remove path hardcoding for hooks handling ... When running the test suite, in case we need to cover the code paths that are handling the hooks, we should not assume the files are installed in the system directories. Change-Id: I1cd09eaf186d28093eb03ad5e9fc096fe7d63a3e	8 years ago
Guillem Jover	696ac4c247	TT#38200 Add support for new NGCP::Template perl module ... The perl Template::Toolkit is very rich, but its "function" support is a bit poor. The ways to do it are either via MACRO directives, or by simulating them with one function per file and then using PROCESS on these. The problem is that this is very clunky, does not support nesting, as we'd need different "argument" names for each "function", and it's quite cumbersome to use, need to assign aguments passed beforehand, and then assign back a designated return value from another variable. This is also one of the reasons some of the functions are not encapsulated, and have been inlined in various loops, because it was not possible to cleanly PROCESS them from those call sites. Instead we should use its native support for perl objects and perl subroutines, which exposes these as proper methods of a designated variable, and have none of the above mentioned problems. So we'll switch from constructs such as: argv.arg-a = variable; argv.arg-b = 'value'; PROCESS 'path-to-library-dir/function' result = out into: result = ngcp.function(variable, 'value'); In addition this might actually be faster, as it does not require processing additional files, and it's all just native perl code. This will be exposed within the NGCP templates as the ngcp object, and new member functions will start replacing our old and clunky native Template PROCESS-style library. Change-Id: Id2f0d181c695a9dd074646881b7d9de3478570af	8 years ago
Guillem Jover	50ecc15441	TT#37401 Use Unix sockets to avoid relying on hostnames for localhost/loopback ... If the file /etc/hosts gets handled by templates, as ongoing changes attempt to do, there's a problem because /etc/hosts gets truncated to create a new file when it's needed to generate itself, to resolve the "localhost" string as hostname, so the generation fails and /etc/hosts gets empty at that point, affecting the system until restored. The simplest way to break that cycle is to switch to Unix sockets. Change-Id: I1e33ead6a134625346b9cf1beb09a7bdbfdfc8d2	8 years ago
Michael Prokop	acfa825767	MT#16391 Initial tests using pytest ... The old testsuite wasn't updated for way too long and since ngcpcfg receives more and more features we need a decent test coverage. pytest seems to provide the right level of abstraction, excellent fixtures and junit-xml reporting as needed. Inspired by Vincent Bernat's https://github.com/vincentbernat/lldpd/tree/master/tests/integration Thanks Victor Seva <vseva@sipwise.com>, Vincent Bernat <vincent@bernat.im>, Christian Hofstaedtler <christian@hofstaedtler.name> and Lukas Prokop <admin@lukas-prokop.at> for feedback, inspiration and help Change-Id: Iffed87e8cc540169bed89c00967a03e80859179e	9 years ago