15 Commits (1054cb4d74dfd43912a4fe7fc64c7e19f0253069)

Author	SHA1	Message	Date
Guillem Jover	e74318ddb4	TT#47820 Fix has_role handling ... The li match was triggering for all wildcards and when li mode was not enabled in some way then we were getting negative results. The proper way to solve the original problem is to relegate the matching of the li modes to the end, so that we can properly match on wildcards and not interfere with other roles. Change-Id: I7cb559a8dc10e8a832c2e2bcd78f1effc1cc101a Fixes: commit 236b56d990	8 years ago
Guillem Jover	769ef925e4	TT#37257 NGCP::Template::Object: Add new ngcp.get_ssh_pub_key function ... To be able to generate an authorized_keys file from templates we need to fetch the public ssh keys for the root user. This function will make this task easier. Change-Id: If8edef0e77a5f3c1167fe8dfd0e92e4d9e468a6a	8 years ago
Guillem Jover	236b56d990	TT#43306 NGCP::Template::Object: Only match li_dist exactly ... This partially reverts commit bc8ae9e795. We should not match li_dist with regexes as then we would trap cases that we should not be covering by the li_dist mapping logic. Just do exact matches. This also fixes the hypothetical case with other regexes that are not the wrongly specified '*'. Change-Id: I9d9d850969e03fa9dc587f2d47a688bc0359e63c	8 years ago
Alexander Lutay	bc8ae9e795	TT#43306 Workaround argv.role='*' case in ngcp.has_role() ... Otherwise it matches on 'li/li_dist' cases and the library get_all_ips returns no IPs if called like: > argv.role='*'; > argv.type='*'; > PROCESS '/usr/lib/ngcp-ngcpcfg/get_all_ips'; > all_ips = out; This is a hotfix commit for backporting into mr6.4.1 while the "proper" fix should be re-considered and committed for mr6.5+ P.S we have 3 tt2 templates where we have * in argv parameters. P.P.S. The code is from Andreas, tnx for the fix! Change-Id: I119a687389075d2ebdcd824ed457f768b5fb2123	8 years ago
Guillem Jover	ae25a37bad	TT#38200 Add support for virtual LI distributed role ... This adds an additional virtual li_dist role on top of the existing li role. The difference is that li is the cluster simpli acting in central mode, while li_dist is the cluster acting in distributed mode. Change-Id: I930c93380a0e88649c325b7faf3c0fb86d78e5ff	8 years ago
Guillem Jover	a333076038	TT#38200 Fix NGCP::Template to accept configuration as a list of elements ... The Template class accepts both a hash reference and a hash to get the configuration arguments. And the Dancer framework passes those as a hash. Change-Id: Ic9ae758bd81a2bb3108900e6f92ad91ad88f3cc9	8 years ago
Guillem Jover	c027cfa199	TT#38200 Make the NGCP::Template a derived class of Template ... Move the ngcp object variable into NGCP::Template::Object, and make NGCP::Template just a customized variant of Template that we can use instead. This way we hide all the internal details of how to set up the environment we need to process NGCP templates. Change-Id: I690cf1a74551f4751380a506ddcc047b0942ba21	8 years ago
Guillem Jover	b4627d33ed	TT#38200 Switch to new perl ngcp.get_mgmt_*() functions ... Change-Id: I17664094c6575c0b3a0229233dc5448e9b90659f	8 years ago
Guillem Jover	24f692344e	TT#38200 Switch to new perl ngcp.get_hostname() function ... Change-Id: I87ca33c497e9a474abb1d57447369f74db1e7da1	8 years ago
Guillem Jover	5d35213a3a	TT#38200 Switch to new perl ngcp.get_firstname() function ... Change-Id: I0802fa8988d7bf84a1ca8caa3770e86d69ba079a	8 years ago
Guillem Jover	1ecd9f92ac	TT#38200 Switch to new perl ngcp.get_peername() function ... Change-Id: I4a669b22484c3b990ad0fc812201cd424226a96f	8 years ago
Guillem Jover	1c5e435a1e	TT#38200 Switch to new perl ngcp.get_nodename() function ... This is another good candidate to replace with a proper ngcp method, as the function is already implemented as a PERL block, and the most used "function". Change-Id: I49dc638a197a0215ea65c0a60c82c6c556aca3fa	8 years ago
Guillem Jover	711d2321ba	TT#38200 Switch to new perl ngcp.has_role function ... This replaces the old has_role Template "function" with a proper method of the ngcp object, anywhere we need to check for the host role, including other macros that could not use our previous "function" before. Which will make it possible to modify the has_role behavior in a single place, and affect all code paths. Change-Id: I73526aa77fab3dec8f33361e142164204d7c1481	8 years ago
Guillem Jover	5104409fd4	TT#38200 Document NGCP::Template->new method ... Change-Id: Ib0082ea645d07fb7da7e1a6d0dd9392fdf37e956	8 years ago
Guillem Jover	696ac4c247	TT#38200 Add support for new NGCP::Template perl module ... The perl Template::Toolkit is very rich, but its "function" support is a bit poor. The ways to do it are either via MACRO directives, or by simulating them with one function per file and then using PROCESS on these. The problem is that this is very clunky, does not support nesting, as we'd need different "argument" names for each "function", and it's quite cumbersome to use, need to assign aguments passed beforehand, and then assign back a designated return value from another variable. This is also one of the reasons some of the functions are not encapsulated, and have been inlined in various loops, because it was not possible to cleanly PROCESS them from those call sites. Instead we should use its native support for perl objects and perl subroutines, which exposes these as proper methods of a designated variable, and have none of the above mentioned problems. So we'll switch from constructs such as: argv.arg-a = variable; argv.arg-b = 'value'; PROCESS 'path-to-library-dir/function' result = out into: result = ngcp.function(variable, 'value'); In addition this might actually be faster, as it does not require processing additional files, and it's all just native perl code. This will be exposed within the NGCP templates as the ngcp object, and new member functions will start replacing our old and clunky native Template PROCESS-style library. Change-Id: Id2f0d181c695a9dd074646881b7d9de3478570af	8 years ago