5 Commits (master)

Author	SHA1	Message	Date
Guillem Jover	3c87cea516	MT#62763 Fix shellcheck issues ... Warned-by: shellcheck Change-Id: I86da18b3f87620b67bd70aa6e0cfe744816c650a	9 months ago
Guillem Jover	a58e66bc9c	MT#59308 commit: Do not include the date in the commit message ... The date is already tracked as part of the commit metadata, and we use the current day which will always match the author date for the commit, so no information is lost. This makes the commit message more clear and removes redundant and distracting information from it. For «ngcpcfg log» we include the date from the commit metadata explicitly in the output, which will be duplicated for old entries but gets it from where it belongs for new ones. (Even though the date is also printed in relative terms on the front of the line.) We now get this output for old and new entries: * b3767f6 (10 hours ago) new [2024-02-02 14:28:11 +0100] (HEAD -> master) * dc0a310 (3 days ago) old [2024-01-30 23:10:32.674452749+01:00] [2024-01-30 23:10:32 +0100] Change-Id: I4eb4faed433db52e6755bc7782ec34545741d452	2 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes ... shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: | not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] | not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] | not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: | # shellcheck source=etc/ngcp-config/ngcpcfg.cfg | # shellcheck source=functions/init | # shellcheck source=functions/logs | # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	6 years ago
Guillem Jover	b789568b73	MT#17219 Use $@ instead of $* when we need to preserve argument grouping ... Using $* in some of these places implies losing data about what constituted a single argument. Change-Id: Ic072e68320d65ac86392c31d7665529b913232fd	10 years ago
Alexander Lutay	e8f7ce894e	MT#15803 Add ngcpcfg log/show scripts to improve usability ... Change-Id: I56f3c6d6cb5187ac471e0ae05ff313f24803fc1c	10 years ago