ngcpcfg

Commit Graph

Author	SHA1	Message	Date
Guillem Jover	cf71caa167	MT#55942 tt2-process: Move YAML config existence check from callers For multi-site support we need to pass all the possible files to load, and these might be different between sites, so we need to check for their existence from within tt2-process, instead of from the outside as that would restrict them to only the current site. Change-Id: I0965506832aa2f0a1ba67b19511c509bec60922e	2 years ago
Mykola Malkov	948f940975	MT#56090 Add maintenance.yml Change-Id: I02aca19e3b2afdc6a3982171f1d2578777694680	2 years ago
Michael Prokop	e51151ec35	TT#173500 Create tmpfiles with template name We want to be able to track down any left-behind tmp files, so ensure we're creating them with according file names. Change-Id: I1aa0ccdb8834e8aef919f1f028028c1bb14cbd01	3 years ago
Guillem Jover	732bc1705b	TT#161150 Unify and switch to NGCP_NODENAME and NGCP_PAIRNAME The HA_NODE, HA_FILE and HA_CONFIG variables and nomenclature are deprecated in favor of the NGCP_NODENAME, NODE_FILE and NODE_CONFIG. Switch the old uses to the new ones. Unify PAIRNAME to NGCP_PAIRNAME. Leave the old HA_ variables for backwards compatibility Change-Id: I11f09f1620c2e456f10fc17229b61ec5a35a732b	3 years ago
Alexander Lutay	6dabc7a42c	TT#154105 Improve error output for 'ngcpcfg get' The previous error message was really confusing: > root@spce:~# ngcpcfg get /asdf > 2021-12-06 18:48:12 sp1: Error: Cannot process template '/tmp/tmp.RBRJg02PEz': > > file error - parse error - input file handle line 1: unexpected token (/asdf) > [% /asdf %] > 2021-12-06 18:48:12 sp1: Error: Generating /tmp/tmp.NKfB8BtJXv based on /tmp/tmp.RBRJg02PEz: FAILED It happens due to the way ngcpcfg using TT2 template which is trying to include the file it the string looks like a PATH. The new error message is more user friendly (and generates proper/non-zero exit code): > root@spce:~# ngcpcfg get /asdf > 2021-12-07 12:42:50 spce: Error: cannot process request for '/asdf'! > root@spce:~# echo $? > 1 > root@spce:~# Change-Id: Ifaf56dec07adf8600bd9d7cf2e733769d6d82a4f	3 years ago
Guillem Jover	4e67890f1f	TT#81050 Fix precedence of HA_CONFIG and PAIR_CONFIG config.yml variants To get uniform and unexpected behavior we should use the exact same precedence used with the tt2 files. Fixes: commit `354e7578c5` Change-Id: I86281f3bd236687baec58b3a2e29cf80550176da	5 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... \|\| exit' or 'cd ... \|\| return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: \| not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] \| not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] \| not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: \| # shellcheck source=etc/ngcp-config/ngcpcfg.cfg \| # shellcheck source=functions/init \| # shellcheck source=functions/logs \| # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	5 years ago
Guillem Jover	354e7578c5	TT#81050 Add HA_CONFIG and PAIR_CONFIG support This makes it possible to use more specific config.yml files either for a pair of nodes, for settings that will always affect both, or for the HA names, for settings that might affect all A or B nodes. This matches the support in the template files. We need to move sourcing the ha_features and carrier_features before sourcing init, as now the ngcpcfg.cfg file can use these variables if set. Change-Id: Ic6b32acceb8f020f48c3afa09d9e84252b3531e7	5 years ago
Guillem Jover	ec70d8e387	TT#71952 tt2-process: Add new option to expect <input> <output> argument pairs This is needed for the get command, so that we can exactly control where to output to, and avoid all the file generation heuristics based on the input files. Change-Id: Iace05d1093342722553ec0bbb8ff0e817f77857c	5 years ago
Guillem Jover	a9166843c2	TT#71952 Parallelize templated output generation Switch away from the old daemon/wrapper architecture, which complicates things and requires more scaffolding code. We turn the daemon/wrapper and build_config into a single perl process that will load all YAML files, and then process each input/output pair on a parallel child, to try to speed up the processing as much as possible. For whole rebuilds, it might speed up the generation by at least a factor of x2, x4 or more, depending on the number of active processors. Change-Id: I51aa2f90336e34a20983d8733f45b64d9b6fea0b	5 years ago
Guillem Jover	2665215e64	TT#51701 Switch from deprecated /var/run to /run Change-Id: I657b18e6f064d93eeb53d8ab28976b4f647b95d7	6 years ago
Alexander Lutay	36a11888d6	TT#68710 Rename 'ngcpcfg values' to 'ngcpcfg get' It was a widely popular question from users. As the common sense pushes them to use 'get' when they use 'set/del'. Let's follow the common logic here. We still support old 'ngcpcfg values' syntax. Change-Id: I40a210b7c13d21a4bff4b6988535c39091f53280	6 years ago

12 Commits (master)