ngcpcfg

Commit Graph

Author	SHA1	Message	Date
Guillem Jover	d1ad545c22	TT#76851 Remove unnecessary inner-loop for interface access The host hash contains interfaces and other keys, but one of these keys contains a list of the interfaces, so we just need to check whether the interface exists in the hash, instead of scanning all the keys in the hash and matching the one that is equal to the one we are looking for which is rather inefficient. Change-Id: If7d49f0a0680b82cd35ffb3007666d19741372c4	7 years ago
Alexander Lutay	1758f7c33b	TT#33255 lib/get_default_pingnodes: add GW IP if allowed/necessary only Change-Id: I1fbc3977cee995561c07351ed5c0b4e463fd4e64	7 years ago
Alexander Lutay	48fa673577	TT#33255 Generate HA pingnodes from network.yml Long long time ago (around release 2.8) we started filling the default HA pingnodes because most of our customers didn't care about them. Lack of pingnodes was causing problems on PRO/Carrier as HA was not being able to make correct decisions about the cluster state which causes split brain and both nodes might end up being active. The idea back then was to use some IPs which MUST always be reachable: - gateway - primary DNS server - secondary DNS server NGCP is barely usable (or likely unstable) if some of the IPs above is no reachable. Sure, those IPs can be redefined in config.yml by the customer IF the customer provides more the 3 IPs. In the past we didn't have GW and DNS IPs in network.yml, also NGCP did NOT generate /etc/resolv.conf and /etc/network/interfaces from templates. Nowadays we have all such information AND generate /etc/resolv.conf from network.yml. However /etc/ha.d/ha.cf was NOT reconfigured against network.yml but still uses workarounds. The macro used in /etc/ha.d/ha.cf reads /etc/resolv.conf to fetch DNS addresses. It causes a list of problems on cloud-based installations (and not only there). Problem description: When DHCP is enabled, the server receives IP from DHCP and normally DNS servers are also included in DHCP packet => Linux/networking saves DNS in /etc/resolv.conf on boot. Later 'ngcpcfg apply' happens and builds all the files in alphabetical order. Unfortunately the order here is /etc/ha.d/ha.cf ... /etc/resolv.conf. So, ngcpcfg builds /etc/ha.d/ha.cf first and inserts there DNS IPs from /etc/resolv.conf->DHCP and not IPs from network.yml. Some seconds later DNS IPs from network.yml will be written in /etc/resolv.conf (as we have ngcpcfg template for /etc/resolv.conf since ~mr4.5). As a result we do change /etc/ha.d/ha.cf twice: - to switch HA from old DNS IPs/pingnodes to pingnodes from DHCP - to switch HA back from DHCP DNS IPs/pingnodes to pingnodes from network.yml It causes two unexpected HA restarts and confuses operators a lot. We should be safer here and use such sensitive data from one place -> network.yml The GW/DNS IPs search logic here is a copy of logic from template /etc/resolv.conf: > For your host find the interface in network.yml which has the gateway defined. > Use GW/DNS IPs for the interface you detected above. Change-Id: I055e17e20bfd2bc722388c61db12ff5c156e9ecc	7 years ago
Guillem Jover	1eac130bc5	TT#10953 Reformat all library functions Convert some deeply nested conditionals into early loop skipping. Change-Id: Ie36a398219153c653df04fd43f5bdff0b69ba33b	9 years ago
Victor Seva	488a16992b	MT#11371 lib/get_default_pingnodes: exclude commented lines at /etc/resolv.conf Change-Id: I18eb22a38b957c5093d7ad71c746df3febf3c6e1	12 years ago
Victor Seva	fb66d58253	MT#10021 get_default_pingnodes: add dns parameter dns = 'yes' returns gateway + dns dns = 'no' returns gateway Change-Id: I44a74c457b8b4c03a0385fb1aae1566063d5272b	12 years ago
Victor Seva	5a886c253f	MT#4823 remove hosts not available or reply truncated	13 years ago
Victor Seva	0a98fb93cb	MT#4823 Add get_default_pingnodes script	13 years ago

8 Commits (master)