7 Commits (master)

Author	SHA1	Message	Date
Guillem Jover	183e80936d	MT#56004 functions: Add a fallback value for NGCPCFG_PID ... This variable is assumed to be set and exported by ngcpcfg when it starts running. But we have code (in the ngcp-upgrade steps), which calls the restore-permissions helper directly w/o going through ngcpcfg, and which then breaks when the variable is not yet set. Add a fallback value so that we do not fail anymore. But we should eventually expose this functionality as an actual command as part of the public ngcpcfg CLI. Change-Id: Ibda18faaff8a26a04240e6ed7a46ee7650b82954	7 months ago
Michael Prokop	2088c32977	TT#82051 shellcheck fix for console_output() to expand escape sequences ... We are using console_output() from within log_info(), which is invoking `console_output "$*\n"`, so we need to expand the escape sequences (without interpreting other format specifiers), which is exactly what "%b" provides in bash. This is a fixup for previous commit 0dda93ad97 Change-Id: I16f354eb35e13568331e5107aff0d1c80dafb822	6 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes ... shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: | not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] | not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] | not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: | # shellcheck source=etc/ngcp-config/ngcpcfg.cfg | # shellcheck source=functions/init | # shellcheck source=functions/logs | # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	6 years ago
Alexander Lutay	fa3593aea1	TT#63758 Add --summary-only option support ... Sometimes (e.g. on 'push-parallel') we need to call ngcpcfg on remote host and generating summary only output about the results. It simplifies complex 'push-parallel' codebase which is critical for huge Carrier installation. P.S. we cannot print summary message all the time to console output, as a lot of code depends on the ngcpcfg output, e.g.: > root@web01a:~# ngcp-ppa gerrit_alutay_63758_push_parallel_2 > ERROR: There are uncommitted changes in config files: > 2019-10-02 11:59:38 web01a: Successfully executed 'diff' on 'web01a' > ERROR: Please commit them or discard > root@web01a:~# Instead, let's be backward compatible with printing on console, but always print this message to log file (as we sometimes need to know ngcpcfg exit code and it was impossible to find it in log file previously.) Change-Id: I9aad0912796500cddb23d1f3eaa428b0b39152d0	6 years ago
Alexander Lutay	90b1ff6b6c	TT#63758 Add new function 'log_warn_n' for 'ngcpcfg push-parallel' ... Change-Id: I83421c788e49739f81ea1969fbaccc812bf25641	6 years ago
Alexander Lutay	f4e5c0b645	TT#65907 Write ngcpcfg PID into ngcpcfg.log file ... It should simplify debug when two ngcpcfg executed in parallel. Change-Id: I5fa77bfe9419c3cff798eaefbdb02f159b7b63c9	7 years ago
Alexander Lutay	8209a5a136	TT#65907 Speedup 'ngcpcfg build' on 20% percent (when we build all files) ... About 50% of previous helper/build_config execution was loading 'functions/main' and we were performing it again and again for every tt2 files we build and we have more then hundred files in ngcpcfg. In fact we need two env variables and logging functions. Let's extract them into the separate function file and load them only. Command: time ngcpcfg build Original results: real 0m27.766s Current results: real 0m19.976s Change-Id: I6896ac437b1548888db7702de92b0ec79ed9d03f	7 years ago