TT#141100 NGCP::Template::Object: Rename get_mgmt_node to get_mgmt_pairname

Keep a backwards compatibility method with a deprecation warning.

Change-Id: Id0dea205391537f2c491e03d06de14b2180fa2c8

lib/NGCP/Template/Object.pm

@@ -153,9 +153,9 @@ sub get_dbnode
     return $self->{config}{hosts}{$hostname}{dbnode};
 }
 
-sub get_mgmt_node
+sub get_mgmt_pairname
 {
-    my ($self) = shift;
+    my $self = shift;
 
     my $ngcp_type = $self->{config}{general}{ngcp_type};
 
@@ -174,6 +174,14 @@ sub get_mgmt_node
     return;
 }
 
+sub get_mgmt_node
+{
+    my $self = shift;
+
+    warnings::warnif('deprecated', 'deprecated alias for get_mgmt_pairname()');
+    return $self->get_mgmt_pairname();
+}
+
 sub get_ssh_pub_key
 {
     my ($self, $key_type) = @_;
@@ -294,9 +302,14 @@ $hostname.
 
 Returns the database name for this node.
 
+=item $mgmtnode = $t->get_mgmt_pairname()
+
+Returns the NGCP management node pairname.
+
 =item $mgmtnode = $t->get_mgmt_node()
 
-Returns the NGCP management node shared name.
+This function is a deprecated alias for $t->get_mgmt_pairname(). It will be
+removed in the future.
 
 =item $ssh_pub_keye = $t->get_ssh_pub_key($key_type)
 

testsuite/NGCP_Template_Object.t

@@ -84,17 +84,17 @@ is($obj->get_firstname('self'), 'self', 'host self has self as first name');
 is($obj->get_firstname('sp1'), 'sp1', 'host sp1 has sp1 as first name');
 is($obj->get_firstname('sp2'), 'sp1', 'host sp2 has sp1 as first name');
 
-# Check get_mgmt_node().
-is($obj->get_mgmt_node(), 'sp', 'spce has sp as mgmt node');
+# Check get_mgmt_pairname().
+is($obj->get_mgmt_pairname(), 'sp', 'spce has sp as mgmt pairname');
 {
     delete local $obj->{config}{hosts}{self};
     local $obj->{config}{general}{ngcp_type} = 'sppro';
-    is($obj->get_mgmt_node(), 'sp', 'sppro has sp as mgmt node');
+    is($obj->get_mgmt_pairname(), 'sp', 'sppro has sp as mgmt pairname');
 
     delete local $obj->{config}{hosts}{sp1};
     delete local $obj->{config}{hosts}{sp2};
     local $obj->{config}{general}{ngcp_type} = 'carrier';
-    is($obj->get_mgmt_node(), 'web01', 'carrier has web01 as mgmt node');
+    is($obj->get_mgmt_pairname(), 'web01', 'carrier has web01 as mgmt pairname');
 }
 
 # Check get_dbnode().