From 5335c8b6862da4604d44d86b5bec8c3fbc6cd557 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Fri, 24 Apr 2026 20:54:22 +0200 Subject: [PATCH] MT#61800 perl: Use variables for filehandles instead of barewords This is a discouraged practice, which is disallowed with newer Perl versions. Change-Id: I1f6de332a370cc7bad4255e7e0394618166b86ea --- sbin/ngcp-network | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sbin/ngcp-network b/sbin/ngcp-network index 5a44b527..0b39e95f 100755 --- a/sbin/ngcp-network +++ b/sbin/ngcp-network @@ -258,15 +258,15 @@ sub get_ip6_addrs { logger("get_ip6_addr for device $interface"); logger("$cmd @args"); - my $childpid = open3 'HIS_WRITE', 'HIS_OUT', 'HIS_ERR', $cmd, @args; - my @stderr = ; - my @stdout = ; + my $childpid = open3 my $fh_in, my $fh_out, my $fh_err, $cmd, @args; + my @stderr = <$fh_err>; + my @stdout = <$fh_out>; logger("stdout: @stdout"); logger("stderr: @stderr"); - close HIS_OUT or croak 'Failed to close stdout'; - close HIS_ERR or croak 'Failed to close stderr'; + close $fh_out or croak 'Failed to close stdout'; + close $fh_err or croak 'Failed to close stderr'; waitpid $childpid, 0; if ($CHILD_ERROR) {