TT#71952 tt2-process: Refactor hook setup and handling

Move the hook selection at the input/output file generation stage, and
refactor the hook execution into a new function.

Change-Id: I010e50d198f946f5e8e5da0e60cf87d5688c45c7

helper/tt2-process

@@ -146,16 +146,25 @@ sub process_template {
         or error("Cannot rename $newfile to $target: $!");
 }
 
+sub run_hook {
+    my ($hook, $file) = @_;
+
+    return unless exists $file->{$hook};
+
+    # Export variable for usage within hook scripts.
+    local $ENV{output_file} = $file->{output};
+
+    # Execute hook script.
+    info("Executing $file->{$hook} for $file->{output}");
+    system("bash $file->{$hook}") == 0
+        or error("Execution of $hook script '$file->{$hook}' failed: $?");
+}
+
 sub process_input {
-    my ($tt, $config, $input, $output) = @_;
+    my ($tt, $config, $file) = @_;
 
-    # Export variable for usage within {pre,post}build scripts,
-    # OUTPUT_DIRECTORY is for customization during testing.
-    ## no critic (Variables::RequireLocalizedPunctuationVars)
-    if (length $ENV{OUTPUT_DIRECTORY}) {
-        $output = "$ENV{OUTPUT_DIRECTORY}/$output";
-    }
-    $ENV{output_file} = $output;
+    my $input = $file->{input};
+    my $output = $file->{output};
 
     # Ensure we do not try to generate a file where a directory with same
     # name exists already.
@@ -163,23 +172,11 @@ sub process_input {
         error("Generating file $output not possible, it's an existing directory.");
     }
 
-    my $input_dirname = dirname($input);
-    my $output_basename = basename($output);
-    my $output_dirname = dirname($output);
-
     # Execute prebuild script.
-    for my $prebuild ((
-        "$input_dirname/$output_basename.prebuild",
-        "$input_dirname/ngcpcfg.prebuild")) {
-        next unless -e $prebuild;
-
-        info("Executing $prebuild for $output");
-        system("bash $prebuild") == 0
-            or error("Execution of prebuild script '$prebuild' failed: $?");
-        last;
-    }
+    run_hook('prebuild', $file);
 
     # If output directory does not exist yet, create it
+    my $output_dirname = dirname($output);
     if (not -d $output_dirname) {
         ## no critic (ValuesAndExpressions::ProhibitLeadingZeros)
         make_path($output_dirname, { mode => 0755 });
@@ -199,16 +196,7 @@ sub process_input {
     }
 
     # Execute postbuild script.
-    for my $postbuild ((
-        "$input_dirname/$output_basename.postbuild",
-        "$input_dirname/ngcpcfg.postbuild")) {
-        next unless -e $postbuild;
-
-        info("Executing $postbuild for $output");
-        system("bash $postbuild") == 0
-            or error("Execution of postbuild script '$postbuild' failed: $?");
-        last;
-    }
+    run_hook('postbuild', $file);
 }
 
 sub generate_iofiles {
@@ -302,21 +290,41 @@ sub generate_iofiles {
             if (exists $filenames_scan{$file}{"$file$ext"}) {
                 my $input = "$file$ext";
                 my $output = ($file =~ s{\Q$NGCPCTL_MAIN\E/templates/}{}r);
+                # Add OUTPUT_DIRECTORY for customization during testing.
+                if (length $ENV{OUTPUT_DIRECTORY}) {
+                    $output = "$ENV{OUTPUT_DIRECTORY}/$output";
+                }
+
                 if ($file =~ m/ngcp-service/) {
                     push @filenames_prio, $input;
                 } else {
                     push @filenames_norm, $input;
                 }
-                $filenames{$input} = $output;
+                $filenames{$input} = {
+                    input => $input,
+                    output => $output,
+                };
+
+                # Select prebuild and postbuild scripts.
+                my $input_dirname = dirname($input);
+                my $output_basename = basename($output);
+                foreach my $hook (qw(prebuild postbuild)) {
+                    foreach my $hookfile ((
+                        "$input_dirname/$output_basename.$hook",
+                        "$input_dirname/ngcpcfg.$hook")) {
+                        next unless -e $hookfile;
+                        $filenames{$input}{$hook} = $hookfile;
+                    }
+                }
+
                 last;
             }
         }
     }
 
-    my @filenames = map { {
-        input => $_,
-        output => $filenames{$_},
-    } } (sort(@filenames_prio), sort(@filenames_norm));
+    my @filenames = map {
+        $filenames{$_}
+    } (sort(@filenames_prio), sort(@filenames_norm));
 
     return @filenames;
 }
@@ -345,12 +353,9 @@ sub process {
     my $tt = NGCP::Template->new();
 
     foreach my $file (generate_iofiles()) {
-        my $input = $file->{input};
-        my $output = $file->{output};
-
         my $pid = fork;
         if (not defined $pid) {
-            error("Cannot fork child process to process $input: $!");
+            error("Cannot fork child process to process $file->{input}: $!");
         }
         if ($pid != 0) {
             # We are the parent.
@@ -367,7 +372,7 @@ sub process {
             next;
         }
 
-        process_input($tt, $config, $input, $output);
+        process_input($tt, $config, $file);
 
         exit 0;
     }