From fb7d1fdc7f5ce893e408a6f934f7b95ea905c586 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Tue, 7 Nov 2017 13:00:50 +0100 Subject: [PATCH] TT#19710 Do not return an explicit undef Change-Id: I0518860d89a2299e323b31870ec394532ab5d8c4 Warned-by: perlcritic --- lib/NGCP/Schema/Result/billing_network_blocks.pm | 4 ++-- lib/NGCP/Schema/Result/voip_contract_location_blocks.pm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/NGCP/Schema/Result/billing_network_blocks.pm b/lib/NGCP/Schema/Result/billing_network_blocks.pm index 7a556409..470d5b42 100644 --- a/lib/NGCP/Schema/Result/billing_network_blocks.pm +++ b/lib/NGCP/Schema/Result/billing_network_blocks.pm @@ -104,7 +104,7 @@ sub TO_JSON { sub _bigint_to_bytes { my ($bigint,$size) = @_; - return undef if !defined $bigint; + return if !defined $bigint; #print '>'.sprintf('%0' . 2 * $size . 's',substr($bigint->as_hex(),2)) . "\n"; return pack('C' x $size, map { hex($_) } (sprintf('%0' . 2 * $size . 's',substr($bigint->as_hex(),2)) =~ /(..)/g)); #print '>' . join('',map { sprintf('%02x',$_) } unpack('C' x $size, $data)) . "\n"; @@ -113,7 +113,7 @@ sub _bigint_to_bytes { sub _bytes_to_bigint { my ($data,$size) = @_; - return undef if !defined $data; + return if !defined $data; return Math::BigInt->new('0x' . join('',map { sprintf('%02x',$_) } unpack('C' x $size, $data))) } diff --git a/lib/NGCP/Schema/Result/voip_contract_location_blocks.pm b/lib/NGCP/Schema/Result/voip_contract_location_blocks.pm index ef223bc6..866d3d0b 100644 --- a/lib/NGCP/Schema/Result/voip_contract_location_blocks.pm +++ b/lib/NGCP/Schema/Result/voip_contract_location_blocks.pm @@ -104,7 +104,7 @@ sub TO_JSON { sub _bigint_to_bytes { my ($bigint,$size) = @_; - return undef if !defined $bigint; + return if !defined $bigint; #print '>'.sprintf('%0' . 2 * $size . 's',substr($bigint->as_hex(),2)) . "\n"; return pack('C' x $size, map { hex($_) } (sprintf('%0' . 2 * $size . 's',substr($bigint->as_hex(),2)) =~ /(..)/g)); #print '>' . join('',map { sprintf('%02x',$_) } unpack('C' x $size, $data)) . "\n"; @@ -113,7 +113,7 @@ sub _bigint_to_bytes { sub _bytes_to_bigint { my ($data,$size) = @_; - return undef if !defined $data; + return if !defined $data; return Math::BigInt->new('0x' . join('',map { sprintf('%02x',$_) } unpack('C' x $size, $data))) }