You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Kirill Solomko 956314d23c MT#66497 restrict subscriber roles in /api/subscribers ... * subscriber and subscriberadmin can no longer modify fields they are not allowed to. A changed value is rejected with 422 "Read-only field(s) for authenticated role: <fields>", unchanged values are accepted (clients sending the fetched values back keep working), omitted fields keep the stored values. Invalid values (e.g. administrative "true" or {}) are rejected with 422 as well: - subscriber on itself: lock, status, primary_number, alias_numbers, pbx_extension, profile_set_id, profile_id, administrative - subscriberadmin on itself: the same except pbx_extension, which can be changed to an extension not used by another subscriber or PBX group of the customer - subscriberadmin on the pilot: lock, status, primary_number, alias_numbers, profile_set_id, profile_id, administrative - subscriberadmin on its other subscribers: profile_set_id, profile_id, administrative The rules are in Utils::Subscriber::get_readonly_fields(), checked by get_readonly_changes() in prepare_resource(), so PUT and PATCH behave the same. Fields a role is allowed to change keep the existing PUT semantics. Previously e.g. a subscriber could unlock itself or assign itself any number or subscriber profile. * replaces the lock/status checks added in MT#66467. * subscriberadmin on its PBX seats: primary_number is derived from pbx_extension, a value other than the stored or the derived one is rejected with 422 (was silently replaced). * subscriberadmin POST with administrative set is rejected with 422 (was silently reset to 0). * subscriberadmin can assign alias numbers to its subscribers only from the PBX pool (non-primary numbers of the pilot), 422 otherwise. Assigned numbers are moved from the pilot, revoked ones are moved back to the pilot via update_subadmin_sub_aliases() (as in the web UI), for POST, PUT and PATCH. Previously any new or unassigned number could be assigned and revoked numbers were released from the customer. /api/numbers is unchanged. * PUT/PATCH/DELETE of subscribers outside of the caller's scope return 404 like GET (subscriber: other subscribers, subscriberadmin: subscribers outside its customer) instead of 403. 403 stays for non-PBX subscriberadmin without the write privilege. * non-PBX subscriberadmin POST returns 403 without the write privilege instead of 500, with it the subscriber is created in the own customer. * SubscriberSubAdminAPI form: add the lock field, so subscriberadmin lock changes of its subscribers are validated as in the admin form and no longer dropped on PUT. PUT without lock/status still resets them (lock 0, status active) as before, PATCH without lock keeps it (previously any subscriberadmin PATCH unlocked the subscriber). * fields visibility is unchanged. * api-subscribers.t: - add restricted fields, PBX pool and access tests for subscriber, subscriberadmin (own, pilot, its subscribers, non-PBX) and admin - fix subscriber credentials, webpassword is not returned by the API, the subscriberadmin tests were not executed at all - other reseller fixture uses its own domain - adapt expectations: subscriberadmin profile changes and subscriberadmin creation are rejected with 422 - TT#28510: re-fetch the pilot, the TT#15441 cleanup may have deleted it (hash order dependent, failed with "Customer has no pbx pilot subscriber yet") * Test::FakeData: unique billing profile name/handle per creation, the profile can be created twice per run (fails on an empty DB). Change-Id: I637330111df278eb62edca25f3406966d8a6ebf1 (cherry picked from commit c6cf9adfa9)		2 days ago
..
api-rest	MT#66497 restrict subscriber roles in /api/subscribers	2 days ago
api-rest2	MT#66071 add contact_email and billing_profile_name filters to contracts API	1 month ago
lib	MT#66497 restrict subscriber roles in /api/subscribers	2 days ago
selenium	MT#62763 Fix pycodestyle issues	9 months ago