3772 Commits (f612ad54d8408cbbcc64a8ceb8f7fa06cf5d16c2)

Author	SHA1	Message	Date
Rene Krenn	f612ad54d8	MT#61513 prevent duplicates in GET /api/callrecordings ... callrecording metakeys such as "uuid" for the involved call party is present multiple times by nature. the ?subscriber_id= query param will then narrow down the result. alongside an implicit role filtering (reseller/subscriber), the sql join and filtering for the uuid key is present 2 times however, and multiplied records slip through. this can be prevented with DISTINCT. to avoid performance impacts and consider other metakeys orrcuring multiple times, it will be applied only if a filter is present. Change-Id: I08047aaee265e2e0a706220e03fd4617da16d33c (cherry picked from commit 598f7dbaf4)	6 months ago
Rene Krenn	22c5b8ad7e	MT#60197 support deleting call recordings per subscriber ... admin panel will no longer delete callrecordings for all parties of the call, but the single subscriber only. rest-api, behaves the same way, if the ?subscriber_id= parameter is provided. when a callrecording is deleted by all call parties, the remaining records and recording files will be dropped. Change-Id: I61f667bdb074a935a8a04473a3685b10e5e09222 (cherry picked from commit 1c09e2773a)	6 months ago
Rene Krenn	16e4b06c75	MT#59597 fix remove trailing+leading % entirely for "wildcard" params ... Change-Id: I371e2d41ff27b2801ead391778d9a2bdef914563 (cherry picked from commit 868e2657b6)	7 months ago
Rene Krenn	fb22a340b9	MT#59597 remove trailing+leading % entirely for "wildcard" param types ... this code is not run by legacy panel, so the check for "/api" request can be removed. Change-Id: I29410fbbf046a8f00443138720b940de0f09f416 (cherry picked from commit 9ba93e69a5)	7 months ago
Rene Krenn	92d3106484	MT#59363 retain trailing+leading wildcard for legacy panel only ... all api query param filters that were harmonized to "wildcard" also appended leading+trailing wildcard (this was from the original idea to make adminUI and legacy panel search behave the same). Change-Id: I017473b84f2844d14a11b4ec8b437df5335c24d0 (cherry picked from commit aa6760228e)	7 months ago
Rene Krenn	8dfc9b1eb3	MT#59363 fix /api/domains/?domain= filter pattern behaviour ... this filter is another spot, where leading/trailing wildcards were added unintentionally, during harmonization. Change-Id: Id23114f8e7ebca018ad222e35b39d8260f1da92f (cherry picked from commit 48b71e68c5)	7 months ago
Marco Capetta	4006915bdb	MT#60864 Fix Sync Email Templates button behavior ... The 'Sync Email Templates' button is shown in the Email Templates page in case some templates is missing for a reseller. The problem is that the button takes into consideration also resellers that are already terminated and for which the template is not needed anymore. Thus the query has been in fixed in order adding: r.status != 'terminated' Change-Id: I2dd551166ae777c8967eae3bda989b669b46b5c0 (cherry picked from commit 97adbaf8e7)	8 months ago
Kirill Solomko	8eba05ed0e	MT#60553 handle API subscriber timezone field separately ... * timezone field for SubscriberSubAdminAPI form is now Text instead of +NGCP::Panel::Field::TimezoneSelect because the template => 'helpers/datatables_field.tt' produces a field validation error, as well as the Field is designed for UI and not API. * add validate_timezone() field validation to SubscriberAPI and SubscriberSubAdminAPI forms. Change-Id: I6391694284477976d8d6cee71a81e2241bd94937 (cherry picked from commit e83588874b)	8 months ago
Marco Capetta	59f56f4e6a	MT#61065 Fix 'cli' preference removal ... In commit b51c0c9698 the possibility to change the 'cli' preference by subscriber and subscriber_admin was added (under certain limits). On the other hand, the additiona of that part of code broke the possibility to remove the preference using the PATCH api. It is a very uncommon scenario though, but it seems anyway used by some customer. We may think to deprecate this possibility one day, but till then we don't have to create regression to customer. Change-Id: Ie695b567929eb79b1ba63d3c5a31ae5ce7b559bd (cherry picked from commit f9a328f83d)	9 months ago
Marco Capetta	0d4467e291	MT#60756 Fix subscriberprofiles POST api call as reseller ... Administrators with reseller role were not able to create new subscriberprofiles because API was fialing with 500 error. In particular: LOG="«DBIx::Class::Row::store_column(): No such column 'reseller_id' on NGCP::Panel::Model::DB::voip_subscriber_profiles at /usr/share/perl5/NGCP/Panel/Controller/API/SubscriberProfiles.pm line 172» The error was caused by the addition of the reseller_id info in the $resourse even if not needed. Change-Id: I7970a2716d7af959639937a9a844160ab73a9176 (cherry picked from commit d40126ef0a)	9 months ago
Kirill Solomko	04def03994	MT#60300 fix sound sets list rendering for reseller ... * fix code typo that prevented correct rendering of the sound sets list for reseller roles Change-Id: I35ea38a37932b8dd563a0b95f7e2481a5c45cdbe (cherry picked from commit c7ae8c1dcf)	10 months ago
Rene Krenn	5ba2af4a0e	MT#60520 prov templates: fix lookup of items ... item (contract, contact, subscriber) lookup will pick the first matching element (an arbitrary one if multiple are matching). ie. when lookup identifiers are too loose (f.ex. subscribers without domain in a multidomain setup) it might pick a wrong item - which is ok (supposed to bail out at a later step) unless that wrong item is a *terminated* one, causing to proceed checks on a terminated record (which can never happen from API or UI side since those hide terminated items), which produces a misleading 500 error in the end. we prevent this now by ensuring that looked up items are not terminated ones. even if the looked up items is not the desired one, becasue of an inaccurate template. Change-Id: I6691937c2e62b05915c7eac9980224abe2185b2c (cherry picked from commit 0fd36ace55)	11 months ago
Kirill Solomko	ae01a91508	MT#59363 /api/subscriberregistrations change socket field to Text ... * socket field is changed to text for the API endpoint as by default in the LocationEntry form that is used by the UI the field is a prebuilt options list that comes from config.yml extra_sockets, and that severely limits the usage for the API. Change-Id: I71ee1f77dbf458c12655f840282375cee62b7534 (cherry picked from commit 7aeaf0f16d)	1 year ago
Kirill Solomko	8d016b0bdd	MT#56301 move lock_provisioning_voip_subscriber before underrun_lock ... * POST /api/subscribers/ invoke lock_provisioning_voip_subscriber() before underrun_lock(), so that if the subscriber is about to be locked due to customer balance costs, the lock_provisioning_lock_subscriber() invocation will not unlock it back straight after Change-Id: I55020f844c9aa76df2e2f057a88b2ae7c9ebbfcc (cherry picked from commit c6aaaddd87)	1 year ago
Rene Krenn	a1fb2bfd4b	MT#56301 set locklevel of created subscribers only if specified ... Change-Id: I90f2d68dee50ab240de4eb5af7495ddd551c00d8 (cherry picked from commit df670f501f)	1 year ago
Marco Capetta	26456c99a7	MT#56301 Fix API creation of an active subscriber with lock ... Using API is possibile to edit an existing subscriber and set status: active and lock: 2. It is instead impossbile to create a new subscriber with the same configuration because the 'lock' param is not taken into account. The only way to properly setup lock level it is to set the status to 'locked' and this is in fact wrong. The fix address this issue and allow now to create a new subscriber with status: active and lock: 2. Change-Id: Id18e40bc001c5a7de30f5d148231bda93a3b1b3d (cherry picked from commit 8945b8a5ac)	1 year ago
Kirill Solomko	96364f14a5	MT#59835 /api/billingzones fix HAL ngcp:billingfees relation ... * billing fees relation was rendering all associated billing fees and that was causing huge data sets to be returned if a billing zones had many fees, now instead a single link is returned /api/billingfees/?billing_zone_id=:id. this is also on par with other links like /api/billingfees/:id Change-Id: Iabb7afb3bf43abf9a22c71750d45a1962a7f16ec (cherry picked from commit e4cda08bd4)	1 year ago
Kirill Solomko	8d97e6631f	MT#59797 /api/headerruleconditions (actions) fix reseller role ... * fix resultset when user role is reseller so that reseller_id is joined correctly and a db error is not produced anymore. Change-Id: I2a1b357037d983f23770bb59519fc2cb8b68a7e4 (cherry picked from commit bf249f9d96)	1 year ago
Rene Krenn	72768c0a1e	MT#59748 drop ngcp-provisioning-template test dbhost ... Change-Id: I7218ed36cff2f51f5a6f862f41e5da94ff0d464b (cherry picked from commit 14e5b918b3)	1 year ago
Rene Krenn	cbe6b0762c	MT#59434 always take aliases from voip_numbers ... in case the DB shows discrepancy because of missing primary provisioning.voip_dbaliases records, align with legacy panel behaviour and also take the restapi aliases list from voip_numbers, instead of voip_dbaliases. .. while trying to keep the performance gain from https://gerrit.mgm.sipwise.com/c/ngcp-panel/+/65086. Change-Id: Ibd7f8c8bc6a39ae2c31b4e8818080674ab77d66c (cherry picked from commit 740bb764e5)	1 year ago
Rene Krenn	e0dee320aa	MT#56817 MT#56362 fix query param sorting for regulary chained rs ... Change-Id: I82d3a0ce67ffb61273fc716016885f6431852eff (cherry picked from commit c837dc1043)	1 year ago
Rene Krenn	badb90c1eb	MT#56817 MT#56362 fix query param sorting for rs chained the regular way ... Change-Id: I0dab56ae07666eb695d7f30ef633a876ff8258fb (cherry picked from commit aae0b7e071)	1 year ago
Rene Krenn	22c3696930	MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd (cherry picked from commit a15d00894a)	1 year ago
Rene Krenn	8e9be5b63e	MT#59216 restore appending wildcard behaviour ... with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d (cherry picked from commit 672a3110bc)	1 year ago
Kirill Solomko	52ad4f81bd	MT#59238 fix rewrite rules transaction control for PATCH,DELETE ... * /api/rewriterules PATCH, DELETE methods used the generic transaction, which conflicted with the xmlrpc reload command. * own_transaction_control was only set for PUT and now also extended to PATCH, DELETE to ensure that dialplan_sip_reload() is called properly after $guard->commit. Change-Id: I7313b4f6d1f6699bf38ae34749c5383a3943f61d (cherry picked from commit 80f8b1da0b)	1 year ago
Kirill Solomko	edaca5c52e	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs ... * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e (cherry picked from commit a4d54b10e4)	1 year ago
Rene Krenn	2fb7b3ebbf	MT#58890 force cft_ringtimeout as number ... Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa (cherry picked from commit cc8fd8928d)	1 year ago
Rene Krenn	50333dd988	MT#59025 fix peering groups name filter ... Change-Id: I329e644c937058069c5932abf8e897dce48a8c10 (cherry picked from commit 1e9f223276)	1 year ago
Rene Krenn	c7d653565f	MT#58762 adjust restpi tests to harmonized wildcard filters ... Change-Id: I68b2199a3487fedb388803012c950c3abca1a8b3 (cherry picked from commit aa2d07ef29) (cherry picked from commit 5f070d0fd8)	2 years ago
Rene Krenn	182e67e2dc	MT#58762 harmonize restapi wildcard filters ... - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b (cherry picked from commit 308a974059) (cherry picked from commit 5b62ba15f3)	2 years ago
Rene Krenn	3b69942ab1	MT#56239 avoid ambersand symbol in apidoc descriptions ... Change-Id: Ic024d16c008648cb4d9cf14ae0e58d1ebe8febe9 (cherry picked from commit 71480acfa3)	2 years ago
Rene Krenn	d43cd398f4	MT#56239 api/callrecordings support filtering multiple metakeys ... filtering an Entity-Attribute-Value model cannot be done as simple conjunctions, but requires either INTERSECT set operation, or joining the same table multiple times. Change-Id: I5ce1ae1ece9406b6610487654f09d768a233b122 (cherry picked from commit 8e82715eb8)	2 years ago
Rene Krenn	7dd64659eb	MT#56239 api general caller/callee wildcard search support ... various api rails will need to support ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcards=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wildcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: Ie6065b0cfa883f7963e1dc8259fffea9a1edfdfe (cherry picked from commit 9c3a549094)	2 years ago
Rene Krenn	a710e9618e	MT#58346 fix conversations voicemail timestamp filter ... Change-Id: I86fc4db7d5efddf73f6c0b068b1c9e79913fddaf (cherry picked from commit 5eff0601b5)	2 years ago
Rene Krenn	c70d6fa42e	MT#58346 fix panel datatable filtering ... Change-Id: I4ce2e07a3ffa0715e385d811737f850aacaa5d90 (cherry picked from commit d546387651)	2 years ago
Rene Krenn	df2251e44e	MT#58346 caller/callee filters for conversations ... the conversation list now supports ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcard=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wilddcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: I792d2ea9c649c69c4b5cc98076097cb96467d4bc (cherry picked from commit ae612eb401)	2 years ago
Marco Capetta	b79d73232e	MT#58596 Enable api soundgroups and soundhandles for subscriber ... The commit extends what done already in e15e40423 allowing the subscribers to get the soundgroups and soundhandles using API. This is necessary for some CSC features like the selection of the Custom Announcement to play after Call Forward. Change-Id: I40d57d1efdc107c64fe3efafd9e87d1403c4d124	2 years ago
Marco Capetta	5a9b8e2179	MT#54356 Fix swagger documentation for 'calllist' api ... The 'duration' field is reported in the documentation as 'number' but in fact it is a string, for example: "0:00:16.495". In the commit the definition of the parameter is changed from PosInteger to Text Change-Id: I317006f5bbb5c4b7ffea0abe29dc0b175d8f95e6 (cherry picked from commit 958e40e2ca)	2 years ago
Marco Capetta	63946da618	MT#57129 Anonymize caller in conversation list when clir is equal to 1 ... In case a susbcriber or subscriber admin get the conversation list using the API, the caller is not properly anonymized when clir is set to 1. This is a big security hole. With the fix, the caller is authomatically anonymized. Of course, administrators and resellers can still see the original caller number. Change-Id: I9bc676718e38ae1d462f43176e4c6611528f7e54 (cherry picked from commit a7f82c264b)	2 years ago
Fabricio Santolin da Silva	dc6e5b5dc4	MT#58468 Fix special characters incorrectly interpreted by paps ... Change-Id: I15682d0e3bbe53cc372a5eb1a162e7592e9a3b11 (cherry picked from commit 3c5cf0b537)	2 years ago
Kirill Solomko	9b4099ea40	MT#58430 fix allowed_ngcp_types in API GET ... * allowed_ngcp_types check is now correct in the Controller:API::Root::GET * also fix allowed roles check Change-Id: I2446d7377d2a1ef152560bfb2799bb9debd0f34b (cherry picked from commit 706b472465)	2 years ago
Kirill Solomko	50ae851653	MT#58409 /api/profilepreferences fix filtering for admins ... * as now all profile preferences should be visible for admin users, the excessive _check_profile() filtering is removed, as well as it improves the performance due to less sql queries (was 1 extra query per preference). the preferences based on attributes are correctly filtered for subscriber and subscriberadmin 'roles'. Change-Id: Ifaa8c7de1f73d07fce3ef0df725a01f1c5d5d80c (cherry picked from commit 0c4800fbb0)	2 years ago
Rene Krenn	3e68a79924	MT#58337 show destination call costs/zones in invoice callist ... invoices support call direction for the summary and zone costs, however the detailed call list (available to customer invoices only) always shows *source* costs and zone details. this is fixed accordingly. in&out call directions implies a slow OR query, and is not supported, as noted in the documentation. Change-Id: Ib4a8a8f535a9f170b1f3ca9a6b9be36c033d439e (cherry picked from commit 9d8ac1785f)	2 years ago
Kirill Solomko	205f2ea4a8	MT#58157 escape uri refs in body.tt ... * URI that comes from c.req.uri must be escaped as Catalyst provides c.req.uri unescaped. * new Catalyst::NGCP::Plugin::EscapeURI with escape_uri() function * new NGCP::Panel::Utils::Generic::escape_uri() that uses URI::Escape::uri::escape_utf8() * c.req.uri and c.req.path occurrences in layout/body.tt are now escaped with c.escape_uri() Change-Id: Id0483fa6e570a0ff8db84b1d470caf5405cc0886 (cherry picked from commit c826fccb29)	2 years ago
Sipwise Jenkins Builder	289440913d	TT#4166 I18N dump: snapshot 2023.08.30-00.21.05 ... Change-Id: I931cca45f1966fde3eb89fbe385640c9cf10eaa1	2 years ago
Kirill Solomko	b7c22618c8	MT#57987 /api/rewriterules calculate priority on create ... * when a new rewrite rule is created and the priority attribute is not specified, only the first rewrite rule of the same rewrite rule set is set as 50, and the following are as: "MAX(priority) of the same rewrite rule set"+1 Change-Id: I1f1ae275e00918a34a625409987f21044b3b940f	2 years ago
Sipwise Jenkins Builder	ae99153421	TT#4166 I18N dump: snapshot 2023.08.11-00.26.05 ... Change-Id: I60bb2bccf2986ab689d79154eadc57eee4f6f250	2 years ago
Kirill Solomko	6953de937c	MT#33041 add reseller max subscribers support ... * Max subscribers can now be defined in the Reseller contract * Max subscribers is now shown in int Reseller's "Reseller Contract" Details (with an indictaion of how many subscribers are created out of the defined max subscribers, as well as when the limit is reached (similar to the Customer's Details page) * Add reseller subscribers count checks on the UI Create Subscriber page * Add reseller subscribers count checks in /api/contracts POST/PUT * Prevent max_subscribers definition for Peering contracts in /api/contracts POST/PUT Change-Id: I1561d4eb7da5b1a0a0c99acabd18d2a9cd98dec7	2 years ago
Rene Krenn	8fbd46e5fc	MT#57382 DELETE /api/faxes/id ... Change-Id: If578cd842d83e3471659164826d3e0305018cc29	2 years ago
Marco Capetta	967bc581fe	TT#179901 Discontinue iNew dedicated features and code (part 2) ... Remove party_call_control feature Change-Id: I6ea1c725a463ee62696de93a7ee52080515cc2b7	2 years ago