ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Irina Peshinskaya	a1360159b0	TT#46791 Wait for ajax table loading for "Edit" button work Change-Id: Icb4cdc87e818dc6fc592334d7efed79de23c0b91	6 years ago
Alexander Lutay	82172e5b1a	TT#46791 Fix floating bug with 'Edit' problem on page 'Weekdays' (try #2 ) The full issue description you can find in commit message `a9399b1efd`. In short, Selenium can't press on "Edit" button because it is being hidden on every AJAX request to backend. (Un)fortunately the previous fix opened new ngcp-panel JS issue reported as TT#50005: JS performs several AJAX requests to backend and the second request still cause the same problem as previous caused the first one. Luckily JS performs only one request to backend on the page load. And starts doubling them when we enter something into "filter". As a result, the previous commit has been reverted and new approach is proposed here: we will just wait data appearance in "Dates" (which means the first AJAX request is finished). Change-Id: If991af70e1ad1b00b04e4118c0b5f52b2d636eba	6 years ago
Alexander Lutay	cb7d6ec0af	TT#46791 Use proper variable name in test controller_billing.t The previous variable name didn't represent the real code context. The changes were initially part of commit `a9399b1efd` and were extracted to separate commit as initial commit had been reverted in commit 0601b821006f. Change-Id: Idf06a06b60498ec5df7a9472aa38413997dc23cb	6 years ago
Alexander Lutay	18d4e25574	Revert "TT#46791 Fix floating bug with 'Edit' problem on 'Weekdays' page" The fix here didn't work well because another ngcp-panel issue has been noticed and reported as TT#50005, the second AJAX request aborts Selenium test by hiding "Edit" button. The better approach is follow. This reverts commit `a9399b1efd`. Change-Id: Icf6251261f0cbc12ef4e819b3352dc3ebf7c4246	6 years ago
Alexander Lutay	a9399b1efd	TT#46791 Fix floating bug with 'Edit' problem on 'Weekdays' page It was old floating issue which randomly failed the test and jenkins job ngcp-panel-test-selenium-docker became often yellow. The problem here was in two facts: - 'Edit' button available with mouseover only - there is AJAX on this page for filtering 'Dates' records. Historically we have no ability to wait for all AJAX loadings. When Selenium moved mouse over Edit column to press it, AJAX can be finished and removed "Processing..." label from "Dates" field. It cause loosing mouseover from "Edit" button and button is hidden causing "element not interactable": > # Click 'Edit' button for element 'Wednesday' > Can't use string ("element not interactable") as a HASH ref while "strict refs" in use at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 684. > at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 655. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 27. It has been workarounded here as we cannot wait for AJAX. We are creating fake query for "Dates" (searching "thisshouldnotexist") and waiting until the table "Dates" has no search results records. It means AJAX has finished and we can continue with the test. Also here I have renamed confusing button from 'edit' to 'delete', as we press delete. And we have to clean previous search 'thisshouldnotexist' with proper '2008-02-28' which we want to delete. Change-Id: I55af32991687e82c3e57b15c066e772ff0b77123	6 years ago
Alexander Lutay	72834f126d	TT#46791 Add timeout 1 second for controller_billing.t It will give Ajax enough time to load 'Edit' button, otherwise we have some mystery which randomly happens when Jenkins tests VMs on Google Cloud: > # Edit Wednesday > ok 26 > # Move mouse over 'Weekdays' row to make 'Edit' button available > # Find 'Edit' button for element 'Wednesday' > ok 27 > # Click 'Edit' button for element 'Wednesday' > Can't use string ("element not interactable") as a HASH ref while "strict refs" in use at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 684. > at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 655. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 27. Locally it is not reproducible, also VM on Proxmox has no such issues as well. I spend too much time here trying to find the root of the issue, maybe Firefox version we are currently using has some issues here. Give up, sleep 1. Change-Id: I168270f6f6d25d8bdccfe6a40b2bc63aa0c5068e	7 years ago
Alexander Lutay	45bf7ec433	TT#46791 Call proper method 'click()' instead of 'click' (cosmetic) This is mainly for the code consistency. Change-Id: I1e820ef3693f541c21b86929c4887d434a74f35f	7 years ago
Alexander Lutay	95e1c49208	TT#46791 Wait for 'Edit' button in controller_billing.t The 'Edit' button appears only after mouse-over event, and we might have race conditions here when we are trying to click on not-yet available/accessible button causing: > Can't use string ("element not interactable")... Let's wait for button and then proceed with 'click()', it is the behaviour we use everywhere, while it was missing here. Also improve debug messages here for easier debug next time. Change-Id: Iae955bb3f937da6b5c10369bc49f6dd75611dc87	7 years ago
Gerhard Jungwirth	a672389bc7	TT#17853 selenium test adaptions for geckodriver all selenium tests are working with newest geckodriver (0.18.0) and patched S:R:D issues: - setting the window size: not urgent - the unsupported move_to: fixed (new move_action) - setting the implicit wait timeout: fixed upstream in S:R:D Change-Id: Ic5b52cd866f4fd93682d67a4fd8a76ec54ea70cf	8 years ago
Gerhard Jungwirth	3b8651ac2a	MT#14585 improve selenium test quality use strict and warnings therefore forbid unquoted strings factor out initialisation screenshot functionality is implemented upstream Change-Id: I18a0dcc7a6418dc9fd2fa64d367ae226018a7645	10 years ago
Alexander Lutay	5879cfe0e1	MT#14585 Move selenium tests on Selenium::Remote::Driver(::Extensions) Change-Id: I5c2133598196a620d4e8a6376beb800cdde81f3c	10 years ago
Alexander Lutay	bd9a184c56	MT#14585 Move ngcp-panel-selenium tests to folder 't/selenium/' Also simplify tests names. Change-Id: I9142160ec0ae5aad9287ce38b5f552e1790c285f	10 years ago

12 Commits (ef70c3d5a01ac3458bb77fe6389660a366953bc6)