47 Commits (e8f41aba5078f91176aa7a80cb22c4d7adac81e4)

Author	SHA1	Message	Date
Kirill Solomko	9d598d4502	MT#59478 improve MSG, LOG log string data storing ... * $c->error array now contains the $message as the first element instead, so that it's possible to obtain all the error data in the code when fetching it from @{$c->error}. the first element is not logged in the error log. * api_response $c->response_body part is now stored in MSG= and possible errors / other log data is now stored in LOG= to: - reduce amount of log lines when an API error response occurs from 2 to 1 - the message part usually contains either HTTP response message (e.g. Internal Server Error) or a validation message string, so it belongs to the MSG= part of the log line, where as the internal log data is more related to the LOG= part - both MSG= and LOG= parts are escaped for GDPR related obfuscation * Utils::Messag::info(): $msg is now also obfuscated if it's detected as a reference (also because logging is moved for the API part to $msg), as well as truncated for possible new-line char and white-spaces. Change-Id: I3b670b2251ec3060037ed6863f18d95975120b8d	1 year ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Rene Krenn	40c4ade6ea	TT#118802 log raw perl catalyst request time ... (cherry picked from commit 05f2f1137d6d3ce1deb1880eb1427b94e409c691) Change-Id: I6bda815d2ccf2800a0a352c0d44aaee8039ee8d5	4 years ago
Guillem Jover	467084705d	TT#71950 Fix typos ... Warned-by: codespell Change-Id: If7e52bf2fbf013586e802e5ebb77a272599d9c38	5 years ago
Rene Krenn	6d89e74253	TT#59803 obfuscate .*password.* fields in request+response body (json) ... Change-Id: I9f457b8cd9b0ff2e94c5795fb9987f97af5ac1f9	6 years ago
Rene Krenn	157206a6bb	TT#59803 opfuscate password fields in any logmessage part ... Change-Id: Ia48db97a54c2a0a87b88f5780b636f5582527945	6 years ago
Rene Krenn	64a6637a88	TT#56340 fix ip logged instead of username ... Change-Id: I3a60c7a1b14506337a38a6578aafff1d70828d91	6 years ago
Rene Krenn	cae5270af5	TT#56340 panel logline obfuscation ... adds gdpr obfuscation quoting for: + subscriber numbers + subscriber ip addresses + subscriber usernames + any logmessage "DATA": query parameters, form data, response data + subscriber uuid's + call id's + callforward sip uri's the quoting is centralized by $c->qs() ("quote sensitive"), using catalyst plugin mechanism. escape symbols are set to « (\x{ab}) and » (\x{bb}). generate_logfile_data_inventory.pl was modified to mark loglines with "gdpr affected" status, if $c->qs() was used in a log message. Change-Id: I0f42d7992594232ae33e5666b0a64009211c5b76	6 years ago
Rene Krenn	7952117b0d	TT#56463 remove use Catalyst; from Utils/Message.pm ... Change-Id: I54a2967fff7739edef9f1620073c0cf5ecfba811	6 years ago
Rene Krenn	76b88062a1	TT#56411 honor use_session => 0 for bcrypt auth ... Revert "Revert "TT#56411 honor use_session => 0 for bcrypt auth WIP"" This reverts commit 1cfc524f80. Change-Id: I7eb0842bd61a4aaddbe50206fb974110ead8efb6	6 years ago
Rene Krenn	1cfc524f80	Revert "TT#56411 honor use_session => 0 for bcrypt auth WIP" ... This reverts commit 4789f6b61f. Change-Id: I6b514443afe9e2a8dbc1ae4a527a38fd3fc1d1c6	6 years ago
Rene Krenn	4789f6b61f	TT#56411 honor use_session => 0 for bcrypt auth WIP ... Change-Id: I549c4e6fc18b7cb738e99b3a6e254a47db3af0cf	6 years ago
Irina Peshinskaya	b27e4c5b87	TT#46856 Add openvpn toggle from admin panel ... Change-Id: I128e49117bd211edc44e2bf286c80cfc5a677b6a	7 years ago
Gerhard Jungwirth	4feeb76a93	TT#38005 fix/resolve various perlcritic errors ... this is to fix the TAP tests of the sipwise QA chain fixed (or ignored): - ControlStructures::ProhibitMutatingListFunctions - Documentation::RequirePodSections - InputOutput::RequireEncodingWithUTF8Layer - Subroutines::ProhibitSubroutinePrototypes - BuiltinFunctions::ProhibitStringySplit - TestingAndDebugging::ProhibitNoStrict - TestingAndDebugging::ProhibitProlongedStrictureOverride - InputOutput::ProhibitTwoArgOpen - CodeLayout::ProhibitQuotedWordLists Change-Id: I7dce4ce123bad40de2d9b51ba5b1a141e20c3783	7 years ago
Michael Prokop	12234e584d	TT#22411 Fix spelling mistakes/typos ... s/Diffrent/Different/ s/If it mathes/If it matches/ s/addreses/addresses/ s/altough/although/ s/autenticate/authenticate/ s/curently/currently/ s/dont't/don't/ s/dont/don't/ s/existance/existence/ s/explicitely/explicitly/ s/in in/in/ s/lenght/length/ s/neccessary/necessary/ s/occured/occurred/ s/occurence/occurrence/ s/packge/package/ s/paramters/parameters/ s/perfomed/performed/ s/propery/property/ s/recieve/receive/ s/reponse/response/ s/sematical/semantical/ s/serie /series / s/than than/than/ s/the the/the/ s/underun/underrun/ s/wether/whether/ s/wihout/without/ NOTE: Ignoring stuff in share/static + debian/changelog though Change-Id: I90fe718c92582eedf9325d2df3c3280f5f25afd7	8 years ago
Irina Peshinskaya	5ef25afdbe	TT#17848 Separate invoice creation method ... Change-Id: I6b0701ccb80601c7171e0891950276e9d375b429	8 years ago
Kirill Solomko	b2843a640d	MT#21683 fix a typo in log_passwords ... Change-Id: I691967b32e367c4449f53dd3c5d529a24ab05da1	9 years ago
Kirill Solomko	e0656339a0	MT#21683 no password length expose in the hidden form ... Change-Id: Ife59ff36d56c77db414cc7b0af7bdd8c1a31d493	9 years ago
Kirill Solomko	b821f24ee7	MT#21683 respect log_password config option and hide passwords if disabled ... Change-Id: I58cf444339b84419e8255c3345ad47f89c79ac23	9 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Rene Krenn	7f7e3332d1	MT#15477 topup log ... any *attempt* of a top-up request should be logged. +create top-up log records for api in order to record failed top-up requests as well, the somewhat tricky thing is to have two separate transactions here +propery casting of topup request json field values to numbers etc., so the transaction for creating the log entry cannot fail and e.g. requests with subscriber_id='blah' are recorded correctly +new "request_token" parameter for /api/topupvoucher and /api/topupcash, to identify and filter for particular requests. +topup log api resource +topup log api tests +fix to correctly reject used vouchers +topup log panel UI +fix for balanceintervals.t threaded tests Change-Id: I86eb845f6173803705b12cc7e5cdbac9a3153a0a	10 years ago
Rene Krenn	bef06dce91	MT#14301 deleting prof packages instead of terminating ... +profile package details view to overlook associations +voucher count is properly checked before deleting a package +package_id filters for /api/customers and /api/vouchers +Fake::Time replaced by Time::Warp for balance_interval tests +cleanup Change-Id: Idc34220a9d29c115453eeee2907e70a71cf9f0cc	10 years ago
Rene Krenn	c378681a24	MT#13903 balance interval catchup and resize WIP ... + synchronized contract balance catchup + balance interval resizing upon profile package transitions + dynamic interval length, interval start, carry-over propagation, .. + end-of-month 'preserve' mode correction for strictly aligned month intervals for start_mode=customer "create" timestamp + new api/balanceintervals resource to inspect contracts' balance interval histories + updated affected panel UI controllers + test case with time warps using Time::Fake caveats: - creating an invoice for a given 'period' (month) has to be refactored to select a disitnct balance interval. right now it takes the last interval in the month specified. - generate_invoice.pl is broken and needs a major refactoring Change-Id: I7bb54a83b76e510b1baa573a986d05400a7fec1e	10 years ago
Kirill Solomko	86f78f3b3b	MT#7705 - update last request tx_id only for a new request to work with scenarios where there are more than one reply for a request	11 years ago
Kirill Solomko	79d39d7926	MT#7705 - Remove newline from log strings passed to the logger	11 years ago
Kirill Solomko	22225a3b8d	MT#7705 - LOG= is now persistent in the log messages.	11 years ago
Kirill Solomko	71eadae6ea	MT#7705 - Message.pm further edited the pod doc	11 years ago
Kirill Solomko	503cdfcc7f	MT#7705 - remove =item from pod formatting	11 years ago
Kirill Solomko	c2fb0c6e32	MT#7705 - added doc for Utils/Message.pm	11 years ago
Kirill Solomko	c1c72dd6c7	MT#8547 - replaced experimental "smartmatch" code with the sane if/else custom SWITCH blocks	11 years ago
Kirill Solomko	2bebc00548	MT#7705 - Add logging for the rest of Controller/* modules. Message.pm: add data size check and trim the value if > 500 length	11 years ago
Kirill Solomko	66e8536f55	MT#7705 - add cname parameter passed to Message for anon subs name definition	11 years ago
Andreas Granig	71acba7111	MT#7705 Fix undef check in logger	11 years ago
Kirill Solomko	cc3d7c3b93	MT#7705 - Fix parametrized sprintf for logging	11 years ago
Kirill Solomko	db5c05fa8e	MT#7705 - Maxdepth for data structures is limited to 1 for the log messages. Check for undefined $desc in Message.pm when no $desc is passed for logging	11 years ago
Kirill Solomko	68a1aa349e	MT#7705 - Rework logging for Controller/Billing module. Improve Message.pm $log parsing and shown as LOG= (optional)	11 years ago
Kirill Solomko	ddc16492cf	MT#7705 - Message.pm - add str data types possibility. no $c->flash for API calls	11 years ago
Kirill Solomko	e24bea1f6a	MT#7705 - get_log_params() set default $type to "panel"	11 years ago
Kirill Solomko	8bc694dbe9	MT#7705 - Rework logging for API calls. Improve log messages in Message.pm	11 years ago
Kirill Solomko	a90de685e9	MT#7705 - add "$data" argument into log methods to manually pass data if required. remove trailing whitespaces	11 years ago
Kirill Solomko	a100ad5ea8	MT#7705 add IP into logged messages	11 years ago
Kirill Solomko	18e07b2950	MT#7705 change Panel.pm to use ngcp-panel/logging.conf, reworked Utils/Message.pm logging	11 years ago
Gerhard Jungwirth	1991296383	Filter Contract Contacts by whether they have a reseller_id ... in case the product in billing_mappings is one of (SIP_PEERING, PSTN_PEERING, VOIP_RESELLER)	12 years ago
Andreas Granig	9a1873bfd8	Fix test environment.	12 years ago
Gerhard Jungwirth	07d3ee5244	provide error message on "column" cannot be null ... and by making the respective field not_nullable prevent this from even happening Mantis: 3677#c22033	12 years ago
Gerhard Jungwirth	0909c813f3	Use the messaging utility for Domains	12 years ago
Gerhard Jungwirth	62124acf50	Have a new messaging util for custom filtering of error messages ... Use MooseX Method signatures for a cleaner environment	12 years ago