4 Commits (e8f41aba5078f91176aa7a80cb22c4d7adac81e4)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	1c10d54924	TT#144254 Rework ALE devices provisioning bootstrap ... * move to_log() and data_to_str() methods to the parent VendorREST module * rename send_request() to send_http_request() * use common send_http_request method for HTTP requests dispatching * improve logging * improve error handling Change-Id: I403aa8053e4abfaf6992b62809f15ab72e3a06fc	4 years ago
Alexander Lutay	94ef1fef2c	TT#89451 Update ALE redirect URL to api.eds.al-enterprise.com ... On 8/21/20 7:17 AM, Zhang Jason wrote: > For the RPS, we switched to new EDS domain: > https://api.eds.al-enterprise.com > > And for the previous domain name, > to keep compatibility, it’s still usable; We need to switch to new URL as old one works in backward compatibility mode only. Change-Id: I9c0db38a9422f32c79940fb79581d47c75e8fce5	5 years ago
Flaviu Mates	16365fb256	TT#76783 - Implemend ALE RPS devices auto provisioning ... * Implement checking/creation of server, profile and prepare request for device creation on ALE RPS * Prepare request for device deletion on ALE RPS * Changes in Panel to support provisioning via the ALE RPS Change-Id: I24b62c03b64c56fcbcabea71428d0b70b46706e6	5 years ago