3533 Commits (e5dd7e558786a0a93c904d9ede27fdbc05df3893)

Author	SHA1	Message	Date
Oleksandr Duts	e5dd7e5587	TT#129169 API: DELETE /api/admins/:id return wrong http 500 ... * Fix http code to 403 - Cannot delete own user Change-Id: I21225e112fd7e5b746381753b2e52474b6069c5c	4 years ago
Kirill Solomko	81ebdb8dcf	Revert "TT#151751 refactor persisting subscriber webpassword" ... This reverts commit 5e9066c4fb. This implementation breaks: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) Change-Id: I0e8389e8ab34ad72f1b87a684daba77f1030f8ba	4 years ago
Kirill Solomko	e95ed81ca7	TT#154500 improve admin users behaviour ... * admin users with is_master = 0, cannot see other admin users (this includes system users) and brings the is_master flag to the common behaviour * ccareadmin, ccare users can now access te UI Admins page as well as /api/admins but they are limited to see/manage only themselves * admin users cannot see system users (UI/API) * reseller users cannot see system/admin users (UI/API) * admin users cannot modify their own role and flags except for: email, password, can_reset_password (UI/API) * UI edit form now does not render fields that are not meant to be modified by a user (exception: "login") Change-Id: I82e1946437fd2ec4651abd24074470c695a40582	4 years ago
Rene Krenn	9a3c3cd42c	TT#153100 fix subscriber username queryparam search ... Change-Id: I56ca6601bb1abc38552561e0a110e875e9282a3b	4 years ago
Oleksandr Duts	9855b6ab45	TT#149461 Enhance /api/admins to accept the role data property ... - Optional "role" parameter is added for POST PUT PATCH. If "role" is provided then the passed flags are ignored and are applied internally by the server according to the provided role. If "role" is not provided then the former flags based approach is applied. Change-Id: Ib6e591ff6dc50122e0ec49a348153ca820fc2e03	4 years ago
Alexander Lutay	aac3a16e5e	TT#153950 Add label 'Invoice Template' to Invoice create page ... Otherwise the table is not signed at all on create 'Invoice' page. Change-Id: Idea6ab1df49b5de9db1b469fb872d031378bf3a4	4 years ago
Kirill Solomko	ca87855521	TT#149462 Form/Administrator/Reseller role_id required=0 ... * role_id field is set to optional as the API uses the form and there is no support for the role_id there yet Change-Id: Ib663b4d9d0501eca2310a7e95733c2166c9872eb	4 years ago
Oleksandr Duts	206877a476	TT#149462 Enhance UI admins role usage ... - Add Role column on /administrator table - Add Role dropdown input on /administrator/:id/edit - Add Role dropdown input on /administrator/create - Implements logic to resolve flags and role id params: 1. role_id is passed(create/edit) then flags will be overrided according to the concrete role. 2. role_id is not passed(create/edit) then flags will be checked to determine role id according to the concrete flags pattern: Role | Flags ----------- --------------------------------- system | is_system = 1, admin | is_superuser = 1 reseller | is_superuser = 0 ccareadmin | is_ccare = 1, is_superuser = 1 ccare | is_ccare = 1, is_superuser = 0 lintercept | lintercept = 1 Change-Id: Ia923a47f664a162d78a06efcc006f84dcd08701d	4 years ago
Kirill Solomko	4e309b9ef1	TT#153050 add API soft_expand query parameter ... * soft_expand=1 in API requests when coped with the expand query parameter tells the API to ignore possible expand conflicts (such as field mismatch or a permission issue), returning 200 OK instead of 409 Conflict Change-Id: Ib798aabddb1b4d66fc9708acbf713037696ad600	4 years ago
Rene Krenn	5445c72cc7	TT#144300 accept Windows .csv file uploads ... Change-Id: I2aae72cfc4ee418e6db8946152150f4fb400af31	4 years ago
Rene Krenn	5e9066c4fb	TT#151751 refactor persisting subscriber webpassword ... a multitude of issues popped after introducing bcrypted webpasswords in the database. most recently the PATCH /api/susbcribers rail was reported to reset the webpassword unintentionally. subscriber login fails afterwards, which is a severe issue. the bugs are adressed by this refactorings. the change also introduces a global variable $NGCP::Panel::Utils::Auth::ENCRYPT_SUBSCRIBER_WEBPASSWORDS to control encrypting webpasswords. it is still enabled as of now, but it's worth to consider disabling it. there other ways to have a "cost" for an authentication request, eg. adding a simple sleep(1sec). Change-Id: I2d47d54a2d83568546ffdd2b211337a5f56be3a2	4 years ago
Kirill Solomko	55a8d5568f	TT#152901 prosody provision ignore error on timeout ... * when a domain is provisionined in prosody and there is no connection to the host/port, the error is ignored and ok response is returned instead. Prosody does not have a persistent database and rather loads vhosts from kamailio.domain on startup and if it is down during domain creation/removal where will be no discrepancies when it starts. The new error checking behaviour benefits the CARRIER setups where a proxy host is still in xmlhosts but is not available (powered off) or prosody is not running there for some reason. Change-Id: Idaaaf2b31985873db9228958b60ff14fca5d1bf6	4 years ago
Rene Krenn	37f748cb76	TT#151401 invoice: calc totals from CDRs ... by default, re-rating CDRs of prepaid customers will not update the contract balances. in that case the total values on invoice PDFs become out of sync with the zone details list. Change-Id: Iba78b6386140012bb087235997880e8c28cc0972	4 years ago
Kirill Solomko	ac94626f9e	TT#149456 fix and improve user role_id retreival, api tests ... * NGCP::Panel::Utils::UserRole::_field_to_name now supports both hash and object to parse the roles from * NGCP::Panel::Utils::UserRole::resolve_role_id returns undef if no roles has been passed or there are no entries for the role in the database * Fix NGCP::Panel::Utils::Journals to correctly fetch and set $journal{$role_id} * Adjust api-journals.t, remove tx_id, user_id, role_id from checks Change-Id: Ieff23bd4291f3b88ba92bbfc2b00b57f66bf76e1	4 years ago
Kirill Solomko	16b4dfe5dd	TT#149456 Journal allow empty role_id ... Change-Id: Ibfb2707a730839b43cd7bda15082fd309f67be76	4 years ago
Oleksandr Duts	747af33a7a	TT#151250 Write journal resource params: user_id, reseller_id, role_id, tx_id. ... Change-Id: Ie6ae9f3a49fbd4be4f302a568669f78aecfdfe25	4 years ago
Oleksandr Duts	e58cb2cc39	TT#149456 Admins introduce role_id flag ... - role_id is taken from billing.acl_roles and written into the billing.admins table when a new admin user is created/updated via UI/API. This is the first step towards the role based admin user handling. Change-Id: I0804379cbbcab174cebbb292397a39cb3ea01a31	4 years ago
Rene Krenn	d9878f667b	TT#147151 fix dashboard ajaxrail for reseller balance sum ... Change-Id: I72f003ec74cd2658490da541de7e905d4e3aac7a	4 years ago
Rene Krenn	0b320b9eb6	TT#147151 fix widget ajax rail for customer costs ... Change-Id: I8b250c1ac884ad59c20b99be281583138f20e53e	4 years ago
Rene Krenn	2172e50e6e	TT#147151 fix ajax rail for reseller contract selection ... Change-Id: Id45b15378a396d0c1d5fd8fe9d07be07b6015ae5	4 years ago
Rene Krenn	27d86e75b0	TT#147151 fix dashboard peering contractbalance sum ... Change-Id: Id65db9d185ef5a3bf8bba4211e3154a53f7220b4	4 years ago
Sipwise Jenkins Builder	a47d0092c7	TT#4166 I18N dump: snapshot 2021.11.16-01.22.40 ... Change-Id: I00b882be15be9e5a03172726e773110208bfd6e4	4 years ago
Rene Krenn	d786af1591	TT#147151 finish refactoring of avoiding JOIN billing.product ... follow up on TT#147151 (fast loading/paging/searching panel datatables), which broke restapi tests. Change-Id: I799cb9087b9405c71dec4c690e7a7bab5dfdbdde	4 years ago
Flaviu Mates	fe09f80224	TT#86652 Fix utf8 fax body encoding ... * decode utf8 on multipart/form-data request since we encode the json for this content type, and the fax body gets double encoded and ends up wrong Change-Id: I50d10879e5fe1ba99141e76d311641fcd5d568a1	4 years ago
Kirill Solomko	6a0b5d7a75	TT#149459 expand consider null fields as valid ... * when field expand is requested and the field has "null" value (profile_id,profile_set_id), the field is considered as correct instead of returning 409 Conflict Change-Id: I2dfa918a0b99bff75429baa3e94a734fcb8c17e2	4 years ago
Kirill Solomko	2223ecf12e	TT#149460 add expand by profile_id, profile_set_id ... * profile_id expands NGCP::PanelRole::API::SubscriberProfiles allowed_roles: admin, reseller * profile_set_id expands NGCP::PanelRole::API::SubscriberProfileSets allowed_roles: admin, reseller Change-Id: I86aa81273d6f12fb1734b6c94597ca2e16b0bc12	4 years ago
Rene Krenn	f9ff14fab2	TT#146800 support decimal VAT rates ... Change-Id: I7222e012fbc6c848527f0f7a2a45c56894ae509b	4 years ago
Kirill Solomko	78b80e7064	TT#149459 enhance expand functionality with allowed_roles ... * allowed_roles in the expand defintion restrict the field only to the roles in the allowed list, otherwise the field is not expanded. Change-Id: Ib6f776388457327f2fa85e71deb9591022cee2da	4 years ago
Oleksandr Duts	ad6467561f	TT#149650 UI language handling ... * Change UI language workaround. Priority: 1. Parameter "lang". 2. Cookie "ngcp_panel_lang". 3. Default english - "i-default". * Add parameter "lang_save" - save the "lang" value at "ngcp_panel_lang" cookie. Change-Id: I0abc9e3ab564ba56d2e3f9b0dee47d32c27e0049	4 years ago
Kirill Solomko	8c556bbe36	TT#149459 improve and automate expand functionality ... * add dictionary support for fields that are expanded if encountered in all endpoints, with a possibility to override it, if defined on the endpoint's field level * move expand definitions from form fields into the Expand dictionary * simplify the expand usage, it now operates only with the <x>_id fields that are returned and visible in the response (e.g. if reseller_id is returned, then ?expand=reseller_id), the returned expand object name is <expand_field_name>_expand the, so in case of ?expand=reseller_id, the returned object will be reseller_id_expand * adapt Role/SystemContacts to work correctly with the expand functionality * expanded fields are returned as <expanded_field_name>_expand Change-Id: I4cab44ede9b40c70a95bbcedc81f58dd1f4e3b67	4 years ago
Oleksandr Duts	ddb7412d85	TT#134102 API language handling ... * Fix for language solving for API requests. Changed the sequence of language choosing: 1. Request parameter "lang" for API and UI. 2. Cookie value "ngcp_panel_lang" for UI only. 3. User agent/browser language for API and UI. Change-Id: Id5d814deead22eb7e2908fdc742b0c8474314d49	4 years ago
Kirill Solomko	f8d982708b	TT#147151 restore get_contract_rs() product join ... * restore the removed product table join in get_contract_rs() as get_contract_rs() and product.class are used in many places in the code that have their own filters by product.class Fixes: 133bd43df TT#147151 fast loading/paging/searching panel datatables Change-Id: I56e20f240ccc08cf1c9a25947f67990691425549	4 years ago
Javier Rodriguez	effb0e25a0	TT#146901 adding greet and temp directories into /api/voicemailgreetings for PUT/PATCH methods ... Change-Id: I72177d3baa4c76e38e8c6d99f4af7543252f7472	4 years ago
Rene Krenn	e83ed0960d	TT#147400 subscriber identifiers/lookup for prov template ... option to just lookup an existing susbcriber (instead of creating it). Change-Id: Ib5352541753c3435a48a56b36af5fe7dda1d51da	4 years ago
Rene Krenn	133bd43df4	TT#147151 fast loading/paging/searching panel datatables ... query refactoring an rowcount clipping for UI datatables that are slow when using millions of subscribers: contacts customers contracts subscribers billing profiles billing networks billing profile packages Change-Id: Ia50e3aa52684772548569b6908f0cbc08395a5a7	4 years ago
Javier Rodriguez	26bccf25d3	TT#146901 adding greet and temp directories into /api/voicemailgreetings for GET method ... Change-Id: Ib87c8128423416e8542afec500d13ea5dfa6881f	4 years ago
Javier Rodriguez	1b12afb13f	TT#146900 correction for time format via /api/voicemails/ ... Change-Id: I8f74c24560e1bfc9e7fe77b54d48e26d393e4dc8	4 years ago
Kirill Solomko	748ac564b0	TT#148250 enhance API expand functionality ... * add recursive expand support, so it's possbile now to do nested expands as "expand=contract.reseller". * comma separated fields support is preserved and with the enhanced expand "expand=contract.reseller,customer.billing_profile" it enables expanding "contract" with nested "reseller", as well as "customer" with nested "billing_profile". Change-Id: Ie82f5118dc13e57a0397566295644452f29bccde	4 years ago
Oleksandr Duts	a65d00c3a8	TT#139800 Enable subscriber access to /api/autoattendants/:id ... * "subscriber" role can now retrieve own autoattendant data. This is needed for the CSC interface. Change-Id: Id10b302205fe458d5793ae8f7bd9201233f9a0d4	4 years ago
Oleksandr Duts	e058a15958	TT#139351 enable DELETE method in /api/invoicetemplates/:id ... Change-Id: I3be4c4cee36d459da03b883f38d2b6442dbc304b	4 years ago
Oleksandr Duts	8017805589	TT#124802 GET /api/admins/:id/journal - fixing ... * Admins with is_system and is_superuser are able to see the items for all roles. * Admin is able to see own journal. Change-Id: I3e5d459b08ff7ef218220f1ae11974351121c489	4 years ago
Rene Krenn	e73dd3ea27	TT#132650 api .csv upload for provisioningtemplates ... the POST /api/provicioningtemplates/<reseller>/<template> request will accept text/csv content type to provision many susbcribers at once. Change-Id: I59079ba8f2bacc0ce2b1367d2bd1a7251cf4763c	4 years ago
Kirill Solomko	e4cfb19a38	TT#139550 fix vmnotify play/delete ... * fix vmnotify play from the UI regression * fix vmnotify DELETE API method * fix vmnotify DELETE UI method Change-Id: Id1224eb425c75be9325b707311ed3d0ac82ef2b7	4 years ago
Rene Krenn	4c47920f2e	TT#132650 run provisioningtemplate from api ... provisioning templates with their dynamic forms can be executed by a entityitem POST request, ie. POST /api/provicioningtemplates/<reseller>/<template> or POST /api/provisioningtemplates/<readonly template> Change-Id: I77f6c9d42e1afdb49635d3f11e4d73bcf6269605	4 years ago
Kirill Solomko	b199ad3e1e	TT#139550 improve vmnotify behaviour ... * vmnotify() now accepts cli and uuid arguments * API handling of voicemails is now improved to: - send a notify if the item's INBOX/Old has been changed - correctly process DELETE to send vmnotify after the item's removal Change-Id: Ic00ae825cf091bce273e55aa37cd0a7ac80d8b0f	4 years ago
Kirill Solomko	67bc755276	TT#139550 vmnotify use correct uuid ... * wrong value was used in the vmnotify select query, now the correct uuid is used Change-Id: I311cc7ea9cce01014dd40761d0bc7f594ecca7b2	4 years ago
Alexander Lutay	f1e00a0408	TT#141802 use proper SNOM param 'setting_server' on SRAPS ... For some reason SNOM SRAPS has two parameters with identical 'param_name'='setting_server': * "Settings Server URL" * "Settings Server" NGCP need to use the second one on SRAPS to set device redirect URL. We were receiving it by luck in the past. The commit e548057d4 introduced performance improvement to 'last' the search in loop after finding the proper 'param_name'. As a result of improvement we set wrong option on SRAPS. Dump of options for the history: * "Settings Server URL": >{ > 'links' => { > 'self' => 'https://secure-provisioning.snom.com/api/v1/settings/5683038cec6c4fa9be95b2de9d1750e8', > 'group' => 'https://secure-provisioning.snom.com/api/v1/setting-groups/8ab9230acf3f4060868509a93ad53f3f' > }, > 'attrs' => [], > 'choices' => undef, > 'default_value' => undef, > 'description' => undef, > 'field_type' => 'url', > 'fkey' => $VAR1->{'indexed'}{'enabled'}, > 'group' => '8ab9230acf3f4060868509a93ad53f3f', > 'multiple' => $VAR1->{'indexed'}{'enabled'}, > 'name' => 'Setting Server URL', > 'no_profiles' => 164, > 'param_name' => 'setting_server', > 'product_groups' => ['6cdbd3dfe5fe40e28c909f118a509b8a'], > 'section' => 'global', > 'sortable' => $VAR1->{'indexed'}{'enabled'}, > 'uses_permissions' => $VAR1->{'indexed'}{'enabled'}, > 'uuid' => '5683038cec6c4fa9be95b2de9d1750e8', > 'indexed' => { > 'default_size' => 4, > 'max_size' => 0, > 'start' => 0, > 'enabled' => bless( do{\(my $o = 0)}, 'JSON::PP::Boolean' ) > } >} * "Settings Server": >{ > 'links' => { > 'self' => 'https://secure-provisioning.snom.com/api/v1/settings/50a400560eec4dc0b96b026094e06562', > 'group' => 'https://secure-provisioning.snom.com/api/v1/setting-groups/8ab9230acf3f4060868509a93ad53f3f' > }, > 'attrs' => [], > 'choices' => undef, > 'default_value' => undef, > 'description' => 'Setting Server for Desk phones', > 'field_type' => 'text', > 'fkey' => bless( do{\(my $o = 0)}, 'JSON::PP::Boolean' ), > 'group' => '8ab9230acf3f4060868509a93ad53f3f', > 'multiple' => $VAR1->{'fkey'}, > 'name' => 'Setting Server', > 'no_profiles' => 3189, > 'param_name' => 'setting_server', > 'product_groups' => ['1a45a2a3f6b94c4cbfa5439b446132f7'], > 'section' => 'phone-settings', > 'sortable' => $VAR1->{'fkey'}, > 'uses_permissions' => bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ), > 'uuid' => '50a400560eec4dc0b96b026094e06562', > 'indexed' => { > 'default_size' => 4, > 'max_size' => 0, > 'start' => 0, > 'enabled' => $VAR1->{'fkey'} > } >}; The commit introduces the second filtering parameter 'section'='phone-settings', as we cannot rely on any other parameters. Change-Id: Iec2b2a0c2068efb90af20af3dba711dfc7f55ca8 Fixes: commit e548057d40	4 years ago
Kirill Solomko	68dcad8c70	TT#139550 improve vmnotify messaging ... * improve select from voicemail_spool to avoid sequental scan with like '%..' * select now fetches all messages count * add old messages count support * old/new messages are reported as 0 if not returned from voicemail_spool Change-Id: I11ac1a407e8d22fe828a17cda55aa3298c6e6f02	4 years ago
Kirill Solomko	5a31937140	TT#132650 EntitiesItem fix incorrect hal item debug ... * non-existing hal resource key was used in the debugging string causing the item operations, such as PATCH to produce 500 error Change-Id: I9e53dcf8b4b21385b9b1b877d87319023222f620	4 years ago
Kirill Solomko	4e33039bb6	TT#145300 fix domain vs customer reseller check ... * fix a wrong expression that checks domain vs customer reseller id Change-Id: I0da43bffa833ce5432848c23aacf307bc1b0a3ff	4 years ago