ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling * Role/Entities: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	2 years ago
Flaviu Mates	ab03c593c1	TT#88901 - Fix /api/admincerts GET * Request was failing with /?page=1&rows=10 because query params was an empty array containing an empty hash; it should be empty array only. Change-Id: I69717ab589c78ebb27c4cc4825b78f6900800eaf	6 years ago
Flaviu Mates	444a0d35b3	TT#88901 - Add GET and DELETE method for /api/admincerts * the GET request will show whether an admin has or has not a certificate * the DELETE request will remove an admin's certificate Change-Id: I2b233a76a4436a4d3a95749410e74aabd9fca531	6 years ago
Flaviu Mates	aec7c8921b	TT#76111 - Change LI admins flags permissions * Admin with lawful intercept will no longer be able to have any flags besides 'is_active', 'read_only', 'can_reset_password' * Remove reseller filter on interceptions since LI admins should see all interceptions * Add permissions to /api/admincerts and reseller ajax for LI admins Change-Id: Id912424b9bbd3ab3cbbc373ac116fda035f81fd3	6 years ago
Andreas Granig	8f8e1d5fc9	TT#78557 - Use bcrypt to hash webpassword * Change the way webpassword is handled accross NGCP Panel UI/API to comply with new password encryption * At login, if password is not encrypted with high cost due to the ngcp-bcrypt-webpassword script, encrypt it with proper cost * Accept old password format as well until all webpasswords are encrypted Change-Id: Iefa9584a62ab4b7d2a224d10bdd415e9cbb8dfb5	6 years ago
Irina Peshinskaya	d7c6689b93	TT#22496 TT#22495 Disable "sipwise" admin edit and delete Change-Id: I33341247220c389f997ca02104ccfa6028e76ebb	9 years ago
Andreas Granig	a52558b411	TT#22422 Implement capabilities endpoint Used to fetch whether pbx, faxserver, rtcengine etc is enabled. * Fix rtcengine reseller creation: - Refuse to create reseller if rtcengine part fails - Use proper auto-generated rtcengine values (pass, domain) to not fail on reseller names which are not forming valid hostnames. * Implement /api/admins/id to support testing - add test - fix creating admins with overly long login - fix various ACL bugs handling /api/admins/ - fix creating /api/admincerts/ as r/o user * Fix test framework - use proper client cert when switching API user Change-Id: I602fdd8181c0b3f23e76e3eab0df90a1ff9e986f (cherry picked from commit 0d376bd8b59db65296090d26f2c84d704129beef)	9 years ago
Irina Peshinskaya	07b9f8dcae	TT#10837 Make allowed_roles array reference Change-Id: I6ed557df160b963f964cd3cc09f79132ff37cfe8	9 years ago
Andreas Granig	b60b439220	TT#13249 Implement API to create admin client cert Admins can use this to generate a new ssl client certificate package in ZIP format containing a PEM and a P12 cert, the same way you can do it on the admin panel. Admins can generate that for themselves in all cases, or for others if they are master or superuser. If role is reseller, then masters can only do this within their own reseller. Change-Id: I32d5c1b5af5324d1c80b34bacecd7f2665cd91c7	9 years ago

9 Commits (e16002678ff626522a2789babea1bfdf331eb0f2)