54 Commits (d9f283cbc865b453c643d9a3c26333db03a061aa)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	e2afe2ea06	MT#56087 fix /api/callforwards sets auto creation ... * with PUT/PATCH data source and bnumber quick sets are correctly automatically created now Change-Id: Ia6f3be8958081f1611a1473b35c73826a9ed8784	2 years ago
Kirill Solomko	2b144caf2c	TT#128605 implement dynamic fields expand ... * add API functionality to request additional data and expand fields in GET methods * syntax: - /api/resource/?expand=all - expands all expandable fields e.g.: customer_id field is expanded and customer internally is queried and returned under "customer" => {...} (the returned data is identical to what /api/customers/id would return) - /api/resource/?expand=reseller_id,customer_id - expands only reseller_id and customer_id fields, if they are expandable - /api/resource/?expand=reseller_id,invalidfield_id - returns the data and expands only fields that are expandable (reseller_id in this case) but if it finds either unknown fields or non-expandable fields, changes HTTP status code to "409 Conflict" * adapt all API endpoints to support dynamic expand fields expanding functionality, however the actual expand for them requires modifying the form fields in the following format: has_field 'contact_id' => ( element_attr => { expand => { class => 'NGCP::Panel::Role::API::CustomerContacts', id_field => 'contact_id', alias => 'contact', fetch => 0, }, }, ); - class - represents the class that should be used by the logic to fetch the relevant data - id_field - which field from the resource needs to be expanded, it should be the "id" field (subscriber_id, domain_id, etc.) - alias - (optional), under which key the fetched data is stored. the field name is used as the key if the option is omitted. - fetch - (optional), if the returned data is under $data->{contract_id} then it will be fetched from there and stored under the key (field name or alias), otherwise the whole retreived data is stored under the key (field name or alias) * adapt /api/autoattendants to use the new approach (old one was expand=1) * currently supported endpoints with expand: - admins - autoattendants - domains - customers - customercontacts - resellers - subscribers Change-Id: Iac53409dad944ed4794039a48dc3a9f6dce25bc1	4 years ago
Rene Krenn	f6a2802130	TT#83502 api: drop ringtimeout pref when deleting last CFT ... if there are no more *enabled* CFT left after editing callforwards (simple/advanced), the ringtimeout has to be removed. Change-Id: Idc450b410a3822d787f32229a06d5c1f1438e632	5 years ago
Flaviu Mates	727af5dd56	TT#74527 - Upgrade /api/callforwards ... * Introduce posibility to provision source sets, time sets, b number sets and destination sets in the same request with defining call forwards. Change-Id: I8dd426bcf50a605e257af5e62ca404884bfe9c0d	5 years ago
Marco Capetta	5b39645647	TT#62269 add new call forward type "cfo" ... * "cfo" is for Call Forward Rerouting * "cfo" was not added into the "Secretary Manager" part Change-Id: I3c9eed1329ef93a1e643ace5f7b8c2db172f406d	6 years ago
Kirill Solomko	ce664263b2	TT#65101 add ccareadmin ccare roles ... * ccareadmin and ccare roles have full access to Customers, Subscribers and their preferences/settings, and read-only access to BillingProfiles,InvoceTemplates, EmailTemplates * ccare role is restricted to the related reseller Change-Id: I6cf7d3adf912f0fa98d1ef5c02abea2f4331ec4b	6 years ago
Rene Krenn	cae5270af5	TT#56340 panel logline obfuscation ... adds gdpr obfuscation quoting for: + subscriber numbers + subscriber ip addresses + subscriber usernames + any logmessage "DATA": query parameters, form data, response data + subscriber uuid's + call id's + callforward sip uri's the quoting is centralized by $c->qs() ("quote sensitive"), using catalyst plugin mechanism. escape symbols are set to « (\x{ab}) and » (\x{bb}). generate_logfile_data_inventory.pl was modified to mark loglines with "gdpr affected" status, if $c->qs() was used in a log message. Change-Id: I0f42d7992594232ae33e5666b0a64009211c5b76	6 years ago
Irina Peshinskaya	9ed0657d4c	TT#40503 Show journal links to allowed roles only ... Change-Id: I547b2db4767b1e383506bc812b6486db944fceec	7 years ago
Kirill Solomko	62a81f1ec7	TT#40010 add new call forward type "cfr" ... * "cfr" is for Call Forward Rerouting * "cfr" was not added into the "Secretary Manager" part Change-Id: I8cbc9888e827a343a2f80970f36de7ee011c7c66	7 years ago
Gerhard Jungwirth	9210ac0487	TT#37206 is_regexp flag for callforwardings ... implemented for Source Sets and B-Number Set in: * Panel * /api/cfbnumbersets/ * /api/cfsourcesets/ * /api/callforwards/ in addition, the fields have also been documented in the forms (and therefore also in the API documentation) Change-Id: I955dd9addf1e61ec7516b4c518adec151248bacc	7 years ago
Gerhard Jungwirth	a97cbbab0d	TT#37205 bnumber cf in API: /api/callforwards ... plus reorganize the Form to reduce code duplication Change-Id: I361fccb7b717649ebd439992d79856c97413feeb	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Kirill Solomko	3c6dba6070	TT#19459 check for undefined CF sourceset mode ... * CF source set is optional, in this case its value should be default to 'whitelist' Change-Id: If521c5ebf361ff22f5c491f4cfd7e26fad5476d8	8 years ago
Kirill Solomko	ad5f1b2ef7	TT#19459 add whitelist/blacklist mode to cf source sets ... * enables a mode for cf source sets, where all numbers are considered as whitelisted or blacklisted (similar to the NCOS levels mode) Change-Id: I84e76e5ba717050c48bcaf5c1fd5f67ed5582cab	8 years ago
Gerhard Jungwirth	8f98cd1d73	TT#4335 callforwards and speeddials subscriber api ... Change-Id: Ie48e86e74121f8c96bed97390a3803f51a247df5	8 years ago
Gerhard Jungwirth	dedea3b357	TT#4335 api reminders via subscriber login ... Change-Id: Ieba906d23695380600feecd82eab9e06b7a68702	8 years ago
Gerhard Jungwirth	7a5c1eb12a	TT#4335 callforwards for subadmin API ... Change-Id: I3e11c1405f971261aee6e6aff558a8bc2aad2185	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Rene Krenn	7b646044d8	TT#6735 TT#5850 refactor "profile" events to track number changes ... Change-Id: I59a01ebe0ddb440bc9a4f091c85b84641ae460b1	8 years ago
Irina Peshinskaya	37f6d0ea6e	TT#5954 Add announcement field to the destinations ... Change-Id: I2ac25edfd03bb9f72f343be1cb398a09ef29fb12	8 years ago
Irina Peshinskaya	69923f301a	TT#2393 Fix typo in sset deletion ... Change-Id: If646446f3cd6998687146ada25cd5694c108c685	9 years ago
Andreas Granig	776dd24f6f	TT#2371 Implement SMS forwarding ... Change-Id: If3478f7e962aa514931268bc560caa3c1dde9fc1	9 years ago
Gerhard Jungwirth	af86cac827	TT#2393 implement a-number cf for API ... callforward based on source-numbers in rest-api Change-Id: I94dcd67f09dd027e444894d2b549b9901eee7c22	9 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Gerhard Jungwirth	bb03c1ff46	MT#17173 fix item filtering in API ... item_rs from API.pm was not executed before Change-Id: I803f5680d174820db9497d4f7cc1902bfa54a9ab	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Rene Krenn	45b0f85705	MT#16121 PUT /api/callforwards/id json-hal response broken ... +due to optimisations in hal_from_item +journal affected as well, thats how we found this +so the last failing journal testcase should be fixed Change-Id: I33824cc92c4a4895d2dd3afe8bd963f442f556f5	9 years ago
Gerhard Jungwirth	85e2fdfd75	MT#16883 set vmb prefix in API ... Change-Id: Id9991e9baf1b5eb37f6b8cc88ab2dc23a6c93833	10 years ago
Irina Peshinskaya	7fffffb199	MT#16121 Optimize callforwards GET method ... Change-Id: I5672073eaa8b5594a3e4d4d2be64054584771d2b	10 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Gerhard Jungwirth	ffa327bfbf	MT#12905 set cf cli to the primary number ... Change-Id: I1e571fa4dc156de83c910dbfecd0280fa8b75b58	10 years ago
Rene Krenn	c411ece3a9	MT#11917 'must-have' api resources complete ... - ApplyRewrites + AutoAttendants ~ BillingFees OK + BillingProfiles + BillingZones - CallControls OK * CallForwards - CallLists - Calls OK * CCMapEntries OK * CFDestinationSets OK * CFMappings OK * CFTimeSets OK ~ Contracts + CustomerBalances OK * CustomerContacts OK * CustomerPreferences OK * Customers - CustomerZoneCosts + DomainPreferences OK + Domains ~ EmailTemplates OK * FaxserverSettings - Interceptions - Invoices ~ InvoiceTemplates + NcosLevels + NcosPatterns + PbxDeviceConfigFiles + PbxDeviceConfigs + PbxDeviceFirmwareBinaries ~ PbxDeviceFirmwares + PbxDeviceModelImages + PbxDeviceModels + PbxDeviceProfiles + PbxDevices OK * ProfilePreferences OK * Reminders OK ~ Resellers + RewriteRules + RewriteRuleSets - SoundFileRecordings ~ SoundFiles ~ SoundHandles OK * SoundSets OK * SpeedDials OK * SubscriberPreferences OK ~ SubscriberProfiles OK ~ SubscriberProfileSets - SubscriberRegistrations OK * Subscribers OK ~ SystemContacts OK * TrustedSources - VoicemailRecordings - Voicemails * VoicemailSettings Change-Id: Ibbaf8be32c6cda71637e16c40f345a15b8c1f530	10 years ago
Rene Krenn	96c731a144	MT#11917 Journaling for first set of resources ... the journal module introduces a change history of resources modified by api invocations. the history of the 'customer' resource demo is accessible at /api/customers/x/journal. Change-Id: I4d5d11bc3e35160feed587ce4c1db565991866b2	10 years ago
Kirill Solomko	8717f99396	MT#10965 - Callforwards api DELETE fix to use callforwards instead of rewriterules, check for non-existing mapping auto removed by mysql ... Change-Id: Id6fb16b15fae86b00ddf1e4ab590d43c05fe0e03	10 years ago
Andreas Granig	6a611ea779	MT#9263 Remove simple_destination on update	11 years ago
Andreas Granig	17a3260153	MT#9263 Introduce simple_destination in CF API	11 years ago
Gerhard Jungwirth	0ea1958cf2	MT#9291 CallForwards URI deflation ... original implementation in NGCP::Panel::Field::URI. Possible refactorings: a) into Utils::Subscriber b) setup proper deflation for api forms.	11 years ago
Irka	3e80b5fce6	MT#8609 API: Don't add ringtimeout into empty callforwardTimeout.	11 years ago
Irka	b59e7bb3df	MT#8367 Remove potentially ambiguous voip_subscribers.status reference ... Now DBIx uses subqueries for sequential searches so no ambiguity is present now.	11 years ago
Gerhard Jungwirth	3ab01777b4	MT#8157 api callforwards fix timeset deletion ... and only delete autocreated ones anyway	11 years ago
Gerhard Jungwirth	c1c1117600	MT#8035 Write start_ivr and end_ivr events ... when updating cf_mappings or cf_destination_sets one entry per cf_mapping	11 years ago
Gerhard Jungwirth	f56f49a7e8	MT#7841 callforward api: hide ids	11 years ago
Andreas Granig	5471f9115b	MT#7271 API: Explicitely set cf pref on update ... Make sure that if we have a mapping, that we also set or update the preference to the mapping id.	11 years ago
Gerhard Jungwirth	4d2722c5c1	MT#7271 API set user_preference on updating callforwards	11 years ago
Gerhard Jungwirth	2fc4743183	MT#6497 API use billing subscriber id on all places in cf_*_sets ... that is: - api/cfdestinationsets - api/cftimesets	11 years ago
Gerhard Jungwirth	d4cf98646d	MT#6497 API cfdestinationsets	11 years ago