3920 Commits (d0eddeee57c29f68bd91922f552a92a58a8bb80f)

Author	SHA1	Message	Date
Kirill Solomko	d0eddeee57	MT#64280 add ngcp_admin_ui_jwt realm and X-NGCP-Admin-UI header ... * ngcp_admin_ui_jwt is a copy of api_admin_jwt realm but with use_session: 1 * ngcp_admin_ui_jwt is used when X-NGCP-Admin-UI header is provided Change-Id: Ia82f97df922a69866f7c7d63ad1566ff0fc4bc2a (cherry picked from commit 41fb2d22cc)	3 months ago
Rene Krenn	b4472b74a0	MT#63980 fix Javascript prov templates raising errors ... The JE module will populate $@, hence an enclosing eval{} wipes the error string unintentionally. in addition the "die" method is now exposed in Javascript templates, to use it to bail out, ie. to propagate a msg from an input validation to the UI. Change-Id: Id3fcf8a7820ee3df51e0cc6323350f5f5908fcf4 (cherry picked from commit 5fb5a860c3)	4 months ago
Kirill Solomko	df6d7e401a	MT#64172 enable use_session = 0 for all API and JWT realms ... * this disables $c->user_exists to result in successful auth if correct session is provided. Change-Id: Id91b88f6f30dcca6a7b40eb61a23e2bbdabce7dd (cherry picked from commit 6003c3bab4)	4 months ago
Kirill Solomko	adfbb76f21	MT#64131 fix non-default NULL preference render ... * non-default NULL value is now correctly selected in the UI preferences list as well as in the edit form. Change-Id: Ief3b2e6778441c736589cfccc5a5fb7e60a7dcf0 (cherry picked from commit f6246ba094)	5 months ago
Kirill Solomko	56825b26cc	MT#64121 fix $c->error $c->error handling ... * errors coming from Utils::Preferences can have only 1 element in $c->error, the case is now correctly handled. Change-Id: I9f5d384da8b5cb50b78636309dbaab5efa9bdee2 (cherry picked from commit 9d70f62f70)	5 months ago
Kirill Solomko	be69c8fa0f	MT#64067 fix subscriberpreferences PUT update_item ... * PUT update_item is fixed to properly expect 3 values Change-Id: Id63445f76ffbc312aadafc7b502fffd070eb0089 (cherry picked from commit 56b15e8197)	5 months ago
Kirill Solomko	158b6a46ca	MT#64098 enable logger autoflush ... * Preamble: disabled autoflush caused logs to be written only when a request is finished, and what is worse, all of them with exact same time. As logging $c->log->* happens via syslog and rsyslog already uses buffering for that, there is no reason to cause such additional buffering by the Perl logger (which is Log4perl in this case). On top of it, it's already the default option for Log4Perl and was only inactive in the Panel app. * enable autoflush during Log4Perl init in the Panel app. Change-Id: I7cdcf7de30489d84fd8a9af88cb40669113ddbc1 (cherry picked from commit bb6b737c26)	5 months ago
Kirill Solomko	2d31d86c3d	MT#64067 address deadlock detection for preferences ... * improve Role/API/Preferences err_code callback to check deadlocks (via $self->check_deadlock) and set $process_extras->{retry_tx} = 1 so that the outer caller can act upon it and restart the transaction. * increase deadlock attempts from 2 to 5 as some deadlocks seem to take longer time to resolve. * wait 1 second between deadlock retry attempts as otherwise if a deadlock takes more than 1 second and all the retries are done within less than a second it will cause an error. * EntitiesItem: add support for retry_tx and call goto TX_START if $process_extras->{retry_tx} (when check_deadlock is processed externally, like in Utils::Preferences::update_item in the err_code callback). Change-Id: Ib56383710041c21d72782047a852353296c22215 (cherry picked from commit eae620f204)	5 months ago
Rene Krenn	d52e481e51	MT#63706 skip_locked for POST /api/subscriber/ ... add the SELECT .. SKIP LOCK mechanism for POST /api/subscriber/, to reduce lock wait timeouts when creating suscribers for the same customer in parallel. Change-Id: I067102b3dc726e5d12fa859613b548d007ce29ee (cherry picked from commit f501fc1dcf)	5 months ago
Rene Krenn	927f8f7146	MT#63706 skip_locked for DELETE /api/subscriber/id #1 ... Change-Id: I1bbc4d72ca405a4b3935b27d37e503be777de291 (cherry picked from commit a5ac1e959e)	5 months ago
Rene Krenn	ba8d64e746	MT#63706 skip_locked for DELETE /api/subscriber/id ... while acquiring locks is skipped nowadays for collections eg. a GET /api/subscribers/, timeouts were still reported for individual DELETE /api/subscriber/id requests. this change adds logic to skip acquiring locks for DELETE /api/subscribers. there is also a fix to make GET /api/subscribers/id and GET /api/subsriberpreferences/id work. Change-Id: Ie71abecd1f8387b9f56e8e0a47a5f1b16a6f308d (cherry picked from commit 2a5bd4c409)	5 months ago
Marco Capetta	3f2b406c85	MT#63893 Fix typo in commit 3b17ab6c54 ... Change-Id: Ieaa0f18cfab821a2c85de1a3602946c1855c8dba (cherry picked from commit 4f64c07ac5)	6 months ago
Marco Capetta	9a0b02014a	MT#63893 Call 'sip_dispatcher_reload' while changing peerings via API ... For scenarios when: * a peering server is enabled or disabled * a peering probe is enabled or disabled * a peering group with active peering servers or peering probes is removed a "sip_dispatcher_reload" XMLRPC request is sent to kamalilio-proxy, otherwise the dispatcher cache is not reflected and therefore, not available with the actual state until next kamailio-proxy restart. Change-Id: If3a98115224eb132126d5a53df7320cb6a33deba (cherry picked from commit 3b17ab6c54)	6 months ago
Rene Krenn	86c7d19ec4	MT#63724 reduce contract_cnt limit to 10 ... select count(1) from (select 1 from Y .. limit X) can have a longer runtime, depending on order of rows in table Y. to better limit the runtime, X is reduced from 1000 to 10. the UI will show now "used by 10+ contracts" instead of "used by 1000+ contracts". Change-Id: I028b0569cd5f3325d4bd6bed314517b061e4659b (cherry picked from commit 82b253973e)	7 months ago
Rene Krenn	340f92caac	MT#63706 skip_locked for GET /api/subscriber/id ... while acquiring locks is skipped meanwhile for collections eg. a GET /api/subscribers/, timeouts were still reported for individual GET /api/subscriber/id requests. this change adds logic to skip acquiring locks for GET /apu/subscribers/id and GET /api/subsriberpreferences/id. Change-Id: I0b739dd42947e30938e84b1339ba9b7535da8cb8 (cherry picked from commit 73664f29ba)	7 months ago
Kirill Solomko	cdc9e6f464	MT#63597 fix /api/callists GET by id ... * GET by id no longer throws 500 error with DBIx::Class::Row::get_column(): No such column 'source_cli_suppression_id' Change-Id: I852451e001b5fbbbd8e6363bc36da0d5b06c1539 (cherry picked from commit b6df422bba)	7 months ago
Kirill Solomko	ed71b62616	MT#63605 fix GET invoicetemplates without reseller_id ... * 'reseller' level invoice templates are correctly returned with reseller_id: null, instead of 500 error Change-Id: Ied1e7626fcbb2c28bf3850dd1788f06574ef892b (cherry picked from commit 0d3aac99a7)	7 months ago
Rene Krenn	d250d3a762	MT#63358 readonly prodile_id for GET /api/subscribers ... profile_id field seems mandatory for admin UI. bringing it back as readonly. Change-Id: I40d0842b83b54b37e80a469da4234c6feddcdaba (cherry picked from commit 4c7b7891c8)	9 months ago
Kirill Solomko	cb669386da	MT#63320 /api/vouchers rename to search by base64_code ... * the query parameter is now named base64_code to closely represent the expected value. * check and add trailing '=' if it's missing in the provided base64_code. Change-Id: I37c03cd663116d85b5115b5feee1eb6b282596be (cherry picked from commit b74fbabccc)	9 months ago
Kirill Solomko	a7c45f170c	MT#63320 fix /api/vouchers search by code ... * base64 code provided in the query params is now correctly re-encoded as encrypted base64 string to use in search. Change-Id: Id9e45079b260bdc51465a781124f6fbb636cf2db (cherry picked from commit 927be2a757)	9 months ago
Kirill Solomko	2388101583	MT#63182 add deadlock detection for DELETE /api/subscribers ... Change-Id: Idce6eccdbd490e69349808b6965f8212fe3e6e37 (cherry picked from commit aff1517a59)	9 months ago
Fabricio Santolin da Silva	db111dfb8e	MT#63070 Add request for sems to clear its audio cache ... This patch add the request for sems to clear its audio cache when the SoundSet is updated. Change-Id: Id6970b429b211f93d088703dcdfac15dd8d43088 (cherry picked from commit 0850b11f8a)	10 months ago
Kirill Solomko	528ebfc4c8	MT#63199 /api/subscriberpreferences add lockwait and deadlock detection ... * lockwait and deadlock detection is now in place for ALL /api/subscriberpreferences endpoint methods. Change-Id: Icb613677dfca1187b3a1e707588ad6e9547d3c9a (cherry picked from commit 9ee717744a)	10 months ago
Kirill Solomko	fbc76543bb	MT#63182 /api/subscribers add lockwait and deadlock detection ... * API::check_deadlock() add lockwait detection. * lockwait and deadlock detection is now in place for ALL /api/subscribers endpoint methods. because of logic complexity it uses own deadlock detection instead of relying on Entities. It however uses $self->check_deadlock() and similar logic. Change-Id: Idc1876910711563fe14c878541e350ad373d6d31 (cherry picked from commit 3bb3d9e4e4)	10 months ago
Kirill Solomko	153040f11c	MT#63062 /api/customercontacts fix PUT/PATCH reseller_id validation ... * add Form::Contact::AdminAPI that uses reseller_id field instead of reseller for better error message * update_contact() fix reseller_id validation for admin roles * update_contact() copy reseller_id from $old_resource for reseller roles so that further reseller_id checks can pass. Change-Id: Ic9559a944265f5c8bceada6077fcf8e14d6bc5d4 (cherry picked from commit b8cd29ce32)	10 months ago
Kirill Solomko	a0ec043032	MT#63062 fix /api/customercontacts for reseller roles ... * fix logic in update_contact() that was performed with the reseller_id that became undef after form validation for reseller roles. Change-Id: I2e1d386f01b5d279188a7600d2d7f0d9d44b7853 (cherry picked from commit f7a3b1eab2)	10 months ago
Kirill Solomko	ae849e3595	MT#62705 fix get_peer_auth_params() $rs ... * fix $rs check expression to check for both undef and $rs->value as otherwise it fails when $type is neither 'subscirbers' nor 'peerings' Change-Id: I59e2c445416d5107a4aa207a9f16552d806df54d (cherry picked from commit 8037316fe4)	12 months ago
Kirill Solomko	46e6b95568	MT#62705 improve peer_auth registrations support ... * DELETE /api/peeringgroups and PUT/PATCH/DELETE /api/peeringservers now call sip_create_peer_registration or delete_peer_registration correspondingly to correctly reflect the registartion on related changes * rework Panel::Utils::Peering create_peer_registration() and delete_peer_registration() - use provisioning peer db object in the argument instead of a separate hash to simplify its logic - adjust related UI parts that call these functions as well as cleanup now unnesessary code from there * Panel::Utils::Peering: remove '_' prefix from _sip* functions as they are not private but rather public class methods * Panel::Utils::Preferences - add suport for 'peer_auth' updates for type='peerings' (was only supported for 'subscribers') - remove '_' prefix from _is_peer_auth_active() * Panel::Utils::Sems - simplify peer registration by using the the db object (same as for subscribers) - only create/delete peer registration when the peering is enabled, otherwise there will be errors related to unavailable $prov_peer->lcr_gw->id Change-Id: I0fc79a6580fd17aa34df870fb7a93e33edfff15b (cherry picked from commit 4d26ca5c9a)	12 months ago
Rene Krenn	ee332b3db1	MT#62283 fix dbix "for update no lock" patch ... Change-Id: I51f2bf23c467c9919794548499ae13dd98430370 (cherry picked from commit 3c497cb52c)	12 months ago
Rene Krenn	d2012c1ee8	MT#62283 exclude "for update no lock" in tests ... Change-Id: I12ff4d1f8ba0b150a1918de40dafa1efd6a92c10 (cherry picked from commit 764ab7d2d1)	12 months ago
Rene Krenn	b83fedd610	MT#62283 "for update no lock" logic for GET /subscribers and /contracts ... to unblock the web UI on heavy loaded systems with call rating enabled, "select .. for update no lock" will no longer wait for acquiring locks when retrieving subscriber or contract contract pages. the contract_balance record creation is will be skipped for such contracts that are locked elsewhere. for rails such as /customerbalances, an explicit contract id row lock timeout is introduced, so it does not depend on the mariadb wait_timeout. Change-Id: I6e96342f3f761279a5876c871d2477977823a39e (cherry picked from commit 82af5cf518)	12 months ago
Kirill Solomko	26ffaf0d82	MT#62600 fix UI invoice create/edit ... * fix Invoice create/edit operation error Couldn't render template "invoice/create.tt: file error - invoice/create.tt: not found"<BB> that was related to an incomplete restricted function call. Change-Id: Ic457f180ca99fcdacd51b2ba3bb5606719ea9bdd (cherry picked from commit 7a7c5cd364)	1 year ago
Rene Krenn	75bd22b8c4	MT#61646 fix phoenbook .csv encoding ... Change-Id: Iaf7e6a0d13f34459fb00478dc6285875fba52cfb (cherry picked from commit 8a11b8e996)	1 year ago
Marco Capetta	ab34a06fe8	MT#62546 Fix permanent registration nat flags ... Due to changes in how kamailio manage the NAT contacts and the corresponding natping, the flags that the API or web interface sets while a permanent registration is created have to be updated. Before: * Default cflag is set to 0 (natping disabled) * If nat option, then cflag is set to 64 New: * Default cflag is set to 256 (netping disabled) * If nat option, then cflag is set to 128 Change-Id: I39b1d7a697ef72267fd8a05edf0552d2c1403733 (cherry picked from commit 1be3f5a257)	1 year ago
Kirill Solomko	ae5a3b73fe	MT#62178 fix external_id, profile auto removal for subscriber roles ... * fix 'subscriber' and 'subscriberadmin' roles using PATCH to cause external_id, and profile fields removed. * remove profile_id field from the 'subscriber' and 'subscriberadmin' form Change-Id: Id8bb068ca7fcac2c0c5954f2ed79e841d18ac398 (cherry picked from commit 97e457c92b)	1 year ago
Kirill Solomko	4899e86fdb	MT#61572 allow subscriber to GET resellerbrandinglogos ... * 'subscriber' role can now GET resellerbrandinglogos * fix 'subscriberadmin' role access to POST resellerbrandinglogos Change-Id: I4002117e15e5557dfbfe887dea3773d8704aeb14 (cherry picked from commit 989e7b5640)	1 year ago
Kirill Solomko	af4d120e94	MT#62223 improve error response handling when log_response is off ... * log_response: 0 is reworked, it now always logs the response but in case if it's off the body is not logged. * adjust error logging, the error in the body is correctly logged in the response even if log_response: 0 Change-Id: I6dfddeccffb5464b830133235bf63c5e82ae6073 (cherry picked from commit e8f41aba50)	1 year ago
Kirill Solomko	1a8210f3d4	MT#62223 API unhandled internal errors cause 500 error ... * unhandled internal errors (such as DBI error) are now properly returned as 500 Internal Server Error instead of 200 OK Change-Id: Iabc80cd200c9091dd249bc90aa586d5d7b616b69 (cherry picked from commit cbc4e57d45)	1 year ago
Kirill Solomko	8c69ddf504	MT#62180 /api/subscribers prevent subscribers from POST/DELETE ... * regular subscribers should not be able to use POST as they are not allowed to create other subscribers, nor other PBX groups. resource. * they should not be able to use DELETE as they cannot delete themselves nor other subscribers, nor PBX groups. Change-Id: Idaacb344b65ff8c5da9f4c3649a9b4089938a82c (cherry picked from commit 4eace822b5)	1 year ago
Richard Fuchs	a54248e1c5	MT#59979 defuse license logs ... A missing license is allowable on CE systems. Don't log errors if license is missing. Don't die if sysopen() fails. Change-Id: I00c8ecf361548da6452f1b631d308d9aa8901368 (cherry picked from commit 015ee893d9)	1 year ago
Kirill Solomko	25381e726b	MT#62093 return 403 Banned for banned users ... * add banned user redirect for API requests Change-Id: I0b09879c2e0802c8cc649c92c239449742314b56 (cherry picked from commit d5fd8679fe)	1 year ago
Rene Krenn	55b06ee835	MT#61558 fix reseller (branding) license restriction ... some rails got disabled when introducing the fine-grained license restrictions in api/panel, ie. reseller branding. Change-Id: I0b3690d8e0353c31f2c8680db63c4dd4df7600fe (cherry picked from commit 9f4c50c5dd)	1 year ago
Kirill Solomko	56d5094cb3	MT#61673 /api/calllists fix missing type response field ... * The 'type' field is now present in the reponse as it's described in the form and also the search params but was not rendered correctly because in the database it is as 'call_type' Change-Id: If7b69a33ed9578be6873462dbab79c9a2079b076 (cherry picked from commit 1873193814)	1 year ago
Rene Krenn	f3efcc36cc	MT#61513 prevent duplicates in GET /api/callrecordings ... callrecording metakeys such as "uuid" for the involved call party is present multiple times by nature. the ?subscriber_id= query param will then narrow down the result. alongside an implicit role filtering (reseller/subscriber), the sql join and filtering for the uuid key is present 2 times however, and multiplied records slip through. this can be prevented with DISTINCT. to avoid performance impacts and consider other metakeys orrcuring multiple times, it will be applied only if a filter is present. Change-Id: I08047aaee265e2e0a706220e03fd4617da16d33c (cherry picked from commit 598f7dbaf4)	1 year ago
Rene Krenn	6db10cc3f7	MT#60197 support deleting call recordings per subscriber ... admin panel will no longer delete callrecordings for all parties of the call, but the single subscriber only. rest-api, behaves the same way, if the ?subscriber_id= parameter is provided. when a callrecording is deleted by all call parties, the remaining records and recording files will be dropped. Change-Id: I61f667bdb074a935a8a04473a3685b10e5e09222 (cherry picked from commit 1c09e2773a)	1 year ago
Marco Capetta	2dddd7ec82	MT#60864 Fix Sync Email Templates button behavior ... The 'Sync Email Templates' button is shown in the Email Templates page in case some templates is missing for a reseller. The problem is that the button takes into consideration also resellers that are already terminated and for which the template is not needed anymore. Thus the query has been in fixed in order adding: r.status != 'terminated' Change-Id: I2dd551166ae777c8967eae3bda989b669b46b5c0 (cherry picked from commit 97adbaf8e7)	2 years ago
Kirill Solomko	ad90357078	MT#60553 handle API subscriber timezone field separately ... * timezone field for SubscriberSubAdminAPI form is now Text instead of +NGCP::Panel::Field::TimezoneSelect because the template => 'helpers/datatables_field.tt' produces a field validation error, as well as the Field is designed for UI and not API. * add validate_timezone() field validation to SubscriberAPI and SubscriberSubAdminAPI forms. Change-Id: I6391694284477976d8d6cee71a81e2241bd94937 (cherry picked from commit e83588874b)	2 years ago
Marco Capetta	d2ef595fac	MT#61065 Fix 'cli' preference removal ... In commit b51c0c9698 the possibility to change the 'cli' preference by subscriber and subscriber_admin was added (under certain limits). On the other hand, the additiona of that part of code broke the possibility to remove the preference using the PATCH api. It is a very uncommon scenario though, but it seems anyway used by some customer. We may think to deprecate this possibility one day, but till then we don't have to create regression to customer. Change-Id: Ie695b567929eb79b1ba63d3c5a31ae5ce7b559bd (cherry picked from commit f9a328f83d)	2 years ago
Marco Capetta	c27388f218	MT#60756 Fix subscriberprofiles POST api call as reseller ... Administrators with reseller role were not able to create new subscriberprofiles because API was fialing with 500 error. In particular: LOG="«DBIx::Class::Row::store_column(): No such column 'reseller_id' on NGCP::Panel::Model::DB::voip_subscriber_profiles at /usr/share/perl5/NGCP/Panel/Controller/API/SubscriberProfiles.pm line 172» The error was caused by the addition of the reseller_id info in the $resourse even if not needed. Change-Id: I7970a2716d7af959639937a9a844160ab73a9176 (cherry picked from commit d40126ef0a)	2 years ago
Kirill Solomko	afb2dba6d5	MT#59449 fix perform_auth to send correct realm to ban check ... * perform_auth $realm is in a form of a subrealm, e.g. api_admin_http api_admin_jwt, etc. where for bans check it's 'admin' realm. Therefore, user_is_banned() is now called from there using explicit 'admin' realm as the argument. Change-Id: I3a10a9b492bf9dbe83ddd34a8851e83b23f90587 (cherry picked from commit a3945269fc)	2 years ago