45 Commits (cca1477f9a81f2c65f220e367cbbf8112da014d9)

Author	SHA1	Message	Date
Kirill Solomko	cca1477f9a	MT#62223 improve error response handling when log_response is off ... * log_response: 0 is reworked, it now always logs the response but in case if it's off the body is not logged. * adjust error logging, the error in the body is correctly logged in the response even if log_response: 0 Change-Id: I6dfddeccffb5464b830133235bf63c5e82ae6073 (cherry picked from commit e8f41aba50)	2 months ago
Kirill Solomko	b041888807	MT#60656 add max_age password validation support ... * UI: password are now validated against $c->config->{security}{password}{web_max_age_days} (unless it's 0) and if the password is expired the user is redirected automatically to /changepassword page, and after successful password change back to the original page. * API: if password is expired all API requests will be returning 403 Forbidden "Password expired", except PUT/PATCH to /api/admins or /api/subscribers with the new password in place. * successful login on the UI now redirects to /dashboard instead of / (to prevent unintended redirect to v2) Change-Id: I075f8e17cc9b0658d6b3b3d526ca5b379d050ce4	9 months ago
Kirill Solomko	9d021be65a	MT#59979 add license control ... * UI and API parts are now under license control * new Util::License::get_license($c, $name) - fetches license status by name (1 if enabled, and also if /proc/ngcp/check if 'ok') * add Catalyst::Plugins::NGCP::License with license($name) to fetch valid license by name from anywhere using $c->license('pbx') or from the templates using c.license('pbx'). It internally uses Util::License::get_license($c, $name) * License::get_license_status($c) now requires $c as first argument as well logs license status check errors. * new ActionRoles::License that enables usage of :Does(License) RequiresLicense('pbx') LicenseDetachTo('/denied_page') in the Controller chains * Add license control for UI elements and return 403 Forbidden if a resource is covered by licenses and the license is not active * Hide UI elements if a license is not active * API/Entities/Entities new $c->set_config key: - per endpoint: $c->set_config({ required_licenses => [qw/pbx device_provisioning/] } - or per method: $c->set_config({ required_licenses => { POST => [qw/pbx device_provisioning/] } } } * In case if an API endpoint does not have a license: 403 Forbidden "Invalid license" reply is returned. * Add license based restrictions to API endpoints * /api documentation: - completely hide endpoints that do not have an active license - hide only methods that does not have an active license Change-Id: Iba45fc5068b02306a617fed7b5405f2210574b61	9 months ago
Kirill Solomko	6543743992	MT#60162 improve expand functionality for collections ... * in general expand collection now performs only 1 sql query to per expand field to fetch all items by the ids instead of fetching them for every single collection item, that should significantly increase performance in case of large databases and reduce work for the database * introduce $c->stash->{expand_cache} that contains cached data for the expand fields to avoid multiple same calculations * expand_field() and expand_field_data() have been reworked to support expand_cache * new method expand_prepare_collection() is called for all API GET collection methods before preparing resource hal fields, to change the expand logic to only cache the data instead of fetching it from the database * new method expand_collection_fields() that is called in all API GET collection methods after the @embedded data is prepared to finalise the expand collection fields * for expand collection there is only 1 SQL request per expand field that fetches all items -in [ids to expand] and then the expand_collection_fields() uses the cached items_by_ids with O(1) fetch from the cache by id Change-Id: Ie7c6115472878febf0d8c9b4d833f5c23b15c78b	10 months ago
Kirill Solomko	6926930b3a	MT#60227 handle Accept: application/json header ... * if Accept: applicaton/json header is provided for API request - the response's Content-Type header is set to application/json. The return content in this case is preserved as HAL but it's helpful for the clients that only expect aplication/json response Content-Type Change-Id: I8c60da4df7d639f45953d8ace699a59fefc88ddf	11 months ago
Kirill Solomko	1872f342a0	MT#59478 Entities/EntitiesItem more $c->has_errors checks ... * additional $c->has_errors checks for post/patch/put/delete to cover all possible expected called inherited methods scenarios and returns. Change-Id: I0e09ba62bcaa51d582315d9cbb672a4cf11bacf0	1 year ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	09b589738d	TT#182101 Phonebook feature is hidden for CE ... * templates now rely on c.config.general.ngcp_type and hide the Phonebook feature everywhere if ngcp_type is CE * introduce "allowed_ngcp_types" config for Controller::API::* that is an array, and when specified, only the ngcp_type roles are allowed, otherwise if not specified all ngcp types allowed (default) * Controller::API::Root: - filter controllers from the documentation rendedring that have allowed_ngcp_type config specified and do not match the current ngcp type * Role::API Role::Entities* - new method check_allowed_ngcp_types() - check_allowed_ngcp_types() is now called in Entities and EntitiesItem auto() and denies to 404 Path not found if the ngcp type does not match * "Phonebook" UI is now hidden for CE * /api/phonebookentries is now hidden for CE Change-Id: I41d4b2f87121f281472be3775b862333923fe37f	3 years ago
Rene Krenn	b6e696621b	TT#132650 /api/provisioning_templates CRUD rail ... the /api/provisionintemplates rail provides the operations to create, edit and delete "provisioning templates" know from the "batch provisioning" feature of admin panel. these templates can also be defined in config.yml, while it is however only possible to edit templates stored in the database. executing a template and/or uploading a .csv for bulk execution will be available in a separate part. Change-Id: If8627327270edfce5bca1be3b1f777c1bd44e90f	4 years ago
Guillem Jover	467084705d	TT#71950 Fix typos ... Warned-by: codespell Change-Id: If7e52bf2fbf013586e802e5ebb77a272599d9c38	5 years ago
Irina Peshinskaya	1fe6db943d	TT#48198 Use items array from paginations in all api controllers ... Change-Id: I1856cd4f073d32b4465d0778baf5f9f7c708f78c	6 years ago
Irina Peshinskaya	ffd1b487bf	TT#40503 Add journal actions to entities FW ... Change-Id: Ia0d51f246756f649dc440cde7b4fb0e8056d3ced	7 years ago
Irina Peshinskaya	3a814a98a1	TT#37684 Fix broken journal rails ... Place journal action configuration to correct place Change-Id: I0cd82d0801ac6ce4ad40b86ec715d6704ecff0b0	7 years ago
Irina Peshinskaya	6d69eebf74	TT#35538 Prepare API to faxes changes ... * Consider POST body not utf8 encoded, so encode "json" parameter * Allow empty body for multipart/form-data controlled by configuration as faxes took text from "json" part too. * Allow empty return from create, meaning asynchronous operations, like fax creation * Allow to skip hal validation through form. Can be used for collections without PUT and PATCH. Change-Id: If0d0e7cdc6abe53d76ad0b18568e93743040e90f	7 years ago
Kirill Solomko	f976fe03fb	TT#35714 use collection_nav_links in all API controllers ... * colelction_nav_links() should be used instead of the old self/prev/next href link code * Entities.pm fix colletion_nav_links() to pass missing $c->request->params * collection_nav_links() use default $c->request->path and $c->request->params if those arguments are not specified Change-Id: Icca5afac812f2e06e6927ba6f4e91057f9745d21	7 years ago
Irina Peshinskaya	8eec82f1bb	TT#34567 Use already created hal links for embedded and Location ... Change-Id: I3e32ecb89cc9b6966dbe5caa2fa7a26054c7b23b	7 years ago
Irina Peshinskaya	05c2708832	TT#34567 Apply mandatory parameters to hal links ... Change-Id: I90dd7f7ae600ccfa589a7624681f35655ae9a098	7 years ago
Irina Peshinskaya	5adf181084	TT#34567 Use getter for the API controller config ... Change-Id: I17eaa813a3b7eb0ae18c110e12037af713016dad	7 years ago
Irina Peshinskaya	4c53ac4d7d	TT#34564 Add csv download and upload to PhonebookEntries API ... Change-Id: Ie4bd350348370ba51fe868cf478244a549dec930	7 years ago
Irina Peshinskaya	3308321387	TT#34015 Clear and stable implementation of early input check ... Change-Id: I12788583d24f8a02e6e29f04194d8daa0b159efa (cherry picked from commit e946675f4893ba50e0389ff78642b783f7386318)	7 years ago
Irina Peshinskaya	60e209ca84	TT#34015 Introduce /api/phonebookentries ... * /api/phonebookentries is used for the phonebook_reseller phonebook_contract phonebook_subscriber data storage interaction Change-Id: If45390fd3080886e03602216cfbacc33296f1558	7 years ago
Irina Peshinskaya	b9f593b7fc	TT#28460 Entities classes use more unified config ... And introduce EntityPreferences Change-Id: I4753f14e1ba2c1e6d01559b44ba0138891c91e81	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Gerhard Jungwirth	edbef3c5b8	TT#29617 remove unnecessary form exceptions ... with the previous commit, there is no need anymore to specify form exceptions manually. validate_form will now automatically consider fields in the correct format with and without "_id" Change-Id: I70afae4003c6407c7a37396630110736f1fb13f8	7 years ago
Irina Peshinskaya	3becbebe1b	TT#28453 Fix roles for config_allowed_roles inheritance entities ... And add subscriber as allowed role for the pbxdevicemodels Change-Id: Ifc373a57fcc647d83d955df80494d4a60c825db3	7 years ago
Irina Peshinskaya	7709f541bf	TT#23955 Consider form_exceptions in the Entities GET ... Change-Id: Id407f7af9e9696d76b16e602b2c0d50818c99a45	8 years ago
Irina Peshinskaya	34bc2d5485	TT#21348 Add Item class for the conversations API ... Change-Id: Id357e747842d5c3e0f11634dfd5fa950ca36cb1c	8 years ago
Irina Peshinskaya	38ef5dafb2	TT#21819 Allow to adjust resource before form validation. ... Add separate pre-process method Change-Id: I939d4d516de7d3d955b281b6afb6c59006771c8d	8 years ago
Andrii Pogrebennyk	2bcac80e96	Revert "TT#21819 Allow to adjust resource before form validation" ... This reverts commit 2031ea21c5. Change-Id: I6f4092eddc6f7c203c808e3c9ce255c49aa7aa41	8 years ago
Irina Peshinskaya	2031ea21c5	TT#21819 Allow to adjust resource before form validation ... Change-Id: I47d71a6df12bdaa6f20f30fd9562f1ad2d91ecad	8 years ago
Irina Peshinskaya	ce315a86c6	TT#21819 Add provisioning fields to the API response resource ... Remove excrescent code from the pbxdevicemodels API & Panel Add roles control per method for the API Use form field "required" attribute for the API uploads Fix getting old resource for the PATCH and PUT methods Change-Id: Ia0515b3d071d45435db7c9138ea9de9447775143	8 years ago
Kirill Solomko	792c2bccf7	TT#20095 improve sms billing handling and journaling ... * billing is split into 2 parts: - init_prepaid_billing (reserves billing/creates session) - perform_prepaid_billing (commits or cancels the session) * when sms fails to be sent the billing session is canceled (was committed before, regardless) * NGCP::Panel::Entities::post - do not do $self->return_representation_post() if api_error_message is present, therefore, the actual error is returned * sms_journal item is now created also in case of an error * improved errors indication Change-Id: I454b8c6a1c04d743ee82e03f8621c7cc4c7c4f98	8 years ago
Irina Peshinskaya	c0940df9db	TT#17638 Rewrite Rule API to set priority ... Change-Id: I84099ab6d4869ee232532668fa15f1cc40501fb8	8 years ago
Irina Peshinskaya	07b9f8dcae	TT#10837 Make allowed_roles array reference ... Change-Id: I6ed557df160b963f964cd3cc09f79132ff37cfe8	8 years ago
Irina Peshinskaya	10b25b2bba	TT#10837 Cleanup unused code and libraries references ... Change-Id: I11b2b3ad480980f391af508f946703ca230be6d1	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override ... the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Andreas Granig	2eff3bf540	TT#9702 Implement I-New SMS charging. ... Change-Id: I3db0f45fcd071577f0799f8682788fa626dccabc (cherry picked from commit b81b067eac)	8 years ago
Gerhard Jungwirth	0b999d6727	TT#4324 voicemail permissions for subadmin ... * /api/voicemailgreetings/ * /api/voicemailrecordings/ * /api/voicemails/ * /api/voicemailsettings/ Change-Id: I3d8974b5d6ae821b03bd8d4a005cec91083eb327	8 years ago
Irina Peshinskaya	c31e254486	TT#5953 Voicemail greetings ... Change-Id: I6024de5a9264b765097dfce3f7ab4b99637eabe3	8 years ago
Gerhard Jungwirth	ea210ba37e	MT#17173 small inconsistencies in Entities modules ... * map regex fixed * get_form may return an array with the exceptions now * use get_item_id consistently * use warnings and strict Change-Id: I9f356814ecf4b51613d3aee3782a6b3b91f04cad	9 years ago
Irina Peshinskaya	a42334ca16	MT#17173 Add return representation ... Change-Id: Icc48160e57e172196db31ff85c419da7e3e9904a	9 years ago
Irina Peshinskaya	ad208784a1	MT#17173 Adapt common API method for not DB entities ... And add some IoC methods Change-Id: I165824e682c1d0a5ae34f5d2da4b9f2fbd040555	9 years ago
Irina Peshinskaya	f288ec2563	MT#17173 Add common methods to use in future API ... Change-Id: I56387a95e916be2e8e94b32a8981c465962ad66f	9 years ago