ngcp-panel

Author SHA1 Message Date

Author	SHA1	Message	Date
Alexander Lutay	23cb63fe4f	TT#68019 Remove JS hint: sourceMappingURL=rrule.js.map from rrule.js and luxon.js Those lines confuses Firefox 69.0.1 (64-bit) on dev laptop and Firefox 68.0.1 on Jenkins in the following way: AXAJ data is not loaded/shows on WEB interface after editing "Time set->Events". The permanent message "Loading..." is displayed in the table. The JS error says: > Source map error: TypeError: NetworkError when attempting to fetch resource. > Resource URL: moz-extension://93b8c0a0-04b0-41df-8ec9-8647b0f75bc2/browser-polyfill.min.js > Source Map URL: browser-polyfill.min.js.map > > Source map error: request failed with status 404 > Resource URL: https://ce-trunk.mgm.sipwise.com:1443/js/libs/rrule/rrule.js > Source Map URL: rrule.js.map It looks like the first message is FF related: https://developer.mozilla.org/en-US/docs/Tools/Debugger/Source_map_errors?utm_source=mozilla&utm_medium=firefox-console-errors&utm_campaign=default which forward us to https://bugzilla.mozilla.org/show_bug.cgi?id=1437937 Also it sometimes appears even page is loaded properly. While the second error message sounds like the origin of our problem. After tracing it down with Andreas Granig (Tnx, BTW!) we noticed the hint lines in rrule.js file. It looks like the map file mentioned there points the browser to load it. In the same time we do not have rrule.js.map in Git repo and moreover we do not use rrule.min.js, so rrule.js.map is useless here. After removing this line we were not able to reproduce the issue, however we should consider it as a shoot in a dark. P.S. Actually we have no ideas about version, origin URL, license for rrule.js library. It has been committed in commit `0162f70fae` > TT#49688 Implement human readable rrule in ical events list So, we cannot provide rrule.js.map file here. As luxon.js file has the same problem and they were committed together, let's clean them together. I hope FF will be happy now. Change-Id: I5ec52b66f4baf76c92eed111a27b8664e7a25fca (cherry picked from commit `8b2516dfe6`)	6 years ago
Irina Peshinskaya	0a5e2dfcb1	TT#54350 Always show hours related text in rrule description Change-Id: Ibda64adaaeacdde3fadf4d83504794367bff5199	6 years ago
Irina Peshinskaya	0162f70fae	TT#49688 Implement human readable rrule in ical events list Change-Id: I4d69be6423d5f4b4fefb645eac59a5d38cf2ca00	6 years ago

Alexander Lutay

TT#68019 Remove JS hint: sourceMappingURL=rrule.js.map from rrule.js and luxon.js

Those lines confuses Firefox 69.0.1 (64-bit) on dev laptop and
Firefox 68.0.1 on Jenkins in the following way:
AXAJ data is not loaded/shows on WEB interface after editing "Time set->Events".
The permanent message "Loading..." is displayed in the table.

The JS error says:

> Source map error: TypeError: NetworkError when attempting to fetch resource.
> Resource URL: moz-extension://93b8c0a0-04b0-41df-8ec9-8647b0f75bc2/browser-polyfill.min.js
> Source Map URL: browser-polyfill.min.js.map
>
> Source map error: request failed with status 404
> Resource URL: https://ce-trunk.mgm.sipwise.com:1443/js/libs/rrule/rrule.js
> Source Map URL: rrule.js.map

It looks like the first message is FF related:
https://developer.mozilla.org/en-US/docs/Tools/Debugger/Source_map_errors?utm_source=mozilla&utm_medium=firefox-console-errors&utm_campaign=default
which forward us to https://bugzilla.mozilla.org/show_bug.cgi?id=1437937
Also it sometimes appears even page is loaded properly.

While the second error message sounds like the origin of our problem.

After tracing it down with Andreas Granig (Tnx, BTW!) we noticed the hint
lines in rrule.js file. It looks like the map file mentioned there points
the browser to load it. In the same time we do not have rrule.js.map in Git repo
and moreover we do not use rrule.min.js, so rrule.js.map is useless here.

After removing this line we were not able to reproduce the issue,
however we should consider it as a shoot in a dark.

P.S. Actually we have no ideas about version, origin URL, license for rrule.js library.
It has been committed in commit 0162f70fae
> TT#49688 Implement human readable rrule in ical events list
So, we cannot provide rrule.js.map file here.

As luxon.js file has the same problem and they were committed together,
let's clean them together. I hope FF will be happy now.

Change-Id: I5ec52b66f4baf76c92eed111a27b8664e7a25fca
(cherry picked from commit 8b2516dfe6)

Irina Peshinskaya

0a5e2dfcb1

TT#54350 Always show hours related text in rrule description

Change-Id: Ibda64adaaeacdde3fadf4d83504794367bff5199

Irina Peshinskaya

0162f70fae

TT#49688 Implement human readable rrule in ical events list

Change-Id: I4d69be6423d5f4b4fefb645eac59a5d38cf2ca00

3 Commits (c967dc1ebffcac4eaf80e75e86878d6857f3638c)