53 Commits (c56be67d54ec7c6571cd1eb9eb9bfb5b946fb06d)

Author	SHA1	Message	Date
Nico Schedel	c56be67d54	TT#56376 selenium: more work on edit peak times ... controller_billing.t: - minor changes to finally open peak times reliably Change-Id: Idea20c812ca746ace3eec95ffeb455828b79c13c	6 years ago
Nico Schedel	5852e2dd0e	TT#56376 selenium: minor changes to controller_billing ... controller_billing.t: - replaced a instance of //table with its proper id - cleaned up a diag message Change-Id: I665ec4b844ac73b6e2ae405ddf53206e2b3bdf66	6 years ago
Nico Schedel	240e6937c1	TT#56376 selenium: fix crash when opening edit dialog in off-peak times ... controller_billing.t: - again, check twice before clicking anything... Change-Id: Ifa5631257e033e0246f21788daea75dcd35afbfb	6 years ago
Nico Schedel	53b958f224	TT#63700 update selenium tests to work with new docker image ... noteable changes: - added function wait_for_attribute, which will pause the script until a elements attribute changes to a desired value - move_action is no longer available, was replaced with ActionChains - fill_element now scrolls to element when it needs to. removed unnecessary scroll_to_element lines with it - there are now checks if a edit window is opened, to prevent element_not_interactable exception - some checks needed sleep(1), else the test would be redirected to a totaly wrong page - added some checks to see if test is on the right page, to prevent failing alert checks Change-Id: Ic516fbd1c5bc94bd8b7cb21b1d6bd089d8880fdf	6 years ago
Nico Schedel	a85457fa22	TT#56376 selenium: call driver->quit() after test has been executed ... every test file now calls $d->quit(); after they are done testing, regardless if successful or not. new geckodriver version has some issues when driver instances are not killed properly Change-Id: If3d9ccf139d4459345d08b96c33e6d76a0831f8f	6 years ago
Nico Schedel	7e4961abcb	TT#56376 selenium: add test: use invalid values when creating billing fee ... controller_billing.t: - first use letters, then use not valid numbers for values in billing fee - check error messages when saving with invalid values Change-Id: Ie3bb6a2b024bfeb298043d5525e8ba58d0822648	6 years ago
Nico Schedel	4417bb95fd	TT#56376 selenium: add new off-peaktimes tests ... controller_billing.t: - try to fill in invalid values in time def - add empty time def - try to fill in invalid values in Special off-peak date - edit Special off-peak date Change-Id: Ic2a8c83bea2f055cdb259d7f4ab3eb5c21d0df03	6 years ago
Nico Schedel	0ba4b15887	TT#56376 selenium: re-enable check for billing network blocks ... controller_billing.t: - edited check, so that jenkins will happily succeed with it Change-Id: I9f5fd054eedba57045fb081fe1e32e54cb86d9ea	6 years ago
Nico Schedel	e0df16d347	TT#56376 selenium: re-write billing zones and billing fee tests ... controller_billing.t: - rewritten tests, because trying to add new tests in the old code was pain - added proper deletion and edit tests Change-Id: I8d1e0149dfbf65f6c95a7eb4b80b2c84827b5838	6 years ago
Nico Schedel	3489a3dcfc	TT#56376 selenium: improvments when creating billing profile ... controller_billing.t: - edit diag texts - change name when editing billing profile, just like in other scripts - check prepaid setting when editing billing profile Change-Id: I3e54440477a3d6e20b711f5a96550d4eeda7ec39	6 years ago
Nico Schedel	f1b0193227	TT#56376 selenium: improved label checks for controller_billing.t ... controller_billing.t: - alert checks now print the actual displayed text if check fails - added missing alert checks - removed unnecessary lines Change-Id: Iba76480349f08dc8d857fcaa195a20af78d382e1	6 years ago
Nico Schedel	5438b95782	TT#56376 selenium: temporarly disable a check for network blocks ... controller_billing.t: - temporarly disable a check for network blocks, since this one still creates problems Change-Id: I2601a729d4901ce4aaf587026d135ee70ee4fba1	6 years ago
Nico Schedel	63a6d8babf	TT#56376 selenium: fix for crashes in controller_billing ... controller_billing.t: - changed how it checks the network block in billing networks Change-Id: I709963d24fba8d4bb142fb5038cc9418dcd20e64	6 years ago
Nico Schedel	25ae53fa19	TT#56376 selenium: add tests: billing networks ... controller_billing.t: - add billing network - check erros if fields are empty - edit billing network - delete billing network Change-Id: I68de6a422036ff2d1e51119bbb79fc30414ba450	6 years ago
Nico Schedel	856cc68e88	TT#56376 selenium: capture screenshot if program crashes ... Common.pm: - Capture a screenshot when a program crashes - Filename will depend on which program crashed i.e ctr_domain crashes are named crash_domain.png, etc - NOTE: this will only trigger in jenkins, since /results usually isnt mounted on workstations Change-Id: I9b953ff2381ab19260ff4afbe2deeeff3ebc9188	6 years ago
Nico Schedel	119c41eba9	TT#56376 selenium: move crash_handler to Collection.pm ... moved crash handler to Collection.pm, because copy pasting changes over 12 files is not fun =). also comparing differences in git is way easier with this change Change-Id: I0278bc4f85c6b6b2a1b56985c30b7100c0c93cd9	6 years ago
Nico Schedel	24c19b906a	TT#56376 selenium: add more features to the crash detection ... - it will now detect more errors (errors with Oops! in the headline and nginx erros) - it prints more information now. (tab title and url) - it looks nicer when some infos are not present (i.e when there is not incident number or incident time availible) - code looks nicer too Change-Id: Id43c061e37fd2f6f18a82833892799e04a243dfe	6 years ago
Nico Schedel	c76559974c	TT#56376 selenium: add missing delete_* calls ... some cleanup calls were missing. missing ones were added where nedded Change-Id: I1706ca89757a35d600fc4c957a8de0ae3d780bba	6 years ago
Nico Schedel	6c19ce2090	TT#56376 selenium: make code much more readable ... - previously, selenium code was in its own subroutine due to a problem how threading was done before, where it would execute files twice. since the way how threading works has changed, this is not a problem anymore and thus the code will be freed from its subroutine - the code which checks if server or script errors occured was moved into a new END block. try/catch silences error messages which is kinda suboptimal when you need to debug issues - this new END block will use a new variable called $run_ok to check if the test run was fine or if something went wrong - this should also make backporting of code much easier since git doesnt like tabs at all Change-Id: I6c6e61e05eabf442eff9f590168e4490393a5bb0	6 years ago
Nico Schedel	6a633263cb	TT#56376 selenium: print more infos if test crashes ... Tests will now print some infos when they crash. If a server crash occured, it will try to get the infos from the Sorry! page + ip of the server. If it cannot detect server issues, it prints out timestamp and server ip. Change-Id: I7be6f405503fd38eb334134294f45dff93a17ad5	6 years ago
Nico Schedel	5f503e2a48	TT#56376 selenium: add label check + missing deletion check to ctr_billing ... controller_billing.t: - add checks if create/delte labels show up and show the right text - add a check if special date definition is deleted Change-Id: Ie08c6640bab080184921af2c92f176856f5d16fb	6 years ago
Nico Schedel	f9bd1179f6	TT#56376 selenium: add cancel deletion tests to controller_admin/billing.t ... added tests to see if the entry is still here after the deletion has been canceled to controller_admin.t and controller_billing.t Change-Id: I62efb80edab1fc1f148863dbab7dfd0358a49073	6 years ago
Nico Schedel	3d70c9aa36	TT#56376 selenium: more tests for controller_billing.t ... controller_billing.t: - click save before entering anything, see if error messages pop up - fill in invalid values, see if they get rejected Change-Id: I790a2ce751a618332d3b6af9f7da73a2d06153a1	6 years ago
Nico Schedel	22ab442c06	TT#56376 selenium: add function create/delete_billing_profile() ... Common.pm: - add new functions create_billing_profile() and delete_billing_profile() - it now allows to specify a custom reseller, which will be important for later tests - these will be used for more tests in controller_customer controller_billing.t - adjusted code to use these new functions Change-Id: Ied8bf9e579d77228dc1bc6c3ad7b0cdc0edb321a	6 years ago
Nico Schedel	5835e29ed2	TT#56376 selenium: cleaned up old code ... cleaned up some old code. will reimplement some of it, hopefully for more tests too. Change-Id: Icba6cf9accff3e8aead139e1007fa800b1db711b	6 years ago
Nico Schedel	d6ac16de61	TT#56376 selenium: replace move_action with move_and_click() ... replaced every occurance of move_action + click with move_and_click. all also have a fallback element if the click doesnt work first try. Change-Id: I0489dacbda264d509c52016f259368666f3d5c15	6 years ago
Nico Schedel	f9ced2f830	TT#56376 selenium: Multithread tests ... Functions.pm: - add create_driver(). It will check which port can be used and returns a webdriver element. testrunner: - start 4 instances of geckodriver instead of 1 - start runner.t by default. it is still possible to run other files if needed. runner.t will first run a test login to see if the server is here. If login doesnt work, it will abort the test. runner.t will then exectute the tests (max. 4 in parallel). Test files have been modified accordingly to either work with runner.t or to execute independently. Change-Id: I628ea82ad786a6ebd713747fe07dda45a538a01c	6 years ago
Nico Schedel	d80ae2759a	TT#56376 selenium: replace code for clicking edit Wednesday button ... controller_billing.t: - replace codeblock for clicking on button "Edit" on column Wednesday. Should speed up the test a little bit. Change-Id: Icbb4e2d53552c42ec32dd5f5cf97648932992cc0	6 years ago
Nico Schedel	5e4b92406b	TT#56376 selenium: add more tests to controller_billing ... controller_billing.t: - add more tests for checking entries - use cleaner xpath Change-Id: I62a8f563ad966a691043770c5799865fb0a5a6d8	6 years ago
Nico Schedel	ff6c0849f1	TT#56376 selenium: improved formatting ... just making code look cleaner Change-Id: Ice2eaa1d14923a5552c3e41080b28958e37e5c9f	6 years ago
Nico Schedel	71803048a4	TT#56376 selenium: generate more unique names for domains, customers, etc. ... Changed how names get generated, because it happens that we generate something like test9123 and later we create test9 that these two names will conflict each other when it comes to searching. Change-Id: I5109e69c9f5b1bd8bcf49be49af535f93a8edbf2	6 years ago
Nico Schedel	e7a0927f0f	TT#56376 selenium: move login_ok() to Collection.pm ... Moving function login_ok() from FirefoxExtensions.pm to Collection.pm. FirefoxExtensions.pm should be used to store functions which make programming stuff easier. Common.pm should be used to store commonly used selenium routines. Edited all files accordingly to work with this change. Change-Id: I00ece7de88f7677665c5b8b87ce1e60be9c5854d	6 years ago
Nico Schedel	ed50e78499	TT#56376 selenium: simplified code around deleting billing fee ... controller_billing.t: - made delete billing fee test a bit simpler Change-Id: I7eecb379045cdf260960b9a06cfc54486fc34ddc	6 years ago
Nico Schedel	d6a901d97b	TT#56376 selenium: add garbage text search to prevent exception ... controller_billing.t: - Add Garbage text search when to the billing page to (hopefully) prevent "stale element exception" or "element not interactable" exceptions. Change-Id: I017d8ab0e09b7425307e1aca686ad351651a00cc	6 years ago
Nico Schedel	4aa76b9560	TT#56376 selenium: delete billing profile after test execution ... controller_billing.t: - Billing profile now gets deleted at the end. - Check if billing profile is deleted. Change-Id: Ia4dcbb8498f4482fe9b76568308314ceecb95d99	6 years ago
Nico Schedel	df4c47dadb	TT#56376 selenium: use name variable in controller_billing ... controller_billing.t: - Add a $billingname at the beginning of the test. This will generate the name "testingprofile + 5 random numbers". Will be used to properly check if a peering group has been created/deleted. - Rewrite create, check and edited other code to use that new variable. Change-Id: Id9403a356b3ceb3c67e51cc3735b75ba90511a7a	6 years ago
Nico Schedel	8ccd614fd9	TT#56376 selenium: fix crash on deleting date definitions ... controller_billing.t: - rewrite find/delete date definition code block to (hopefully) prevent crashing. Change-Id: Iaff9d52e4bc94ed40b4532f0ccd5443598eb3912	6 years ago
Nico Schedel	da24a58196	TT#56376 selenium: controller_billing.t code cleanups ... controller_billing.t: - Made garbage search call much simpler. - Replace find_element with find_element_by_css, prevents crashing if garbage text search didnt work. - Added new ok() tests for find_element_by_css. - Removed commented lines Change-Id: I42cf670c47cdc22db9ba1c8079fac3e3bb5147c8	6 years ago
Nico Schedel	0063078495	TT#56376 remove sleep if browser=htmlunit calls ... HtmlUnit is supposedly no longer used, removing associated sleep calls. Change-Id: I1e9ff8efdb9680e3d90bc5f6b3caad589ae95d03	6 years ago
Nico Schedel	96dc84af28	TT#56376 selenium: fix crash in controller_billing.t ... Test was crashing, because of invisible button madness. Now it will move the cursor to the column it wants to delete. Button shows up and is clickable now. Change-Id: I59aa27d7ef2fe06a6caa28620341363ff99f1042	6 years ago
Nico Schedel	c70b063cfe	TT#56376 selenium: fix crash on find_text() ... Adding try/catch to find_text() to prevent it from crashing if nothing is found. Change-Id: I9bdfae408e41d51db27c1abdd81fd1f3c16bc2f3	6 years ago
Irina Peshinskaya	a1360159b0	TT#46791 Wait for ajax table loading for "Edit" button work ... Change-Id: Icb4cdc87e818dc6fc592334d7efed79de23c0b91	6 years ago
Alexander Lutay	82172e5b1a	TT#46791 Fix floating bug with 'Edit' problem on page 'Weekdays' (try #2) ... The full issue description you can find in commit message a9399b1efd. In short, Selenium can't press on "Edit" button because it is being hidden on every AJAX request to backend. (Un)fortunately the previous fix opened new ngcp-panel JS issue reported as TT#50005: JS performs several AJAX requests to backend and the second request still cause the same problem as previous caused the first one. Luckily JS performs only one request to backend on the page load. And starts doubling them when we enter something into "filter". As a result, the previous commit has been reverted and new approach is proposed here: we will just wait data appearance in "Dates" (which means the first AJAX request is finished). Change-Id: If991af70e1ad1b00b04e4118c0b5f52b2d636eba	6 years ago
Alexander Lutay	cb7d6ec0af	TT#46791 Use proper variable name in test controller_billing.t ... The previous variable name didn't represent the real code context. The changes were initially part of commit a9399b1efd and were extracted to separate commit as initial commit had been reverted in commit 0601b821006f. Change-Id: Idf06a06b60498ec5df7a9472aa38413997dc23cb	6 years ago
Alexander Lutay	18d4e25574	Revert "TT#46791 Fix floating bug with 'Edit' problem on 'Weekdays' page" ... The fix here didn't work well because another ngcp-panel issue has been noticed and reported as TT#50005, the second AJAX request aborts Selenium test by hiding "Edit" button. The better approach is follow. This reverts commit a9399b1efd. Change-Id: Icf6251261f0cbc12ef4e819b3352dc3ebf7c4246	6 years ago
Alexander Lutay	a9399b1efd	TT#46791 Fix floating bug with 'Edit' problem on 'Weekdays' page ... It was old floating issue which randomly failed the test and jenkins job ngcp-panel-test-selenium-docker became often yellow. The problem here was in two facts: - 'Edit' button available with mouseover only - there is AJAX on this page for filtering 'Dates' records. Historically we have no ability to wait for all AJAX loadings. When Selenium moved mouse over Edit column to press it, AJAX can be finished and removed "Processing..." label from "Dates" field. It cause loosing mouseover from "Edit" button and button is hidden causing "element not interactable": > # Click 'Edit' button for element 'Wednesday' > Can't use string ("element not interactable") as a HASH ref while "strict refs" in use at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 684. > at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 655. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 27. It has been workarounded here as we cannot wait for AJAX. We are creating fake query for "Dates" (searching "thisshouldnotexist") and waiting until the table "Dates" has no search results records. It means AJAX has finished and we can continue with the test. Also here I have renamed confusing button from 'edit' to 'delete', as we press delete. And we have to clean previous search 'thisshouldnotexist' with proper '2008-02-28' which we want to delete. Change-Id: I55af32991687e82c3e57b15c066e772ff0b77123	6 years ago
Alexander Lutay	72834f126d	TT#46791 Add timeout 1 second for controller_billing.t ... It will give Ajax enough time to load 'Edit' button, otherwise we have some mystery which randomly happens when Jenkins tests VMs on Google Cloud: > # Edit Wednesday > ok 26 > # Move mouse over 'Weekdays' row to make 'Edit' button available > # Find 'Edit' button for element 'Wednesday' > ok 27 > # Click 'Edit' button for element 'Wednesday' > Can't use string ("element not interactable") as a HASH ref while "strict refs" in use at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 684. > at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 655. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 27. Locally it is not reproducible, also VM on Proxmox has no such issues as well. I spend too much time here trying to find the root of the issue, maybe Firefox version we are currently using has some issues here. Give up, sleep 1. Change-Id: I168270f6f6d25d8bdccfe6a40b2bc63aa0c5068e	7 years ago
Alexander Lutay	45bf7ec433	TT#46791 Call proper method 'click()' instead of 'click' (cosmetic) ... This is mainly for the code consistency. Change-Id: I1e820ef3693f541c21b86929c4887d434a74f35f	7 years ago
Alexander Lutay	95e1c49208	TT#46791 Wait for 'Edit' button in controller_billing.t ... The 'Edit' button appears only after mouse-over event, and we might have race conditions here when we are trying to click on not-yet available/accessible button causing: > Can't use string ("element not interactable")... Let's wait for button and then proceed with 'click()', it is the behaviour we use everywhere, while it was missing here. Also improve debug messages here for easier debug next time. Change-Id: Iae955bb3f937da6b5c10369bc49f6dd75611dc87	7 years ago
Gerhard Jungwirth	a672389bc7	TT#17853 selenium test adaptions for geckodriver ... all selenium tests are working with newest geckodriver (0.18.0) and patched S:R:D issues: - setting the window size: not urgent - the unsupported move_to: fixed (new move_action) - setting the implicit wait timeout: fixed upstream in S:R:D Change-Id: Ic5b52cd866f4fd93682d67a4fd8a76ec54ea70cf	8 years ago