25 Commits (bf249f9d969230f7de3eabf1bf77f65f4b9b52a8)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	2b144caf2c	TT#128605 implement dynamic fields expand ... * add API functionality to request additional data and expand fields in GET methods * syntax: - /api/resource/?expand=all - expands all expandable fields e.g.: customer_id field is expanded and customer internally is queried and returned under "customer" => {...} (the returned data is identical to what /api/customers/id would return) - /api/resource/?expand=reseller_id,customer_id - expands only reseller_id and customer_id fields, if they are expandable - /api/resource/?expand=reseller_id,invalidfield_id - returns the data and expands only fields that are expandable (reseller_id in this case) but if it finds either unknown fields or non-expandable fields, changes HTTP status code to "409 Conflict" * adapt all API endpoints to support dynamic expand fields expanding functionality, however the actual expand for them requires modifying the form fields in the following format: has_field 'contact_id' => ( element_attr => { expand => { class => 'NGCP::Panel::Role::API::CustomerContacts', id_field => 'contact_id', alias => 'contact', fetch => 0, }, }, ); - class - represents the class that should be used by the logic to fetch the relevant data - id_field - which field from the resource needs to be expanded, it should be the "id" field (subscriber_id, domain_id, etc.) - alias - (optional), under which key the fetched data is stored. the field name is used as the key if the option is omitted. - fetch - (optional), if the returned data is under $data->{contract_id} then it will be fetched from there and stored under the key (field name or alias), otherwise the whole retreived data is stored under the key (field name or alias) * adapt /api/autoattendants to use the new approach (old one was expand=1) * currently supported endpoints with expand: - admins - autoattendants - domains - customers - customercontacts - resellers - subscribers Change-Id: Iac53409dad944ed4794039a48dc3a9f6dce25bc1	4 years ago
Flaviu Mates	aec7c8921b	TT#76111 - Change LI admins flags permissions ... * Admin with lawful intercept will no longer be able to have any flags besides 'is_active', 'read_only', 'can_reset_password' * Remove reseller filter on interceptions since LI admins should see all interceptions * Add permissions to /api/admincerts and reseller ajax for LI admins Change-Id: Id912424b9bbd3ab3cbbc373ac116fda035f81fd3	5 years ago
Rene Krenn	fec183ca63	TT#46159 fix saving sip_username re in Intrecept-SOAP ... Change-Id: I00e789ce2f0392f884358299b66d2737f885e366	6 years ago
Rene Krenn	17082b3b38	TT#33369 remove check for LI number in 3306 db (again) ... Revert "TT#11701 check existence of voip number in InterceptionDB" This reverts commit b803c1ae3e. Change-Id: I56832cf412a97c4f0fc9f169498a60653d979614	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Andreas Granig	eb09639458	TT#23569 Fix interception ACLs ... * Make sure resellers with interception rights can query both collections and items * Make sure we only query the reseller specific interceptions when accessing API as reseller Change-Id: I3010f899cbbd1a7a4f60025d95f09f013cc07c03	8 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Rene Krenn	b803c1ae3e	TT#11701 check existence of voip number in InterceptionDB ... Change-Id: I6a4af38dcdcbcfb6491d0bfd3d2a4b99f6a14112	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Rene Krenn	7f4212adaa	MT#21775 tune the "username" interception regexp to tolerate vsc codes ... Change-Id: Iddd57aa27c3110ee29b7ad887bec652e91af3d0c	9 years ago
Rene Krenn	8fe0261630	MT#21775 regexp pattern for interception's sip_username ... Change-Id: Ib6626e577967b10b0b4d4046974fe7018cbbdd5f	9 years ago
Irina Peshinskaya	2b430bdd8d	MT#18561 Change of the LIID is forbidden ... Also call agent request in the update_item method, to make it more safe. And added lost transaction commit Fix 500 response for the incorret x3_port input Change-Id: Ic538ffdd4d7fff833ba5395934a1b2bc6cf71664	9 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Gerhard Jungwirth	bb03c1ff46	MT#17173 fix item filtering in API ... item_rs from API.pm was not executed before Change-Id: I803f5680d174820db9497d4f7cc1902bfa54a9ab	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Andreas Granig	d6096237ef	MT#16985 InterceptDB points to pair instead of RO ... Change-Id: Ie951b784aaaead64d8af2e376dc8d970a3b1dcd0	10 years ago
Andreas Granig	f9ce228e76	MT#16985 Rename CentralDB to RoDB ... Change-Id: I3e4fcf39dc2323213e3f3a69c3bac375421f6bd4	10 years ago
Andreas Granig	638a4de158	MT#16985 Use CentralDB schema for interceptions. ... Change-Id: I4924eafb6d103ac23b33b3c889cbcd457b841ef5	10 years ago
Andreas Granig	520b66201e	MT#16273 Implement X1 agent interface for REST ... On X1 requests, properly update the configured agents on the cluster. Currently we only throw an error if no agents are configured at all, but let it slip through if the actual requests are failing, as they might be down or failing. Change-Id: I0f4e021a5cc4ba6a30e30bb197ed20d4504797d8	10 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Andreas Granig	4e228c1dee	MT#16057 Fix dbix syntax fetching concat numbers ... Change-Id: I6a371c7d7d746206fa45bd916b1b1b60c7b4a968	10 years ago
Andreas Granig	8e0157b78b	MT#8613 Add basic CRUD for LI X-1 provisioning	11 years ago