ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Rene Krenn	5633770f1f	TT#5559 api/events, event test with "missing end-events" cases + api/events resource + removing an autoattendant via /api/callforwards: events OK + removing an autoattendant via /api/cfdestiantions: OK + removing an autoattendant via /api/cfmappings: OK Change-Id: I4c309753b9338582479dba9951f757bb2ecaad7e	9 years ago

Author

SHA1

Message

Date

Andreas Granig

0d3bf6b1ce

TT#22827 Implement form factory

This patch reuses existing forms by clearing them, rather than
re-instantiating them again and again.
Also, panel start time should be better due to less package
pre-loading.

Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e

Rene Krenn

72d9c10650

TT#13973 fix http method override

the factory Catalyst::ActionRole::HTTPMethods action role
is set for any action, and in race with our own
NGCP::Panel::Role::HTTPMethods. the testcase could have
been misleading ever since, as it uses DELETE /api/customers,
which was present when implemting the method override initially,
but dropped on the road to 4.5.

the issue is resolved by overriding
Catalyst::Controller::gather_default_action_roles.
until the class hierachy refactoring is completed, only
consistent way is to add the override to each api controller.
the action_roles config attribute can therefore be
removed.

using Plack::Middleware::MethodOverride as an alternative from
upstream has the drawback to work only with POST. but a required
usecase is to also support translation DELETE requests to PATCH.

Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c

Rene Krenn

5633770f1f

TT#5559 api/events, event test with "missing end-events" cases

+ api/events resource
+ removing an autoattendant via /api/callforwards: events OK
+ removing an autoattendant via /api/cfdestiantions: OK
+ removing an autoattendant via /api/cfmappings: OK

Change-Id: I4c309753b9338582479dba9951f757bb2ecaad7e

3 Commits (b7e82fdf1e93464d9ecd7c2b7cc47a82649e9ea3)