927 Commits (b05628db60d3390887fa14c83580d51b2c01b111)

Author	SHA1	Message	Date
Rene Krenn	b05628db60	TT#81004 support callforwards in provisioning templates ... provisioning templates can now include configuration of callforward mappings, eg.: cf_mappings: cfu: [] cfb: - enabled: 1 destinationset: name: "test" destinations: - destination: "123" cft: [] cfna: [] cfs: [] cfr: [] cfo: [] Change-Id: I8073322630d63e5ef23e7a9f8c299a6010cb4866	3 years ago
Oleksandr Duts	8af29b6470	TT#154351 Sound set propagation ... * Contract default sound set - subscriber propagation for cases: - New customer sound set is created as default. - Customer sound set is changed to default. - New subscriber creation - setting contract default sound set id. * The mentioned cases were implemented for both UI and API. Change-Id: Ia4733c972ae388d3457d0336e3f85b85eec6e9a2	3 years ago
Oleksandr Duts	ace1698a3d	TT#154550 API topuplogs - expand fields ... * The next fields are expanded: package_after_id, package_before_id, profile_after_id, profile_before_id, contract_id, contract_balance_after_id, contract_balance_before_id, subscriber_idvoucher_id. Change-Id: I4d5f12fb88eaaeb8daf45e673c14e92c1512e239	3 years ago
Oleksandr Duts	03271187c7	TT#157400 API/UI admins fix authorization for "system" role ... * Users with "system" role can change all items accross the system including the password changing for other users. * Login "system" has persistant "system" role. * "system" login name is restricted for the user input. Change-Id: Ibaecba35a86f71fa8895ce9d9feab8e768b65d14	3 years ago
Rene Krenn	f3f473ba8d	TT#157700 fix invoice svg rendering broken for 1st detailspage ... Change-Id: I5c1b4b286236931d62b01eb6ed7b5f8b21fb1731	3 years ago
Rene Krenn	599dd0613b	TT#151751 fix plaintext sippassword no longer returned ... this fix addresses regression reported by dominik: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) (cherry picked from commit 5e9066c4fb) Change-Id: I88c9ec40843f1e9a6983952b96c0b0e70fbb1bb1	3 years ago
Rene Krenn	8fac1ef383	Revert "TT#144300 accept Windows .csv file uploads" ... This reverts commit 5445c72cc7. Reason for revert: not needed to support windows line terminator Change-Id: I00f22993e17ec7c9bcb6ee331d07b6da0495586a	3 years ago
Kirill Solomko	5d9618e642	TT#156354 fix a syntax typo when marking voicemail as read ... Change-Id: Ib13a1839e6f5bc9419fb137a2e6d4a23d6993ecd	3 years ago
Kirill Solomko	f4154b1dbc	TT#154500 tighten /api/admins roles ... * An attempt to change own role, login, flags (except for can_reset_password) now returns 403 Forbidden, User cannot modify own permissions * POST checks if the admin has necessarry permissions to create another admin * PUT/PATCH changing own role is now forbidden * PUT/PATCH changing other's admin role now checks permissions * DELETE checks role permissions Change-Id: I990609985ae9cab6213cf47f5f5c8afba2efdda3	4 years ago
Kirill Solomko	81ebdb8dcf	Revert "TT#151751 refactor persisting subscriber webpassword" ... This reverts commit 5e9066c4fb. This implementation breaks: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) Change-Id: I0e8389e8ab34ad72f1b87a684daba77f1030f8ba	4 years ago
Oleksandr Duts	9855b6ab45	TT#149461 Enhance /api/admins to accept the role data property ... - Optional "role" parameter is added for POST PUT PATCH. If "role" is provided then the passed flags are ignored and are applied internally by the server according to the provided role. If "role" is not provided then the former flags based approach is applied. Change-Id: Ib6e591ff6dc50122e0ec49a348153ca820fc2e03	4 years ago
Oleksandr Duts	206877a476	TT#149462 Enhance UI admins role usage ... - Add Role column on /administrator table - Add Role dropdown input on /administrator/:id/edit - Add Role dropdown input on /administrator/create - Implements logic to resolve flags and role id params: 1. role_id is passed(create/edit) then flags will be overrided according to the concrete role. 2. role_id is not passed(create/edit) then flags will be checked to determine role id according to the concrete flags pattern: Role | Flags ----------- --------------------------------- system | is_system = 1, admin | is_superuser = 1 reseller | is_superuser = 0 ccareadmin | is_ccare = 1, is_superuser = 1 ccare | is_ccare = 1, is_superuser = 0 lintercept | lintercept = 1 Change-Id: Ia923a47f664a162d78a06efcc006f84dcd08701d	4 years ago
Rene Krenn	5445c72cc7	TT#144300 accept Windows .csv file uploads ... Change-Id: I2aae72cfc4ee418e6db8946152150f4fb400af31	4 years ago
Rene Krenn	5e9066c4fb	TT#151751 refactor persisting subscriber webpassword ... a multitude of issues popped after introducing bcrypted webpasswords in the database. most recently the PATCH /api/susbcribers rail was reported to reset the webpassword unintentionally. subscriber login fails afterwards, which is a severe issue. the bugs are adressed by this refactorings. the change also introduces a global variable $NGCP::Panel::Utils::Auth::ENCRYPT_SUBSCRIBER_WEBPASSWORDS to control encrypting webpasswords. it is still enabled as of now, but it's worth to consider disabling it. there other ways to have a "cost" for an authentication request, eg. adding a simple sleep(1sec). Change-Id: I2d47d54a2d83568546ffdd2b211337a5f56be3a2	4 years ago
Kirill Solomko	55a8d5568f	TT#152901 prosody provision ignore error on timeout ... * when a domain is provisionined in prosody and there is no connection to the host/port, the error is ignored and ok response is returned instead. Prosody does not have a persistent database and rather loads vhosts from kamailio.domain on startup and if it is down during domain creation/removal where will be no discrepancies when it starts. The new error checking behaviour benefits the CARRIER setups where a proxy host is still in xmlhosts but is not available (powered off) or prosody is not running there for some reason. Change-Id: Idaaaf2b31985873db9228958b60ff14fca5d1bf6	4 years ago
Rene Krenn	37f748cb76	TT#151401 invoice: calc totals from CDRs ... by default, re-rating CDRs of prepaid customers will not update the contract balances. in that case the total values on invoice PDFs become out of sync with the zone details list. Change-Id: Iba78b6386140012bb087235997880e8c28cc0972	4 years ago
Kirill Solomko	ac94626f9e	TT#149456 fix and improve user role_id retreival, api tests ... * NGCP::Panel::Utils::UserRole::_field_to_name now supports both hash and object to parse the roles from * NGCP::Panel::Utils::UserRole::resolve_role_id returns undef if no roles has been passed or there are no entries for the role in the database * Fix NGCP::Panel::Utils::Journals to correctly fetch and set $journal{$role_id} * Adjust api-journals.t, remove tx_id, user_id, role_id from checks Change-Id: Ieff23bd4291f3b88ba92bbfc2b00b57f66bf76e1	4 years ago
Kirill Solomko	16b4dfe5dd	TT#149456 Journal allow empty role_id ... Change-Id: Ibfb2707a730839b43cd7bda15082fd309f67be76	4 years ago
Oleksandr Duts	747af33a7a	TT#151250 Write journal resource params: user_id, reseller_id, role_id, tx_id. ... Change-Id: Ie6ae9f3a49fbd4be4f302a568669f78aecfdfe25	4 years ago
Oleksandr Duts	e58cb2cc39	TT#149456 Admins introduce role_id flag ... - role_id is taken from billing.acl_roles and written into the billing.admins table when a new admin user is created/updated via UI/API. This is the first step towards the role based admin user handling. Change-Id: I0804379cbbcab174cebbb292397a39cb3ea01a31	4 years ago
Rene Krenn	d786af1591	TT#147151 finish refactoring of avoiding JOIN billing.product ... follow up on TT#147151 (fast loading/paging/searching panel datatables), which broke restapi tests. Change-Id: I799cb9087b9405c71dec4c690e7a7bab5dfdbdde	4 years ago
Rene Krenn	f9ff14fab2	TT#146800 support decimal VAT rates ... Change-Id: I7222e012fbc6c848527f0f7a2a45c56894ae509b	4 years ago
Oleksandr Duts	ad6467561f	TT#149650 UI language handling ... * Change UI language workaround. Priority: 1. Parameter "lang". 2. Cookie "ngcp_panel_lang". 3. Default english - "i-default". * Add parameter "lang_save" - save the "lang" value at "ngcp_panel_lang" cookie. Change-Id: I0abc9e3ab564ba56d2e3f9b0dee47d32c27e0049	4 years ago
Kirill Solomko	f8d982708b	TT#147151 restore get_contract_rs() product join ... * restore the removed product table join in get_contract_rs() as get_contract_rs() and product.class are used in many places in the code that have their own filters by product.class Fixes: 133bd43df TT#147151 fast loading/paging/searching panel datatables Change-Id: I56e20f240ccc08cf1c9a25947f67990691425549	4 years ago
Rene Krenn	e83ed0960d	TT#147400 subscriber identifiers/lookup for prov template ... option to just lookup an existing susbcriber (instead of creating it). Change-Id: Ib5352541753c3435a48a56b36af5fe7dda1d51da	4 years ago
Rene Krenn	133bd43df4	TT#147151 fast loading/paging/searching panel datatables ... query refactoring an rowcount clipping for UI datatables that are slow when using millions of subscribers: contacts customers contracts subscribers billing profiles billing networks billing profile packages Change-Id: Ia50e3aa52684772548569b6908f0cbc08395a5a7	4 years ago
Oleksandr Duts	8017805589	TT#124802 GET /api/admins/:id/journal - fixing ... * Admins with is_system and is_superuser are able to see the items for all roles. * Admin is able to see own journal. Change-Id: I3e5d459b08ff7ef218220f1ae11974351121c489	4 years ago
Rene Krenn	e73dd3ea27	TT#132650 api .csv upload for provisioningtemplates ... the POST /api/provicioningtemplates/<reseller>/<template> request will accept text/csv content type to provision many susbcribers at once. Change-Id: I59079ba8f2bacc0ce2b1367d2bd1a7251cf4763c	4 years ago
Rene Krenn	4c47920f2e	TT#132650 run provisioningtemplate from api ... provisioning templates with their dynamic forms can be executed by a entityitem POST request, ie. POST /api/provicioningtemplates/<reseller>/<template> or POST /api/provisioningtemplates/<readonly template> Change-Id: I77f6c9d42e1afdb49635d3f11e4d73bcf6269605	4 years ago
Kirill Solomko	b199ad3e1e	TT#139550 improve vmnotify behaviour ... * vmnotify() now accepts cli and uuid arguments * API handling of voicemails is now improved to: - send a notify if the item's INBOX/Old has been changed - correctly process DELETE to send vmnotify after the item's removal Change-Id: Ic00ae825cf091bce273e55aa37cd0a7ac80d8b0f	4 years ago
Kirill Solomko	67bc755276	TT#139550 vmnotify use correct uuid ... * wrong value was used in the vmnotify select query, now the correct uuid is used Change-Id: I311cc7ea9cce01014dd40761d0bc7f594ecca7b2	4 years ago
Alexander Lutay	f1e00a0408	TT#141802 use proper SNOM param 'setting_server' on SRAPS ... For some reason SNOM SRAPS has two parameters with identical 'param_name'='setting_server': * "Settings Server URL" * "Settings Server" NGCP need to use the second one on SRAPS to set device redirect URL. We were receiving it by luck in the past. The commit e548057d4 introduced performance improvement to 'last' the search in loop after finding the proper 'param_name'. As a result of improvement we set wrong option on SRAPS. Dump of options for the history: * "Settings Server URL": >{ > 'links' => { > 'self' => 'https://secure-provisioning.snom.com/api/v1/settings/5683038cec6c4fa9be95b2de9d1750e8', > 'group' => 'https://secure-provisioning.snom.com/api/v1/setting-groups/8ab9230acf3f4060868509a93ad53f3f' > }, > 'attrs' => [], > 'choices' => undef, > 'default_value' => undef, > 'description' => undef, > 'field_type' => 'url', > 'fkey' => $VAR1->{'indexed'}{'enabled'}, > 'group' => '8ab9230acf3f4060868509a93ad53f3f', > 'multiple' => $VAR1->{'indexed'}{'enabled'}, > 'name' => 'Setting Server URL', > 'no_profiles' => 164, > 'param_name' => 'setting_server', > 'product_groups' => ['6cdbd3dfe5fe40e28c909f118a509b8a'], > 'section' => 'global', > 'sortable' => $VAR1->{'indexed'}{'enabled'}, > 'uses_permissions' => $VAR1->{'indexed'}{'enabled'}, > 'uuid' => '5683038cec6c4fa9be95b2de9d1750e8', > 'indexed' => { > 'default_size' => 4, > 'max_size' => 0, > 'start' => 0, > 'enabled' => bless( do{\(my $o = 0)}, 'JSON::PP::Boolean' ) > } >} * "Settings Server": >{ > 'links' => { > 'self' => 'https://secure-provisioning.snom.com/api/v1/settings/50a400560eec4dc0b96b026094e06562', > 'group' => 'https://secure-provisioning.snom.com/api/v1/setting-groups/8ab9230acf3f4060868509a93ad53f3f' > }, > 'attrs' => [], > 'choices' => undef, > 'default_value' => undef, > 'description' => 'Setting Server for Desk phones', > 'field_type' => 'text', > 'fkey' => bless( do{\(my $o = 0)}, 'JSON::PP::Boolean' ), > 'group' => '8ab9230acf3f4060868509a93ad53f3f', > 'multiple' => $VAR1->{'fkey'}, > 'name' => 'Setting Server', > 'no_profiles' => 3189, > 'param_name' => 'setting_server', > 'product_groups' => ['1a45a2a3f6b94c4cbfa5439b446132f7'], > 'section' => 'phone-settings', > 'sortable' => $VAR1->{'fkey'}, > 'uses_permissions' => bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ), > 'uuid' => '50a400560eec4dc0b96b026094e06562', > 'indexed' => { > 'default_size' => 4, > 'max_size' => 0, > 'start' => 0, > 'enabled' => $VAR1->{'fkey'} > } >}; The commit introduces the second filtering parameter 'section'='phone-settings', as we cannot rely on any other parameters. Change-Id: Iec2b2a0c2068efb90af20af3dba711dfc7f55ca8 Fixes: commit e548057d40	4 years ago
Kirill Solomko	68dcad8c70	TT#139550 improve vmnotify messaging ... * improve select from voicemail_spool to avoid sequental scan with like '%..' * select now fetches all messages count * add old messages count support * old/new messages are reported as 0 if not returned from voicemail_spool Change-Id: I11ac1a407e8d22fe828a17cda55aa3298c6e6f02	4 years ago
Kirill Solomko	4e33039bb6	TT#145300 fix domain vs customer reseller check ... * fix a wrong expression that checks domain vs customer reseller id Change-Id: I0da43bffa833ce5432848c23aacf307bc1b0a3ff	4 years ago
Kirill Solomko	da4278daa3	TT#145300 Adjust domains reseller_id handling ... * domains do not use billing.domain_resellers table anymore but instead the new domains.reseller_id field. That is to remove the unneeded many<>many relation through the additional table where the actual logic only supports one(reseller) to many(domains) relation Change-Id: I1b681543baf1901f19e10c2f6210e4cf6eeb8fbe	4 years ago
Kirill Solomko	1c10d54924	TT#144254 Rework ALE devices provisioning bootstrap ... * move to_log() and data_to_str() methods to the parent VendorREST module * rename send_request() to send_http_request() * use common send_http_request method for HTTP requests dispatching * improve logging * improve error handling Change-Id: I403aa8053e4abfaf6992b62809f15ab72e3a06fc	4 years ago
Alexander Lutay	e548057d40	TT#141802 Improve Snom profile SRAPS handling code ... * add common send_request method for HTTP requests dispatching * improve logging * improve error handling Change-Id: I72ffc6874bf89219ccfd764696bec0c99111d8b3	4 years ago
Alexander Lutay	b106891f68	TT#141802 Add MAC to default SNOM 'bootstrap' URL on SRAPS ... By default NGCP created bootstrap URL on SRAPS as: > http://ngcp.server.com:1445/device/autoprov/bootstrap/ while we need to append it with MAC at the end, as SNOM has device specific firmwares and NGCP need to know MAC to find the device model and return proper firmware to upgrade. The proper bootstrap URL is: > http://ngcp.server.com:1445/device/autoprov/bootstrap/{mac} After firmware upgrade SNOM device will connect to secure URL: > https://ngcp.server.com:1444/device/autoprov/config/{mac} P.S. re-using Panasonic approach for SNOM devices with a difference: Panasonic uses label '{MAC}' and SNOM uses '{mac}'. Change-Id: Ib1530f1adf1154deb5a8fb8a7d856810885f4736	4 years ago
Kirill Solomko	471b9fe861	TT#139550 fix ngcp-vmnotify system call to use the correct args ... * uuid arg is mandatory now and it is added to the ngcp-vmnotify invokation Change-Id: Ie36b06d7abf700fe65a965c0ea8dbe813dc4faa2	4 years ago
Donat Zenichev	7d13b498cc	TT#110302 Small mistake in the 'create_location' of kamailio utils ... In this commit: 79c0c9fe12 there was a mistake done, which needs to be fixed. Change-Id: Iefeebc8bae5ae3b4f58e0e7db01be71773fe973e	4 years ago
Donat Zenichev	79c0c9fe12	TT#110302 Kamailio utils, improve usage of RPC command 'ul.add' ... The latest version of the 'ul.add' RPC command of Kamailio has 11 parameters instead of 9, we have to fix that. Change-Id: Ic70bde77eada095ddf127e18f3ef7e5b3d91478f	4 years ago
Rene Krenn	b6e696621b	TT#132650 /api/provisioning_templates CRUD rail ... the /api/provisionintemplates rail provides the operations to create, edit and delete "provisioning templates" know from the "batch provisioning" feature of admin panel. these templates can also be defined in config.yml, while it is however only possible to edit templates stored in the database. executing a template and/or uploading a .csv for bulk execution will be available in a separate part. Change-Id: If8627327270edfce5bca1be3b1f777c1bd44e90f	4 years ago
Rene Krenn	51f548514a	TT#142001 do not quote LI numbers in Response err messages ... the G2k/LIMA implementation seems to have our error messages hardcoded in their logic. it stareted to fail since we added logline obfuscation, which was also added to response messages in this place. Change-Id: I36c2a74ed17db7013e692d7cbdccf0dbd44e814e	4 years ago
Alexander Lutay	1840af1eb2	TT#142402 Fix v1 'Back' button navigation on v2 (iframe inside iframe) ... The ngcp-panel v1 codebase uses 'back=' GET parameters to record all the navigation path and store it into the session array: '$c->session->{redirect_targets}'. On switch from v1 to v2 using the link 'GO TO NEW ADMIN PANEL', the function 'login_to_v2' is not using the concept of 'back=' GET param, but ngcp-panel still receives and stores the last value with 'empty' path: > $VAR1 = bless( do{\(my $o = 'https://x.x.x.x:1443/')}, 'URI::https' ); > $VAR2 = bless( do{\(my $o = 'https://x.x.x.x:1443/subscriber/155/details')}, 'URI::https' ); > $VAR3 = bless( do{\(my $o = 'https://x.x.x.x:1443/subscriber')}, 'URI::https' ); > $VAR4 = bless( do{\(my $o = 'https://x.x.x.x:1443/dashboard')}, 'URI::https' ); The navigation above is a recorded browsing path on v1 (in a reverse order): - login to ngcp-panel (dashboard page is opened), - open 'Subscribers' - open details for some subscriber with id 155 - open subscriber preferences - click on link 'GO TO NEW ADMIN PANEL'. As a result user is still located on the same page "Preferences", but not on v1 but v2 interface. The empty value is inserted into the array '$c->session->{redirect_targets}' (which is wrong). The empty path 'https://x.x.x.x:1443/' brakes v2 navigation for v1 'Back' button inside iframe. It causes loading of iframe inside iframe, which happens on v2 due to list of redirections: - clicking on v1 button 'back' inside v2 iframe requests https://x.x.x.x:1443/back - it triggers navigation to the top element array 'https://x.x.x.x:1443/' which is wrong/corrupted. - loading '/' cause 302 redirect to '/v2/' (as 'v2' is a default UI for mr10.0+) - loading '/v2/' inside iframe cause the issue with 'v2' content inside 'v2' iframe. This is a commit to prevent inserting an empty 'back_uri' into the session array '$c->session->{redirect_targets}'. Change-Id: I69df4320fa8cde4d23a7d9dd18ffb5eb06ee8df1	4 years ago
Kirill Solomko	fc8a16859f	TT#66577 use kamailo ids for sems_registrations ... * kamailio.sems_registrations now uses kamailio.lcr_gw.id -> peer_host_id kamailio.subscriber.id -> subscriber_id for foreign keys consistency withing the same database Change-Id: I4722729fdee07eb2a153473e85d64faa46eedca5	4 years ago
Donat Zenichev	df30292c6b	TT#66577 Add support of outbound registrations for SIP peerings ... We need to add an improvement, which fulfills the work of the registration mechanism for SIP peerings. Not only do we add here a registration tirggering for peerings, but also a 'type' is introduced, which is mostly needed for XMLRPC commands being sent towards SEMS, to let it understand to whom the $sid is related to. Plus a list of improvements: - de-register peering host on deletion ; - de-register peering host on disable / register of peering host on enable ; Change-Id: I035dfadf6709acb4d106a70f6124f024e719044f	4 years ago
Victor Seva	883cf884f2	TT#137602 prosody: domains are treated as lowercase ... Change-Id: I65af0765112cbf4ba52daf2baf28043197ebeae3	4 years ago
Kirill Solomko	cc10506b2e	TT#129162 fix subscriber webpassword field validation ... * 'webpassword' field is now also validated for invalid (non-ascii) characters * Fix multiple APP input field validation erros to comma joined. * Adjust 'webpassword' field validation errors to have better readability when there are multiple validation errors Change-Id: I21536f97a4da78cc5192a3abd8cd5adef1b819ec	4 years ago
Kirill Solomko	c50b49db96	TT#133800 fix password fields behaviour in API ... * PATCH: password fields are not removed when resource is created for apply_patch(), they are removed under the same condititions later when hal is generated, that is to ensure that admin users without the 'show_passwords' flag as well as subscribers will not run into situation when they use PATCH and cannot apply it for "path": "/password" or/and "path": "/webpassword", as they were removed before apply_patch() * rework encrypted webpassword detection. webpasword is detected as encrypted if its length is 54 or 56 and it contains at least one '$' char, there is a chance for false positive detection when a user provides with a plain-text password with the same pattern but it's very unlikely, as well as since mr8.5 webpasswords are expected to be encrypted, and moreover worth case scenario is that the plain-text password will not be returned to the user Change-Id: I8ea739cbf728b2134f3ce00cee29da42ab3fb4a3	4 years ago
Kirill Solomko	1cdae0b1e0	TT#125902 add Login CSC v2 support ... * Login CSC v2 button is shown on the subscriber's master data page if www_admin.http_csc.csc_js_enable == 1 or 2 * When the login is triggered an auth token is generated internally followed by a redirect to CSC as /?a=auth_token * move generate_auth_token() into Utils/Auth * improve generate_auth_token() arguments support * add /api/authtokens error handling Change-Id: Idd65400bf8ce6ce48979c736f6a199fb567ffaa4	4 years ago