34 Commits (b041888807ab89a0624bd7f9ba75e21ec53861cf)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	2 years ago
Kirill Solomko	6a922c5cfb	MT#56693 parent_name, allow empty sound files, sems audio cache ... * /api/soundsets new parent_name field * /api/soundfiles now allow POST to be done without the upload, for cases when an empty record needs to be added to define "use_parent" behaviour * improve sems audio cache clear on sound files change, now sems instances that are not available (not running/request timeout) are skipped instead of raising an error Change-Id: I83af2ee2fd3672ab35cf330464ace68416ab52be	3 years ago
Marco Capetta	da628f6e0f	MT#56691 Extend Contract Soundsets with all the announcements ... The pre-call announcements and the ringback tone are not under the subscriber administrator control. This make difficult for PBX customers to modify those announcements. Due to that now all the announcement's handle are exposed also to contract soundsets. Change-Id: Ie6c98a6a6ed4de18b267bd553f33afc9eb72f995	3 years ago
Kirill Solomko	44ec794db2	MT#56693 add parent sound set support ... * sound sets can now use other sound sets as parents, in this case if a sound is missing for a sound set, it's taken from the parent one if it exists there, chained parents are also supported with the available sound files "accumulated" across them. * add "expose_to_customer" field to sound sets, it enables exposing system sound sets to customers so they can be used as a parent or assigned to the 'sound_set' preference by 'subscriberadmin'. * add "use_parent" field to sound set files, it's true by default (for existing or missing sound files) and if set to 0, then parents are not used for this particular sound file. * use_parent column is hidden on the UI if a sound set does not have a parent assigned * improve sound set handles list on the UI - Upload is renamed to Add - empty record are shown in the filename column as localised "(empty)" and Edit/Delete action buttons * API /api/soundsets new 'parent_id' field, default null * API /api/soundfiles new 'use_parent' field, default 1 * API /api/soundsets new 'expose_to_customer' field, default 0 * API /api/soundsets customer_id field now contains the customer id for 'subscriberadmin' role and 'null' if it's a system sound set * system sound sets with expose_to_customer == 1 and within the same reseller are now visible to 'subscriberadmin' on the UI and via the API in read-only mode, same with the sound files that belong to the sound set. If a system sound set expose_to_customer is set back to 0, this sound set is automatically removed from all contract sound sets where it was assigned as a parent as well as from all subscriber 'sound_set' preferences. * contract_sound_set|sound_set preference API updates now have tigher checks for contract_id and also if the system sound set is exposed to the customer and belongs to the same reseller Change-Id: I4908fd15e9c224d4c30794ceb8dae1b444bbf56a	3 years ago
Oleksandr Duts	3b9f19b6c8	TT#141101 UI/API fix custom_announcement upload ... * Ability to upload sound set file for custom_announcement. Change-Id: I51dbf3fd9b9820adfa8ebe186c63cf39383a76ee	4 years ago
Kirill Solomko	2b144caf2c	TT#128605 implement dynamic fields expand ... * add API functionality to request additional data and expand fields in GET methods * syntax: - /api/resource/?expand=all - expands all expandable fields e.g.: customer_id field is expanded and customer internally is queried and returned under "customer" => {...} (the returned data is identical to what /api/customers/id would return) - /api/resource/?expand=reseller_id,customer_id - expands only reseller_id and customer_id fields, if they are expandable - /api/resource/?expand=reseller_id,invalidfield_id - returns the data and expands only fields that are expandable (reseller_id in this case) but if it finds either unknown fields or non-expandable fields, changes HTTP status code to "409 Conflict" * adapt all API endpoints to support dynamic expand fields expanding functionality, however the actual expand for them requires modifying the form fields in the following format: has_field 'contact_id' => ( element_attr => { expand => { class => 'NGCP::Panel::Role::API::CustomerContacts', id_field => 'contact_id', alias => 'contact', fetch => 0, }, }, ); - class - represents the class that should be used by the logic to fetch the relevant data - id_field - which field from the resource needs to be expanded, it should be the "id" field (subscriber_id, domain_id, etc.) - alias - (optional), under which key the fetched data is stored. the field name is used as the key if the option is omitted. - fetch - (optional), if the returned data is under $data->{contract_id} then it will be fetched from there and stored under the key (field name or alias), otherwise the whole retreived data is stored under the key (field name or alias) * adapt /api/autoattendants to use the new approach (old one was expand=1) * currently supported endpoints with expand: - admins - autoattendants - domains - customers - customercontacts - resellers - subscribers Change-Id: Iac53409dad944ed4794039a48dc3a9f6dce25bc1	5 years ago
Kirill Solomko	d3566d0aa8	TT#127805 remove temp transcoded files ... * temp files created for transcoding operations are now correctly removed Change-Id: Ie95fccd2ed2a533060e4abc2fa3593c9f951225a	5 years ago
Flaviu Mates	cac9c4dea0	TT#56060 Implement PATCH method for soundfiles ... * There is now a PATCH method for soundfiles so their details can be updated without uploading a new file Change-Id: I96e7b453b9830c40d24c15f5ca364021373dfdee	7 years ago
Flaviu Mates	69bff5fd94	TT#54957 Implement support for uploading multiple sound file types on /api/soundfiles ... * Adapt code to retrieve file type from header, not only to expect WAV, and convert it to WAV internally * Add support for multipart/form-data requests for CSC platform Change-Id: I12dca611a23c90801b1faae269a55b9fcc895244	7 years ago
Kirill Solomko	82e3ce898b	TT#55104 fix sound files update_model error handling ... * API SoundFiles transcoding error is now handled correctly * Fix cases in Role/API/SoundFiles that used last instead of return Change-Id: I2636d654b3b405645761dda834c8215514bf50e2	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	8 years ago
Gerhard Jungwirth	edbef3c5b8	TT#29617 remove unnecessary form exceptions ... with the previous commit, there is no need anymore to specify form exceptions manually. validate_form will now automatically consider fields in the correct format with and without "_id" Change-Id: I70afae4003c6407c7a37396630110736f1fb13f8	8 years ago
Kirill Solomko	5f29592e7a	TT#23772 remove PCMA transcoding for music_on_hold sound files ... * with the removal of PCMA transcoding for music_on_hold sound files, the transcoding only applies to convert any WAV -> expected WAV format by sems * adjust File::Slurp play_file() to use the buffer, to avoid possible issues with the stream data read * fail if the sound file to upload is empty or cannot be read Change-Id: I527aadd279dfe7dee42593be89f65dedf65fd6dd	8 years ago
Kirill Solomko	21975ad88c	Revert "TT#22550 disable sound files transcoding" ... This reverts commit d419c49f76. Change-Id: I634bd8bf8f8725d86b82f17eb0447b23dff81027	8 years ago
Kirill Solomko	171a0facca	Revert "TT#22550 set codec to WAV in the API sound file update" ... This reverts commit e10cc89715. Change-Id: I8bbd12f3cdbc07154224284cdbd743255ba66dc2	8 years ago
Kirill Solomko	e10cc89715	TT#22550 set codec to WAV in the API sound file update ... Change-Id: I791adb3df1f5dfd26e558ddb7758dc837809d4b0	8 years ago
Kirill Solomko	d419c49f76	TT#22550 disable sound files transcoding ... * NGCP sound files do not need transcoding anymore and it is disabled for the sound file upload/download logic (voicemail sound files transcoding is still required and retained) Change-Id: I756c794ae614d3d85096936e217d83f3e0c6db44	8 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	9 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	9 years ago
Gerhard Jungwirth	ab375e637b	TT#4334 adapt soundfiles api to subadmin ... * /api/soundfiles/ * /api/soundfilerecordings/ Change-Id: Ifa2685da38d240ee80c7f6fe5b65cdef2f951fb5	9 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	10 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	10 years ago
Gerhard Jungwirth	bb03c1ff46	MT#17173 fix item filtering in API ... item_rs from API.pm was not executed before Change-Id: I803f5680d174820db9497d4f7cc1902bfa54a9ab	10 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	10 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Gerhard Jungwirth	e8f19f7339	MT#15361 fix post soundfiles creating duplicate entry ... Change-Id: I8f1201325119617fb25b6826ebf249c367a5b82b	10 years ago
Gerhard Jungwirth	e214d316c0	MT#15361 fix soundcache reload on api post ... unifying behaviour with PUT and eliminating duplicate code Change-Id: I8bb15351a64a94407be1ed510ae31489a6b03036	10 years ago
Gerhard Jungwirth	9aad021882	MT#13007 Reload correct service for sound handles ... see 13007#c98465 Change-Id: I44392cb1e45134650a1ad44edd6b24d057c817a6	11 years ago
Kirill Solomko	c1c72dd6c7	MT#8547 - replaced experimental "smartmatch" code with the sane if/else custom SWITCH blocks	11 years ago
Gerhard Jungwirth	9f7f55d07f	MT#8063 api fix uploading music_on_hold ... in case of customer sound set. and prevent uploading multiple items of the same set/handle.	12 years ago
Andreas Granig	3a9d043d40	MT#7899 API: clear audio cache on sound file mod.	12 years ago
Gerhard Jungwirth	75aeaa6add	MT#7421 API soundfiles, check empty filename	12 years ago
Andreas Granig	60de7de4a7	MT#7067 API: Implement sound file handling. ... Create new sound files. Update sound files. Delete sound files.	12 years ago