44 Commits (b041888807ab89a0624bd7f9ba75e21ec53861cf)

Author	SHA1	Message	Date
Kirill Solomko	9dbd6b0e88	MT#59478 /api/contracts address $now and hal_from_contract ... * the following changes resolve an issue where $now in Role/Contracts resource_from_item appeared as an object and failed subsequent logic: - hal_from_contract is renamed to hal_from_item to match correctly the parent method - call hal_from_item and pass $now string there correctly as $params { now => $now } Change-Id: I5c02d5f7df5d9000550505ad120b9531f87e8d65	1 year ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	6953de937c	MT#33041 add reseller max subscribers support ... * Max subscribers can now be defined in the Reseller contract * Max subscribers is now shown in int Reseller's "Reseller Contract" Details (with an indictaion of how many subscribers are created out of the defined max subscribers, as well as when the limit is reached (similar to the Customer's Details page) * Add reseller subscribers count checks on the UI Create Subscriber page * Add reseller subscribers count checks in /api/contracts POST/PUT * Prevent max_subscribers definition for Peering contracts in /api/contracts POST/PUT Change-Id: I1561d4eb7da5b1a0a0c99acabd18d2a9cd98dec7	2 years ago
Kirill Solomko	68af361060	TT#173700 /api/topuplogs expand related fixups ... * Role::API::Contracts add item_by_id() that calls contract_by_id() * Utils::ProfilePackages::catchup_contract_balances return if $contract object is undef * Form::Topup::Log::contract_id expands into Role::API::Customers instead of Role::API::Contracts Change-Id: Id4fc67b8ea1e91f350d0172aafc2b722f34e61f3	3 years ago
Rene Krenn	d786af1591	TT#147151 finish refactoring of avoiding JOIN billing.product ... follow up on TT#147151 (fast loading/paging/searching panel datatables), which broke restapi tests. Change-Id: I799cb9087b9405c71dec4c690e7a7bab5dfdbdde	4 years ago
Kirill Solomko	2b144caf2c	TT#128605 implement dynamic fields expand ... * add API functionality to request additional data and expand fields in GET methods * syntax: - /api/resource/?expand=all - expands all expandable fields e.g.: customer_id field is expanded and customer internally is queried and returned under "customer" => {...} (the returned data is identical to what /api/customers/id would return) - /api/resource/?expand=reseller_id,customer_id - expands only reseller_id and customer_id fields, if they are expandable - /api/resource/?expand=reseller_id,invalidfield_id - returns the data and expands only fields that are expandable (reseller_id in this case) but if it finds either unknown fields or non-expandable fields, changes HTTP status code to "409 Conflict" * adapt all API endpoints to support dynamic expand fields expanding functionality, however the actual expand for them requires modifying the form fields in the following format: has_field 'contact_id' => ( element_attr => { expand => { class => 'NGCP::Panel::Role::API::CustomerContacts', id_field => 'contact_id', alias => 'contact', fetch => 0, }, }, ); - class - represents the class that should be used by the logic to fetch the relevant data - id_field - which field from the resource needs to be expanded, it should be the "id" field (subscriber_id, domain_id, etc.) - alias - (optional), under which key the fetched data is stored. the field name is used as the key if the option is omitted. - fetch - (optional), if the returned data is under $data->{contract_id} then it will be fetched from there and stored under the key (field name or alias), otherwise the whole retreived data is stored under the key (field name or alias) * adapt /api/autoattendants to use the new approach (old one was expand=1) * currently supported endpoints with expand: - admins - autoattendants - domains - customers - customercontacts - resellers - subscribers Change-Id: Iac53409dad944ed4794039a48dc3a9f6dce25bc1	4 years ago
Irina Peshinskaya	5dc3065cdf	TT#51061 Disable prepaid billing plan for peering/reseller contracts ... Change-Id: Ie1756af32cbc5bf5535756758f42ac1a9a9301b7 (cherry picked from commit f9ba1729d94db7febfb10bb879da6bbdf9ea2be2)	6 years ago
Irina Peshinskaya	9ed0657d4c	TT#40503 Show journal links to allowed roles only ... Change-Id: I547b2db4767b1e383506bc812b6486db944fceec	7 years ago
Rene Krenn	145167e3db	TT#38401 switch to new billing mappings tables ... Change-Id: I4e57b50a5668170c66521ed5f130bd8293b76b38	7 years ago
Rene Krenn	b35b0e1cbc	TT#35662 move product_id to billing.contracts ... Change-Id: I5381b36e226b1c0c2032fa40c3a082b85485e4ac	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Gerhard Jungwirth	edbef3c5b8	TT#29617 remove unnecessary form exceptions ... with the previous commit, there is no need anymore to specify form exceptions manually. validate_form will now automatically consider fields in the correct format with and without "_id" Change-Id: I70afae4003c6407c7a37396630110736f1fb13f8	7 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Rene Krenn	979397cff3	MT#20639 TT#5411 contact termination ... +1. terminate if terminated contracts or subscribers exists +2. if active contracts or subscribers -> error +3. delete otherwise +customer contact api DELETE +customer contact testcases +customer api POST +customer api PUT/PATCH +system contact api DELETE +system contact testcases +contract api POST +contract api PUT/PATCH +panel UI contact delete +panel UI contract create no change panel UI contract update +panel UI customer create no change panel UI customer update note contact links like customers.omm_contact or customers.tech_contact are not considered. Change-Id: I19ea6e2245282485cc30d3e92d17a2eb603e0c2d	9 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Gerhard Jungwirth	bb03c1ff46	MT#17173 fix item filtering in API ... item_rs from API.pm was not executed before Change-Id: I803f5680d174820db9497d4f7cc1902bfa54a9ab	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Rene Krenn	ad3719772a	MT#17263 edit offpeak/onpeak using api ... +input validation for verlapping time ranges for both weekdays and special. can be disabled. +root entiy locking +peektime special is growing and not paginated, so PUT/PATCH will get slower if special peektimes are added on a regular basis. they can be removed using the UI however +testcase to check overlap detection Change-Id: I935d943078ab5c81263da88ecd04e004deb26c8b	9 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Rene Krenn	7dfc5fda21	MT#14255 panel UI problem setting subscriber 'lock' detail ... Change-Id: I4873b36526152da64334a8359ce8bfe531ce42a6	10 years ago
Rene Krenn	07c9d1955d	MT#14255 add cash_balance underrun logic ... in short: whenever the contract_balances "cash_balance" is about to decrease, it might drop below thresholds defined by a contract's profile package. in that case, subscribers are to be locked and/or underrun billing profile sets are to be applied. this commit also contains some minor fixes: +when creating/editing profile packages, all billing profiles of initial, topup, underrun sets must show the same interval_free_cash and interval_free_time values. there was also a problem with adding profile sets to packages that use profile with prepaid = 1 (see ticket 14301) +when editing packages using the panel UI, the validation was not properly invoked (!) +the frequency of topups has to be limited to 1 per second. +updating the "lock" subscriber prior to editing or viewing it in the panel UI was added. +topup cash and topup voucher panel UI added +when aquiring multiple contract row locks at once, no joined tables are used any mure. the number of row locks is therefore minimal now (see ticket 14903) +rework of updating prepaid subscriber preference Change-Id: Ideb0fec2404ca10b3ac5d8735f53620d0c3a24ed	10 years ago
Rene Krenn	c7b3d74a21	MT#14317 passing now() to interval catchup and resize ... formerly, the contract_balance catchup (and resize) procedures used contracts.modified_timestamp, whose value was intended to be set explicitly upon update operations. it turns out that mysql ON UPDATE current_timestamp columns effectively ignore the explicit timestamp value, unless it exactly matches the old timestamp value. while this is not an issue for the logic in production usage, this seems to be the reason why the api-balance_intervals.t test fails occassionally with its time-warp cases. Change-Id: I504dd98548b88c99079e071598806d884c4422eb	10 years ago
Rene Krenn	c378681a24	MT#13903 balance interval catchup and resize WIP ... + synchronized contract balance catchup + balance interval resizing upon profile package transitions + dynamic interval length, interval start, carry-over propagation, .. + end-of-month 'preserve' mode correction for strictly aligned month intervals for start_mode=customer "create" timestamp + new api/balanceintervals resource to inspect contracts' balance interval histories + updated affected panel UI controllers + test case with time warps using Time::Fake caveats: - creating an invoice for a given 'period' (month) has to be refactored to select a disitnct balance interval. right now it takes the last interval in the month specified. - generate_invoice.pl is broken and needs a major refactoring Change-Id: I7bb54a83b76e510b1baa573a986d05400a7fec1e	10 years ago
Rene Krenn	2537819f0d	MT#12643 billing networks and multi bill prof WIP ... -properly validate billing mapping intervals -api/contracts and api/customers complete +the problem with updating the "prepaid" preference remains at the moment +billing_mappings field contains future (editable) mappings only, the full schedule is given in a separate field +hal-links to all occurring billing profiles and networks -extended tests: api-customer.t and api-contract.t -api-billingnetworks.t test -billing networks panel controller +search by enclosed IP address -panel UIs for billing networks, customers, contracts +past billing mapping intervals that cannot be edited are displayed by a seperate hfh "block" part of the billing_profiles repeatable -profile packages api, UI +terminating billing profiles (MT#8645) will be broken +fixed now: profile cannot be terminated unless there are: -zero non-terminated customers, whose mappings contain the profile with future or open end -zero profile packages, that link to the profile in either one of their initial-, underrun- or topup profile sets +panel edit should work, termination wip +topup_profiles w/o amounts +contracts/customers API profile_package_id field: +apply the package's initial profiles +api/customer and api/contract profile definition modes (id/profiles/package) +api OK, api-customer.t tests +customer and contract panel UI with selector to specify actual billing mapping, schedule or profile package (same as api) +terminate logic harmonized: profiles, networks, packages +api tests updated +prepare for merging: cleanup, enable tests Change-Id: I6c0dec72f490b5731fc673cd393d6aeb08dd8143	10 years ago
Rene Krenn	96c731a144	MT#11917 Journaling for first set of resources ... the journal module introduces a change history of resources modified by api invocations. the history of the 'customer' resource demo is accessible at /api/customers/x/journal. Change-Id: I4d5d11bc3e35160feed587ce4c1db565991866b2	10 years ago
Andreas Granig	83bd0f93f2	MT#9481 API: set link from customer to balance	11 years ago
Andreas Granig	d156577873	MT#9167 Fix setting contract timestamps	11 years ago
Gerhard Jungwirth	17f092219f	MT#7959 fix contract PUT/PATCH, tests ... now that type is checked by form, it must be properly passed by put/patch. Also error message changed. (cherry picked from commit 526a6c1a19)	11 years ago
Gerhard Jungwirth	fc4bdaf750	MT#7959 update contracts api doc	11 years ago
Gerhard Jungwirth	266d2eb48d	MT#6663 Make API more robust when contract has no billing_profile ... This should at least not fail with 500	11 years ago
Gerhard Jungwirth	6d17b70ab0	MT#6295 API: fix failing customers and contracts requests ... validate max_subscribers (like in earlier versions) but don't require product to be set and typo	11 years ago
Andreas Granig	7d76b46b10	MT#6283 Fix search framework to work on debian ... - overriding item_rs doesn't work with that particular catalyst version, use work-around.	11 years ago
Andreas Granig	11d83a7ead	MT#6283 Implement search-framework. ... - let custom roles "derive" from main api role - have an item_rs in each role - call search logic after each item_rs call automatically - render search query doc dynamically	11 years ago
Andreas Granig	c799df3ebd	MT#3925 API: dynamically render API documentation.	11 years ago
Andreas Granig	efafd55c87	MT#3931 API: Use TryCatch instead of Try::Tiny	12 years ago
Andreas Granig	456df97df0	MT#3931 API: implement customer contract handling.	12 years ago
Andreas Granig	cd2d9e47aa	MT#5255 Fix boolean handling and HFH validation	12 years ago
Andreas Granig	3ce79d6703	MT#5299 API: GET and POST billing profiles.	12 years ago
Andreas Granig	45a460a1ce	MT#3949 API: implement contracts handling.	12 years ago
Andreas Granig	14d9374e8c	MT#3949 API: move common contract stuff to role.	12 years ago
Andreas Granig	7a782eb4fb	MT#5255 API: Create roles for resources. ... Collections and Items have common functions (e.g. hal_from_xxx), so move them into separate roles.	12 years ago