ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling * Role/Entities: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	dee6b60c6e	MT#56208 additional inherited cfs improvements for subscribers * API: GET collection returns only distinct cf sets * UI: inherited cf sets are now shown in the advanced view and having suffix '(inherited)' to distinguish them from the own ones as they are not available in the "Manage Sets" edit dialog. Change-Id: Ifd8c1a46fcb4c2c66f8f63268a1e91b80792c216	2 years ago
Kirill Solomko	e90ba9d517	MT#56208 allow subscriber role access to cf sets * subscriber role can now GET call forward sets that does not belong to the user but used in call forwards assigned to the user * the user can only GET the sets but cannot update/delete them (403 Forbidden is raised in case of attempt) Change-Id: I391b802d962f4bbeae991e3046ac3f132a19edb6	2 years ago
Kirill Solomko	018dc08be6	MT#56026 /api/cfsourcesets subscriberadmin role change * subscriberadmin is now able to fetch cfsourcesets of other subsribers that belong to the customer Change-Id: I95217587430c52cd7078e1604ffec549ae2dd6b5	2 years ago
Kirill Solomko	2b144caf2c	TT#128605 implement dynamic fields expand * add API functionality to request additional data and expand fields in GET methods * syntax: - /api/resource/?expand=all - expands all expandable fields e.g.: customer_id field is expanded and customer internally is queried and returned under "customer" => {...} (the returned data is identical to what /api/customers/id would return) - /api/resource/?expand=reseller_id,customer_id - expands only reseller_id and customer_id fields, if they are expandable - /api/resource/?expand=reseller_id,invalidfield_id - returns the data and expands only fields that are expandable (reseller_id in this case) but if it finds either unknown fields or non-expandable fields, changes HTTP status code to "409 Conflict" * adapt all API endpoints to support dynamic expand fields expanding functionality, however the actual expand for them requires modifying the form fields in the following format: has_field 'contact_id' => ( element_attr => { expand => { class => 'NGCP::Panel::Role::API::CustomerContacts', id_field => 'contact_id', alias => 'contact', fetch => 0, }, }, ); - class - represents the class that should be used by the logic to fetch the relevant data - id_field - which field from the resource needs to be expanded, it should be the "id" field (subscriber_id, domain_id, etc.) - alias - (optional), under which key the fetched data is stored. the field name is used as the key if the option is omitted. - fetch - (optional), if the returned data is under $data->{contract_id} then it will be fetched from there and stored under the key (field name or alias), otherwise the whole retreived data is stored under the key (field name or alias) * adapt /api/autoattendants to use the new approach (old one was expand=1) * currently supported endpoints with expand: - admins - autoattendants - domains - customers - customercontacts - resellers - subscribers Change-Id: Iac53409dad944ed4794039a48dc3a9f6dce25bc1	4 years ago
Flaviu Mates	ded942b740	TT#96502 Introduce duplicate check for /api/cfsourcesets * Due to DB unique name constraint, enpoint was returning 500 on duplicate source sets * Proper 422 is now returned Change-Id: I883fbe71aa77364645467941206ea6b272523c03	4 years ago
Kirill Solomko	ce664263b2	TT#65101 add ccareadmin ccare roles * ccareadmin and ccare roles have full access to Customers, Subscribers and their preferences/settings, and read-only access to BillingProfiles,InvoceTemplates, EmailTemplates * ccare role is restricted to the related reseller Change-Id: I6cf7d3adf912f0fa98d1ef5c02abea2f4331ec4b	6 years ago
Irina Peshinskaya	c76d300f7d	TT#40503 Remove explicit role checking for journal links Change-Id: Id33dc65590d87f15fa565d4a400bd059f6bd9654	7 years ago
Irina Peshinskaya	9ed0657d4c	TT#40503 Show journal links to allowed roles only Change-Id: I547b2db4767b1e383506bc812b6486db944fceec	7 years ago
Gerhard Jungwirth	9210ac0487	TT#37206 is_regexp flag for callforwardings implemented for Source Sets and B-Number Set in: * Panel * /api/cfbnumbersets/ * /api/cfsourcesets/ * /api/callforwards/ in addition, the fields have also been documented in the forms (and therefore also in the API documentation) Change-Id: I955dd9addf1e61ec7516b4c518adec151248bacc	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Gerhard Jungwirth	edbef3c5b8	TT#29617 remove unnecessary form exceptions with the previous commit, there is no need anymore to specify form exceptions manually. validate_form will now automatically consider fields in the correct format with and without "_id" Change-Id: I70afae4003c6407c7a37396630110736f1fb13f8	7 years ago
Gerhard Jungwirth	1f7be85e31	TT#20866 remove dead code (Forms) Change-Id: I26bc316086fa6d9bf18941fc60f8bd2a8e0e28bb	8 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Andreas Granig	dc0bd38e73	TT#4333 Fix CF issues for subscribers * Fix syntax errors and internal errors * Pass set ids back in mappings * Allow updates of mappings both via name and ids Change-Id: I26fdfe96d67563c11040a6c1e87f13a835bb793f	8 years ago
Andreas Granig	f9030b4f21	TT#4333 subscribers/customers/numbers/CF ACL * Implement r/o access to /api/customers for subadmin * Implement r/o access to /api/subscribers for subs * Implement create access to /api/subscribers for subadmins * Implement /api/numbers to re-assign a number * Implement CF endpoints access for subs * Implement new test framework to simplify testing * Fix updating number by using Utils to make sure allowed_clis etc are handled correctly * Install missing docker dependencies for new test framework * Add edr handling on /api/numbers/xx update Change-Id: I678da16cfb1361b2809780cba8c204ac90bb1736	8 years ago
Kirill Solomko	ad5f1b2ef7	TT#19459 add whitelist/blacklist mode to cf source sets * enables a mode for cf source sets, where all numbers are considered as whitelisted or blacklisted (similar to the NCOS levels mode) Change-Id: I84e76e5ba717050c48bcaf5c1fd5f67ed5582cab	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Gerhard Jungwirth	af86cac827	TT#2393 implement a-number cf for API callforward based on source-numbers in rest-api Change-Id: I94dcd67f09dd027e444894d2b549b9901eee7c22	9 years ago

20 Commits (b041888807ab89a0624bd7f9ba75e21ec53861cf)