5243 Commits (85be902c72bbddac24d2f70abb94e4a328c614e7)

 

All Branches   

Search

Author	SHA1	Message	Date
Javier Rodriguez	58c86414ef	TT#158350 Enhance information on ngcp-provisioning-template help ... Currently, the command ngcp-provisioning-template --help provides (among others) the following information: (a) Help information about --first_name=first-name Provide the value for a form field "first_name" (if you have such in your provisioning template). Only relevant if no --file is specified. I think the description is confusing, since it makes the reader understand that the --first_name option is a fixed argument. However, the number of arguments to be provided rely on the input variables defined in the batch provisioning template. Hence, more than one attribute name can be provided as argument (e.g. --first_name=John --last_name=Doe --cc=43 --ac=1 --sn=2521523) My suggestion is changing the current description to: --[input-attribute-name]=[attribute-value] Description: Provide an input attribute name and its value, as defined within the 'fields' tag in the provisioning template (Attribute must not be internal, i.e. 'calculated' type). (b) Help information about 'ngcp-provisioning-template' usage Usage: ngcp-provisioning-template provisioning-template-name [options] ngcp-provisioning-template reseller-name/provisioning-template-name [options] It may be confusing for an Administrator: - In which cases the command syntax above should be used? - 'provisioning-template-name' is a string which can contain spaces, hence the commands above should have the double quotes to ensure proper command execution. My change suggestion: Usage: For templates defined in config.yml file: ngcp-provisioning-template "provisioning-template-name" [options] For templates defined in database: ngcp-provisioning-template "reseller-name/provisioning-template-name" [options] (c) Help option about CSV filename --file=.csv-filename If the file is local to where the command is executed: Is it mandatory to specify the dot at the beginning of the CSV filename? I tested it with or without the dot, and the file is properly considered on both cases. Hence, I would suggest editing the description to just --file=csv-filename. Change-Id: Id08f02900453ca7269d69e7521af099e4b4ca79d	3 years ago
Javier Rodriguez	1be9e7fc88	TT#160850 Fix for Built-In Batch Provisioning Template that Cannot Create A Customer With Several Subscribers ... Added 'status' field to ensure proper DB lookup Change-Id: I095e614ec5501845a2c3920cb436d17d30478e73	3 years ago
Oleksandr Duts	8af29b6470	TT#154351 Sound set propagation ... * Contract default sound set - subscriber propagation for cases: - New customer sound set is created as default. - Customer sound set is changed to default. - New subscriber creation - setting contract default sound set id. * The mentioned cases were implemented for both UI and API. Change-Id: Ia4733c972ae388d3457d0336e3f85b85eec6e9a2	3 years ago
Rene Krenn	81afa6680d	TT#159400 support fraudlimit greater than 10 million ... Change-Id: I1c737afe83ec3808dfacc6fdc9f2cd1b27fff8f8	3 years ago
Oleksandr Duts	c12d5077f0	TT#158250 API: autoattendats - fix subscriber_id expand under subscriberadmin ... * Fix API autoattendats expand subscriber_id for subscriberadmin role. Change-Id: Ib55c9e0370a2405456f3a311c98221b59e3a6d3f	3 years ago
Nico Schedel	a8fcd1dcb7	TT#158401 selenium: fix multiple obscuring elements ... in admins, customers and contracts Change-Id: Ic2f904e207a7c928b6f1a78b0fc61f9a49439de3	3 years ago
Oleksandr Duts	a4d3585430	TT#160300 API: header[rules,ruleactions,ruleconditions] - subscriber_id filter ... Add subscriber_id(billing) filter parameter for GET endpoints: - headerrules - headerruleactions - headerruleconditions Change-Id: Ief568ddbdc3641be5e57411191f5716ab175acb9	3 years ago
Javier Rodriguez	84a33c96f2	TT#160250 'Calculated fields' label changed to 'Language' label ... The 'Calculated fields' label is displayed when creating a new Batch Provisioning template on Admin Panel. This field has a selector which offers the 'Javascript' and 'Perl' options. The label may be confusing, since the options are programming languages (rather than 'calculated' fields) that can be used on provisioning templates. Hence, it is more suitable to change the 'Calculated fields' label to just the 'Language' label. This will also be in concordance with the JSON property 'lang' (short word for "Language") that can be used at API level to set the programming language. Change-Id: Ie944e446bbab845fee644f698023ac1eacf0e866	3 years ago
Marco Capetta	940cf00328	TT#109104 Add new Location mapping mode: forward ... Change-Id: I15e484f30950a1e50c0ec817989d6c6234b36910	3 years ago
Oleksandr Duts	ace1698a3d	TT#154550 API topuplogs - expand fields ... * The next fields are expanded: package_after_id, package_before_id, profile_after_id, profile_before_id, contract_id, contract_balance_after_id, contract_balance_before_id, subscriber_idvoucher_id. Change-Id: I4d5f12fb88eaaeb8daf45e673c14e92c1512e239	3 years ago
Nico Schedel	a15445fbe4	TT#158401 selenium: fixup administrator and reseller tests ... Change-Id: I5d02e7afeeac70f5e88888847b1b84354f3759d7	3 years ago
Kirill Solomko	ccac7fd77f	TT#154353 fix JWT retrieval from the header ... * fix variable assignment when the value is retrieved from the regex Change-Id: I9f589b630bb2af85c64b41f163acdecffa418a59	3 years ago
Rene Krenn	641fb8c2dc	TT#159400 support fraudlimit greater than 1 million ... Change-Id: I5b3721e72fc99933a1f6f617af514f87ad3b8a6c	3 years ago
Nico Schedel	e8502ec4aa	TT#122872 selenium: fixing more misaligned buttons ... mainly settings button wasnt correcty identified anymore, using better way of detecting it. also adjust for moved objects Change-Id: I1de855c37a7fa9bcc0dcd7dbd84aca92a083853f	3 years ago
Sipwise Jenkins Builder	4921c56f7a	Release new version 10.4.0.0+0~mr10.4.0.0	3 years ago
Kirill Solomko	1fe438294b	TT#154353 add JWT token renewal ... * /login_jwt now accepts "jwt" key with an existing valid JWT as the value * upon successful authentication with the token a new token with prolonged expiration time is issued for the authenticated user and returned in the JSON response * add "expires" value in the JSON response that contains a timestamp integer when the issued token expires * fix encode_json() calls formatting * most of JWT related error messages are now appear in the log as INFO instead of ERROR as they are not related to the system errors Change-Id: Ie8e04534c8819dc756b3c64ebc4432ce442a1d31	3 years ago
Kirill Solomko	9dd50e8427	TT#158003 make subscriber location mappings 'location' optional ... * 'location' field is now optional, if not filled it it will always default to an empty string instead of null. This is required for the new mode 'forward' that has no use for this field. If the field is empty in any other mode like 'add' or 'replace', the entry will be skiped by the logic. Change-Id: Ia964c3bb272c9772c51b836ac2418ee4cd7b7f42	3 years ago
Rene Krenn	dcce2b83a1	TT#159000 fix 403 error when loading call details ... Change-Id: I10f4f597d60bec7751417219a8e402dfd5bce4b8	3 years ago
Javier Rodriguez	c3ae96a2bd	TT#153300 Voicemail 'temp' and 'greet' greetings options for Perl-based Admin Panel ... WHAT: This fix allows the options: (a) Voicemail greeting "temp", and (b) Voicemail greeting "greet" to be displayed within Subscriber Preferences -> "Voicemail and Voicebox" on Admin Panel (Perl-based). Hence, an Admin can load 'greet' and 'temp' prompts via Admin Panel, similarly as 'unavail' and 'busy' options. WHY: 'greet' and 'temp' options were added to be managed via API, but they were not available on Admin Panel. Change-Id: Ie2d18f4d9a8e8369f3bbcb8593848ce6ee4b7d32	3 years ago
Rene Krenn	473e4488db	TT#156000 enable callflow UI for users with "call_data" flag ... Change-Id: Iee4b61732fe823a22d7fb2e64720c133a505b287	3 years ago
Guillem Jover	c4faefbb09	TT#156156 Switch to «-» as the word separator in CLI options ... The prevalent convention in the project is to use «-» instead of «_» to split words in options. Switch the options to that, and keep backwards compatibility option alias that emits a deprecation warning while people transition to the new names. The alias will be removed on the next LTS. Change-Id: I003e79a5358aec905bd652c5310217be24fd98c6	3 years ago
Oleksandr Duts	03271187c7	TT#157400 API/UI admins fix authorization for "system" role ... * Users with "system" role can change all items accross the system including the password changing for other users. * Login "system" has persistant "system" role. * "system" login name is restricted for the user input. Change-Id: Ibaecba35a86f71fa8895ce9d9feab8e768b65d14	3 years ago
Oleksandr Duts	938eef9140	TT#119465 API callrecordings - searchable caller/callee ... * Fetch recording_metakeys caller/callee for the certain record id(call). * Add caller/callee fields to the resource and form. * Frefetching recording_metakeys for the call recording. Change-Id: I767ea32e19edfd7cbbc74956200343f680fdb2b4	3 years ago
Rene Krenn	d82d93da9d	TT#71950 fix leftover with 35b568dde ... Change-Id: If71d07972f56cb1b7cb0bbafdcfd3b68cce6e254	3 years ago
Rene Krenn	f3f473ba8d	TT#157700 fix invoice svg rendering broken for 1st detailspage ... Change-Id: I5c1b4b286236931d62b01eb6ed7b5f8b21fb1731	3 years ago
Michael Prokop	35b568dde4	TT#71950 Fix typos ... * successfuly -> successfully * diplay -> display * recieve -> receive * mathes -> matches * cahnged -> changed * Unprocessible -> Unprocessable * The the -> The * repesent -> represents Change-Id: I123f5b1ec8c11fe01db4e5768bd640c4920d3366	3 years ago
Rene Krenn	741cf221d8	TT#146102 remove RFC5321/2 checks from passreset API forms ... Change-Id: Ib13fd8afe37b1648186282676b6e04745d956b0f	3 years ago
Rene Krenn	599dd0613b	TT#151751 fix plaintext sippassword no longer returned ... this fix addresses regression reported by dominik: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) (cherry picked from commit 5e9066c4fb) Change-Id: I88c9ec40843f1e9a6983952b96c0b0e70fbb1bb1	3 years ago
Rene Krenn	3804fb9f35	TT#156753 ngcp-provisioning-templates: support "warn" loglevel ... Change-Id: I0c7117f2cc203b7baee2616f67d642d1dd1fdce7	3 years ago
Rene Krenn	83ffb600f4	TT#156753 ngcp-provisioning-templates: allow unordered opts ... opts such as --log_level=debug or --db_host=192.168.0.1 are not captured properly unless specified before any templateform parameter opts. Change-Id: Ibe61ea55ed745d8e1e88ae8a1f509ac009e16dc3	3 years ago
Rene Krenn	d9cd2da9af	TT#155850 CSC callhistory does not anonymize CLIR numbers ... Change-Id: I8b9cf354ceda20ecda18e53e3de5fee64bb202e0	3 years ago
Rene Krenn	8fac1ef383	Revert "TT#144300 accept Windows .csv file uploads" ... This reverts commit 5445c72cc7. Reason for revert: not needed to support windows line terminator Change-Id: I00f22993e17ec7c9bcb6ee331d07b6da0495586a	3 years ago
Kirill Solomko	5d9618e642	TT#156354 fix a syntax typo when marking voicemail as read ... Change-Id: Ib13a1839e6f5bc9419fb137a2e6d4a23d6993ecd	3 years ago
Oleksandr Duts	581aa090e7	TT#153501 API: GET phonebookentries - fix subscriber access(422) to own phonebooks ... * Roles subscriber and subscriberadmin use the user voip subscriber id as a phonebook context. Change-Id: I5f119837b40169aa6d920774b4fc96551875dfc0	3 years ago
Kirill Solomko	f4154b1dbc	TT#154500 tighten /api/admins roles ... * An attempt to change own role, login, flags (except for can_reset_password) now returns 403 Forbidden, User cannot modify own permissions * POST checks if the admin has necessarry permissions to create another admin * PUT/PATCH changing own role is now forbidden * PUT/PATCH changing other's admin role now checks permissions * DELETE checks role permissions Change-Id: I990609985ae9cab6213cf47f5f5c8afba2efdda3	4 years ago
Oleksandr Duts	8b6939a715	TT#134106 API: GET autoattendants - fix subscriber access ... * Fix UI form [CSC] PBX Settings -> Auto-attendant. * Subscriber can create own slots. Change-Id: I410aa9112edb8f6f2f85ac697f4eef8149db0240	4 years ago
Kirill Solomko	822f053a77	TT#154500 fix administrator form behaviour ... * check $c->state for cases when it does not exist (admin user creation) * return undef instead 0 in the default field method Change-Id: I3aa69ebc0f5ec5a590c113379bdf0a5a94e35747	4 years ago
Oleksandr Duts	e5dd7e5587	TT#129169 API: DELETE /api/admins/:id return wrong http 500 ... * Fix http code to 403 - Cannot delete own user Change-Id: I21225e112fd7e5b746381753b2e52474b6069c5c	4 years ago
Kirill Solomko	81ebdb8dcf	Revert "TT#151751 refactor persisting subscriber webpassword" ... This reverts commit 5e9066c4fb. This implementation breaks: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) Change-Id: I0e8389e8ab34ad72f1b87a684daba77f1030f8ba	4 years ago
Kirill Solomko	e95ed81ca7	TT#154500 improve admin users behaviour ... * admin users with is_master = 0, cannot see other admin users (this includes system users) and brings the is_master flag to the common behaviour * ccareadmin, ccare users can now access te UI Admins page as well as /api/admins but they are limited to see/manage only themselves * admin users cannot see system users (UI/API) * reseller users cannot see system/admin users (UI/API) * admin users cannot modify their own role and flags except for: email, password, can_reset_password (UI/API) * UI edit form now does not render fields that are not meant to be modified by a user (exception: "login") Change-Id: I82e1946437fd2ec4651abd24074470c695a40582	4 years ago
Rene Krenn	9a3c3cd42c	TT#153100 fix subscriber username queryparam search ... Change-Id: I56ca6601bb1abc38552561e0a110e875e9282a3b	4 years ago
Oleksandr Duts	9855b6ab45	TT#149461 Enhance /api/admins to accept the role data property ... - Optional "role" parameter is added for POST PUT PATCH. If "role" is provided then the passed flags are ignored and are applied internally by the server according to the provided role. If "role" is not provided then the former flags based approach is applied. Change-Id: Ib6e591ff6dc50122e0ec49a348153ca820fc2e03	4 years ago
Alexander Lutay	aac3a16e5e	TT#153950 Add label 'Invoice Template' to Invoice create page ... Otherwise the table is not signed at all on create 'Invoice' page. Change-Id: Idea6ab1df49b5de9db1b469fb872d031378bf3a4	4 years ago
Kirill Solomko	ca87855521	TT#149462 Form/Administrator/Reseller role_id required=0 ... * role_id field is set to optional as the API uses the form and there is no support for the role_id there yet Change-Id: Ib663b4d9d0501eca2310a7e95733c2166c9872eb	4 years ago
Oleksandr Duts	206877a476	TT#149462 Enhance UI admins role usage ... - Add Role column on /administrator table - Add Role dropdown input on /administrator/:id/edit - Add Role dropdown input on /administrator/create - Implements logic to resolve flags and role id params: 1. role_id is passed(create/edit) then flags will be overrided according to the concrete role. 2. role_id is not passed(create/edit) then flags will be checked to determine role id according to the concrete flags pattern: Role | Flags ----------- --------------------------------- system | is_system = 1, admin | is_superuser = 1 reseller | is_superuser = 0 ccareadmin | is_ccare = 1, is_superuser = 1 ccare | is_ccare = 1, is_superuser = 0 lintercept | lintercept = 1 Change-Id: Ia923a47f664a162d78a06efcc006f84dcd08701d	4 years ago
Kirill Solomko	4e309b9ef1	TT#153050 add API soft_expand query parameter ... * soft_expand=1 in API requests when coped with the expand query parameter tells the API to ignore possible expand conflicts (such as field mismatch or a permission issue), returning 200 OK instead of 409 Conflict Change-Id: Ib798aabddb1b4d66fc9708acbf713037696ad600	4 years ago
Rene Krenn	5445c72cc7	TT#144300 accept Windows .csv file uploads ... Change-Id: I2aae72cfc4ee418e6db8946152150f4fb400af31	4 years ago
Rene Krenn	5e9066c4fb	TT#151751 refactor persisting subscriber webpassword ... a multitude of issues popped after introducing bcrypted webpasswords in the database. most recently the PATCH /api/susbcribers rail was reported to reset the webpassword unintentionally. subscriber login fails afterwards, which is a severe issue. the bugs are adressed by this refactorings. the change also introduces a global variable $NGCP::Panel::Utils::Auth::ENCRYPT_SUBSCRIBER_WEBPASSWORDS to control encrypting webpasswords. it is still enabled as of now, but it's worth to consider disabling it. there other ways to have a "cost" for an authentication request, eg. adding a simple sleep(1sec). Change-Id: I2d47d54a2d83568546ffdd2b211337a5f56be3a2	4 years ago
Kirill Solomko	55a8d5568f	TT#152901 prosody provision ignore error on timeout ... * when a domain is provisionined in prosody and there is no connection to the host/port, the error is ignored and ok response is returned instead. Prosody does not have a persistent database and rather loads vhosts from kamailio.domain on startup and if it is down during domain creation/removal where will be no discrepancies when it starts. The new error checking behaviour benefits the CARRIER setups where a proxy host is still in xmlhosts but is not available (powered off) or prosody is not running there for some reason. Change-Id: Idaaaf2b31985873db9228958b60ff14fca5d1bf6	4 years ago
Rene Krenn	37f748cb76	TT#151401 invoice: calc totals from CDRs ... by default, re-rating CDRs of prepaid customers will not update the contract balances. in that case the total values on invoice PDFs become out of sync with the zone details list. Change-Id: Iba78b6386140012bb087235997880e8c28cc0972	4 years ago