834 Commits (85be902c72bbddac24d2f70abb94e4a328c614e7)

Author	SHA1	Message	Date
Rene Krenn	d3206fbbeb	MT#58762 harmonize restapi wildcard filters ... - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b (cherry picked from commit 308a974059) (cherry picked from commit aacf44c605)	2 years ago
Rene Krenn	c57231de40	MT#56239 api/callrecordings support filtering multiple metakeys ... filtering an Entity-Attribute-Value model cannot be done as simple conjunctions, but requires either INTERSECT set operation, or joining the same table multiple times. Change-Id: I5ce1ae1ece9406b6610487654f09d768a233b122 (cherry picked from commit 8e82715eb8)	2 years ago
Kirill Solomko	d9ee558764	MT#57100 avoid where ambiguity for query_types search_eq,search_like ... * uses prefix 'me.' for query types search_eq and search_like in the where condition to avoid ambiguity if the search_rs has joins that with the same column names Change-Id: I90fef80970aa4415480b00bbed2fb9fbee1f1ccc (cherry picked from commit c58a8b9b1f)	2 years ago
Rene Krenn	f9dc78a25e	MT#56239 api general caller/callee wildcard search support ... various api rails will need to support ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcards=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wildcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: Ie6065b0cfa883f7963e1dc8259fffea9a1edfdfe (cherry picked from commit 9c3a549094)	2 years ago
Rene Krenn	b1c216ee71	MT#58346 fix conversations voicemail timestamp filter ... Change-Id: I86fc4db7d5efddf73f6c0b068b1c9e79913fddaf (cherry picked from commit 5eff0601b5)	2 years ago
Rene Krenn	f5b6615680	MT#58346 caller/callee filters for conversations ... the conversation list now supports ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcard=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wilddcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: I792d2ea9c649c69c4b5cc98076097cb96467d4bc (cherry picked from commit ae612eb401)	2 years ago
Marco Capetta	1a6567c648	MT#57469 Fix kamailio lcr reload on PATCH/PUT APIs ... When calling a PATCH or PUT API on a peering group or outbound rule the reload of the kamailio lcr module was triggered before the update of the database, thus the kamailio status was not updated. Change-Id: I59ed863c85219e62d6f5b5a2af80db8ef952844c (cherry picked from commit be7193e75b)	2 years ago
Marco Capetta	51e549b9a5	MT#57342 /api/subscribers fix field role inconsistency ... When the subscriber preferences API is called by a subscriber admin of a normal (not PBX) customer, then some values are removed from the output. In all the other cases those values are instead returned. This fix let expose the profile_id, domain_id, status and webpassword to all the types of subscribers because necessary in the CSC context. Change-Id: I629475e7f51d747a55ebfbc44232fb94a54fed06 (cherry picked from commit ce6884ebab)	2 years ago
Kirill Solomko	1a1fb8f4ff	MT#56087 fix /api/callforwards sets auto creation ... * with PUT/PATCH data source and bnumber quick sets are correctly automatically created now Change-Id: Ia6f3be8958081f1611a1473b35c73826a9ed8784 (cherry picked from commit e2afe2ea06)	3 years ago
Kirill Solomko	c31e221028	MT#55871 /api/subscribers optimise GET alias_numbers ... * "alias_numbers" array when the resource is prepared is created directly from the resultset, avoiding 'foreach' loops and conditions. This improves performance on ~8000 voip_numbers from ~35 seconds to ~3 seconds. * is_devid is now always present in the "alias_numbers" object, and it's =0 if there is no related entry in provisioning.voip_dbaliases Change-Id: Ia05b26208f3fec3a9b2203aafe9b4c09b98ca44d (cherry picked from commit 0c4deaaad0)	3 years ago
Kirill Solomko	e19303a7cc	MT#55864 /api/subscribers correctly process administrative flag ... * administrative flag is now correctl set to false when requested by the client Change-Id: I81a1951f90ce9885bff806d39e11098475d93ac1 (cherry picked from commit 507d088586)	3 years ago
Kirill Solomko	84b448cdfd	TT#176050 adjust subfield expands ... Change-Id: I9826d254cec6f03e7c7bad7122450f4a22125e18 (cherry picked from commit 84e698e7ac)	3 years ago
Kirill Solomko	636bf3e8b3	TT#65101 expand now fills the same key only once ... * the same key is now expanded only once to use the same data ref otherwise expand like contract_id.contact_id,contract_id.billing_profile_id makes it so that 2nd contract_id would overwrite the already existing (expanded) contract_id Change-Id: I6cab67c2f549e9165dbf2cfd2f4b84daef503dd8 (cherry picked from commit 0555f32585)	3 years ago
Kirill Solomko	1cf5e6e7c5	TT#176050 add expand support on array of ids ... * it is possible to expand arrays of ids now * add expand support for pbx_group_ids * add expand support for pxb_groupmember_ids * remove _password and _webpassword internally prepared fields from expands by subscriber_id, pbx_group_ids, pbx_groupmember_ids Change-Id: I7651aae4c58d98943e82d1eda6b24d260ff2480a (cherry picked from commit 938f6ba05c)	3 years ago
Kirill Solomko	30240128c4	TT#65101 improve expand=all, /api/domains care roles support ... * expand=all now expands by the all resource keys instead of the current form fields, that is to reflect keys that are created manually in the response such as reseller_id or domain_id * ccare roles now correctly support /api/domains Change-Id: I9951bfd97b76186def4dc799c72da44425faea4a (cherry picked from commit 5a18d5fee8)	3 years ago
Kirill Solomko	c1ecacd81e	TT#186503 fix /api/billingprofiles for ccare roles ... * ccareadmin and ccare roles are now able to correctly fetch the list of billing profiles as well as request one by :id Change-Id: Ie5f9203b1aa9de9f7ed870caa2ea06ba262c9bfd (cherry picked from commit 486b0a10d5)	3 years ago
Kirill Solomko	185b93e03d	TT#186501 fix /api/capabilities for ccare roles ... * ccareadmin and ccare roles are now able to correctly fetch the capabilities data Change-Id: I4f4355dfe594a9342fd35c0c01984ef132d7d1a6 (cherry picked from commit 7e37f4b81c)	3 years ago
Kirill Solomko	f638a12b72	TT#182101 Fix check_allowed_ngcp_types detection ... * use any instead of grep for checking the allowed_ngcp_types array Change-Id: I7382a2a61764a4520cd07d2db67ffa3a5112b378 (cherry picked from commit f311177236)	3 years ago
Kirill Solomko	be4dc2f9a2	TT#182101 Phonebook feature is hidden for CE ... * templates now rely on c.config.general.ngcp_type and hide the Phonebook feature everywhere if ngcp_type is CE * introduce "allowed_ngcp_types" config for Controller::API::* that is an array, and when specified, only the ngcp_type roles are allowed, otherwise if not specified all ngcp types allowed (default) * Controller::API::Root: - filter controllers from the documentation rendedring that have allowed_ngcp_type config specified and do not match the current ngcp type * Role::API Role::Entities* - new method check_allowed_ngcp_types() - check_allowed_ngcp_types() is now called in Entities and EntitiesItem auto() and denies to 404 Path not found if the ngcp type does not match * "Phonebook" UI is now hidden for CE * /api/phonebookentries is now hidden for CE Change-Id: I41d4b2f87121f281472be3775b862333923fe37f (cherry picked from commit 09b589738d)	3 years ago
Kirill Solomko	d3dc152cdc	TT#175000 remove rtcengine logic ... * rtcengine related logic and apps is now removed * remove /api/rtcapps endpoint * remove /api/rtcnetworks endpoint * remove rtcengine relations from resellers such as enable_rtc flags * remove rtcengine related API tests * remove rtcengine and comx related libraries * remove csc webphone ui app * remove webrtc related selenium tests * remove rtcengine flags from /api/capabilities Change-Id: I83a4b0457fac2e0df23d267f8dbc82841dfb3001	3 years ago
Kirill Solomko	996cda6819	TT#173650 enhance /api/customerfraidpreferences ... * the endpoint now contains additional fields starting with prefix current_* that represent the current aggregated value that is used for the preferences and also current_fraud_interval_source current_fraud_daily_source that represent the used source for the current_ values (billing_profie or customer) customer - if the fraud limit is set on the customer level and > 0 billing_profile - if fraud limit is not set on the customer level Change-Id: I074285e3464420a14f65695c40c8b8008a241a8d	3 years ago
Kirill Solomko	68af361060	TT#173700 /api/topuplogs expand related fixups ... * Role::API::Contracts add item_by_id() that calls contract_by_id() * Utils::ProfilePackages::catchup_contract_balances return if $contract object is undef * Form::Topup::Log::contract_id expands into Role::API::Customers instead of Role::API::Contracts Change-Id: Id4fc67b8ea1e91f350d0172aafc2b722f34e61f3	3 years ago
Kirill Solomko	e011960739	Revert "TT#171850 fix unintentional primary number removal" ... This reverts commit 6bdfca91129309561e72eed902a8a4b66604a7bd. Change-Id: Ie7269ac9ce0302928b234302880bfa9896e8cdf0	3 years ago
Kirill Solomko	6bdfca9112	TT#171850 fix unintentional primary number removal ... * the current condition for primary number removal for PUT/PATCH is if the primary number exists and specified in the data as primary_number => undef. The condition failed as the 'primary_number' key was explicitly created regardless of the original user data input, resulting in a false primary_number => undef. Change-Id: I17651046627f5c48696c3f1d17da5aa49452fe9a	3 years ago
Oleksandr Duts	afa9289b66	TT#167900 /api/subscribers improve number duplicate checks ... * primary and alias numbers are now validated that they do not belong to another subscriber * aliases are now validated that they are not already set as the primary number * reduce amount of related sql queries Change-Id: I4397bbdc4bc9001b7feeef22cb8f85ee0b6ce8ff	3 years ago
Oleksandr Duts	4e7e55189c	TT#166900 API phonebookentries - fix form creation for empty params ... * If query params is passed then the role checking is skipped. Change-Id: I05f1b674d4b9a84f2a20c17f76c12258e166027a	3 years ago
Oleksandr Duts	3b9f19b6c8	TT#141101 UI/API fix custom_announcement upload ... * Ability to upload sound set file for custom_announcement. Change-Id: I51dbf3fd9b9820adfa8ebe186c63cf39383a76ee	3 years ago
Oleksandr Duts	f0a5c38874	TT#158252 API/UI cfmappings improve performance ... * Optimize cfmappings DBI - better performance for subscriber preferences API/UI. Change-Id: I6d73ecbe657ee84a43f6cc8f3b048aa011370603	3 years ago
Rene Krenn	b05628db60	TT#81004 support callforwards in provisioning templates ... provisioning templates can now include configuration of callforward mappings, eg.: cf_mappings: cfu: [] cfb: - enabled: 1 destinationset: name: "test" destinations: - destination: "123" cft: [] cfna: [] cfs: [] cfr: [] cfo: [] Change-Id: I8073322630d63e5ef23e7a9f8c299a6010cb4866	3 years ago
Oleksandr Duts	a4d3585430	TT#160300 API: header[rules,ruleactions,ruleconditions] - subscriber_id filter ... Add subscriber_id(billing) filter parameter for GET endpoints: - headerrules - headerruleactions - headerruleconditions Change-Id: Ief568ddbdc3641be5e57411191f5716ab175acb9	3 years ago
Oleksandr Duts	ace1698a3d	TT#154550 API topuplogs - expand fields ... * The next fields are expanded: package_after_id, package_before_id, profile_after_id, profile_before_id, contract_id, contract_balance_after_id, contract_balance_before_id, subscriber_idvoucher_id. Change-Id: I4d5f12fb88eaaeb8daf45e673c14e92c1512e239	3 years ago
Kirill Solomko	9dd50e8427	TT#158003 make subscriber location mappings 'location' optional ... * 'location' field is now optional, if not filled it it will always default to an empty string instead of null. This is required for the new mode 'forward' that has no use for this field. If the field is empty in any other mode like 'add' or 'replace', the entry will be skiped by the logic. Change-Id: Ia964c3bb272c9772c51b836ac2418ee4cd7b7f42	3 years ago
Oleksandr Duts	03271187c7	TT#157400 API/UI admins fix authorization for "system" role ... * Users with "system" role can change all items accross the system including the password changing for other users. * Login "system" has persistant "system" role. * "system" login name is restricted for the user input. Change-Id: Ibaecba35a86f71fa8895ce9d9feab8e768b65d14	3 years ago
Oleksandr Duts	938eef9140	TT#119465 API callrecordings - searchable caller/callee ... * Fetch recording_metakeys caller/callee for the certain record id(call). * Add caller/callee fields to the resource and form. * Frefetching recording_metakeys for the call recording. Change-Id: I767ea32e19edfd7cbbc74956200343f680fdb2b4	3 years ago
Rene Krenn	d82d93da9d	TT#71950 fix leftover with 35b568dde ... Change-Id: If71d07972f56cb1b7cb0bbafdcfd3b68cce6e254	3 years ago
Michael Prokop	35b568dde4	TT#71950 Fix typos ... * successfuly -> successfully * diplay -> display * recieve -> receive * mathes -> matches * cahnged -> changed * Unprocessible -> Unprocessable * The the -> The * repesent -> represents Change-Id: I123f5b1ec8c11fe01db4e5768bd640c4920d3366	3 years ago
Rene Krenn	599dd0613b	TT#151751 fix plaintext sippassword no longer returned ... this fix addresses regression reported by dominik: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) (cherry picked from commit 5e9066c4fb) Change-Id: I88c9ec40843f1e9a6983952b96c0b0e70fbb1bb1	3 years ago
Oleksandr Duts	581aa090e7	TT#153501 API: GET phonebookentries - fix subscriber access(422) to own phonebooks ... * Roles subscriber and subscriberadmin use the user voip subscriber id as a phonebook context. Change-Id: I5f119837b40169aa6d920774b4fc96551875dfc0	3 years ago
Kirill Solomko	f4154b1dbc	TT#154500 tighten /api/admins roles ... * An attempt to change own role, login, flags (except for can_reset_password) now returns 403 Forbidden, User cannot modify own permissions * POST checks if the admin has necessarry permissions to create another admin * PUT/PATCH changing own role is now forbidden * PUT/PATCH changing other's admin role now checks permissions * DELETE checks role permissions Change-Id: I990609985ae9cab6213cf47f5f5c8afba2efdda3	3 years ago
Kirill Solomko	81ebdb8dcf	Revert "TT#151751 refactor persisting subscriber webpassword" ... This reverts commit 5e9066c4fb. This implementation breaks: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) Change-Id: I0e8389e8ab34ad72f1b87a684daba77f1030f8ba	4 years ago
Kirill Solomko	e95ed81ca7	TT#154500 improve admin users behaviour ... * admin users with is_master = 0, cannot see other admin users (this includes system users) and brings the is_master flag to the common behaviour * ccareadmin, ccare users can now access te UI Admins page as well as /api/admins but they are limited to see/manage only themselves * admin users cannot see system users (UI/API) * reseller users cannot see system/admin users (UI/API) * admin users cannot modify their own role and flags except for: email, password, can_reset_password (UI/API) * UI edit form now does not render fields that are not meant to be modified by a user (exception: "login") Change-Id: I82e1946437fd2ec4651abd24074470c695a40582	4 years ago
Oleksandr Duts	9855b6ab45	TT#149461 Enhance /api/admins to accept the role data property ... - Optional "role" parameter is added for POST PUT PATCH. If "role" is provided then the passed flags are ignored and are applied internally by the server according to the provided role. If "role" is not provided then the former flags based approach is applied. Change-Id: Ib6e591ff6dc50122e0ec49a348153ca820fc2e03	4 years ago
Kirill Solomko	4e309b9ef1	TT#153050 add API soft_expand query parameter ... * soft_expand=1 in API requests when coped with the expand query parameter tells the API to ignore possible expand conflicts (such as field mismatch or a permission issue), returning 200 OK instead of 409 Conflict Change-Id: Ib798aabddb1b4d66fc9708acbf713037696ad600	4 years ago
Rene Krenn	5e9066c4fb	TT#151751 refactor persisting subscriber webpassword ... a multitude of issues popped after introducing bcrypted webpasswords in the database. most recently the PATCH /api/susbcribers rail was reported to reset the webpassword unintentionally. subscriber login fails afterwards, which is a severe issue. the bugs are adressed by this refactorings. the change also introduces a global variable $NGCP::Panel::Utils::Auth::ENCRYPT_SUBSCRIBER_WEBPASSWORDS to control encrypting webpasswords. it is still enabled as of now, but it's worth to consider disabling it. there other ways to have a "cost" for an authentication request, eg. adding a simple sleep(1sec). Change-Id: I2d47d54a2d83568546ffdd2b211337a5f56be3a2	4 years ago
Oleksandr Duts	e58cb2cc39	TT#149456 Admins introduce role_id flag ... - role_id is taken from billing.acl_roles and written into the billing.admins table when a new admin user is created/updated via UI/API. This is the first step towards the role based admin user handling. Change-Id: I0804379cbbcab174cebbb292397a39cb3ea01a31	4 years ago
Rene Krenn	d786af1591	TT#147151 finish refactoring of avoiding JOIN billing.product ... follow up on TT#147151 (fast loading/paging/searching panel datatables), which broke restapi tests. Change-Id: I799cb9087b9405c71dec4c690e7a7bab5dfdbdde	4 years ago
Kirill Solomko	6a0b5d7a75	TT#149459 expand consider null fields as valid ... * when field expand is requested and the field has "null" value (profile_id,profile_set_id), the field is considered as correct instead of returning 409 Conflict Change-Id: I2dfa918a0b99bff75429baa3e94a734fcb8c17e2	4 years ago
Kirill Solomko	78b80e7064	TT#149459 enhance expand functionality with allowed_roles ... * allowed_roles in the expand defintion restrict the field only to the roles in the allowed list, otherwise the field is not expanded. Change-Id: Ib6f776388457327f2fa85e71deb9591022cee2da	4 years ago
Kirill Solomko	8c556bbe36	TT#149459 improve and automate expand functionality ... * add dictionary support for fields that are expanded if encountered in all endpoints, with a possibility to override it, if defined on the endpoint's field level * move expand definitions from form fields into the Expand dictionary * simplify the expand usage, it now operates only with the <x>_id fields that are returned and visible in the response (e.g. if reseller_id is returned, then ?expand=reseller_id), the returned expand object name is <expand_field_name>_expand the, so in case of ?expand=reseller_id, the returned object will be reseller_id_expand * adapt Role/SystemContacts to work correctly with the expand functionality * expanded fields are returned as <expanded_field_name>_expand Change-Id: I4cab44ede9b40c70a95bbcedc81f58dd1f4e3b67	4 years ago
Rene Krenn	133bd43df4	TT#147151 fast loading/paging/searching panel datatables ... query refactoring an rowcount clipping for UI datatables that are slow when using millions of subscribers: contacts customers contracts subscribers billing profiles billing networks billing profile packages Change-Id: Ia50e3aa52684772548569b6908f0cbc08395a5a7	4 years ago