31 Commits (60fa23cb681afe3223794eccd0d6d8f6cb426152)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Rene Krenn	c2b5602183	TT#103450 enable lintercept role for interceptions PUT/DELETE ... Change-Id: Ie03a9a7dce7778a580a80a354364dddbd21996f9	4 years ago
Irina Peshinskaya	ffde9a6389	TT#37552 Fix formatting - remove duplicated commit call ... Change-Id: Iaa99baf0885524224bb7e0cbcaab12c00522da17	7 years ago
Irina Peshinskaya	0aa178ee01	TT#37552 Fix formatting - add missed newline ... Change-Id: Ia33d864175439dca679916fbac667d78244fc0f1	7 years ago
Alexander Lutay	5626bfc678	TT#29620 Clean TAP test warning: ProhibitMutatingListFunctions = Don't modify in list functions ... Change-Id: Ic9f19e4ee575044947bb6c38e8ca8217b369394f	7 years ago
Gerhard Jungwirth	00633d1618	TT#30376 filter interception numbers from log ... Change-Id: I280e7fd7266c47d9e3afdd0a96874a7f620e5316	7 years ago
Irina Peshinskaya	0d4d8cdb23	TT#28460 Format: Remove excrescent empty lines ... Change-Id: I5ff73d92bf62451fb6dbdae85ca07428c3f5af5d	7 years ago
Irina Peshinskaya	75d6edbcd9	TT#28460 Format: add line between subs in API controllers ... Change-Id: I67f11fef716941dc965dffd4e8fbb1a211791bbf	7 years ago
Irina Peshinskaya	9fa2a19b4f	TT#28460 Replace configs - not journalized ... Change-Id: I9843a780817922f23faa91041d3fab9b7336b2a3	7 years ago
Irina Peshinskaya	92e6215b71	TT#28460 Remove gather_default_action_roles ... Change-Id: Ie8080a9ac3b5b1004de456fe0ece7b31ed1541fe	7 years ago
Irina Peshinskaya	6dbb3b2229	TT#28460 Introduce return_representation in item packages ... Change-Id: Ibc2afdffd8a70245b6656f78bad2c4fc5273526e	7 years ago
Irina Peshinskaya	2498c8810e	TT#28460 Remove copy-pasted sub HEAD and sub end ... Change-Id: Ia06320ead891945eebe715fa34012a14d5529f17	7 years ago
Irina Peshinskaya	05774c2338	TT#28460 Remove copy-pasted sub OPTIONS ... Change-Id: I2b00ea267edcc3caa00eaac5753638794a13398c	7 years ago
Irina Peshinskaya	b14f34f008	TT#28460 Change parents in API controllers ... Use Entities and EntitiesItem respectively Change-Id: I5d32b010cc51810acee42d14c5c24ce3d4267602	7 years ago
Andreas Granig	eb09639458	TT#23569 Fix interception ACLs ... * Make sure resellers with interception rights can query both collections and items * Make sure we only query the reseller specific interceptions when accessing API as reseller Change-Id: I3010f899cbbd1a7a4f60025d95f09f013cc07c03	8 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override ... the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Irina Peshinskaya	2b430bdd8d	MT#18561 Change of the LIID is forbidden ... Also call agent request in the update_item method, to make it more safe. And added lost transaction commit Fix 500 response for the incorret x3_port input Change-Id: Ic538ffdd4d7fff833ba5395934a1b2bc6cf71664	9 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Rene Krenn	3e57109750	MT#19419 custom action role to support http method override ... Change-Id: I2d9fbf1f4feca76b91bdf73d4184ea707cc04e78	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Gerhard Jungwirth	45115f5d6e	MT#15269 fix some api tests, add test selection ... by choosing "stable" (about 1m30s) or "fast" (about 30s) as second argument of testrunner, only tests are run, which are currently succeeding on a plain trunk vm using docker. (times are on my machine) I hope we can in this way re-enable them on nightlies (or even in gerrit) so that devs have some better feedback on the impact of our changes. Current status of tests (in trunk): | Problems: | api-callforwards.t | api-balanceintervals.t | api-faxes.t | api-journals.t | | Fixed: | api-all-links.t | api-contracts.t | api-customercontacts.t | api-customers.t | api-rewriterulesets.t | api-root.t | | Working: | api-billingfees.t | api-billingnetworks.t | api-billingprofiles.t | api-billingzones.t | api-calllists.t | api-calls.t | api-cert-auth.t | api-cfdestinationsets.t | api-ncoslevels.t | api-pbxdevicemodels.t | api-pbxdevices.t | api-peeringgroups.t | api-peeringrules.t | api-peeringservers.t | api-preferences.t | api-profilepackages.t | api-resellers.t | api-rewriterules.t | api-soundsets.t | api-subscriberregistrations.t | api-subscribers.t | api-systemcontacts.t | api-threads.t | api-topuplogs.t | api-trustedsources.t | api-valid-patch.t | api-vouchers.t Change-Id: I74e672d9dc6bcccfd3ace2fe233dbcf325c6fc4d	9 years ago
Andreas Granig	7db73430c9	MT#17887 Properly update captagent on X1 PUT/PATCH ... Change-Id: I8e90ecf3444fc355297dcd28548213242617a105	9 years ago
Andreas Granig	011622f079	MT#16985 Use Moose in trunk for API ... Got dropped by accident. Change-Id: I47311bd57424d6a7e9faba66100934244c9dd72f	10 years ago
Andreas Granig	d6096237ef	MT#16985 InterceptDB points to pair instead of RO ... Change-Id: Ie951b784aaaead64d8af2e376dc8d970a3b1dcd0	10 years ago
Andreas Granig	f9ce228e76	MT#16985 Rename CentralDB to RoDB ... Change-Id: I3e4fcf39dc2323213e3f3a69c3bac375421f6bd4	10 years ago
Andreas Granig	638a4de158	MT#16985 Use CentralDB schema for interceptions. ... Change-Id: I4924eafb6d103ac23b33b3c889cbcd457b841ef5	10 years ago
Andreas Granig	520b66201e	MT#16273 Implement X1 agent interface for REST ... On X1 requests, properly update the configured agents on the cluster. Currently we only throw an error if no agents are configured at all, but let it slip through if the actual requests are failing, as they might be down or failing. Change-Id: I0f4e021a5cc4ba6a30e30bb197ed20d4504797d8	10 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Andreas Granig	8e0157b78b	MT#8613 Add basic CRUD for LI X-1 provisioning	11 years ago