945 Commits (597f01c39cdac557ce7deb4e46919255bb9c8e3e)

Author	SHA1	Message	Date
Kirill Solomko	999332d270	TT#171850 fix api-subscribers tests ... * Utils::Subscriber::update_subscriber_numbers() fix an error when $current_primary_number is undefined * t/api-rest: remove devid_alias from the tests as the field is deprecated and no longer in use Change-Id: I6e472398a7a393cd83de5818157629338388ec8e	4 years ago
Kirill Solomko	e011960739	Revert "TT#171850 fix unintentional primary number removal" ... This reverts commit 6bdfca91129309561e72eed902a8a4b66604a7bd. Change-Id: Ie7269ac9ce0302928b234302880bfa9896e8cdf0	4 years ago
Kirill Solomko	6bdfca9112	TT#171850 fix unintentional primary number removal ... * the current condition for primary number removal for PUT/PATCH is if the primary number exists and specified in the data as primary_number => undef. The condition failed as the 'primary_number' key was explicitly created regardless of the original user data input, resulting in a false primary_number => undef. Change-Id: I17651046627f5c48696c3f1d17da5aa49452fe9a	4 years ago
Kirill Solomko	f91797cbc5	TT#170500 password reset v2 fix redirect url ... * v2 redirect url is changed to /v2/#/recoverpassword Change-Id: If8624624dad5f31188ef47060ee3bb07a2531112	4 years ago
Rene Krenn	eac6c2dc4c	TT#146101 add external base url parameter ... for deployments that expose panel/csc via a proxy, the auto-generated base url printed in emails can be unreachable. we therefore introduce the option to explicitly specify a base url to use. it will support an sprintf pattern with individual params for eg.: - protocol scheme - domain part - port - base url path Change-Id: I6a9ca23126c669d249ef7f3e092cae0161235ebe	4 years ago
Rene Krenn	e1f48f0fba	TT#155600 use trailing wildcard in datatable search ... Change-Id: I7b8fe1240b12f66363e7a9f15dec36d7fa860a3b	4 years ago
Kirill Solomko	23796e02b4	TT#158252 GET /api/subscriberpreferences fix ambiguous id ... * distinct alias name was missing in the prefetch structure Change-Id: I3a306160d96faa8a46bc8ae386d0c71f7d6cc59c	4 years ago
Oleksandr Duts	afa9289b66	TT#167900 /api/subscribers improve number duplicate checks ... * primary and alias numbers are now validated that they do not belong to another subscriber * aliases are now validated that they are not already set as the primary number * reduce amount of related sql queries Change-Id: I4397bbdc4bc9001b7feeef22cb8f85ee0b6ce8ff	4 years ago
Kirill Solomko	38b48e860b	TT#158252 GET /api/subscriberpreferences performance ... * prepare_resource() use prefetch 'attribute' to address scenarios with high amount of preferences per subscriber Change-Id: I7a32ff9953ccf9a3cc7e482639c6bd3cdb28eb0f	4 years ago
Kirill Solomko	d7c7391644	Revert "TT#158252 API GET subscriberpreferences - fix DBI timeout" ... This reverts commit a6b5ac98c0. Change-Id: Ie9c70a0821db61cb2bc1634d54ae0f6d3a096a92	4 years ago
Donat Zenichev	493ca399a5	TT#167350 outbound registration: add proper transport handling ... We need to properly handle transport picking for the SIP peerings: - in case a non-default 'outbound_socket' is set for the peering, give a precedence to the transport used for it ; - in case a default 'outbound_socket' is set for the peering, use a transport protocol configured for this SIP peering ; The idea is quite simple, and meets our current requirements. Change-Id: I98d55b090f04642442d83da83d441aca0f000dec	4 years ago
Kirill Solomko	4554155627	TT#167400 change call forwardings preference to be distinct ... * Call forwardings related internal usr preferences are now distinct per call forward type (maximum 1 record per call forward type, if at least one forwarding for this type exists). This change is meant to address the issue when there are >1000 call forwardings per subscriber, which leads to performance issues. Other components (kamailio) only uses this preference as a boolean to check if there are call forwardings at all per type, therefore, more than one preference, per type, per subscriber is not needed. Change-Id: Iffa475700a74f56eff67400ce9b57092018a14a0	4 years ago
Rene Krenn	4df49f5639	TT#168050 fix allowed_cli check for duplicates ... Change-Id: I09874917c946b0e9be60ca1a0682f70c2d4f84df	4 years ago
Oleksandr Duts	3b9f19b6c8	TT#141101 UI/API fix custom_announcement upload ... * Ability to upload sound set file for custom_announcement. Change-Id: I51dbf3fd9b9820adfa8ebe186c63cf39383a76ee	4 years ago
Oleksandr Duts	a6b5ac98c0	TT#158252 API GET subscriberpreferences - fix DBI timeout ... * Add pref->attribute prefetching. * Remove unused contract balance calling. Change-Id: Idff3893beb42aa72bd04d6248a390ab6c89fe4a1	4 years ago
Rene Krenn	ebfcc70505	TT#157700 invoice templates call direction mode ... so far the invoice contained outgoing calls only. this change introduces the "call direction" mode for invoice templates, to configure invoices with either - outgoing calls only - incoming calls only - both outgoing and incoming calls Change-Id: I3a9d4e3dbb83de63cc2bfab5f1c55714fe487c25	4 years ago
Rene Krenn	2441d05642	TT#81004 fix exports for check CF destinations ... Change-Id: Ia241779d0c1b384f3ca7f6804e5bbcdc462e963a	4 years ago
Rene Krenn	b61d5c9735	TT#81004 fix check CF destination with "timeout" or "priority" vals ... Change-Id: I4757f399baa4f6c804a4c636b722677318189c2d	4 years ago
Rene Krenn	b05628db60	TT#81004 support callforwards in provisioning templates ... provisioning templates can now include configuration of callforward mappings, eg.: cf_mappings: cfu: [] cfb: - enabled: 1 destinationset: name: "test" destinations: - destination: "123" cft: [] cfna: [] cfs: [] cfr: [] cfo: [] Change-Id: I8073322630d63e5ef23e7a9f8c299a6010cb4866	4 years ago
Oleksandr Duts	8af29b6470	TT#154351 Sound set propagation ... * Contract default sound set - subscriber propagation for cases: - New customer sound set is created as default. - Customer sound set is changed to default. - New subscriber creation - setting contract default sound set id. * The mentioned cases were implemented for both UI and API. Change-Id: Ia4733c972ae388d3457d0336e3f85b85eec6e9a2	4 years ago
Oleksandr Duts	ace1698a3d	TT#154550 API topuplogs - expand fields ... * The next fields are expanded: package_after_id, package_before_id, profile_after_id, profile_before_id, contract_id, contract_balance_after_id, contract_balance_before_id, subscriber_idvoucher_id. Change-Id: I4d5f12fb88eaaeb8daf45e673c14e92c1512e239	4 years ago
Oleksandr Duts	03271187c7	TT#157400 API/UI admins fix authorization for "system" role ... * Users with "system" role can change all items accross the system including the password changing for other users. * Login "system" has persistant "system" role. * "system" login name is restricted for the user input. Change-Id: Ibaecba35a86f71fa8895ce9d9feab8e768b65d14	4 years ago
Rene Krenn	f3f473ba8d	TT#157700 fix invoice svg rendering broken for 1st detailspage ... Change-Id: I5c1b4b286236931d62b01eb6ed7b5f8b21fb1731	4 years ago
Rene Krenn	599dd0613b	TT#151751 fix plaintext sippassword no longer returned ... this fix addresses regression reported by dominik: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) (cherry picked from commit 5e9066c4fb) Change-Id: I88c9ec40843f1e9a6983952b96c0b0e70fbb1bb1	4 years ago
Rene Krenn	8fac1ef383	Revert "TT#144300 accept Windows .csv file uploads" ... This reverts commit 5445c72cc7. Reason for revert: not needed to support windows line terminator Change-Id: I00f22993e17ec7c9bcb6ee331d07b6da0495586a	4 years ago
Kirill Solomko	5d9618e642	TT#156354 fix a syntax typo when marking voicemail as read ... Change-Id: Ib13a1839e6f5bc9419fb137a2e6d4a23d6993ecd	4 years ago
Kirill Solomko	f4154b1dbc	TT#154500 tighten /api/admins roles ... * An attempt to change own role, login, flags (except for can_reset_password) now returns 403 Forbidden, User cannot modify own permissions * POST checks if the admin has necessarry permissions to create another admin * PUT/PATCH changing own role is now forbidden * PUT/PATCH changing other's admin role now checks permissions * DELETE checks role permissions Change-Id: I990609985ae9cab6213cf47f5f5c8afba2efdda3	4 years ago
Kirill Solomko	81ebdb8dcf	Revert "TT#151751 refactor persisting subscriber webpassword" ... This reverts commit 5e9066c4fb. This implementation breaks: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) Change-Id: I0e8389e8ab34ad72f1b87a684daba77f1030f8ba	4 years ago
Oleksandr Duts	9855b6ab45	TT#149461 Enhance /api/admins to accept the role data property ... - Optional "role" parameter is added for POST PUT PATCH. If "role" is provided then the passed flags are ignored and are applied internally by the server according to the provided role. If "role" is not provided then the former flags based approach is applied. Change-Id: Ib6e591ff6dc50122e0ec49a348153ca820fc2e03	4 years ago
Oleksandr Duts	206877a476	TT#149462 Enhance UI admins role usage ... - Add Role column on /administrator table - Add Role dropdown input on /administrator/:id/edit - Add Role dropdown input on /administrator/create - Implements logic to resolve flags and role id params: 1. role_id is passed(create/edit) then flags will be overrided according to the concrete role. 2. role_id is not passed(create/edit) then flags will be checked to determine role id according to the concrete flags pattern: Role | Flags ----------- --------------------------------- system | is_system = 1, admin | is_superuser = 1 reseller | is_superuser = 0 ccareadmin | is_ccare = 1, is_superuser = 1 ccare | is_ccare = 1, is_superuser = 0 lintercept | lintercept = 1 Change-Id: Ia923a47f664a162d78a06efcc006f84dcd08701d	4 years ago
Rene Krenn	5445c72cc7	TT#144300 accept Windows .csv file uploads ... Change-Id: I2aae72cfc4ee418e6db8946152150f4fb400af31	4 years ago
Rene Krenn	5e9066c4fb	TT#151751 refactor persisting subscriber webpassword ... a multitude of issues popped after introducing bcrypted webpasswords in the database. most recently the PATCH /api/susbcribers rail was reported to reset the webpassword unintentionally. subscriber login fails afterwards, which is a severe issue. the bugs are adressed by this refactorings. the change also introduces a global variable $NGCP::Panel::Utils::Auth::ENCRYPT_SUBSCRIBER_WEBPASSWORDS to control encrypting webpasswords. it is still enabled as of now, but it's worth to consider disabling it. there other ways to have a "cost" for an authentication request, eg. adding a simple sleep(1sec). Change-Id: I2d47d54a2d83568546ffdd2b211337a5f56be3a2	4 years ago
Kirill Solomko	55a8d5568f	TT#152901 prosody provision ignore error on timeout ... * when a domain is provisionined in prosody and there is no connection to the host/port, the error is ignored and ok response is returned instead. Prosody does not have a persistent database and rather loads vhosts from kamailio.domain on startup and if it is down during domain creation/removal where will be no discrepancies when it starts. The new error checking behaviour benefits the CARRIER setups where a proxy host is still in xmlhosts but is not available (powered off) or prosody is not running there for some reason. Change-Id: Idaaaf2b31985873db9228958b60ff14fca5d1bf6	4 years ago
Rene Krenn	37f748cb76	TT#151401 invoice: calc totals from CDRs ... by default, re-rating CDRs of prepaid customers will not update the contract balances. in that case the total values on invoice PDFs become out of sync with the zone details list. Change-Id: Iba78b6386140012bb087235997880e8c28cc0972	4 years ago
Kirill Solomko	ac94626f9e	TT#149456 fix and improve user role_id retreival, api tests ... * NGCP::Panel::Utils::UserRole::_field_to_name now supports both hash and object to parse the roles from * NGCP::Panel::Utils::UserRole::resolve_role_id returns undef if no roles has been passed or there are no entries for the role in the database * Fix NGCP::Panel::Utils::Journals to correctly fetch and set $journal{$role_id} * Adjust api-journals.t, remove tx_id, user_id, role_id from checks Change-Id: Ieff23bd4291f3b88ba92bbfc2b00b57f66bf76e1	4 years ago
Kirill Solomko	16b4dfe5dd	TT#149456 Journal allow empty role_id ... Change-Id: Ibfb2707a730839b43cd7bda15082fd309f67be76	4 years ago
Oleksandr Duts	747af33a7a	TT#151250 Write journal resource params: user_id, reseller_id, role_id, tx_id. ... Change-Id: Ie6ae9f3a49fbd4be4f302a568669f78aecfdfe25	4 years ago
Oleksandr Duts	e58cb2cc39	TT#149456 Admins introduce role_id flag ... - role_id is taken from billing.acl_roles and written into the billing.admins table when a new admin user is created/updated via UI/API. This is the first step towards the role based admin user handling. Change-Id: I0804379cbbcab174cebbb292397a39cb3ea01a31	4 years ago
Rene Krenn	d786af1591	TT#147151 finish refactoring of avoiding JOIN billing.product ... follow up on TT#147151 (fast loading/paging/searching panel datatables), which broke restapi tests. Change-Id: I799cb9087b9405c71dec4c690e7a7bab5dfdbdde	5 years ago
Rene Krenn	f9ff14fab2	TT#146800 support decimal VAT rates ... Change-Id: I7222e012fbc6c848527f0f7a2a45c56894ae509b	5 years ago
Oleksandr Duts	ad6467561f	TT#149650 UI language handling ... * Change UI language workaround. Priority: 1. Parameter "lang". 2. Cookie "ngcp_panel_lang". 3. Default english - "i-default". * Add parameter "lang_save" - save the "lang" value at "ngcp_panel_lang" cookie. Change-Id: I0abc9e3ab564ba56d2e3f9b0dee47d32c27e0049	5 years ago
Kirill Solomko	f8d982708b	TT#147151 restore get_contract_rs() product join ... * restore the removed product table join in get_contract_rs() as get_contract_rs() and product.class are used in many places in the code that have their own filters by product.class Fixes: 133bd43df TT#147151 fast loading/paging/searching panel datatables Change-Id: I56e20f240ccc08cf1c9a25947f67990691425549	5 years ago
Rene Krenn	e83ed0960d	TT#147400 subscriber identifiers/lookup for prov template ... option to just lookup an existing susbcriber (instead of creating it). Change-Id: Ib5352541753c3435a48a56b36af5fe7dda1d51da	5 years ago
Rene Krenn	133bd43df4	TT#147151 fast loading/paging/searching panel datatables ... query refactoring an rowcount clipping for UI datatables that are slow when using millions of subscribers: contacts customers contracts subscribers billing profiles billing networks billing profile packages Change-Id: Ia50e3aa52684772548569b6908f0cbc08395a5a7	5 years ago
Oleksandr Duts	8017805589	TT#124802 GET /api/admins/:id/journal - fixing ... * Admins with is_system and is_superuser are able to see the items for all roles. * Admin is able to see own journal. Change-Id: I3e5d459b08ff7ef218220f1ae11974351121c489	5 years ago
Rene Krenn	e73dd3ea27	TT#132650 api .csv upload for provisioningtemplates ... the POST /api/provicioningtemplates/<reseller>/<template> request will accept text/csv content type to provision many susbcribers at once. Change-Id: I59079ba8f2bacc0ce2b1367d2bd1a7251cf4763c	5 years ago
Rene Krenn	4c47920f2e	TT#132650 run provisioningtemplate from api ... provisioning templates with their dynamic forms can be executed by a entityitem POST request, ie. POST /api/provicioningtemplates/<reseller>/<template> or POST /api/provisioningtemplates/<readonly template> Change-Id: I77f6c9d42e1afdb49635d3f11e4d73bcf6269605	5 years ago
Kirill Solomko	b199ad3e1e	TT#139550 improve vmnotify behaviour ... * vmnotify() now accepts cli and uuid arguments * API handling of voicemails is now improved to: - send a notify if the item's INBOX/Old has been changed - correctly process DELETE to send vmnotify after the item's removal Change-Id: Ic00ae825cf091bce273e55aa37cd0a7ac80d8b0f	5 years ago
Kirill Solomko	67bc755276	TT#139550 vmnotify use correct uuid ... * wrong value was used in the vmnotify select query, now the correct uuid is used Change-Id: I311cc7ea9cce01014dd40761d0bc7f594ecca7b2	5 years ago
Alexander Lutay	f1e00a0408	TT#141802 use proper SNOM param 'setting_server' on SRAPS ... For some reason SNOM SRAPS has two parameters with identical 'param_name'='setting_server': * "Settings Server URL" * "Settings Server" NGCP need to use the second one on SRAPS to set device redirect URL. We were receiving it by luck in the past. The commit e548057d4 introduced performance improvement to 'last' the search in loop after finding the proper 'param_name'. As a result of improvement we set wrong option on SRAPS. Dump of options for the history: * "Settings Server URL": >{ > 'links' => { > 'self' => 'https://secure-provisioning.snom.com/api/v1/settings/5683038cec6c4fa9be95b2de9d1750e8', > 'group' => 'https://secure-provisioning.snom.com/api/v1/setting-groups/8ab9230acf3f4060868509a93ad53f3f' > }, > 'attrs' => [], > 'choices' => undef, > 'default_value' => undef, > 'description' => undef, > 'field_type' => 'url', > 'fkey' => $VAR1->{'indexed'}{'enabled'}, > 'group' => '8ab9230acf3f4060868509a93ad53f3f', > 'multiple' => $VAR1->{'indexed'}{'enabled'}, > 'name' => 'Setting Server URL', > 'no_profiles' => 164, > 'param_name' => 'setting_server', > 'product_groups' => ['6cdbd3dfe5fe40e28c909f118a509b8a'], > 'section' => 'global', > 'sortable' => $VAR1->{'indexed'}{'enabled'}, > 'uses_permissions' => $VAR1->{'indexed'}{'enabled'}, > 'uuid' => '5683038cec6c4fa9be95b2de9d1750e8', > 'indexed' => { > 'default_size' => 4, > 'max_size' => 0, > 'start' => 0, > 'enabled' => bless( do{\(my $o = 0)}, 'JSON::PP::Boolean' ) > } >} * "Settings Server": >{ > 'links' => { > 'self' => 'https://secure-provisioning.snom.com/api/v1/settings/50a400560eec4dc0b96b026094e06562', > 'group' => 'https://secure-provisioning.snom.com/api/v1/setting-groups/8ab9230acf3f4060868509a93ad53f3f' > }, > 'attrs' => [], > 'choices' => undef, > 'default_value' => undef, > 'description' => 'Setting Server for Desk phones', > 'field_type' => 'text', > 'fkey' => bless( do{\(my $o = 0)}, 'JSON::PP::Boolean' ), > 'group' => '8ab9230acf3f4060868509a93ad53f3f', > 'multiple' => $VAR1->{'fkey'}, > 'name' => 'Setting Server', > 'no_profiles' => 3189, > 'param_name' => 'setting_server', > 'product_groups' => ['1a45a2a3f6b94c4cbfa5439b446132f7'], > 'section' => 'phone-settings', > 'sortable' => $VAR1->{'fkey'}, > 'uses_permissions' => bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ), > 'uuid' => '50a400560eec4dc0b96b026094e06562', > 'indexed' => { > 'default_size' => 4, > 'max_size' => 0, > 'start' => 0, > 'enabled' => $VAR1->{'fkey'} > } >}; The commit introduces the second filtering parameter 'section'='phone-settings', as we cannot rely on any other parameters. Change-Id: Iec2b2a0c2068efb90af20af3dba711dfc7f55ca8 Fixes: commit e548057d40	5 years ago