3704 Commits (4fd28056c37cd2770efdb5ee12c499db684e77f8)

Author	SHA1	Message	Date
Marco Capetta	4fd28056c3	MT#57240 Allow '+' char in device line number definition ... Change-Id: I0234d7fd3a34d55cd1370a65f93171264eb7f44f (cherry picked from commit b013f3560a)	2 years ago
Kirill Solomko	3be315b61c	MT#57216 fix advanced cf sets selection for admins ... * $c->user->id was wrongly used in the advanced cfs selection and now changed to $prov_subscriber->id to filter it regardless of the user editing the cfs Change-Id: I8fa65bbce625d4b21dbb620a1f92919ed7fe2a88 (cherry picked from commit 7bc5ec093f)	2 years ago
Marco Capetta	4cced36db5	MT#56776 Fix peer deletion when not enabled ... Deletion of a disabled peer was not working because panel was trying to get the correspondant ID from the LCR table, while the entry is not there because peer was in fact disabled. To fix it an additional check has been added to evaluate if the peer is enabled or not at the moment of the deletion. Change-Id: I3c488a8711c5f7b486b6c0a3950738fb8689bb07 (cherry picked from commit 0274ab04c3)	2 years ago
Marco Capetta	4a87bf6204	MT#56835 Fix device provisioning when external_number is in use ... In case device is provisioned with lines that use the external_number feature, then the provisioning system uses the pilot subscriber username instead. This because the external_number is not properly passed to the provisioning templates. Change-Id: I48e494b303db318d504578f10e8b44aa9b64ddc5 (cherry picked from commit 26b63e88f0)	2 years ago
Kirill Solomko	0aaa4dcdf3	MT#56802 fix preferences default values selection ... * preferences form with enum values now set the default one as selected if no preference is set yet. * disable autocomplete for the preferences table fields. this addresses Firefox using incorrect selected values even though the correct data is sent by the server. Change-Id: I6865eec05c085b89e651b125a7f35724859ccbc2 (cherry picked from commit 3c1842c122)	2 years ago
Kirill Solomko	3e0a0a94b5	MT#56744 audio transcoding fixes ... * detect WAV GSM 6.10 format and provide sox with the correct type 'gsm'/'sndfile' as otherwise it fails to detect it * use Capture::Tiny instead of IPC::Simple for better capture (out,err,rc) * mp3/ogg decoding fixes to reflect the GSM 6.10 possible formats Change-Id: I79c5657543ccc4741efb3bdd56d7a0a37f251a4c (cherry picked from commit f8831929a4)	2 years ago
Kirill Solomko	f10405eab4	MT#56455 fix peering groups timeset relation ... * fix wrong timeset relation name from timeset.name to time_set.name Change-Id: Iaeb20310943ca4c0c2254f2f4d53c770739bdbe2 (cherry picked from commit fa82bac3ca)	2 years ago
Kirill Solomko	fca9e94984	MT#56432 UI prevent ncos level timeset to have different reseller_id ... Change-Id: Ic4874d48e59a4104ddc297ee29fc136a8faf7c37 (cherry picked from commit 6843e26f9b1c193ad68ced97890b6e85d753fad4)	2 years ago
Kirill Solomko	4a93dc5eaa	MT#56432 add timeset field to Form/NCOS/AdminLevel ... Change-Id: I72aa388cc46f40d933de0c3dbd53b6cb3a9111e0 (cherry picked from commit ba2894de48)	2 years ago
Kirill Solomko	0b18d2c5da	MT#55931 PbxFieldDevicesAPI form target_number is now optional ... * target_number field is now defined as optional Change-Id: Ia50305d882b3726bd869fd8ef8bc40df1182a9d8 (cherry picked from commit d7d9416ac0)	2 years ago
Kirill Solomko	307866aca6	MT#56432 add time set support to ncos levels ... * add NCOS Levels UI Time Set support * add NCOS Levels API Time Set support Change-Id: I03201c09462f0f0ceff39da271bcf8ca1fc797b8 (cherry picked from commit 2a0b8dcc1e)	2 years ago
Kirill Solomko	dee6b60c6e	MT#56208 additional inherited cfs improvements for subscribers ... * API: GET collection returns only distinct cf sets * UI: inherited cf sets are now shown in the advanced view and having suffix '(inherited)' to distinguish them from the own ones as they are not available in the "Manage Sets" edit dialog. Change-Id: Ifd8c1a46fcb4c2c66f8f63268a1e91b80792c216	2 years ago
Kirill Solomko	36974efa03	MT#55931 add /api/pbxdevices target_number support ... * target_number is now supported and it must contain only [0-9#*]+ Change-Id: I9b1548c2dd0f644c1f21668471599c34347f1109	2 years ago
Kirill Solomko	519de11d8c	MT#55931 add autoprov field device target_number support ... * the UI field device edit form now contains a checkbox that, when checked, replaces the subscriber devices dropdown with an input text (only [0-9#*] chars are allowed) * aligned the related script code to automatically detect and handle switching between the sub number / target_number Change-Id: I70ae5cf5bb81f5953d25a760fbf0efe6c418f6cb	2 years ago
Marco Capetta	36ae8cedb9	MT#55931 Add new speeddial, forward, transfer device buttons ... Change-Id: I0b9c1f3ddb0d4cd3fe28995b170e9104c668a553	2 years ago
Kirill Solomko	e90ba9d517	MT#56208 allow subscriber role access to cf sets ... * subscriber role can now GET call forward sets that does not belong to the user but used in call forwards assigned to the user * the user can only GET the sets but cannot update/delete them (403 Forbidden is raised in case of attempt) Change-Id: I391b802d962f4bbeae991e3046ac3f132a19edb6	2 years ago
Kirill Solomko	80bf560b8d	MT#55687 add ncos_set preferences support ... * ncos_set preferences are now supported in the UI/API Change-Id: I0e479712d3f27a6ae5f8b77f06c616406e1742f5	2 years ago
Kirill Solomko	9254092a3f	MT#56234 get_usr_preference_rs and prov_subscriber ... * get_usr_prerefence_rs is streamlined to the other get_*_preference_rs functions and prov_subscriber param is now optional there, that allows to return a resultset of usr preferences matching the attribute name. * this fix also fixes DELETE soundset where if contract_id is defined, the logic tries to remove all 'contract_sound_set' usr_preference across all subscribers that have it assigned. Change-Id: Ia43327c8bcf93047d29da6401cbd97bce2971578	2 years ago
Kirill Solomko	766cab0f9c	MT#56286 fix subscriberprofile api attribute field ... * update_item(): check that $resource->{attributes} contains data and an array before processing it * api-journals.t: fix subscriberprofile 'attributes' field Change-Id: I28a2e22859cd998f99277e88037dff23981038f3	2 years ago
Kirill Solomko	673ac66c70	MT#56234 fix cli check for subscriber roles ... * cli preference assigned number is only checked when the user's role is subscriberadmin or subscriber Change-Id: I71f9207f4705eb1ae6f4ea0810dd3a1e541144cf	2 years ago
Kirill Solomko	b838c5d0e7	MT#56286 render all subscriber profiles with prof_pref = 1 ... * on the subscriber profile preferences page, only preferences that had enabled attributes plus had prof_pref = 1 were shown. that caused confusions as subscriber profile attributes are rendered from exposed_to_customer = 1 and do not use the prof_pref flag, whereas the rendered preferences do not use the expose_to_customer flag and use prof_pref = 1 instead. now to avoid the confusions, all voip_preferences that are not internal and have prof_pref = 1, shown in on the preferences page (and accessible via API). if the list needs to be reduced, then it must be properly done by removing the prof_pref flag for them. Change-Id: I7f2428e319d2c8d322ee5e4efd96615178c1f3ef	2 years ago
Kirill Solomko	45d9fb34b5	MT#56286 fix subscriber profiles form and api update ... * subscriber profile form is fixed so that the attributes list is now correctly shown in the old UI * /api/subscriberprofiles update, attribute values are now correctly transformed for the validation and processing Change-Id: I4418250d4a0e702d75524ab5999eb47429be5a04	2 years ago
Kirill Solomko	8288a30f61	MT#56234 cli preference edit filter for subscriberadmin ... * Preferences::create_preference_form() now contains a check for 'cli' preference to only allow numbers that belong to the same customer if role is 'subscriberadmin' Change-Id: I8eb3bed928a943330ab0045d2893365b533b0c16	2 years ago
Kirill Solomko	6c179dd5c4	MT#56234 get_usr_preference changes ... * as_admin param is no longer needed as get_usr_preference() fetches actually set preference for a susbcriber and used only by the code (not exposed directly to 'subscriber', 'subscriberadmin' roles * with the aforedescribed, get_usr_preference() no longer filters by expose_to_customer, expose_to_subscriber for 'subscriber' and 'subscriberadmin' roles * refactor get_usr_preferences() to be simple and in line with the other get_*_preferences() as it's mainly responsible for fetching the preference as requested by the internal code Change-Id: Ia52d8f4ebfd854901bf446e29fb475dea1fba866	2 years ago
Kirill Solomko	6d487452bb	MT#56234 susbcriber preferences related changes ... * fix customer_view role name typo so that it's correctly limited to for 'subscriberadmin' role * revert behaviour of get_usr_preference_rs() to return undef if no preference is found (no access) * get_usr_preference_rs() now also fetches all internal preferences for internal work for 'subscriber' and 'subscriberadmin' roles but they remain invisible for them and not accesible for direct changes (only when requested by internal logic) * new get_usr_preference_rs() 'as_admin' parameter that enables for internal requests to return the preference value for 'subscriberadmin' and 'subscriber' roles, currently used to show 'lock' status and 'display_name', which are otherwise inaccessible as those preferences do not have expose_to_customer, expose_to_subscriber flags * fix api_prference_defs() correct filtering of preferences for 'subscriber' and 'subscriberadmin' roles Change-Id: I1a0e51ace1c649f9061deaccb7d6e9f8459f0ed8	2 years ago
Kirill Solomko	81d50cdce1	MT#56234 get_usr_preference_rs changes ... * get_usr_preference now always returns a ResultSet object as it expected. If there is no preference found an empty ResultSet object is returned that does not have ->first. That is now in line with how the usage of the function works in the current codebase and should not produce errors when there was a preference requested that did not exist and 'undef' was returned instead of an object. * remove 'skipping' debug code that caused a lot of spam in the panel-debug.log reporting skipped usr preferences for 'subscriberadmin' and 'subscriber' roles Change-Id: Ia9d033994e36afd48c2b6d91b08163f871a71b4c	2 years ago
Kirill Solomko	8459e03f51	MT#56234 update_voicemail_number update all use cases ... * update use cases for update_voicemail_number() and provide $param{c} Change-Id: I016ea49e1f619e129010909b673e1e7c7ef08c91	2 years ago
Kirill Solomko	b51c0c9698	MT#56234 restrict cli preference allowed numbers for subscriberadmin ... * subscriberadmin can now only set numbers that belong to the customer as 'cli' Change-Id: Iecc2c5dc322e13292e1ec0d9262451c8947da671	2 years ago
Kirill Solomko	f1cc84c34f	MT#56234 add voip_preferences.expose_to_subscriber support ... * expose_to_subscriber is a new preferences flag that indicates that the preference can be read/modified by 'subscriber' role * expose_to_customer now only does the same as expose_to_subscriber but for 'subscriberadmin' role * get_usr_preference() not expects $params{$c} to be passed as an argument * fix update_voicemail_number() behaviour, it correctly updates number for subscribers of a subscriberadmin as well as no longer fails with an error if echo_voicemail_number or cli are not available (not set or not visible) Change-Id: I95fade92efb541146e9e56ba4f517af79fa71b5a	2 years ago
Kirill Solomko	34eeac7fc2	MT#56068 fix /api/resellerbrandings reseller_id field ... * reseller_id is now only mandatory for the 'admin' role Change-Id: Idd090332ed2877b2a2c06c9cce741757cc718737	3 years ago
Kirill Solomko	e2afe2ea06	MT#56087 fix /api/callforwards sets auto creation ... * with PUT/PATCH data source and bnumber quick sets are correctly automatically created now Change-Id: Ia6f3be8958081f1611a1473b35c73826a9ed8784	3 years ago
Kirill Solomko	4f8603d15f	MT#56068 /api/resellerbrandings/:id change ... * :id is now the brainding's id instead of reseller_id. That was rather a bug and now fixed and consistent with the rest of the endpoints. Change-Id: I794e577499050a95ed68c21af3f963f9f8e9c274	3 years ago
Kirill Solomko	f942b07a1e	MT#32992 fix /api/resellerbrandnglogos ... * add described query_params 'subscriber_id', 'reseller_id' so they are avaialable on the doc * remove search by param from Role::ResellerBrandingLogos::_item_rs() * fix Role::ResellerBrandingLogos::_item_rs() queries * Controller::API::ResellerBrandingLogos* - now always returns the binary data containing the logo and with the Content-Type header - change NOT_FOUND message to indicate that the ResellerBrandingLogo is either not found or does not have image/image_type * do not log response queries * fix allowed_role to be: admin, reseller, subsscriberadmin Change-Id: Iaadb47fb2d72886a8d9244a523d5914500a4dd20	3 years ago
Kirill Solomko	2904de66b9	MT#56028 /api/cftimesets subscriberadmin role change ... * subscriberadmin is now able to fetch cftimesets of other subsribers that belong to the customer Change-Id: If7931e154ab825a6ebca25bec49b8ea28d87bafd	3 years ago
Kirill Solomko	ae32c62fd1	MT#56027 /api/cfdestinationsets subscriberadmin role change ... * subscriberadmin is now able to fetch cfdestinationsets of other subsribers that belong to the customer Change-Id: I212f0e31a8e77caa6f681f227771e0b11efb5f62	3 years ago
Kirill Solomko	018dc08be6	MT#56026 /api/cfsourcesets subscriberadmin role change ... * subscriberadmin is now able to fetch cfsourcesets of other subsribers that belong to the customer Change-Id: I95217587430c52cd7078e1604ffec549ae2dd6b5	3 years ago
Kirill Solomko	4c1a9d9c11	MT#56029 /api/cfbnumbersets subscriberadmin role change ... * subscriberadmin is now able to fetch cfbnumbersets of other subsribers that belong to the customer Change-Id: Ib92c161f320257ba2d6614e10d9eaf03247e7014	3 years ago
Rene Krenn	e9367e0cfe	MT#55972 support wildcard search for customer external_id ... Change-Id: I8287f7650f68dab2e806259ec00ffad2ba45fe1a	3 years ago
Rene Krenn	d6c3ae470e	MT#55957 interceptions: consider active subscribers only ... Change-Id: I136d600f876aca754c60514d5640b619d41d82f5	3 years ago
Kirill Solomko	64b71cdcd1	MT#32999 /api/cfmappings subscriberadmin scope of view change ... * subscriberadmin can now see all other customer's subscribers call forwards as well as per subscriber_id Change-Id: I4bdaf3390667fc7208fa6dbde9292b8ba911667f	3 years ago
Rene Krenn	ff198cef49	MT#55694 MT#55419 provide generated datatable search tooltips ... the search field of admin-panel datatables was tuned/configured over time to allow fastest possible search, "as-you-type". for large tabels it eg. will only include indexed columns, which never was transparent to the users. the UI will now display tooltip texts with detailed hints about included columns, wildcard support, etc. Change-Id: I737732a55003d50068236bb0150a2f47d06deaf5	3 years ago
Kirill Solomko	0c4deaaad0	MT#55871 /api/subscribers optimise GET alias_numbers ... * "alias_numbers" array when the resource is prepared is created directly from the resultset, avoiding 'foreach' loops and conditions. This improves performance on ~8000 voip_numbers from ~35 seconds to ~3 seconds. * is_devid is now always present in the "alias_numbers" object, and it's =0 if there is no related entry in provisioning.voip_dbaliases Change-Id: Ia05b26208f3fec3a9b2203aafe9b4c09b98ca44d	3 years ago
Kirill Solomko	507d088586	MT#55864 /api/subscribers correctly process administrative flag ... * administrative flag is now correctl set to false when requested by the client Change-Id: I81a1951f90ce9885bff806d39e11098475d93ac1	3 years ago
Kirill Solomko	826d3f1d9f	MT#55618 /api/subscribers fix default contract_sound_set assignment ... * when a new subscriber is created via POST, if the associated customer has at least one default contract_sound_set, it is correctly assigned to the subscriber as the "contract_sound_set" preference. the logic is now inline with the UI behaviour Change-Id: Ifeb86faf6718648b29e6391bd16752766358ed0f	3 years ago
Michael Prokop	2b3a18b190	TT#76552 send_template: log mail sending actions ... We need to trace sending mails to be able to track down possibly not sent mails, see e.g. MT#31936. Use quotesensitive to not leak from/to information into logs, but handle this properly to ensure we're GDPR safe. Change-Id: I4d09d073e12b1dd61053956252b59ad06a29d59d	3 years ago
Rene Krenn	67f6063341	MT#55551 add ccare roles to /api/callforwards ... Change-Id: I414e10fca61bc535471a0b2525b7e684ea9d23e5	3 years ago
Kirill Solomko	a86e868a6f	MT#55538 /api/soundsets allow filtering by customer_id=null ... * when customer_id query param is specified as customer_id=null or customer_id=NULL it now correctly fetches soundsets that do not have customer_id assigned to them Change-Id: I8de3d9615c133c2abd3eb2b5f4fea8de5b652417	3 years ago
Rene Krenn	d4d924e146	MT#55436 mark concurrent_* fraudpref fields as readonly ... Change-Id: I47f3a42163703c57cecdbcf4dd84e9e7a9cbe2e7	3 years ago
Rene Krenn	a9f53cdf82	MT#55418 hide billing mappings with terminated profiles in AUI ... Change-Id: Id480f3c0928d8e3d0a29dd3508c08de68e64ce5a	3 years ago
Rene Krenn	afe80f0110	MT#55421 fix deleting domains ... xmlrpc request such as domain.reload can fail, when database content was not yet replicated. Change-Id: I769f9470b526ef5175826e6c18cbe28c6c1501ca	3 years ago