3404 Commits (476f93778b97a7deab36355e4904de1ccbeec19d)

Author	SHA1	Message	Date
Kirill Solomko	476f93778b	TT#133800 fix webpassword, change subadmin expose password ... * webpassword is not correctly removed based on length, and remain visible when in plain-text or empty (unset) * config->security->password_(sip|web)_expose_subadmin now only affects subscribers under the same customer that are not this subscriber admin Change-Id: I329e0f1ad97dd513a33e3652ed03b4a43a95ed04 (cherry picked from commit 535c38cd93)	4 years ago
Kirill Solomko	d1e119445b	TT#129162 Admins fix password field transformation ... * password field is virtual and needs to be transformed into saltedpass, restored the removed logic that does that in process_form_resource() Change-Id: I8baabbef2bdb46db850e12b6e0c638ca5c3deddf (cherry picked from commit 992c9f1e48)	4 years ago
Kirill Solomko	9838121715	TT#129162 fix subscriber webpassword field validation ... * 'webpassword' field is now also validated for invalid (non-ascii) characters * Fix multiple APP input field validation erros to comma joined. * Adjust 'webpassword' field validation errors to have better readability when there are multiple validation errors Change-Id: I21536f97a4da78cc5192a3abd8cd5adef1b819ec (cherry picked from commit cc10506b2e)	4 years ago
Kirill Solomko	2a438339ef	TT#133901 fix administrative flag for subscriberadmin ... * 'administrative' field is read only for susbcriberadmin role and that caused it to be removed from the final update 'resource', setting it to 0 if not existed. now the 'administrative' field is only changed in the database if it's defined in the 'resource'. Change-Id: I50738a77052c2163b19b2a42293c7a00e2780bc3 (cherry picked from commit 3ef167575c)	4 years ago
Kirill Solomko	1870bb7bdf	TT#130750 do not pack() jwt secret ... * the extra packing of the secret key during encode/decode conflicts with the API v2 implementation * move JWT "typ" from the payload to the header Change-Id: Ica5822d810d6eaf7b3ae017f7037f25637b6f861 (cherry picked from commit 53408c2e94)	4 years ago
Victor Seva	5b9bbabf2b	TT#137602 prosody: domains are treated as lowercase ... Change-Id: I65af0765112cbf4ba52daf2baf28043197ebeae3 (cherry picked from commit 883cf884f2)	4 years ago
Victor Tsvetov	a38e843adb	TT#137552 Update German translations ... Import new translations from Crowdin. 99% translated 81% approved Change-Id: I78db4d313fb1ae8481fe82a8aa15cf8bdedba8c5 (cherry picked from commit c9e56364a4)	4 years ago
Rene Krenn	4155971dd5	TT#134807 "ignore domain" option for billing profiles ... fee matching works in 2 attempts: 1. try to find a fee matching <user@domain> 2. if none found, try to find a fee matching <user> the billing_profile record will get a new field "ignore_domain". if set to "1", step#1 above should be skipped. Change-Id: I7f0a8f1dd8d5699ad4e2b8242c68fb9f75fc1bff (cherry picked from commit 48f8938dfd)	4 years ago
Kirill Solomko	87b706d595	TT#133800 fix webpassword field removal ... * webpassword field was unconditionally deleted in API GET and DELETE methods, it now relies on resource_from_item for the common approach Change-Id: I703158fd2022b49a49470db28cb22f37e613f841 (cherry picked from commit 02f3f6b3a1)	4 years ago
Victor Tsvetov	b9d0d148aa	TT#126853 Replace "free minutes" with "free calling time" ... The value of "interval_free_time" preference is specified in seconds. To avoid confusion, use the term "free calling time" rather than "free minutes" in tooltips. Change-Id: Ia4bd507e4a2281723fd2168a34b2178bf404f867 (cherry picked from commit 0592f3f731)	4 years ago
Kirill Solomko	2c5e4d5ab8	TT#133800 fix password fields behaviour in API ... * PATCH: password fields are not removed when resource is created for apply_patch(), they are removed under the same condititions later when hal is generated, that is to ensure that admin users without the 'show_passwords' flag as well as subscribers will not run into situation when they use PATCH and cannot apply it for "path": "/password" or/and "path": "/webpassword", as they were removed before apply_patch() * rework encrypted webpassword detection. webpasword is detected as encrypted if its length is 54 or 56 and it contains at least one '$' char, there is a chance for false positive detection when a user provides with a plain-text password with the same pattern but it's very unlikely, as well as since mr8.5 webpasswords are expected to be encrypted, and moreover worth case scenario is that the plain-text password will not be returned to the user Change-Id: I8ea739cbf728b2134f3ce00cee29da42ab3fb4a3 (cherry picked from commit c50b49db96)	4 years ago
Victor Tsvetov	e4bded2d27	TT#115002 Fix collecting i18n strings from Forms ... Fix ngcp_panel_dump_db_strings.pl to load Forms modules properly. Make modules not to fail when they are called without ctx context. Change-Id: I695978b1831068f37198bce9f6a5b9e406d79ede (cherry picked from commit 21bbb382d6)	4 years ago
Alexander Lutay	8de7b9f2d6	TT#130659 Improve path debug output in panel-debug.log ... It is much more usable to see the debug information as URLs: > Jul 22 08:24:53 sp1 ngcp-panel: DEBUG: *** New GET request on path: / > Jul 22 08:24:53 sp1 ngcp-panel: DEBUG: *** New GET request on path: /subscriber > Jul 22 08:24:53 sp1 ngcp-panel: DEBUG: *** New GET request on path: /subscriber/ajax Instead of Catalyst oriented way: > Jul 22 08:24:53 sp1 ngcp-panel: DEBUG: *** New GET request on path: > Jul 22 08:24:53 sp1 ngcp-panel: DEBUG: *** New GET request on path: subscriber > Jul 22 08:24:53 sp1 ngcp-panel: DEBUG: *** New GET request on path: subscriber/ajax Change-Id: I38699152e232c5f5aa2ef218db9bf61c692bbf33 (cherry picked from commit 12c2911fe4)	4 years ago
Alexander Lutay	a48ed18570	TT#130659 Improve debug log layout (common style, removing plus/star markers) ... It was close to impossible to read ngcp-panel debug log due to: * missing clear marker of the start reuqest processing, use '***' once only * some personal markers (like '+++++++') have been removed as they have no meaning for other developers. Let's remove the personal markers and work to make the panel debug log well readable for all developers. Change-Id: I69faff3ab2258fc156e88c7b8da0edfef14c3e6e (cherry picked from commit 6fbf99e461)	4 years ago
Alexander Lutay	d25ed73bcc	TT#130659 Stop calling systemd openvpn status twice on every HTTP request ... The ngcp-panel<=>openvpn functionality has never been finished but on every HTTP requset ngcp-panel was asking systemd about openvpn status. Twice! From /var/log/ngcp/panel-debug.log : > Jul 19 09:36:32 sp1 ngcp-panel: DEBUG: Path: dashboard > Jul 19 09:36:32 sp1 ngcp-panel: DEBUG: systemctl list-unit-files openvpn.service > Jul 19 09:36:32 sp1 ngcp-panel: DEBUG: systemctl is-enabled openvpn@ovpn > ... > Jul 19 09:36:33 sp1 ngcp-panel: DEBUG: Path: dashboard/ajax/peering_sum > Jul 19 09:36:33 sp1 ngcp-panel: DEBUG: systemctl list-unit-files openvpn.service > Jul 19 09:36:33 sp1 ngcp-panel: DEBUG: systemctl is-enabled openvpn@ovpn > ... > Jul 19 09:36:33 sp1 ngcp-panel: DEBUG: Path: dashboard/ajax/emergency_mode > Jul 19 09:36:33 sp1 ngcp-panel: DEBUG: systemctl list-unit-files openvpn.service > Jul 19 09:36:33 sp1 ngcp-panel: DEBUG: systemctl is-enabled openvpn@ovpn It is unnecessary load, moreover for not-yet finished feature. Let's move openvpn WIP functionality into 'NGCP Support Status' page and finish it there one day. The goal of this commit is to stop DOS'ing systemd. Change-Id: I6c9ba9e1b218e58b5adffe741f4490b3729d17e7 (cherry picked from commit 6263f167e2)	4 years ago
Kirill Solomko	4627e2e5a4	TT#127357 /api/callists return correct call type ... * /api/callists "type" field now contains the same call type value as it is in the database, for flexibility so that customers can implement their own logic around it, as well as filtering by the query parameter "type" works as expected. * For history: in /api/callists in case of direction "in", the type was replaced with type=call regardless of the what was in the database Change-Id: I1174b34747fe1b739cd6bfc050911c58c4b0964a (cherry picked from commit 118d2c3d5c)	5 years ago
Kirill Solomko	351a8c36cc	TT#121250 improve sip_lcr_reload and sip_domain_reload ... * sip_lcr_reload is now called after "commit" in all API endpoints, to correctly reflect updated DB changes. It was correct in /api/peeringrules POST but not correct in DELETE, as well as also not correct in /api/peeringservers and /api/peeringgroups * sip_domain_reload does not check if the domain is successfully reload in kamailio proxy as is logic is redundant, it fails however if domain reload XMLRPC request failed on any available proxy servers. Another reason is by default tcp_conn_wq_max in kamailio-proxy is 32KB by default and that causes an impact when domain.dump XMLRPC is used on very large domain sets (600+), as well as sip_domain_reload has improved performance with the removed XMLRPC domain.dump body parsing. Change-Id: I17c5718198b06b1ce78b2654f3d7c3bd2830f60b (cherry picked from commit d17c4be4a5)	5 years ago
Kirill Solomko	ab4d8e22f1	TT#130450 use uuid in /api/cfdestinationsets /api/cfmappings ... * unify the logic and use uuid in /api/cfdestinationsets and /api/cfmappings if the subscriber's primary number is empty Change-Id: Ibdb7e2a2bcd33165be5ec1d92c4f1df24f59405a (cherry picked from commit 1dfdad0a8f)	5 years ago
Flaviu Mates	db8f0feff6	TT#126601 Implement /api/authtokens endpoint ... * the endpoint will receive "type" (expires|onetime) and "expires" (positive integer representing seconds) * type will define the expiray method for the token; onetime: the token expires as soon as it's used, or after "expires" seconds if not used expires: the token can be used multiple times until it expires according to the "expires" param value * login_jwt endpoint for generating the JWT token for subscribers has been enhanced to accept the "token" param, containing the token generated using the /api/authtokens endpoint * admin_login_jwt endpoint for generating the JWT token for admins has been enhanced to accept the "token" param, containing the token generated using the /api/authtokens endpoint * login_jwt and amin_login_jwt will respond with 403 "Forbidden" if the token role stored in Redis does not match the role of the user that generated it * /api/authtokens is hidden from documentation for now Change-Id: I4eb76c2b08f2e24774fa84ba0ccf7412ce8670e8 (cherry picked from commit 9b422ddabf)	5 years ago
Rene Krenn	944823b780	TT#121500 fix missing mos_data in /api/conversations ... Change-Id: Ia0a549a96d1fd311021a474d5098b1ab859e5a31	5 years ago
Alexander Lutay	1961077d73	TT#128256 Add localisation for phonebook 'Upload CSV' page ... Otherwise localisation is missing for 'Upload CSV' page https://x.x.x.x:1443/phonebook/upload_csv Change-Id: I5c174cecf0d74486e8b700d2b1aca6b87e43b15b (cherry picked from commit 8885d06a42)	5 years ago
Rene Krenn	5c5047a070	TT#121500 fix missing mos_data in /api/callists ... Change-Id: I4e958dd6ec05042c6ee18bbd7ed7186792a6be50 (cherry picked from commit 2b751b139d612d20964e7ba236c60a2a1b316d86)	5 years ago
Kirill Solomko	698c0215aa	TT#129162 fix passwork characters check ... * check that the password variable contains a value Change-Id: Iba1cf809d5cd81b3dbbeb4686765a667e339d93f (cherry picked from commit 63812835c0)	5 years ago
Kirill Solomko	a2002e118a	TT#129162 respect framed setting for root default ... Change-Id: Ibced32326b213ba2d8cce90cc5d915e464b56027 (cherry picked from commit 407490c101)	5 years ago
Kirill Solomko	cefd712509	TT#129162 add bcrypt password characters check ... Change-Id: I08723d02a7e4bc042351444b201d1f96cc986af3 (cherry picked from commit f4597b6ed7)	5 years ago
Kirill Solomko	871fbe41e2	TT#129162 tighten user access checks ... * add additional centralised checks for inactive and read_only users. * use_userdata_from_session=0 now for all auth realms to cause the data re-fetched from the database, to avoid scenarios when a user is set as inactive or read_only and UI keeps using the cached data. the change only affects cookie and JWT subscriber based sessions as in all other cases, the auth data is fetched from the storage regardless. * add is_active=1 flag for the internal 'system' role, as otherwise access would be permanently denied for it. * default 403 error for denied api requests is changed to "Forbidden" instead of "Forbidden path". Change-Id: I1d6d3c765ca8e017e11845c1f5260243a3963c3b (cherry picked from commit 20e77c7b54)	5 years ago
Victor Tsvetov	e85042c4df	TT#129160 Complete missing Russian translations ... Add missing translations. Some of them are machine-translated and require later proofreading. Change-Id: I18a8e87938665e705ba045eb9b9fccbd8c3fc34e (cherry picked from commit 829479e153)	5 years ago
Flaviu Mates	128d07347a	TT#128850 Fix 500 eror on /api/preferencedefs ... * add quotation with ~ for square brackets ([]) comming from the database, as it is needed for I18N Change-Id: Ia1253e90d47858a930a4a9569c2d27993a0cd4bc (cherry picked from commit 131fe8e270)	5 years ago
Flaviu Mates	18c4692fcc	TT#128552 Add filtering by name for /api/billingprofiles ... Change-Id: I8b62b4b7ad4aec3d0538fb84a3b73e451fcb1db1 (cherry picked from commit c1752e7e82)	5 years ago
Flaviu Mates	87c1305ca0	TT#128253 Add localization support for /api/.+preferencedefs ... Change-Id: Ibee6b7c4952167a112c80d6972b7a9471a6ff958 (cherry picked from commit f27eedf33c)	5 years ago
Rene Krenn	7fa17c8c74	TT#118802 log raw perl catalyst request time ... (cherry picked from commit 05f2f1137d6d3ce1deb1880eb1427b94e409c691) Change-Id: I6bda815d2ccf2800a0a352c0d44aaee8039ee8d5 (cherry picked from commit 40c4ade6ea)	5 years ago
Alexander Lutay	29fe568b35	TT#115002 Update dataTables.*.js localization files ... * all: sort alphabetically for better diff tool usability * de: translated 'sSortAscending/sSortDescending/sLoadingRecords' * de: corrected punctuation for 'sZeroRecords' * es: removed 'sUrl' as missing in 'default/english' file * fr: add missing translation file * it: corrected punctuation for 'sZeroRecords' * ru: add missing strings 'sLoadingRecords/sEmptyTable' * ru: removed 'sUrl' as missing in 'default/english' file * ru: corrected punctuation for 'sZeroRecords' Change-Id: If62137e7e5910e884f8d8eccb055999806cbb731 (cherry picked from commit 3f96d76269)	5 years ago
Kirill Solomko	6df13ee59e	TT#127805 remove temp transcoded files ... * temp files created for transcoding operations are now correctly removed Change-Id: Ie95fccd2ed2a533060e4abc2fa3593c9f951225a (cherry picked from commit d3566d0aa8)	5 years ago
Flaviu Mates	a840fc5224	TT#125850 Add filtering by 'type' for /api/contracts ... Change-Id: Ibc1f1fe4558472523d949cdea30815a08637e138	5 years ago
Flaviu Mates	fe7f65d948	TT#99700 Fix subscribers PATCH in case of admin without show_passwords ... * restore password field in prepare_resource after it was deleted in resource_from_item for admins without show_passwords flag * the password is restored only in case it's missing from resource and it's present in DB Change-Id: I390fb8fb94f4546734cb899c741dc90e439df068	5 years ago
Kirill Solomko	102e494708	TT#121250 /api/peeringrules fix lcr.reload ... * xmlrpc lcr.reload request is now sent after the transaction is committed, otherwise the reload operation is performed without the newly added changes in the peering rules Change-Id: I728605a8d277b00d02a3f864c84f172306f7b090	5 years ago
Flaviu Mates	e09c478ee1	TT#124275 Add 'Login to CSC' button in subscriber page ... * upon pressing the button, a new session object with selected subscriber's details will be inserted in Redis, and also a new ngcp-panel_subscriber cookie will be created containing the session id of the previously created session object; then the user will be redirected to CSC v1 address where the selected subscriber will be authenticated based on the cookie and Redis info * the new button will be available for admin, reseller, ccare and ccareadmin roles Change-Id: I03952efe4abe18e61884859c466d700a7885ead4	5 years ago
Kirill Solomko	85c7d7c071	TT#123550 add /api/platforminfo virtual endpoint ... * /api/platforminfo does not have its own endpoint file and therefore, does not appear in the rendered documentation. it only supports GET method and renders the template file. the endpoint is designed to provide with the prerendered JSON data containing the current platform configuration. * /api/platforminfo supports both authenticated and anonymous requests, where based on that, the template provides with the corresponding info withing the current scope. Change-Id: Idc8138595eda2c14e7f8dc7ed97cc50039fd1adc	5 years ago
Flaviu Mates	43abaeee4d	TT#119464 Add start_time and end_time filter params to callrecordings ... * the new filter params works as follows: * if start_time is provided, recordings with start time greater than provided value are displayed * if end_time is provided, recordings with end time less than provided value are displayed Change-Id: Ie9cfb88141506581e2b724d4502b88091f9c7a02	5 years ago
Kirill Solomko	eb9a263e58	TT#119501 XMLDispatcher add skip host support ... * when a target host times out, instead of generating an error, the host is skipped, this is due to the fact that some proxy hosts can be disabled but still present in the xmlhosts table * introduce new code in $ret = distpach(...), -1 indicates that the host was skipped because of the timeout. Change-Id: I0f7b5c64124c6481a142c1821a88ab9c3a652bd1	5 years ago
Flaviu Mates	884229fc74	TT#123650 Fix 500 error in Panel UI Email Templates ... * Replace wrong usage of 'reseller_id' filter for missed templates resultsedl use 'id' instead, because the query is made directly on resellers table Change-Id: I85bdcda79168979c8b1bb0503ab7bba91c5f8a78	5 years ago
Flaviu Mates	f4cb6933b4	TT#119550 Allow subscribers to manage their registrations ... * give access to subscribers roles to see, create and update own registrations * subscriberadmins can manage all registrations of subscribers under same customer Change-Id: I643121da901b0ed99fc718106a1632da4e1e1936	5 years ago
Flaviu Mates	7177959a79	TT#119550 Fix registrations pagination on parametrized request ... * Previous commit for full scan pagination removed pagination for subscriber_id filter which was anyway not working properly in some corner cases * Introduced usage of Data::Page which correctly paginates through the results Change-Id: Ic1c98c090b9e92362ab1f2d9b0de0c39660d9e20	5 years ago
Flaviu Mates	35d9c3598a	TT#122001 Allow subscribers to access /api/subscriberprofiles ... * subscribers are now allowed to fetch their own subscriber profile, they can't modify them Change-Id: Iabf1244020d0f453257993cf24d4c9036a125397	5 years ago
Gerhard Jungwirth	64c120a5e5	TT#44168 create additional form for subadmin non-pbx subscriber edit ... The fix has been created by Gerhard Jungwirth three years ago for branch 'mr5.5' and was not merged into branch 'master'. It is a follow up master commit to address customer ticket TT#82306. The cherry-pick has been done AS IS, with one small trivial resolution: > + my $is_pbx_customer = $c->stash->{billing_mapping}->product->class eq "pbxaccount"; > my $base_number; > > ++<<<<<<< HEAD > + if($subscriber->contract->product->class eq "pbxaccount") { > ++======= > + if($is_pbx_customer) { > ++>>>>>>> 239d4a385... TT#44168 create additional form for subadmin non-pbx subscriber edit Change-Id: Ie242c4ad44fc21319cdaa29dcca423fe241aab20 (cherry picked from commit 239d4a3859)	5 years ago
Victor Tsvetov	c3474aed69	TT#118401 Complete the missing French translations ... Add the missing 25% of French translations in i18n fr.po file. The translation and proofreading were done by Alconost (Chawki Benzehra). Change-Id: I8078eef0dd0118716801114855ab3ede23c981d7	5 years ago
Victor Tsvetov	dfe2a659eb	TT#115002 Unwrap i18n PO translation files ... Unwrap wrapped lines in existing i18n PO translation files to prepare them for new unwrapped versions from Crowdin. To promise consistent format the normalization was done by 'script/extract_i18n.sh'. Change-Id: I9ec8394c83fa6bfde25fdaa9ab1b5d94f2512fa9	5 years ago
Victor Tsvetov	63356d2ebe	TT#115002 Normalize i18n English messages.pot file ... Remove location file name duplicates repeated inside the same context line. Bring the new "u-Law" version of 'transcode_PCMU' voip_preferences attribute. Change-Id: Ibf16e5090f79ccf9a6ce3cb3bd171f22f7d07899	5 years ago
Kirill Solomko	1e06df3fdf	TT#114304 /api/resellers?status support multi values ... * /api/resellers 'status' query parameter now supports comma separated multi values e.g.: status=active,locked Change-Id: I16b7499079a7ac7b2070910141ba12fada52bbb4	5 years ago
Kirill Solomko	0484c0d15f	TT#114304 add status query param to /api/resellers ... * it's now possible to filter reselelers by their status (active, terminated), the default return of all resellers has not changed. Change-Id: I6e1f2b6745ac6c3c4a012fe261ee5db810084be3	5 years ago