26 Commits (41fb2d22cc0daaa56b8a893fe3cfcc8a3419fe3a)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	2 years ago
Kirill Solomko	22a8e95c29	MT#57708 sound set/file use READ COMMITTED ... * as changes to sound sets and sound files cause internal triggers + SP to be invoked, the gap locking should be reduced to avoid possible deadlocks, hence READ COMMITTED transaction isolation level is used for all sound sets and sound files change operations. * fix a condition that caused an evaluation error when both old_parent_id and parent_id are undef. Change-Id: I7e69a0a0e5878c03b086977933315e532aaa2a29	3 years ago
Kirill Solomko	89173442f3	MT#57223 improve sems audio cache invalidation ... * clear_audio_cache is now invoked also from: - when a sound file is added (to reflect use_parent/potential child sets) - when a parent is changed for a sound set (to reflect current and potential child sets) - when a sound set is removed (to reflect potential child sets) * clear_audio_cache() is reworked - clear_audio_cache() now calls virtual_child_sound_sets to fetch all potentially affected child sound sets and also clears audio cache for them. if the amount of fetched sound_sets is greater than 10000 then the the whole audio cache is invalidated * _clear_audio_cache_service() is reworked - supports/expects a list of sound sets and sends them as a string with ':' separator - if both sound handle and sound sets are provided it calls clearFiles (so that only the specific sound handle is cleared) - if only sound sets are provided it calls clearSets (so that all of the cached files beloning to the sets are removed) - if none of the above are provided it calls clearAll to invalidate the whole cache Change-Id: Ie85f208e27183e88665803b93bb16d7de8e3d7ac	3 years ago
Kirill Solomko	6a922c5cfb	MT#56693 parent_name, allow empty sound files, sems audio cache ... * /api/soundsets new parent_name field * /api/soundfiles now allow POST to be done without the upload, for cases when an empty record needs to be added to define "use_parent" behaviour * improve sems audio cache clear on sound files change, now sems instances that are not available (not running/request timeout) are skipped instead of raising an error Change-Id: I83af2ee2fd3672ab35cf330464ace68416ab52be	3 years ago
Kirill Solomko	44ec794db2	MT#56693 add parent sound set support ... * sound sets can now use other sound sets as parents, in this case if a sound is missing for a sound set, it's taken from the parent one if it exists there, chained parents are also supported with the available sound files "accumulated" across them. * add "expose_to_customer" field to sound sets, it enables exposing system sound sets to customers so they can be used as a parent or assigned to the 'sound_set' preference by 'subscriberadmin'. * add "use_parent" field to sound set files, it's true by default (for existing or missing sound files) and if set to 0, then parents are not used for this particular sound file. * use_parent column is hidden on the UI if a sound set does not have a parent assigned * improve sound set handles list on the UI - Upload is renamed to Add - empty record are shown in the filename column as localised "(empty)" and Edit/Delete action buttons * API /api/soundsets new 'parent_id' field, default null * API /api/soundfiles new 'use_parent' field, default 1 * API /api/soundsets new 'expose_to_customer' field, default 0 * API /api/soundsets customer_id field now contains the customer id for 'subscriberadmin' role and 'null' if it's a system sound set * system sound sets with expose_to_customer == 1 and within the same reseller are now visible to 'subscriberadmin' on the UI and via the API in read-only mode, same with the sound files that belong to the sound set. If a system sound set expose_to_customer is set back to 0, this sound set is automatically removed from all contract sound sets where it was assigned as a parent as well as from all subscriber 'sound_set' preferences. * contract_sound_set|sound_set preference API updates now have tigher checks for contract_id and also if the system sound set is exposed to the customer and belongs to the same reseller Change-Id: I4908fd15e9c224d4c30794ceb8dae1b444bbf56a	3 years ago
Irina Peshinskaya	73d4c8fa74	TT#47906 Fix soundsets POST without contract or customer ... Change-Id: I148e475ed1766c0fa7e4cad981402c36ea24818d	7 years ago
Irina Peshinskaya	bb04e38d65	Revert "Revert "TT#47906 Remove unnecessary code from /api/soundsets/"" ... This reverts commit 04500cbc40. Change-Id: Id13dc9c487420371bf5e69a519fd6a135d9f0d92	7 years ago
Kirill Solomko	04500cbc40	Revert "TT#47906 Remove unnecessary code from /api/soundsets/" ... This reverts commit af314a0d33. Change-Id: Ieb643178d9b8168f4c1b56dce6d621f306094751	7 years ago
Irina Peshinskaya	af314a0d33	TT#47906 Remove unnecessary code from /api/soundsets/ ... And fix discrepancy between doc and accepted parameter Change-Id: Ied28b5c93f2f6c528af4dba070054c828404e84e	7 years ago
Irina Peshinskaya	4ceb7754b7	TT#47906 Fix discrepancy between doc and code in /api/soundsets/ ... generated from form api doc shows contract_id parameter, but code consider only customer_id Change-Id: I55a91e052a04ee182b1d39f89ff5543439945c72	7 years ago
Irina Peshinskaya	e0ee27d2bb	TT#47569 Rename soundset override parameter to replace_existing ... Change-Id: I9d7ddb0592e4631fe1cf38ea8554f17284d6b331	7 years ago
Irina Peshinskaya	b88000b968	TT#47569 Add possibility to load default files in sounsets api ... Change-Id: I1bf9a90ca3655772d9c671f9de725c974ebdd0bd	7 years ago
Irina Peshinskaya	9ed0657d4c	TT#40503 Show journal links to allowed roles only ... Change-Id: I547b2db4767b1e383506bc812b6486db944fceec	8 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	8 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	9 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	9 years ago
Gerhard Jungwirth	3fc22bd277	TT#4334 adapt soundsets and autoattendants for subadmin ... Change-Id: I62f5d4d6227f209ebe1e8949fe0d5db5303c30e9	9 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	10 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	10 years ago
Gerhard Jungwirth	bb03c1ff46	MT#17173 fix item filtering in API ... item_rs from API.pm was not executed before Change-Id: I803f5680d174820db9497d4f7cc1902bfa54a9ab	10 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	10 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Rene Krenn	b5dca5e6e2	MT#11917 next batch of API resources w. journal ... -enhanced test detail: did not detect missing CRUD operations yet -query param 'operation' didn't work for 'recent' yournal entry of all API resources so far -fix of several copy paste errors in existing rest api code -... Change-Id: I71b54212d8126b0280fcad2e568fad52a673cbf0	11 years ago
Andreas Granig	b827f73ab4	MT#5879 PoC of generating invoice out of template ... Rework zone fee handling. Implement invoice creation (WIP) - still real template data missing.	12 years ago
Andreas Granig	aaac4b6415	MT#7067 API: Implement sound set handling.	12 years ago