763 Commits (3ec080493d4de9580d3054a79e08cd97034ed430)

Author	SHA1	Message	Date
Kirill Solomko	1d560ba079	MT#62178 fix external_id, profile auto removal for subscriber roles ... * fix 'subscriber' and 'subscriberadmin' roles using PATCH to cause external_id, and profile fields removed. * remove profile_id field from the 'subscriber' and 'subscriberadmin' form Change-Id: Id8bb068ca7fcac2c0c5954f2ed79e841d18ac398 (cherry picked from commit 97e457c92b) (cherry picked from commit 62e42e62d0)	10 months ago
Kirill Solomko	6a64d43d04	MT#62180 /api/subscribers prevent subscribers from POST/DELETE ... * regular subscribers should not be able to use POST as they are not allowed to create other subscribers, nor other PBX groups. resource. * they should not be able to use DELETE as they cannot delete themselves nor other subscribers, nor PBX groups. Change-Id: Idaacb344b65ff8c5da9f4c3649a9b4089938a82c (cherry picked from commit 4eace822b5) (cherry picked from commit 08be9a8afb)	11 months ago
Rene Krenn	55da4f0647	MT#60197 support deleting call recordings per subscriber ... admin panel will no longer delete callrecordings for all parties of the call, but the single subscriber only. rest-api, behaves the same way, if the ?subscriber_id= parameter is provided. when a callrecording is deleted by all call parties, the remaining records and recording files will be dropped. Change-Id: I61f667bdb074a935a8a04473a3685b10e5e09222 (cherry picked from commit 1c09e2773a) (cherry picked from commit 22c5b8ad7e)	1 year ago
Rene Krenn	9eaf851f7e	MT#59363 fix /api/domains/?domain= filter pattern behaviour ... this filter is another spot, where leading/trailing wildcards were added unintentionally, during harmonization. Change-Id: Id23114f8e7ebca018ad222e35b39d8260f1da92f (cherry picked from commit 48b71e68c5) (cherry picked from commit 8dfc9b1eb3)	1 year ago
Marco Capetta	1569e45da8	MT#60756 Fix subscriberprofiles POST api call as reseller ... Administrators with reseller role were not able to create new subscriberprofiles because API was fialing with 500 error. In particular: LOG="«DBIx::Class::Row::store_column(): No such column 'reseller_id' on NGCP::Panel::Model::DB::voip_subscriber_profiles at /usr/share/perl5/NGCP/Panel/Controller/API/SubscriberProfiles.pm line 172» The error was caused by the addition of the reseller_id info in the $resourse even if not needed. Change-Id: I7970a2716d7af959639937a9a844160ab73a9176 (cherry picked from commit d40126ef0a) (cherry picked from commit 0d4467e291)	1 year ago
Kirill Solomko	cc7ba9e24f	MT#56301 move lock_provisioning_voip_subscriber before underrun_lock ... * POST /api/subscribers/ invoke lock_provisioning_voip_subscriber() before underrun_lock(), so that if the subscriber is about to be locked due to customer balance costs, the lock_provisioning_lock_subscriber() invocation will not unlock it back straight after Change-Id: I55020f844c9aa76df2e2f057a88b2ae7c9ebbfcc (cherry picked from commit c6aaaddd87) (cherry picked from commit 8d016b0bdd)	2 years ago
Rene Krenn	521d25f094	MT#56301 set locklevel of created subscribers only if specified ... Change-Id: I90f2d68dee50ab240de4eb5af7495ddd551c00d8 (cherry picked from commit df670f501f) (cherry picked from commit a1fb2bfd4b)	2 years ago
Marco Capetta	b9974aad50	MT#56301 Fix API creation of an active subscriber with lock ... Using API is possibile to edit an existing subscriber and set status: active and lock: 2. It is instead impossbile to create a new subscriber with the same configuration because the 'lock' param is not taken into account. The only way to properly setup lock level it is to set the status to 'locked' and this is in fact wrong. The fix address this issue and allow now to create a new subscriber with status: active and lock: 2. Change-Id: Id18e40bc001c5a7de30f5d148231bda93a3b1b3d (cherry picked from commit 8945b8a5ac) (cherry picked from commit 26456c99a7)	2 years ago
Rene Krenn	0e732ef469	MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd (cherry picked from commit a15d00894a)	2 years ago
Rene Krenn	e09b432049	MT#59216 restore appending wildcard behaviour ... with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d (cherry picked from commit 672a3110bc)	2 years ago
Kirill Solomko	84f6f22025	MT#59238 fix rewrite rules transaction control for PATCH,DELETE ... * /api/rewriterules PATCH, DELETE methods used the generic transaction, which conflicted with the xmlrpc reload command. * own_transaction_control was only set for PUT and now also extended to PATCH, DELETE to ensure that dialplan_sip_reload() is called properly after $guard->commit. Change-Id: I7313b4f6d1f6699bf38ae34749c5383a3943f61d (cherry picked from commit 80f8b1da0b)	2 years ago
Kirill Solomko	2341735b55	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs ... * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e (cherry picked from commit a4d54b10e4)	2 years ago
Rene Krenn	94caa43950	MT#58890 force cft_ringtimeout as number ... Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa (cherry picked from commit cc8fd8928d)	2 years ago
Rene Krenn	d1bc3017dc	MT#59025 fix peering groups name filter ... Change-Id: I329e644c937058069c5932abf8e897dce48a8c10 (cherry picked from commit 1e9f223276)	2 years ago
Rene Krenn	e4a0067cef	MT#58936 fix customerzonecosts resourcename ... Change-Id: I22b052bc6931e5426e1aa982396c446cb1c67883 (cherry picked from commit 2101e2246d)	2 years ago
Rene Krenn	92127019de	MT#58936 direction filter param for /api/customerzonecosts ... Change-Id: Ie831381576ffdb2a08375cf73bc66c1c5e6d2076 (cherry picked from commit 853bc9f535)	2 years ago
Rene Krenn	5f070d0fd8	MT#58762 adjust restpi tests to harmonized wildcard filters ... Change-Id: I68b2199a3487fedb388803012c950c3abca1a8b3 (cherry picked from commit aa2d07ef29)	2 years ago
Rene Krenn	5b62ba15f3	MT#58762 harmonize restapi wildcard filters ... - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b (cherry picked from commit 308a974059)	2 years ago
Rene Krenn	cf20a2f5bc	MT#56239 avoid ambersand symbol in apidoc descriptions ... Change-Id: Ic024d16c008648cb4d9cf14ae0e58d1ebe8febe9 (cherry picked from commit 71480acfa3)	2 years ago
Rene Krenn	b7482ee6d8	MT#56239 api/callrecordings support filtering multiple metakeys ... filtering an Entity-Attribute-Value model cannot be done as simple conjunctions, but requires either INTERSECT set operation, or joining the same table multiple times. Change-Id: I5ce1ae1ece9406b6610487654f09d768a233b122 (cherry picked from commit 8e82715eb8)	2 years ago
Rene Krenn	d8ac62283d	MT#56239 api general caller/callee wildcard search support ... various api rails will need to support ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcards=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wildcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: Ie6065b0cfa883f7963e1dc8259fffea9a1edfdfe (cherry picked from commit 9c3a549094)	2 years ago
Rene Krenn	fa3ee961be	MT#58346 caller/callee filters for conversations ... the conversation list now supports ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcard=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wilddcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: I792d2ea9c649c69c4b5cc98076097cb96467d4bc (cherry picked from commit ae612eb401)	2 years ago
Marco Capetta	2f99ceae39	MT#58596 Enable api soundgroups and soundhandles for subscriber ... The commit extends what done already in e15e40423 allowing the subscribers to get the soundgroups and soundhandles using API. This is necessary for some CSC features like the selection of the Custom Announcement to play after Call Forward. Change-Id: I40d57d1efdc107c64fe3efafd9e87d1403c4d124	2 years ago
Kirill Solomko	a7d7afc5c6	MT#58430 fix allowed_ngcp_types in API GET ... * allowed_ngcp_types check is now correct in the Controller:API::Root::GET * also fix allowed roles check Change-Id: I2446d7377d2a1ef152560bfb2799bb9debd0f34b (cherry picked from commit 706b472465)	2 years ago
Kirill Solomko	b7c22618c8	MT#57987 /api/rewriterules calculate priority on create ... * when a new rewrite rule is created and the priority attribute is not specified, only the first rewrite rule of the same rewrite rule set is set as 50, and the following are as: "MAX(priority) of the same rewrite rule set"+1 Change-Id: I1f1ae275e00918a34a625409987f21044b3b940f	2 years ago
Kirill Solomko	6953de937c	MT#33041 add reseller max subscribers support ... * Max subscribers can now be defined in the Reseller contract * Max subscribers is now shown in int Reseller's "Reseller Contract" Details (with an indictaion of how many subscribers are created out of the defined max subscribers, as well as when the limit is reached (similar to the Customer's Details page) * Add reseller subscribers count checks on the UI Create Subscriber page * Add reseller subscribers count checks in /api/contracts POST/PUT * Prevent max_subscribers definition for Peering contracts in /api/contracts POST/PUT Change-Id: I1561d4eb7da5b1a0a0c99acabd18d2a9cd98dec7	2 years ago
Rene Krenn	8fbd46e5fc	MT#57382 DELETE /api/faxes/id ... Change-Id: If578cd842d83e3471659164826d3e0305018cc29	2 years ago
Marco Capetta	967bc581fe	TT#179901 Discontinue iNew dedicated features and code (part 2) ... Remove party_call_control feature Change-Id: I6ea1c725a463ee62696de93a7ee52080515cc2b7	3 years ago
Rene Krenn	cde01e7d66	MT#53849 peer/reseller invoicing ... Change-Id: I0d869edb697779e7d02caaea70c237f0c87f4d50	3 years ago
Kirill Solomko	22a8e95c29	MT#57708 sound set/file use READ COMMITTED ... * as changes to sound sets and sound files cause internal triggers + SP to be invoked, the gap locking should be reduced to avoid possible deadlocks, hence READ COMMITTED transaction isolation level is used for all sound sets and sound files change operations. * fix a condition that caused an evaluation error when both old_parent_id and parent_id are undef. Change-Id: I7e69a0a0e5878c03b086977933315e532aaa2a29	3 years ago
Kirill Solomko	9d9c0d0669	MT#57580 add expose_to_customer support for NCOS ... * NCOS Levels and NCOS Sets now have expose_to_customer option (boolean). If enabled, the NCOS Level/Set can be seen and used by Customers in their and their subscribers' preferences * NCOS Levels and NCOS Sets with expose_to_customer = 0 (default) are not visible anymore to subscribers. * API GET /api/ncoslevels is now accessible by 'subscriberadmin' role and returns a list of NCOS Levels that belong to the same reseller and with expose_to_customer = 1 (fields are limited to id,name,description). * When NCOS Level is expose_to_customer is set from 1 to 0, all assigned ncos preferences for contracts and subscribers are that contain the NCOS Level are removed. Change-Id: Id7c444b4a0834939a128179ded6670705258519b	3 years ago
Kirill Solomko	19f5c68bce	MT#56693 fix /api/soundfiles without Content-Type ... * prevent an error if /api/soundfiles is called without the Content-Type header Change-Id: I1c0844c789839ad4dabedef216336b1387db074e	3 years ago
Kirill Solomko	391aa3fbc3	MT#57564 convert deprecated timezone names ... * timezone names are converted to their links, and if a link is found (means that the current name is deprecated), it's validated and stored as the link. Change-Id: I6348659178400a96eaadd70f79b792c4fa25d7d4	3 years ago
Marco Capetta	be7193e75b	MT#57469 Fix kamailio lcr reload on PATCH/PUT APIs ... When calling a PATCH or PUT API on a peering group or outbound rule the reload of the kamailio lcr module was triggered before the update of the database, thus the kamailio status was not updated. Change-Id: I59ed863c85219e62d6f5b5a2af80db8ef952844c	3 years ago
Kirill Solomko	89173442f3	MT#57223 improve sems audio cache invalidation ... * clear_audio_cache is now invoked also from: - when a sound file is added (to reflect use_parent/potential child sets) - when a parent is changed for a sound set (to reflect current and potential child sets) - when a sound set is removed (to reflect potential child sets) * clear_audio_cache() is reworked - clear_audio_cache() now calls virtual_child_sound_sets to fetch all potentially affected child sound sets and also clears audio cache for them. if the amount of fetched sound_sets is greater than 10000 then the the whole audio cache is invalidated * _clear_audio_cache_service() is reworked - supports/expects a list of sound sets and sends them as a string with ':' separator - if both sound handle and sound sets are provided it calls clearFiles (so that only the specific sound handle is cleared) - if only sound sets are provided it calls clearSets (so that all of the cached files beloning to the sets are removed) - if none of the above are provided it calls clearAll to invalidate the whole cache Change-Id: Ie85f208e27183e88665803b93bb16d7de8e3d7ac	3 years ago
Kirill Solomko	0370507310	MT#57155 /api/rewriterules add filter by direction,field ... * filter by direction and field (caller or callee) Change-Id: I0205ead6cf2a1d51532992f67a5add63cdeb51e0	3 years ago
Rene Krenn	5e2f599eb9	MT#57171 speedup DELETE /api/lnpnumbers/id ... Change-Id: I2b3f817b95e311b922e935453f659893004c5be4	3 years ago
Kirill Solomko	407d6f3f3b	MT#56693 /api/soundets fix DELETE subscriberadmin access ... * subscriberadmin can only delete items that belong to the same contract_id, otherwise 'read-only' forbidden error is returned Change-Id: I3ef2716039626bc1b208a5c7af06cf87f69cad73	3 years ago
Kirill Solomko	c58a8b9b1f	MT#57100 avoid where ambiguity for query_types search_eq,search_like ... * uses prefix 'me.' for query types search_eq and search_like in the where condition to avoid ambiguity if the search_rs has joins that with the same column names Change-Id: I90fef80970aa4415480b00bbed2fb9fbee1f1ccc	3 years ago
Kirill Solomko	c5b288a9da	MT#57085 fix /api/peeringroups form operations ... * API now has own GroupAPI form with the correct fields for API * db/form field name conversion is moved to the newly added resource_from_item() and process_form_resource() functions * simplify code for GET/POST/PUT/PATCH operations Change-Id: I99b76801a2894c8a4821513186796627db728189	3 years ago
Kirill Solomko	6a922c5cfb	MT#56693 parent_name, allow empty sound files, sems audio cache ... * /api/soundsets new parent_name field * /api/soundfiles now allow POST to be done without the upload, for cases when an empty record needs to be added to define "use_parent" behaviour * improve sems audio cache clear on sound files change, now sems instances that are not available (not running/request timeout) are skipped instead of raising an error Change-Id: I83af2ee2fd3672ab35cf330464ace68416ab52be	3 years ago
Rene Krenn	a9b1ba896b	MT#56917 fix rwr 'description' filter ... a 500 error results when specifying the RewriteRule "description" filter because of ambigous field names. Change-Id: I9c0a9f6c84ec62fca4c77ce904fb07c4dadef13b	3 years ago
Kirill Solomko	2a0b8dcc1e	MT#56432 add time set support to ncos levels ... * add NCOS Levels UI Time Set support * add NCOS Levels API Time Set support Change-Id: I03201c09462f0f0ceff39da271bcf8ca1fc797b8	3 years ago
Marco Capetta	36ae8cedb9	MT#55931 Add new speeddial, forward, transfer device buttons ... Change-Id: I0b9c1f3ddb0d4cd3fe28995b170e9104c668a553	3 years ago
Kirill Solomko	e90ba9d517	MT#56208 allow subscriber role access to cf sets ... * subscriber role can now GET call forward sets that does not belong to the user but used in call forwards assigned to the user * the user can only GET the sets but cannot update/delete them (403 Forbidden is raised in case of attempt) Change-Id: I391b802d962f4bbeae991e3046ac3f132a19edb6	3 years ago
Kirill Solomko	f942b07a1e	MT#32992 fix /api/resellerbrandnglogos ... * add described query_params 'subscriber_id', 'reseller_id' so they are avaialable on the doc * remove search by param from Role::ResellerBrandingLogos::_item_rs() * fix Role::ResellerBrandingLogos::_item_rs() queries * Controller::API::ResellerBrandingLogos* - now always returns the binary data containing the logo and with the Content-Type header - change NOT_FOUND message to indicate that the ResellerBrandingLogo is either not found or does not have image/image_type * do not log response queries * fix allowed_role to be: admin, reseller, subsscriberadmin Change-Id: Iaadb47fb2d72886a8d9244a523d5914500a4dd20	3 years ago
Rene Krenn	e9367e0cfe	MT#55972 support wildcard search for customer external_id ... Change-Id: I8287f7650f68dab2e806259ec00ffad2ba45fe1a	3 years ago
Rene Krenn	67f6063341	MT#55551 add ccare roles to /api/callforwards ... Change-Id: I414e10fca61bc535471a0b2525b7e684ea9d23e5	3 years ago
Kirill Solomko	a86e868a6f	MT#55538 /api/soundsets allow filtering by customer_id=null ... * when customer_id query param is specified as customer_id=null or customer_id=NULL it now correctly fetches soundsets that do not have customer_id assigned to them Change-Id: I8de3d9615c133c2abd3eb2b5f4fea8de5b652417	3 years ago
Rene Krenn	f75fdcd943	MT#33062 prevent error 500 when deleting registrations ... Change-Id: I7c9731260b973730702c7380881c71bfdc84fa21	3 years ago