ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Rene Krenn	72d9c10650	TT#13973 fix http method override the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	9 years ago
Gerhard Jungwirth	7c188a6822	TT#2395 UPN rewrite cli via API Change-Id: I18856fc0608632f3fda888fc58b33a41f2804600	10 years ago

Author

SHA1

Message

Date

Rene Krenn

72d9c10650

TT#13973 fix http method override

the factory Catalyst::ActionRole::HTTPMethods action role
is set for any action, and in race with our own
NGCP::Panel::Role::HTTPMethods. the testcase could have
been misleading ever since, as it uses DELETE /api/customers,
which was present when implemting the method override initially,
but dropped on the road to 4.5.

the issue is resolved by overriding
Catalyst::Controller::gather_default_action_roles.
until the class hierachy refactoring is completed, only
consistent way is to add the override to each api controller.
the action_roles config attribute can therefore be
removed.

using Plack::Middleware::MethodOverride as an alternative from
upstream has the drawback to work only with POST. but a required
usecase is to also support translation DELETE requests to PATCH.

Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c

Gerhard Jungwirth

7c188a6822

TT#2395 UPN rewrite cli via API

Change-Id: I18856fc0608632f3fda888fc58b33a41f2804600

2 Commits (2a34ce3d6c9598b46256bb23912cfecd906ffc4b)