844 Commits (2a0b8dcc1e7155720f208e8938fbfbe926e057fd)

Author	SHA1	Message	Date
Kirill Solomko	2a0b8dcc1e	MT#56432 add time set support to ncos levels ... * add NCOS Levels UI Time Set support * add NCOS Levels API Time Set support Change-Id: I03201c09462f0f0ceff39da271bcf8ca1fc797b8	3 years ago
Kirill Solomko	dee6b60c6e	MT#56208 additional inherited cfs improvements for subscribers ... * API: GET collection returns only distinct cf sets * UI: inherited cf sets are now shown in the advanced view and having suffix '(inherited)' to distinguish them from the own ones as they are not available in the "Manage Sets" edit dialog. Change-Id: Ifd8c1a46fcb4c2c66f8f63268a1e91b80792c216	3 years ago
Kirill Solomko	36974efa03	MT#55931 add /api/pbxdevices target_number support ... * target_number is now supported and it must contain only [0-9#*]+ Change-Id: I9b1548c2dd0f644c1f21668471599c34347f1109	3 years ago
Marco Capetta	36ae8cedb9	MT#55931 Add new speeddial, forward, transfer device buttons ... Change-Id: I0b9c1f3ddb0d4cd3fe28995b170e9104c668a553	3 years ago
Kirill Solomko	e90ba9d517	MT#56208 allow subscriber role access to cf sets ... * subscriber role can now GET call forward sets that does not belong to the user but used in call forwards assigned to the user * the user can only GET the sets but cannot update/delete them (403 Forbidden is raised in case of attempt) Change-Id: I391b802d962f4bbeae991e3046ac3f132a19edb6	3 years ago
Kirill Solomko	766cab0f9c	MT#56286 fix subscriberprofile api attribute field ... * update_item(): check that $resource->{attributes} contains data and an array before processing it * api-journals.t: fix subscriberprofile 'attributes' field Change-Id: I28a2e22859cd998f99277e88037dff23981038f3	3 years ago
Kirill Solomko	45d9fb34b5	MT#56286 fix subscriber profiles form and api update ... * subscriber profile form is fixed so that the attributes list is now correctly shown in the old UI * /api/subscriberprofiles update, attribute values are now correctly transformed for the validation and processing Change-Id: I4418250d4a0e702d75524ab5999eb47429be5a04	3 years ago
Kirill Solomko	6c179dd5c4	MT#56234 get_usr_preference changes ... * as_admin param is no longer needed as get_usr_preference() fetches actually set preference for a susbcriber and used only by the code (not exposed directly to 'subscriber', 'subscriberadmin' roles * with the aforedescribed, get_usr_preference() no longer filters by expose_to_customer, expose_to_subscriber for 'subscriber' and 'subscriberadmin' roles * refactor get_usr_preferences() to be simple and in line with the other get_*_preferences() as it's mainly responsible for fetching the preference as requested by the internal code Change-Id: Ia52d8f4ebfd854901bf446e29fb475dea1fba866	3 years ago
Kirill Solomko	6d487452bb	MT#56234 susbcriber preferences related changes ... * fix customer_view role name typo so that it's correctly limited to for 'subscriberadmin' role * revert behaviour of get_usr_preference_rs() to return undef if no preference is found (no access) * get_usr_preference_rs() now also fetches all internal preferences for internal work for 'subscriber' and 'subscriberadmin' roles but they remain invisible for them and not accesible for direct changes (only when requested by internal logic) * new get_usr_preference_rs() 'as_admin' parameter that enables for internal requests to return the preference value for 'subscriberadmin' and 'subscriber' roles, currently used to show 'lock' status and 'display_name', which are otherwise inaccessible as those preferences do not have expose_to_customer, expose_to_subscriber flags * fix api_prference_defs() correct filtering of preferences for 'subscriber' and 'subscriberadmin' roles Change-Id: I1a0e51ace1c649f9061deaccb7d6e9f8459f0ed8	3 years ago
Kirill Solomko	34eeac7fc2	MT#56068 fix /api/resellerbrandings reseller_id field ... * reseller_id is now only mandatory for the 'admin' role Change-Id: Idd090332ed2877b2a2c06c9cce741757cc718737	3 years ago
Kirill Solomko	e2afe2ea06	MT#56087 fix /api/callforwards sets auto creation ... * with PUT/PATCH data source and bnumber quick sets are correctly automatically created now Change-Id: Ia6f3be8958081f1611a1473b35c73826a9ed8784	3 years ago
Kirill Solomko	4f8603d15f	MT#56068 /api/resellerbrandings/:id change ... * :id is now the brainding's id instead of reseller_id. That was rather a bug and now fixed and consistent with the rest of the endpoints. Change-Id: I794e577499050a95ed68c21af3f963f9f8e9c274	3 years ago
Kirill Solomko	f942b07a1e	MT#32992 fix /api/resellerbrandnglogos ... * add described query_params 'subscriber_id', 'reseller_id' so they are avaialable on the doc * remove search by param from Role::ResellerBrandingLogos::_item_rs() * fix Role::ResellerBrandingLogos::_item_rs() queries * Controller::API::ResellerBrandingLogos* - now always returns the binary data containing the logo and with the Content-Type header - change NOT_FOUND message to indicate that the ResellerBrandingLogo is either not found or does not have image/image_type * do not log response queries * fix allowed_role to be: admin, reseller, subsscriberadmin Change-Id: Iaadb47fb2d72886a8d9244a523d5914500a4dd20	3 years ago
Kirill Solomko	2904de66b9	MT#56028 /api/cftimesets subscriberadmin role change ... * subscriberadmin is now able to fetch cftimesets of other subsribers that belong to the customer Change-Id: If7931e154ab825a6ebca25bec49b8ea28d87bafd	3 years ago
Kirill Solomko	ae32c62fd1	MT#56027 /api/cfdestinationsets subscriberadmin role change ... * subscriberadmin is now able to fetch cfdestinationsets of other subsribers that belong to the customer Change-Id: I212f0e31a8e77caa6f681f227771e0b11efb5f62	3 years ago
Kirill Solomko	018dc08be6	MT#56026 /api/cfsourcesets subscriberadmin role change ... * subscriberadmin is now able to fetch cfsourcesets of other subsribers that belong to the customer Change-Id: I95217587430c52cd7078e1604ffec549ae2dd6b5	3 years ago
Kirill Solomko	4c1a9d9c11	MT#56029 /api/cfbnumbersets subscriberadmin role change ... * subscriberadmin is now able to fetch cfbnumbersets of other subsribers that belong to the customer Change-Id: Ib92c161f320257ba2d6614e10d9eaf03247e7014	3 years ago
Kirill Solomko	64b71cdcd1	MT#32999 /api/cfmappings subscriberadmin scope of view change ... * subscriberadmin can now see all other customer's subscribers call forwards as well as per subscriber_id Change-Id: I4bdaf3390667fc7208fa6dbde9292b8ba911667f	3 years ago
Kirill Solomko	0c4deaaad0	MT#55871 /api/subscribers optimise GET alias_numbers ... * "alias_numbers" array when the resource is prepared is created directly from the resultset, avoiding 'foreach' loops and conditions. This improves performance on ~8000 voip_numbers from ~35 seconds to ~3 seconds. * is_devid is now always present in the "alias_numbers" object, and it's =0 if there is no related entry in provisioning.voip_dbaliases Change-Id: Ia05b26208f3fec3a9b2203aafe9b4c09b98ca44d	3 years ago
Kirill Solomko	507d088586	MT#55864 /api/subscribers correctly process administrative flag ... * administrative flag is now correctl set to false when requested by the client Change-Id: I81a1951f90ce9885bff806d39e11098475d93ac1	3 years ago
Kirill Solomko	0555f32585	TT#65101 expand now fills the same key only once ... * the same key is now expanded only once to use the same data ref otherwise expand like contract_id.contact_id,contract_id.billing_profile_id makes it so that 2nd contract_id would overwrite the already existing (expanded) contract_id Change-Id: I6cab67c2f549e9165dbf2cfd2f4b84daef503dd8	3 years ago
Kirill Solomko	5a18d5fee8	TT#65101 improve expand=all, /api/domains care roles support ... * expand=all now expands by the all resource keys instead of the current form fields, that is to reflect keys that are created manually in the response such as reseller_id or domain_id * ccare roles now correctly support /api/domains Change-Id: I9951bfd97b76186def4dc799c72da44425faea4a	3 years ago
Kirill Solomko	486b0a10d5	TT#186503 fix /api/billingprofiles for ccare roles ... * ccareadmin and ccare roles are now able to correctly fetch the list of billing profiles as well as request one by :id Change-Id: Ie5f9203b1aa9de9f7ed870caa2ea06ba262c9bfd	3 years ago
Kirill Solomko	7e37f4b81c	TT#186501 fix /api/capabilities for ccare roles ... * ccareadmin and ccare roles are now able to correctly fetch the capabilities data Change-Id: I4f4355dfe594a9342fd35c0c01984ef132d7d1a6	3 years ago
Kirill Solomko	84e698e7ac	TT#176050 adjust subfield expands ... Change-Id: I9826d254cec6f03e7c7bad7122450f4a22125e18	3 years ago
Kirill Solomko	938f6ba05c	TT#176050 add expand support on array of ids ... * it is possible to expand arrays of ids now * add expand support for pbx_group_ids * add expand support for pxb_groupmember_ids * remove _password and _webpassword internally prepared fields from expands by subscriber_id, pbx_group_ids, pbx_groupmember_ids Change-Id: I7651aae4c58d98943e82d1eda6b24d260ff2480a	3 years ago
Kirill Solomko	f311177236	TT#182101 Fix check_allowed_ngcp_types detection ... * use any instead of grep for checking the allowed_ngcp_types array Change-Id: I7382a2a61764a4520cd07d2db67ffa3a5112b378	3 years ago
Kirill Solomko	09b589738d	TT#182101 Phonebook feature is hidden for CE ... * templates now rely on c.config.general.ngcp_type and hide the Phonebook feature everywhere if ngcp_type is CE * introduce "allowed_ngcp_types" config for Controller::API::* that is an array, and when specified, only the ngcp_type roles are allowed, otherwise if not specified all ngcp types allowed (default) * Controller::API::Root: - filter controllers from the documentation rendedring that have allowed_ngcp_type config specified and do not match the current ngcp type * Role::API Role::Entities* - new method check_allowed_ngcp_types() - check_allowed_ngcp_types() is now called in Entities and EntitiesItem auto() and denies to 404 Path not found if the ngcp type does not match * "Phonebook" UI is now hidden for CE * /api/phonebookentries is now hidden for CE Change-Id: I41d4b2f87121f281472be3775b862333923fe37f	3 years ago
Kirill Solomko	22eb317b70	TT#180551 /api/topuplogs add filter by customer_id ... * customer_id filter is now possible, which behaves the same as the existing contract_id. This is to add consistency as filtering by customer_id is available in other endpoints Change-Id: I1577d06133f9629c363940a4e8d2fb8012336e21	3 years ago
Kirill Solomko	d3dc152cdc	TT#175000 remove rtcengine logic ... * rtcengine related logic and apps is now removed * remove /api/rtcapps endpoint * remove /api/rtcnetworks endpoint * remove rtcengine relations from resellers such as enable_rtc flags * remove rtcengine related API tests * remove rtcengine and comx related libraries * remove csc webphone ui app * remove webrtc related selenium tests * remove rtcengine flags from /api/capabilities Change-Id: I83a4b0457fac2e0df23d267f8dbc82841dfb3001	4 years ago
Kirill Solomko	996cda6819	TT#173650 enhance /api/customerfraidpreferences ... * the endpoint now contains additional fields starting with prefix current_* that represent the current aggregated value that is used for the preferences and also current_fraud_interval_source current_fraud_daily_source that represent the used source for the current_ values (billing_profie or customer) customer - if the fraud limit is set on the customer level and > 0 billing_profile - if fraud limit is not set on the customer level Change-Id: I074285e3464420a14f65695c40c8b8008a241a8d	4 years ago
Kirill Solomko	68af361060	TT#173700 /api/topuplogs expand related fixups ... * Role::API::Contracts add item_by_id() that calls contract_by_id() * Utils::ProfilePackages::catchup_contract_balances return if $contract object is undef * Form::Topup::Log::contract_id expands into Role::API::Customers instead of Role::API::Contracts Change-Id: Id4fc67b8ea1e91f350d0172aafc2b722f34e61f3	4 years ago
Kirill Solomko	e011960739	Revert "TT#171850 fix unintentional primary number removal" ... This reverts commit 6bdfca91129309561e72eed902a8a4b66604a7bd. Change-Id: Ie7269ac9ce0302928b234302880bfa9896e8cdf0	4 years ago
Kirill Solomko	6bdfca9112	TT#171850 fix unintentional primary number removal ... * the current condition for primary number removal for PUT/PATCH is if the primary number exists and specified in the data as primary_number => undef. The condition failed as the 'primary_number' key was explicitly created regardless of the original user data input, resulting in a false primary_number => undef. Change-Id: I17651046627f5c48696c3f1d17da5aa49452fe9a	4 years ago
Oleksandr Duts	afa9289b66	TT#167900 /api/subscribers improve number duplicate checks ... * primary and alias numbers are now validated that they do not belong to another subscriber * aliases are now validated that they are not already set as the primary number * reduce amount of related sql queries Change-Id: I4397bbdc4bc9001b7feeef22cb8f85ee0b6ce8ff	4 years ago
Oleksandr Duts	4e7e55189c	TT#166900 API phonebookentries - fix form creation for empty params ... * If query params is passed then the role checking is skipped. Change-Id: I05f1b674d4b9a84f2a20c17f76c12258e166027a	4 years ago
Oleksandr Duts	3b9f19b6c8	TT#141101 UI/API fix custom_announcement upload ... * Ability to upload sound set file for custom_announcement. Change-Id: I51dbf3fd9b9820adfa8ebe186c63cf39383a76ee	4 years ago
Oleksandr Duts	f0a5c38874	TT#158252 API/UI cfmappings improve performance ... * Optimize cfmappings DBI - better performance for subscriber preferences API/UI. Change-Id: I6d73ecbe657ee84a43f6cc8f3b048aa011370603	4 years ago
Rene Krenn	b05628db60	TT#81004 support callforwards in provisioning templates ... provisioning templates can now include configuration of callforward mappings, eg.: cf_mappings: cfu: [] cfb: - enabled: 1 destinationset: name: "test" destinations: - destination: "123" cft: [] cfna: [] cfs: [] cfr: [] cfo: [] Change-Id: I8073322630d63e5ef23e7a9f8c299a6010cb4866	4 years ago
Oleksandr Duts	a4d3585430	TT#160300 API: header[rules,ruleactions,ruleconditions] - subscriber_id filter ... Add subscriber_id(billing) filter parameter for GET endpoints: - headerrules - headerruleactions - headerruleconditions Change-Id: Ief568ddbdc3641be5e57411191f5716ab175acb9	4 years ago
Oleksandr Duts	ace1698a3d	TT#154550 API topuplogs - expand fields ... * The next fields are expanded: package_after_id, package_before_id, profile_after_id, profile_before_id, contract_id, contract_balance_after_id, contract_balance_before_id, subscriber_idvoucher_id. Change-Id: I4d5f12fb88eaaeb8daf45e673c14e92c1512e239	4 years ago
Kirill Solomko	9dd50e8427	TT#158003 make subscriber location mappings 'location' optional ... * 'location' field is now optional, if not filled it it will always default to an empty string instead of null. This is required for the new mode 'forward' that has no use for this field. If the field is empty in any other mode like 'add' or 'replace', the entry will be skiped by the logic. Change-Id: Ia964c3bb272c9772c51b836ac2418ee4cd7b7f42	4 years ago
Oleksandr Duts	03271187c7	TT#157400 API/UI admins fix authorization for "system" role ... * Users with "system" role can change all items accross the system including the password changing for other users. * Login "system" has persistant "system" role. * "system" login name is restricted for the user input. Change-Id: Ibaecba35a86f71fa8895ce9d9feab8e768b65d14	4 years ago
Oleksandr Duts	938eef9140	TT#119465 API callrecordings - searchable caller/callee ... * Fetch recording_metakeys caller/callee for the certain record id(call). * Add caller/callee fields to the resource and form. * Frefetching recording_metakeys for the call recording. Change-Id: I767ea32e19edfd7cbbc74956200343f680fdb2b4	4 years ago
Rene Krenn	d82d93da9d	TT#71950 fix leftover with 35b568dde ... Change-Id: If71d07972f56cb1b7cb0bbafdcfd3b68cce6e254	4 years ago
Michael Prokop	35b568dde4	TT#71950 Fix typos ... * successfuly -> successfully * diplay -> display * recieve -> receive * mathes -> matches * cahnged -> changed * Unprocessible -> Unprocessable * The the -> The * repesent -> represents Change-Id: I123f5b1ec8c11fe01db4e5768bd640c4920d3366	4 years ago
Rene Krenn	599dd0613b	TT#151751 fix plaintext sippassword no longer returned ... this fix addresses regression reported by dominik: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) (cherry picked from commit 5e9066c4fb) Change-Id: I88c9ec40843f1e9a6983952b96c0b0e70fbb1bb1	4 years ago
Oleksandr Duts	581aa090e7	TT#153501 API: GET phonebookentries - fix subscriber access(422) to own phonebooks ... * Roles subscriber and subscriberadmin use the user voip subscriber id as a phonebook context. Change-Id: I5f119837b40169aa6d920774b4fc96551875dfc0	4 years ago
Kirill Solomko	f4154b1dbc	TT#154500 tighten /api/admins roles ... * An attempt to change own role, login, flags (except for can_reset_password) now returns 403 Forbidden, User cannot modify own permissions * POST checks if the admin has necessarry permissions to create another admin * PUT/PATCH changing own role is now forbidden * PUT/PATCH changing other's admin role now checks permissions * DELETE checks role permissions Change-Id: I990609985ae9cab6213cf47f5f5c8afba2efdda3	4 years ago
Kirill Solomko	81ebdb8dcf	Revert "TT#151751 refactor persisting subscriber webpassword" ... This reverts commit 5e9066c4fb. This implementation breaks: * $resource{_password}/{_webpassword} cannot be set before the form validation as they are effectively removed by it, causing /api/susbcribers returning no passwords at all for 'subscriber' roles * Having them after the patch makes no sense either as next resource_from_item call will effectively remove them again (in PATCH) Change-Id: I0e8389e8ab34ad72f1b87a684daba77f1030f8ba	4 years ago