ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Kirill Solomko	f72f8291a7	MT#60393 /api/timesets fix reseller_id validation * fix reselelr_id for 'reseller' role and it's now automatically set to the user's reseller_id instead of throwing a validation error Change-Id: Ic732366aea6c4106c37961e599cd1e40fdaba5b2	2 years ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling * Role/Entities: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	2 years ago
Irina Peshinskaya	80b0cf0a35	TT#47534 Remove unnecessary debug from timesets api Change-Id: Ica3afc7a9eddf1561ffb28051ea58e45fbc6ad25	7 years ago
Irina Peshinskaya	ec178cd8e4	TT#47534 Implement api timesets upload/download Change-Id: I9d83b19e9d5efee8cd360392e304d14e997a4712	7 years ago
Irina Peshinskaya	92ac694c6c	TT#49689 Rename method _timesets to _timeset Change-Id: Id2a1e3bd69896c815ccd0ae4373e044326aa40c2	7 years ago
Irina Peshinskaya	e462e95957	TT#41628 Add web ui for the TimeSets Add test script for API Fix DateTime create/update issue in TimeSets API (get2put case) (add and edit functionlity used raw/inflated data respecively) Add datetimepicker field Change-Id: If724b7350658c306dbbecbc04309d1d1c0b4a3e2	8 years ago
Gerhard Jungwirth	25efe6622e	TT#41627 new /api/timesets in iCal format Change-Id: Ie94a799ac1491c005835ac21f89e30bb6266c4a7	8 years ago

7 Commits (0d3aac99a7b72778e3ed60bd139ab5ab15b8eca7)