4021 Commits (099ff703fbdfea31fecacf85eccaf284bba8ecde)

Author	SHA1	Message	Date
Rene Krenn	3190db4baf	MT#65579 do not set primary_number undef in shared resource_from_item ... Keep missing primary numbers absent from the shared helper so provisioning template update paths do not treat them as an explicit clear. Also fix perlcritic mixed boolean operators. NGCP-Flow: mr13.5 Change-Id: Ib5ef634e7a9e65678ec872d71d65aea8301fc364 (cherry picked from commit e7c0f0bd65)	2 weeks ago
Rene Krenn	c59fc02a3e	MT#65579 use JSON::Types::bool for is_devid in resource_from_item ... Keep journal-safe JSON booleans after moving resource_from_item into Utils::Subscriber, matching the previous Role/API behaviour. Change-Id: I357a4f5f4a25f8a7295341dcbff80a14d3cb6f51 (cherry picked from commit 9767845c0a) (cherry picked from commit 7d745c4b79)	2 weeks ago
Rene Krenn	43c835de78	MT#65579 fix is_devid boolean conversion in resource_from_item ... Avoid the ambiguous bareword "bool" call that 500s subscriber API responses when alias is_devid is a plain DB integer. Change-Id: I8829e064ee658ae35676aa8414c58c0e16ffd5fa (cherry picked from commit e485aff6b4) (cherry picked from commit 8a97c8c270)	2 weeks ago
Rene Krenn	f1d8ae662d	MT#65579 support updating existing subscribers via prov templates ... Reuse shared resource_from_item/update_subscriber helpers so templates can match by identifier, fill missing fields from the DB item, and update instead of only creating. Change-Id: I5fa9be12914677c3b6ef5c4c0617cb75447b45c9 (cherry picked from commit a0bfa9377c) (cherry picked from commit 9969eed3e9)	2 weeks ago
Rene Krenn	9dc03c9d5d	MT#65218 prov templates: improve contract and subscriber lookup ... - when using "identifer" to lookup a contract, the prepare_billing_profile() you produce an error. - when using "identifier" to lookup a subscriber, the prepare_resource() could cause an error. - eliminate a "Old package separator deprecated" warning from JE::Destroyer. - the "now" variable was not properly exposed in the JS scripting language context Change-Id: I3253f92f345c1532f489fc87b3c91370e34a3066 (cherry picked from commit baab52c682) (cherry picked from commit 84c7c2be4e)	2 weeks ago
Rene Krenn	f1dfa01df4	MT#65464 Fix LDAP OTP registration crash on /api/otpsecret ... LDAP login stored a raw DB::admins row as $c->user, so API response logging failed when fetching the OTP QR after an invalid OTP on login_jwt. Wrap the admin in RoleFromRealm, pass the admin auth realm to set_authenticated, logout on OTP failure, and make Message logging tolerate raw user rows or role lookup failures. Change-Id: I29fda2324eadc7fb1f25f06ae6418ab594b69fa0 (cherry picked from commit 70d5c894a6) (cherry picked from commit 8d8c40db0e)	4 weeks ago
Rene Krenn	f6642e6012	MT#65464 fix LDAP login 500 when user lookup fails ... get_user_dn called ->dn on an undefined search result when LDAP lookup failed, causing login_jwt to crash instead of returning 403. Return early when no entry is found and log a clear message when the LDAP URI is missing or the connection fails. Change-Id: I5f00df840d304e4da2b35750c9c1f2e6972f1edb (cherry picked from commit 3e1d3c09a5) (cherry picked from commit 6d8281f0f5)	4 weeks ago
Kirill Solomko	38dfa2774c	MT#65092 fix /api/voicemails $q variable typo ... Change-Id: I7e662960b873124762dcc3711636fc9a243fe0fa (cherry picked from commit 44cab5c602) (cherry picked from commit 0d888a3aa2)	1 month ago
Kirill Solomko	b94890a3e9	MT#65092 address query param string pattern match in certain endpoints ... * new function Generic::Utils::parse_query_string($str) that performs the following: - escapes unescaped '%' and '_' occurrences when needed (as they are reserved internally for the "like" operation - converts all unescaped '*' and '?' chars to their "sql like op" '%' and '_' counterparts. * change endpoints that used escape_search_string_pattern() to use parse_query_string() instead, to avoid: a) overescaping b) automatic string wrapping with '*' that prevents strict match all sql builder queries that use $q after parse_query_string() use returned $op ('like', '=') as the operator, to easily set strict or like match. Change-Id: I961b5d032036f13a7460d91f8c197538ffba1997 (cherry picked from commit 8089861097) (cherry picked from commit 540fd925ee)	2 months ago
Kirill Solomko	9f27df0992	MT#65368 fix UI /logout link ... * when /logout is used on the old UI, it no longer produces ERROR: Couldn't render template "logout/logout_index.tt" Change-Id: I94f29c8a400da509ca26ddf2f410ddc76edec55f (cherry picked from commit f21064a2d4) (cherry picked from commit 3aae763172)	2 months ago
Kirill Solomko	a0974c69bc	MT#65048 check subscriber profile preferences on update ... * when subcsriber preferences are modified, keys are checked against a subscriber profile and if any of them is not accessible (disabled in the assigned profile) a 422 error is now raised. That is mostly relevant for PATCH "op":"add" that returned 204 OK before regardless. This change only affects access to /api/subscriberpreferences by the 'subscriber' and the 'subscriberadmin' roles * Controller::API::SubscriberPreferencesItem: remove unintended "last" from catch {}. * Utils::Preferences: remove 2 debug lines. Change-Id: Ie20e5b8d4420c814bc786c34ddd952ee13d355ae (cherry picked from commit a7f13331e8) (cherry picked from commit 396034c43b)	2 months ago
Kirill Solomko	d1ef649bb0	MT#65243 Plugin::NGCP::Redis handle 'active-replica' state ... * Catalyst::Plugin::NGCP::Redis::_wait_for_master_role() only expected the 'master' value to be considered as OK, whereas with Redis/KeyDB the value can be also 'active-replica'. Therefore, consider both 'master' and 'active-replica' values as OK. Change-Id: I16a0657a3a78a2f2b3c892c21ce0d9d6ebec0a0c (cherry picked from commit 5d7e137ec9) (cherry picked from commit 2c1c0642ed)	2 months ago
Kirill Solomko	64772bd64e	MT#64972 /api/customers email_template auto assign change ... * if an email template id is explicitly provided as "null", it will be assigned as "null". * remove email templates auto creation (copy from raw) for resellers if they do not have the specific one assigned to them. that proved to work contraversal as if a customer doesn't have an email template assigned to the reseller, and does not want to change their business logic (by explicitly providing "null") during POST /api/customers for those templates, the auto creation for reseller prevents it and causes complications, as well as it's not the intended role for /api/customers to automatically affect reseller configuration in such a way. Change-Id: Ie8cf0bffdd397279260a9601367f4457634ed5c8 (cherry picked from commit e956227ab0) (cherry picked from commit 25d1fc6e72)	4 months ago
Rene Krenn	476abe0fee	MT#64788 mitigate CVE-2024-28344 ... check the target url host when redirecting after pressing a "back" form button. Change-Id: I03b424ec71f3ed985faf42087d1bf1dc6f2e4ff6 (cherry picked from commit a040dc4b46) (cherry picked from commit af04c4b825)	4 months ago
Rene Krenn	4b8269ea37	MT#62342 encode XMLRPC request body, decode XMLRPC response body ... prevent api 500 errors ie. from LibXML parsing because of invalid chars. Change-Id: I2630ba285e1da7bcbfe5558bad1b7c30fa86bebe (cherry picked from commit 14caac386c) (cherry picked from commit 936a944a54)	4 months ago
Kirill Solomko	fb83ee2734	MT#64891 enhance Redis connection handling ... * Catalyst::Plugin::NGCP::Redis changes - new function _connect_and_cache() that now contains the migrated connect & cache code returns the connection reference - new function _get_replication_role() that sends "INFO replication" command to the server and returns the role string back - new function _wait_for_master_role() that tries to wait 5 seconds for the server to return the 'master' role, with 1 second attempt intervals - rework redis_get_connection to obtain the connection inside try/catch and use _wait_for_master_role() after reconnect, as well as using it for the 'heartbeat' part to test dead connections instead of PING (so 1 command is sent in the end instead of 2). * With the redis_get_connection rework not only does it perform an automatic reconnect attempt if it detects a dead connection but it also waits until the server is 'master', which might happen during the db node switchovers, so API requests that happen during the switchover do not end up with errors "READ ONLY ROLE", and unless there is something persistently wrong on the server side, the reconnections/swithovers should be transparent now for the clients, with only probabaly 1-2 second delays on select API requests while the server is becoming the new 'master'. Change-Id: I41bf1f55a07b56e4fceef243f09f316694d62a39 (cherry picked from commit e5d7232b63) (cherry picked from commit 3a07710ad5)	4 months ago
Marco Capetta	5760e35b34	MT#64627 Call sip_dispatcher_reload when peer transport is updated ... In case of update of the transport protocol used by the peer, the kamailio dispatcher module has to be reloaded because the probing. if enabled, has to be sent using the new protocol. Change-Id: Iab5fe2c63547068c3aca0e46e8862b025475d8f0 (cherry picked from commit 079ae19306) (cherry picked from commit fe2523a061)	4 months ago
Kirill Solomko	659b322655	MT#62339 RedisLocationResultSet fix $filter assignment typo ... * fix $filter =// typo, should have been $filter =. Change-Id: I33e742cefc530406b736c72f3c9e325be9b84106 (cherry picked from commit 8b288081f8) (cherry picked from commit 8dfc4b775b)	5 months ago
Kirill Solomko	2acba0c1f7	MT#62339 /api/subscriberregistrations add total_count support ... * Panel::Utils::RedisLocationResultSet: - add total_count() that returns total count of all entries without pagination - add total count aggregation during _find(), _row_from_mapkey(), _scan() that aggregates total entries that can be shown without pagination * SubscriberRegistrations: - return correct total_count of all possible entries that can be shown (without pagination) - fix a 500 error when 'subscriber_id' contains a non-existing subscriber Change-Id: I914356a809a005c21bb662498ca78dd35affc0ee (cherry picked from commit d1280015c4) (cherry picked from commit c54bd2c753)	5 months ago
Rene Krenn	14ccb0ce30	MT#64761 prov templates: support contract-only mode ... provisioning templates basically work on subscriber level. this change introduces support for processing files with contract data only. Change-Id: I2f75aaf01e70b1348549c957ab68faf0d786bca9 (cherry picked from commit 8481c5adb7) (cherry picked from commit ca9d2b7149)	5 months ago
Rene Krenn	02be97f525	MT#64594 prov templates: fraud preferences support ... this change introduces support to set contract fraud preferences via provisioning template, ie: fraud_preferences: fraud_interval_limit: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_limit : 10000; }" fraud_interval_lock: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_lock : 2; }" fraud_interval_notify: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_notify : 'jdoe@sipwise.com'; }" fraud_daily_limit: 500 fraud_daily_lock: 2 fraud_daily_notify: "jdoe@sipwise.com" Change-Id: Id7e67fd71e0b1d291ee5e2ea9e2ea9b6bae64781 (cherry picked from commit 47b5cc7b7b) (cherry picked from commit cef21955fd)	5 months ago
Rene Krenn	383397884a	MT#64584 prov templates: contract_balance support ... this change introduces support to set balances via provisioning template, ie: contract_balance: cash_balance_code: function ( return 123; } free_time_balance: 456 Change-Id: I85d444b26c8f4d50ace39518f7c33c292b4afa0b (cherry picked from commit 03fec29b38) (cherry picked from commit c7e07c35b2)	5 months ago
Rene Krenn	6f680ed09a	MT#64142 do not translate CF dropdown items ... names of CF destinationsets, sourcesets etc. are provided by the user and can therefore contain patterns that are then unintentionally interpreted by the perl Maketext Module, causing 500 errors as a consequence. translations are better disabled for the dropdown option items. Change-Id: I20fa5c5ad79f78f8d2f682ea54984e92997ec34c (cherry picked from commit 10df50468b) (cherry picked from commit ec2f3c3fb7)	5 months ago
Rene Krenn	c62a3e4ddc	MT#63759 prov templates: parse .csv header ... to process .csv files created via excel "save as" -> "CSV UTF-8" directly, the header is now analyzed by Text::CSV_XS. this will automagically determine utf BOM and separator char. furthermore, some fixes are added for provisionion templates base on JavaScript, after adding a trim() method for strings. caching of domains (+resellers, billing_profiles, profile_packages is now fixed to propery print "unknown domain ..." for each line. furthermore, the ngcp-provisioning_template script is fixed to work again after changes: MT#60558 invoke max subscribers/group license check only on POST MT#59078 ?create_primary_acli= query param Change-Id: I8b53ab1c6071de27c62d29e921634063a725c130 (cherry picked from commit 2460c6e3d8) (cherry picked from commit 570ef59c99)	5 months ago
Rene Krenn	9992a03d51	MT#61442 allow utf8 for creating data::hal links ... prevent api 500 error when building urls in data::hal from item data tha carry odd utf8 fields (ie. usernames of banned users) Change-Id: I0c2c0bf0170bf97bf8a05c35fdb343860b6aeef4 (cherry picked from commit 3ff0395cac) (cherry picked from commit bb14424105)	6 months ago
Kirill Solomko	5822b4e99a	MT#64346 skip email dispatch without a dest email ... * when during email template sending invokation there is no target email, the process is correctly skipped. Change-Id: I810b258c9e623b75598fb5da9b98ff499a419c44 (cherry picked from commit 00b960814d) (cherry picked from commit 981cd81b01)	6 months ago
Kirill Solomko	ec585b5fbb	MT#64232 improve check_subscriberadmin_write_access ... * subscriberadmin can now edit own data in scenarios where it's a SIP customer subscriber * add a check to that the edited subscriber belongs to the same customer Change-Id: I69a84c481be413ac5604c74856e760eee648b637 (cherry picked from commit 224aec5fc8) (cherry picked from commit db9931a505)	7 months ago
Kirill Solomko	4d82d63dc4	MT#64295 better handling of via_route empty string ... * transform via_route empty string into undef and store it as undef without validating it against SIP-URI Change-Id: Iefae7b26910201183ae3d049b3785a68dc81ce64 (cherry picked from commit c417cc622d) (cherry picked from commit ca75c7a73a)	7 months ago
Kirill Solomko	16616e94f4	MT#64297 /api/platforminfo expose sip.external_sbc config ... * sip.external_sbc options are exposed to authenticated admin users in /api/platforminfo Change-Id: Ifea5eb43b8638299d1ef916c65a17fa18f833f82 (cherry picked from commit a97490e97d) (cherry picked from commit 185929d385)	7 months ago
Kirill Solomko	8595ce6411	MT#64295 fix /api/peeringservers via_route validation ... * NGCP::Form::Peering::Server rework via_route URI check from a comma separated list to a single value as well as improve value transformation and validation logic * /api/peeringservers add via_route value transformation as pre_proccess_form_resource() Change-Id: I742a40534a4861dd30e0ccbc6684c02d2386f642 (cherry picked from commit 638b2f20ae) (cherry picked from commit 4279c0e3bb)	7 months ago
Kirill Solomko	8db4d7433c	MT#64282 replace redirect with ajax_logout separation ... * a better way is to leave /logout as is and instead separate ajax_logout so that it's not chained from /logout anymore, resulting in 200 OK with empty application/json response, and without redirects by default Change-Id: Ide4f3845532e176e6866ebe61155e04d02aa3fbd (cherry picked from commit c48355ca03) (cherry picked from commit d3ebb2c509)	7 months ago
Kirill Solomko	0020ec8802	MT#64282 add redirect=0 option to /ajax_logout ... * ajax_logout can now return 200 without further redirect when redirect=0 query param is provided Change-Id: I03f499e1090895c2fb382494dd4cc872427692f1 (cherry picked from commit 4a1f5f4b28) (cherry picked from commit 6fa0f84119)	7 months ago
Kirill Solomko	15b4b050b2	MT#64280 add ngcp_admin_ui_jwt realm and X-NGCP-Admin-UI header ... * ngcp_admin_ui_jwt is a copy of api_admin_jwt realm but with use_session: 1 * ngcp_admin_ui_jwt is used when X-NGCP-Admin-UI header is provided Change-Id: Ia82f97df922a69866f7c7d63ad1566ff0fc4bc2a (cherry picked from commit 41fb2d22cc) (cherry picked from commit 49ed5f9889)	7 months ago
Rene Krenn	56866b0f44	MT#63980 fix Javascript prov templates raising errors ... The JE module will populate $@, hence an enclosing eval{} wipes the error string unintentionally. in addition the "die" method is now exposed in Javascript templates, to use it to bail out, ie. to propagate a msg from an input validation to the UI. Change-Id: Id3fcf8a7820ee3df51e0cc6323350f5f5908fcf4 (cherry picked from commit 5fb5a860c3) (cherry picked from commit 09ba4aa7b5)	7 months ago
Kirill Solomko	000e48b679	MT#64172 admin_jwt restore use_session = 1 ... * sessions are used for admin_jwt realm because admin-ui iframed content relies on it as well as this realm is not related to API Change-Id: I6c0ee99301757c1479ce8148240b9583da144ea3 (cherry picked from commit acf142a993) (cherry picked from commit b54d3092c3)	7 months ago
Kirill Solomko	8335b5c46d	MT#64172 enable use_session = 0 for all API and JWT realms ... * this disables $c->user_exists to result in successful auth if correct session is provided. Change-Id: Id91b88f6f30dcca6a7b40eb61a23e2bbdabce7dd (cherry picked from commit 6003c3bab4) (cherry picked from commit fb826c0a53)	7 months ago
Rene Krenn	03a53ff042	MT#63818 ldap auth: support dn lookup ... this change will allow to transform the NGCP admin login name to a ldap dn by searching the directory. this is the same technique sssd also uses. Change-Id: Ic852cb0e27aaf31177f2ccf692507b12d2fce3a5 (cherry picked from commit 4905f124bf) (cherry picked from commit a5e6fe1ecc)	7 months ago
Kirill Solomko	09062b902d	MT#64131 fix non-default NULL preference render ... * non-default NULL value is now correctly selected in the UI preferences list as well as in the edit form. Change-Id: Ief3b2e6778441c736589cfccc5a5fb7e60a7dcf0 (cherry picked from commit f6246ba094) (cherry picked from commit 4782f68839)	8 months ago
Kirill Solomko	c3c2d80067	MT#64121 fix $c->error $c->error handling ... * errors coming from Utils::Preferences can have only 1 element in $c->error, the case is now correctly handled. Change-Id: I9f5d384da8b5cb50b78636309dbaab5efa9bdee2 (cherry picked from commit 9d70f62f70) (cherry picked from commit f5e014c430)	8 months ago
Kirill Solomko	6d21639a91	MT#64067 fix subscriberpreferences PUT update_item ... * PUT update_item is fixed to properly expect 3 values Change-Id: Id63445f76ffbc312aadafc7b502fffd070eb0089 (cherry picked from commit 56b15e8197) (cherry picked from commit a2b54623ce)	8 months ago
Kirill Solomko	bad8d58dac	MT#64098 enable logger autoflush ... * Preamble: disabled autoflush caused logs to be written only when a request is finished, and what is worse, all of them with exact same time. As logging $c->log->* happens via syslog and rsyslog already uses buffering for that, there is no reason to cause such additional buffering by the Perl logger (which is Log4perl in this case). On top of it, it's already the default option for Log4Perl and was only inactive in the Panel app. * enable autoflush during Log4Perl init in the Panel app. Change-Id: I7cdcf7de30489d84fd8a9af88cb40669113ddbc1 (cherry picked from commit bb6b737c26) (cherry picked from commit 6a59163433)	8 months ago
Kirill Solomko	60203fabaa	MT#64067 address deadlock detection for preferences ... * improve Role/API/Preferences err_code callback to check deadlocks (via $self->check_deadlock) and set $process_extras->{retry_tx} = 1 so that the outer caller can act upon it and restart the transaction. * increase deadlock attempts from 2 to 5 as some deadlocks seem to take longer time to resolve. * wait 1 second between deadlock retry attempts as otherwise if a deadlock takes more than 1 second and all the retries are done within less than a second it will cause an error. * EntitiesItem: add support for retry_tx and call goto TX_START if $process_extras->{retry_tx} (when check_deadlock is processed externally, like in Utils::Preferences::update_item in the err_code callback). Change-Id: Ib56383710041c21d72782047a852353296c22215 (cherry picked from commit eae620f204) (cherry picked from commit b3391957d4)	8 months ago
Rene Krenn	6683cef716	MT#63706 skip_locked for POST /api/subscriber/ ... add the SELECT .. SKIP LOCK mechanism for POST /api/subscriber/, to reduce lock wait timeouts when creating suscribers for the same customer in parallel. Change-Id: I067102b3dc726e5d12fa859613b548d007ce29ee (cherry picked from commit f501fc1dcf) (cherry picked from commit 27445ac30e)	9 months ago
Rene Krenn	bfce26385e	MT#63706 skip_locked for DELETE /api/subscriber/id #1 ... Change-Id: I1bbc4d72ca405a4b3935b27d37e503be777de291 (cherry picked from commit a5ac1e959e) (cherry picked from commit bd4fcd2bea)	9 months ago
Rene Krenn	aeaea00eb6	MT#63706 skip_locked for DELETE /api/subscriber/id ... while acquiring locks is skipped nowadays for collections eg. a GET /api/subscribers/, timeouts were still reported for individual DELETE /api/subscriber/id requests. this change adds logic to skip acquiring locks for DELETE /api/subscribers. there is also a fix to make GET /api/subscribers/id and GET /api/subsriberpreferences/id work. Change-Id: Ie71abecd1f8387b9f56e8e0a47a5f1b16a6f308d (cherry picked from commit 2a5bd4c409) (cherry picked from commit 6af00a900f)	9 months ago
Kirill Solomko	49997b141f	MT#63859 add expand by carrier_id ... * /api/lnpnumbers can now expand by carrier_id Change-Id: Ia484041c413a240800c1610f0bc92c141bded14d (cherry picked from commit d0783b1856) (cherry picked from commit c953cc5e28)	9 months ago
Kirill Solomko	de1ce24ad7	MT#63839 add expand by subscriber_email_template_id ... * subscriber_email_template_id can now be globally expanded Change-Id: Ifad15d328ed6cfb81670974a8a4a2f9ad6196652 (cherry picked from commit be0e9de01b) (cherry picked from commit 66cb37fe24)	9 months ago
Marco Capetta	eb6c92a6c1	MT#63893 Fix typo in commit 3b17ab6c54 ... Change-Id: Ieaa0f18cfab821a2c85de1a3602946c1855c8dba (cherry picked from commit 4f64c07ac5) (cherry picked from commit 7c6b604376)	9 months ago
Marco Capetta	bbdbc65b6c	MT#63893 Call 'sip_dispatcher_reload' while changing peerings via API ... For scenarios when: * a peering server is enabled or disabled * a peering probe is enabled or disabled * a peering group with active peering servers or peering probes is removed a "sip_dispatcher_reload" XMLRPC request is sent to kamalilio-proxy, otherwise the dispatcher cache is not reflected and therefore, not available with the actual state until next kamailio-proxy restart. Change-Id: If3a98115224eb132126d5a53df7320cb6a33deba (cherry picked from commit 3b17ab6c54) (cherry picked from commit 074482bd5f)	9 months ago
Kirill Solomko	19d36631df	MT#63050 /api/customers email_template auto assign ... * POST /api/customers now assigns reseller's default email_templates that are not specified in the DTO. If reseller's default template does not exist (reseller that was created via UI v1 without values), it automatically created as a copy of the raw default template for the reseller, and then assigned to the customer. Change-Id: I0f74154724e1d053002ec4fcc59a5f99cedd322c (cherry picked from commit d1686f5243) (cherry picked from commit 48f67e81c0)	10 months ago