330 Commits (mr8.5.2)

Author	SHA1	Message	Date
Alexander Lutay	c2ae23fff9	TT#46791 Improve 'prove' output for Selenium and REST API tests ... It improves readability slightly. Change-Id: Iaecd72eded4f495a38e2009eef89445f6517b688	6 years ago
Alexander Lutay	82172e5b1a	TT#46791 Fix floating bug with 'Edit' problem on page 'Weekdays' (try #2) ... The full issue description you can find in commit message a9399b1efd. In short, Selenium can't press on "Edit" button because it is being hidden on every AJAX request to backend. (Un)fortunately the previous fix opened new ngcp-panel JS issue reported as TT#50005: JS performs several AJAX requests to backend and the second request still cause the same problem as previous caused the first one. Luckily JS performs only one request to backend on the page load. And starts doubling them when we enter something into "filter". As a result, the previous commit has been reverted and new approach is proposed here: we will just wait data appearance in "Dates" (which means the first AJAX request is finished). Change-Id: If991af70e1ad1b00b04e4118c0b5f52b2d636eba	6 years ago
Alexander Lutay	cb7d6ec0af	TT#46791 Use proper variable name in test controller_billing.t ... The previous variable name didn't represent the real code context. The changes were initially part of commit a9399b1efd and were extracted to separate commit as initial commit had been reverted in commit 0601b821006f. Change-Id: Idf06a06b60498ec5df7a9472aa38413997dc23cb	6 years ago
Alexander Lutay	18d4e25574	Revert "TT#46791 Fix floating bug with 'Edit' problem on 'Weekdays' page" ... The fix here didn't work well because another ngcp-panel issue has been noticed and reported as TT#50005, the second AJAX request aborts Selenium test by hiding "Edit" button. The better approach is follow. This reverts commit a9399b1efd. Change-Id: Icf6251261f0cbc12ef4e819b3352dc3ebf7c4246	6 years ago
Alexander Lutay	dce4c30823	TT#46791 Fix floating bug with 'Delete' button on 'Peering Servers' page ... Jenkins reports time-2-time issue on 'Peering Servers' page: > # Delete the previously created Peering Rule > ok 14 > Can't use string ("no such element") as a HASH ref while "strict refs" in use at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 684. > at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 655. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 14. It was caused by slow AJAX loading here. The button 'Delete' was not yet loaded and we were just do 'sleep 1' and were trying to press it. How we are clearly waiting for the record to be loaded before trying to delete it. Change-Id: Ia20cb427262e9c973ce4853d3ebb17438780afd0	6 years ago
Alexander Lutay	a9399b1efd	TT#46791 Fix floating bug with 'Edit' problem on 'Weekdays' page ... It was old floating issue which randomly failed the test and jenkins job ngcp-panel-test-selenium-docker became often yellow. The problem here was in two facts: - 'Edit' button available with mouseover only - there is AJAX on this page for filtering 'Dates' records. Historically we have no ability to wait for all AJAX loadings. When Selenium moved mouse over Edit column to press it, AJAX can be finished and removed "Processing..." label from "Dates" field. It cause loosing mouseover from "Edit" button and button is hidden causing "element not interactable": > # Click 'Edit' button for element 'Wednesday' > Can't use string ("element not interactable") as a HASH ref while "strict refs" in use at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 684. > at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 655. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 27. It has been workarounded here as we cannot wait for AJAX. We are creating fake query for "Dates" (searching "thisshouldnotexist") and waiting until the table "Dates" has no search results records. It means AJAX has finished and we can continue with the test. Also here I have renamed confusing button from 'edit' to 'delete', as we press delete. And we have to clean previous search 'thisshouldnotexist' with proper '2008-02-28' which we want to delete. Change-Id: I55af32991687e82c3e57b15c066e772ff0b77123	6 years ago
Alexander Lutay	72834f126d	TT#46791 Add timeout 1 second for controller_billing.t ... It will give Ajax enough time to load 'Edit' button, otherwise we have some mystery which randomly happens when Jenkins tests VMs on Google Cloud: > # Edit Wednesday > ok 26 > # Move mouse over 'Weekdays' row to make 'Edit' button available > # Find 'Edit' button for element 'Wednesday' > ok 27 > # Click 'Edit' button for element 'Wednesday' > Can't use string ("element not interactable") as a HASH ref while "strict refs" in use at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 684. > at /home/selenium/Selenium-Remote-Driver/lib/Selenium/Remote/Driver.pm line 655. > # Tests were run but no plan was declared and done_testing() was not seen. > # Looks like your test exited with 255 just after 27. Locally it is not reproducible, also VM on Proxmox has no such issues as well. I spend too much time here trying to find the root of the issue, maybe Firefox version we are currently using has some issues here. Give up, sleep 1. Change-Id: I168270f6f6d25d8bdccfe6a40b2bc63aa0c5068e	7 years ago
Alexander Lutay	45bf7ec433	TT#46791 Call proper method 'click()' instead of 'click' (cosmetic) ... This is mainly for the code consistency. Change-Id: I1e820ef3693f541c21b86929c4887d434a74f35f	7 years ago
Alexander Lutay	571c09fdc8	TT#46791 Fix exit code passing in pipe for selenium testrunner ... The old code didn't work as expected, as RC receives 'tee' exit code (which is zero in most of the cases) instead of 'prove' exit code. The new code gets 'prove' exit code and it changes nothing at the end, as we just print it into debug message. Anyway Jenkins operates with JUnit output to detect issues. It is better to have 'correct' code here to prevent misunderstanding in the future. Change-Id: I09f399813179590a67c25509f310c91f7e297f3a	7 years ago
Alexander Lutay	95e1c49208	TT#46791 Wait for 'Edit' button in controller_billing.t ... The 'Edit' button appears only after mouse-over event, and we might have race conditions here when we are trying to click on not-yet available/accessible button causing: > Can't use string ("element not interactable")... Let's wait for button and then proceed with 'click()', it is the behaviour we use everywhere, while it was missing here. Also improve debug messages here for easier debug next time. Change-Id: Iae955bb3f937da6b5c10369bc49f6dd75611dc87	7 years ago
Guillem Jover	bcab88a09d	TT#39401 Use List::Util in perl core instead of List::MoreUtils ... We can replace the apply usage with map plus a returning s///. This also fixes a hidden bug with the liblist-moreutils-perl dependency missing from debian/control, being indirectly pulled by some other dependency, while an implementation detail. Change-Id: Ibfc7b362ad77c4b202d93cf71774c40623503f14	7 years ago
Gerhard Jungwirth	b47cf5f70f	TT#17853 TT#21767 make new selenium library visible to jenkins ... adapt PERL5LIB in a way, so that jenkins is also able to find it (it uses /home/selenium/jenkins_docker_run) Change-Id: I2d5ab35c77abd2dda9f676768da8cd6a36c4ddfb	8 years ago
Michael Prokop	1cd3fb497b	TT#17853 TT#21767 Use git version of Selenium::Remote::Driver ... Selenium::Remote::Driver v1.20 is the latest upstream release and is missing some patches/PRs that we need for selenium tests of ngcp-panel. Packaging the git version properly in the Debian way is hard because of the way upsteam handles releases with separate branches (one of them even being out-of-date, sigh). So instead let's use a tarball from their latest git version until we see a v.1.21 release. Symlinking the geckodriver binary to /usr/bin/geckodriver addresses: | Unable to find the geckodriver binary in your $PATH. at /home/selenium/Selenium-Remote-Driver/lib/Selenium/CanStartBinary/FindBinary.pm line 66. Change-Id: I8ddf3c76a008ce5b0aa67b62154a9614f90cb659	8 years ago
Michael Prokop	2b9b5f8b61	TT#17853 selenium tests: update to geckodriver v0.18.0 ... Change-Id: I545f160d5dc1a0d60cd2e9dc4ad946989efd4f8c	8 years ago
Gerhard Jungwirth	a672389bc7	TT#17853 selenium test adaptions for geckodriver ... all selenium tests are working with newest geckodriver (0.18.0) and patched S:R:D issues: - setting the window size: not urgent - the unsupported move_to: fixed (new move_action) - setting the implicit wait timeout: fixed upstream in S:R:D Change-Id: Ic5b52cd866f4fd93682d67a4fd8a76ec54ea70cf	8 years ago
Michael Prokop	67f2e54be6	TT#17853 Use Selenium::Remote::Driver with further patches to address bugs/incompatibilities ... This package update includes further patches to address Selenium test failures with geckodriver/Firefox: * move_to: 4d0b8e7255 * timeouts: 2c55f3dcb9 Change-Id: I587f32230ce7cc8d912e052a93fb7d31fd7c90c1	8 years ago
Alexander Lutay	cccc6a9a41	TT#17032 prove STDERR output is not a part of Jenkins's result XML ... Which confuses developers which are debugging failed tests, as details like below are not a part of XML Jenkins displays on a WEB: > # Failed test 'create test customer w/o profile package' > # at t/api-rest/api-balanceintervals.t line 1578. > # got: '500' > # expected: '201' > Use of uninitialized value in concatenation (.) or string at t/api-rest/api-balanceintervals.t line 1580. > Thread 4 terminated abnormally: malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before "<!DOCTYPE HTML>\n<!-...") at /usr/share/perl5/JSON.pm line 171. 'man prove' says: > -m, --merge Merge test scripts' STDERR with their STDOUT. Change-Id: I945d4d8867fc9c061f96d067be14125af7cc5a46	8 years ago
Michael Prokop	2b021efb56	TT#17853 Fix selenium related toolchain, replacing selenium with geckodriver ... An unintended docker image rebuild of ngcp-panel-tests-selenium-jessie resulted in failures with our selenium tests. A series of problems started: 1) Updating the Selenium version resulted in an error message by Selenium, requesting the geckodriver binary (https://github.com/mozilla/geckodriver - being a proxy for using W3C WebDriver-compatible clients to interact with Gecko-based browsers). So Selenium versions >=3 depend on geckodriver. 2) Recent versions of Selenium also depend on Java >=8, available only via backports for jessie. Since we avoid usage of backports as much as possible and we'd have to upgrade once anyway we decided to base our fresh docker image on stretch. 3) We have to backport Selenium::Remote::Driver (Debian package libselenium-remote-driver-perl) for stretch (since it's not available in Debian, even though there's an ITP: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839569). It has a bug which prevents its usage for us: https://github.com/gempesaw/Selenium-Remote-Driver/issues/319 -> We fixed the problem via our own backport and submitted a PR towards upstream: https://github.com/gempesaw/Selenium-Remote-Driver/pull/321 4) Firefox from Debian/stretch (firefox-esr 52.2.0esr-1~deb9u1) fails with geckodriver e.g. in click events, the current Firefox version 54 works fine though. So instead install only the relevant runtime packages from Debian and use the Firefox version v54 from upstream. Resulting changes: * switch from Debian/jessie to Debian/stretch * no longer use selenium at all but only geckodriver instead (recent versions of selenium depend on geckodriver anyway) * do all package/file changes in /home/selenium/ (to clearly see what's from us/docker and what are actual temporary files) * testrunner related changes: - invoke vncserver with `-localhost no` option to accept VNC connections not only from localhost only - adjust vncserver process name for Xvnc4->Xtigervnc switch - start geckodriver instead of selenium * package related changes: - backported libtest-pretty-perl (v0.32) - backported libselenium-remote-driver-perl (v1.20) - add curl to package list since it's handy for debugging test failures, like e.g. `curl -X POST localhost:4444/session --data {}` - add procps to have pkill binary available inside testrunner - openjdk/java is no longer needed since we don't depend on selenium anymore - vnc4server is now a transitional package for tigervnc-standalone-server, so directly depend on it Change-Id: I607ffd4fce80f9e84b76c3c7a19824819ac4503c	8 years ago
Victor Seva	8994522f91	TT#17502 docker: fix relative path from new context ... * update Dockerfile documentation Change-Id: Ib1c2491118d1fc02cae0ed198fefe06ccd954660	8 years ago
Andreas Granig	81e398804f	TT#2766 Fix selenium for outbound peering rules. ... Change-Id: I9f33a9a914af27eabfb820f4d1ee836f9d0acb24 (cherry picked from commit ffc0d18333)	9 years ago
Alexander Lutay	6d35b85a6b	MT#22099 Docker >=1.11 no longer has /.dockerinit, adjust docker run check accordingly ... File /.dockerinit no longer exists. With Docker versions 1.11 and 1.12 there's /.dockerenv available, though it's not yet sure whether this will be present in the future too, so check for either /.dockerenv or a proper cgroup setup inside the docker container. File /proc/1/cgroup with Docker version 1.12.1 on Debian/jessie looks like: | root@4c3a1c6d773c:/# cat /proc/1/cgroup | 8:freezer:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 | 7:perf_event:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 | 6:net_cls,net_prio:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 | 5:cpuset:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 | 4:blkio:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 | 3:cpu,cpuacct:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 | 2:devices:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 | 1:name=systemd:/docker/4c3a1c6d773c1a5675f24ff58540ff1a290489e7325e1e66ec2c3392aa3a1145 See https://github.com/docker/docker/issues/18355 and https://github.com/docker/docker/pull/19490 for details. Change-Id: I79fff0eead1a11f80b461791b2285a65d706262a	9 years ago
Victor Seva	c6b51a136c	MT#17293 Switch Dockerfile files to use a sipwise-jessie image ... This way we get a Debian Jessie system with Sipwise mirrors and need not do any additional setup. Change-Id: I89e9acd846132508e135f7443482c0371c80d2b2	9 years ago
Michael Prokop	9b95f357d8	MT#8075 Refresh Dockerfile + set DOCKER_NAME for *-source-tests ... With the update to docker distribution v2.2.1 we need to push new images Change-Id: Ic9e10d4827fe836beeba7480bf2c17002400798d	9 years ago
Michael Prokop	a236b39bef	MT#15071 Jenkins<->docker integration support ... The jenkins_docker_run script is invoked from Jenkins when running the docker image. The testrunner script now takes two additional arguments to support sharing test results via another docker volume and to control output format ("pretty" as default but junit for usage on Jenkins). While at it fix some quoting issue identified by shellcheck. Change-Id: Ided716e0e0ca23751b0ee2961f3e301acb80128d	10 years ago
Gerhard Jungwirth	7f2076e8ab	MT#15071 some docker conveniences ... Change-Id: I901a6012ad00e5f318ac6eda5c107e5c4d1241b7	10 years ago
Gerhard Jungwirth	c044e2410a	MT#15033 clean Build.PL server startup ... options to start the panel directly or a mysql server are dropped. this also drops dependencies Change-Id: I4be60c8495d94b5fc0bcac742602bec3c988e5fb	10 years ago
Michael Prokop	b17bc4da82	MT#14585 Docker setup for selenium tests ... This provides a setup to run ngcp-panel tests against selenium-server using docker. It's based on Debian/jessie and assumes are reachable NGCP system for running the tests against (e.g. via `vagrant up ce-trunk`). For usage instructions refer to the Dockerfile. NOTE: replacing 'jessie' with 'wheezy' in the Dockerfile provides a setup based on Debian/wheezy. Change-Id: I79ca4d44c3a7c454f99148889d4b0d075a79e82b	10 years ago
Gerhard Jungwirth	3b8651ac2a	MT#14585 improve selenium test quality ... use strict and warnings therefore forbid unquoted strings factor out initialisation screenshot functionality is implemented upstream Change-Id: I18a0dcc7a6418dc9fd2fa64d367ae226018a7645	10 years ago
Alexander Lutay	5879cfe0e1	MT#14585 Move selenium tests on Selenium::Remote::Driver(::Extensions) ... Change-Id: I5c2133598196a620d4e8a6376beb800cdde81f3c	10 years ago
Alexander Lutay	bd9a184c56	MT#14585 Move ngcp-panel-selenium tests to folder 't/selenium/' ... Also simplify tests names. Change-Id: I9142160ec0ae5aad9287ce38b5f552e1790c285f	10 years ago