4046 Commits (mr26.1)

Author	SHA1	Message	Date
Marco Capetta	bea08fb66a	MT#65665 return redirect credentials on pbxdevicemodels on GET API ... The bootstrap_config_redirect_*_user and _password values are stored in provisioning.autoprov_redirect_credentials, while _profile is a sync parameter in provisioning.autoprov_sync. resource_from_item only called devmod_sync_parameters_prefetch_api, so GET returned the profile but silently dropped the credentialsm. Add devmod_sync_credentials_prefetch_api, mirroring the read-back the web UI already does in Controller::Device, and call it from resource_from_item for the admin and reseller roles only, which are the roles allowed to write these fields. Subscriber and subscriberadmin GETs keep them hidden. Change-Id: I02a8975fbf9fe60796832cf281d054e634ce6c00 (cherry picked from commit 8042d9f4d1)	1 week ago
Rene Krenn	acbbb78fb2	MT#65652 update primary number when only cc/ac/sn split changes ... Skip primary number processing only when cc/ac/sn parts match, so a resplit with the same concatenated CLI still updates voip_numbers. Change-Id: I69e1c4e69ea9fd7df111ee2d371c8e99c478c04f (cherry picked from commit f3ba2dfa02)	1 week ago
Marco Capetta	b4a807aeeb	MT#65224 renumber voicemail msgnum on folder change and delete ... Asterisk uses its built-in ODBC voicemail storage against kamailio.voicemail_spool, which expects msgnum to be contiguous 0..N-1 within each (mailboxuser, dir) folder. Asterisk maintains that invariant itself, but the panel rewrote dir (or deleted a row) without ever touching msgnum, leaving gaps and duplicates that make asterisk mis-play and mis-count the messages. Add two helpers to Utils::Subscriber reproducing the asterisk semantics: * renumber_voicemail_folder() compacts a single folder to 0..N-1 ordered by (msgnum, id). It skips greetings, which live in the same table with msgnum -1. * move_voicemail_to_folder() appends the message at the end of the target folder the way asterisk does (last_msg_index + 1), then compacts both the source and the target folder. Both run inside a transaction, so the web UI paths that have no transaction guard of their own are covered as well. Use them in all four affected paths: * PATCH/PUT /api/voicemails/{id} (Role::API::Voicemails) * DELETE /api/voicemails/{id} (Controller::API::VoicemailsItem) * mark_voicemail_read() for the CSC/admin listen action * delete_voicemail() in the subscriber web UI The compaction is deliberately self-healing, so it also repairs folders already corrupted by the previous behaviour. Change-Id: I665de1966bc37c1069ff56fb30c99da85f224f71 (cherry picked from commit d01cff87ba)	2 weeks ago
Marco Capetta	88b52e89e3	MT#56865 Fix autoprovisioning of Grandstream devices ... The autoprovisioning of Grandstream devices was not working since a while or even never really worked. In the SOAP request to register the new device in the GAPS server was missing the '$query_string' parameter, thus the server responded back with: response=200; page={"code":7,"desc":"try to http base authorization failed","ret":null,"time":1785401492}#012; err=try to http base authorization failed; This change should not affect the provisioning of other vendors because the '$query_string' parameter is set to an empty string by default. Change-Id: I6637ce82351c46ec631c1047ec50ccb5404228e1 (cherry picked from commit cc34719693)	2 weeks ago
Rene Krenn	79fc0de181	MT#65579 do not set primary_number undef in shared resource_from_item ... Keep missing primary numbers absent from the shared helper so provisioning template update paths do not treat them as an explicit clear. Also fix perlcritic mixed boolean operators. NGCP-Flow: mr26.1 Change-Id: Ib5ef634e7a9e65678ec872d71d65aea8301fc364	2 weeks ago
Rene Krenn	e52b6f9f7d	MT#65579 use JSON::Types::bool for is_devid in resource_from_item ... Keep journal-safe JSON booleans after moving resource_from_item into Utils::Subscriber, matching the previous Role/API behaviour. Change-Id: I357a4f5f4a25f8a7295341dcbff80a14d3cb6f51 (cherry picked from commit 9767845c0a)	2 weeks ago
Rene Krenn	f6c55b256d	MT#65579 fix is_devid boolean conversion in resource_from_item ... Avoid the ambiguous bareword "bool" call that 500s subscriber API responses when alias is_devid is a plain DB integer. Change-Id: I8829e064ee658ae35676aa8414c58c0e16ffd5fa (cherry picked from commit e485aff6b4)	2 weeks ago
Rene Krenn	1889732def	MT#65579 support updating existing subscribers via prov templates ... Reuse shared resource_from_item/update_subscriber helpers so templates can match by identifier, fill missing fields from the DB item, and update instead of only creating. Change-Id: I5fa9be12914677c3b6ef5c4c0617cb75447b45c9 (cherry picked from commit a0bfa9377c)	2 weeks ago
Kirill Solomko	7063648062	MT#65432 add cf sets subscriber_id support subscriberadmin ... * subscriberadmin role can now correctly provide with a subscriber_id under which the cf set is created/updated, only ones that belong to the same customer are valid. The behaviour remains unchanged if the subscriber_id is omitted as the subscriberadmin id is used in this case. Change-Id: I51f0333e51865e91a127338ac5f888eb88d15271 (cherry picked from commit 9470652038) (cherry picked from commit 3401540d0a)	3 weeks ago
Rene Krenn	60387aa8dc	MT#65464 Fix LDAP OTP registration crash on /api/otpsecret ... LDAP login stored a raw DB::admins row as $c->user, so API response logging failed when fetching the OTP QR after an invalid OTP on login_jwt. Wrap the admin in RoleFromRealm, pass the admin auth realm to set_authenticated, logout on OTP failure, and make Message logging tolerate raw user rows or role lookup failures. Change-Id: I29fda2324eadc7fb1f25f06ae6418ab594b69fa0 (cherry picked from commit 70d5c894a6)	1 month ago
Rene Krenn	68240a7dca	MT#65464 fix LDAP login 500 when user lookup fails ... get_user_dn called ->dn on an undefined search result when LDAP lookup failed, causing login_jwt to crash instead of returning 403. Return early when no entry is found and log a clear message when the LDAP URI is missing or the connection fails. Change-Id: I5f00df840d304e4da2b35750c9c1f2e6972f1edb (cherry picked from commit 3e1d3c09a5)	1 month ago
Kirill Solomko	9aed2d73b6	MT#65092 fix /api/voicemails $q variable typo ... Change-Id: I7e662960b873124762dcc3711636fc9a243fe0fa (cherry picked from commit 44cab5c602)	2 months ago
Kirill Solomko	df99d1ae40	MT#65092 address query param string pattern match in certain endpoints ... * new function Generic::Utils::parse_query_string($str) that performs the following: - escapes unescaped '%' and '_' occurrences when needed (as they are reserved internally for the "like" operation - converts all unescaped '*' and '?' chars to their "sql like op" '%' and '_' counterparts. * change endpoints that used escape_search_string_pattern() to use parse_query_string() instead, to avoid: a) overescaping b) automatic string wrapping with '*' that prevents strict match all sql builder queries that use $q after parse_query_string() use returned $op ('like', '=') as the operator, to easily set strict or like match. Change-Id: I961b5d032036f13a7460d91f8c197538ffba1997 (cherry picked from commit 8089861097)	2 months ago
Kirill Solomko	9e9f097de8	MT#65368 fix UI /logout link ... * when /logout is used on the old UI, it no longer produces ERROR: Couldn't render template "logout/logout_index.tt" Change-Id: I94f29c8a400da509ca26ddf2f410ddc76edec55f (cherry picked from commit f21064a2d4)	2 months ago
Kirill Solomko	a7f13331e8	MT#65048 check subscriber profile preferences on update ... * when subcsriber preferences are modified, keys are checked against a subscriber profile and if any of them is not accessible (disabled in the assigned profile) a 422 error is now raised. That is mostly relevant for PATCH "op":"add" that returned 204 OK before regardless. This change only affects access to /api/subscriberpreferences by the 'subscriber' and the 'subscriberadmin' roles * Controller::API::SubscriberPreferencesItem: remove unintended "last" from catch {}. * Utils::Preferences: remove 2 debug lines. Change-Id: Ie20e5b8d4420c814bc786c34ddd952ee13d355ae	2 months ago
Kirill Solomko	5d7e137ec9	MT#65243 Plugin::NGCP::Redis handle 'active-replica' state ... * Catalyst::Plugin::NGCP::Redis::_wait_for_master_role() only expected the 'master' value to be considered as OK, whereas with Redis/KeyDB the value can be also 'active-replica'. Therefore, consider both 'master' and 'active-replica' values as OK. Change-Id: I16a0657a3a78a2f2b3c892c21ce0d9d6ebec0a0c	2 months ago
Sipwise Jenkins Builder	c593702b0f	TT#4166 I18N dump: snapshot 2026.06.02-22.20.34 ... Change-Id: I38d357112ee83a1df2f835b9a8c5e108440a6bfe	2 months ago
Rene Krenn	baab52c682	MT#65218 prov templates: improve contract and subscriber lookup ... - when using "identifer" to lookup a contract, the prepare_billing_profile() you produce an error. - when using "identifier" to lookup a subscriber, the prepare_resource() could cause an error. - eliminate a "Old package separator deprecated" warning from JE::Destroyer. - the "now" variable was not properly exposed in the JS scripting language context Change-Id: I3253f92f345c1532f489fc87b3c91370e34a3066	3 months ago
Rene Krenn	908815904a	MT#60441 fix saving contract prefs with location_id ... for preference values discriminated by location_id, the location_id param (passed as as a query param) needs to be provided in each query. Change-Id: Id3938ae3c18c4cb108ff7726aaad4a3512550319	3 months ago
Sipwise Jenkins Builder	a8ec178bcb	TT#4166 I18N dump: snapshot 2026.05.12-22.18.30 ... Change-Id: I8a20c2b3f80d425edfa4e3f917334c1d2f43e6c7	3 months ago
Michael Prokop	5993a1e1bc	MT#55576 Switch mail interface from sendmail(1) to SMTP ... We had to disable plenty of systemd security hardening options because NGCP::Panel::Utils::Email used the sendmail(1) interface. Switch to usage of sending mail via SMTP Net::SMTP instead, which should allow us to apply our common systemd hardening. Note that we can't drop the dependency on libemail-sender-perl yet, as share/tools/generate_invoices.pl:use still relies on it. Sendmail doesn't talk to any SMTP port, as it invokes the sendmail(1) binary and writing the message to its stdin. Default to SMTP on localhost with port 25, to get similar behavior. While at it, fixed the swapped log levels (original $c->log->info was used for failure, and $c->log->error on success). Change-Id: Ie7120d4a8e55eb645c99b5d52c8326e7a7d42f8b	3 months ago
Kirill Solomko	ce12aed828	MT#64923 callforward sets add own boolean field ... * /api/callforwards (per set), /api/cfdestinationsets, /api/cfsourcesets, /api/cfbnumbersets, /api/cftimesets return "own" field for subscriber and subscriberadmin roles only, this field indicates if the call forward set belongs to the same subscriber that requests it. * /api/callforwards fix default value for 'cfr' and 'cfo' cftypes from null to {}, to match all the other cftype default values. Change-Id: I9c5c60dfb16301703341c1ba17c751079f79ae8b	3 months ago
Sipwise Jenkins Builder	5091368bb4	TT#4166 I18N dump: snapshot 2026.04.24-22.20.31 ... Change-Id: Ic9e6ad3e06105da50d9c8d8f222580eef9045190	4 months ago
Marco Capetta	3377270667	MT#63396 Add 'phonebook' internal preference to show/hide CSC menu ... Change-Id: I77aa4d77a25aa1298e286373ee6f7772b08f9bb8	4 months ago
Kirill Solomko	e956227ab0	MT#64972 /api/customers email_template auto assign change ... * if an email template id is explicitly provided as "null", it will be assigned as "null". * remove email templates auto creation (copy from raw) for resellers if they do not have the specific one assigned to them. that proved to work contraversal as if a customer doesn't have an email template assigned to the reseller, and does not want to change their business logic (by explicitly providing "null") during POST /api/customers for those templates, the auto creation for reseller prevents it and causes complications, as well as it's not the intended role for /api/customers to automatically affect reseller configuration in such a way. Change-Id: Ie8cf0bffdd397279260a9601367f4457634ed5c8	4 months ago
Kirill Solomko	e5d7232b63	MT#64891 enhance Redis connection handling ... * Catalyst::Plugin::NGCP::Redis changes - new function _connect_and_cache() that now contains the migrated connect & cache code returns the connection reference - new function _get_replication_role() that sends "INFO replication" command to the server and returns the role string back - new function _wait_for_master_role() that tries to wait 5 seconds for the server to return the 'master' role, with 1 second attempt intervals - rework redis_get_connection to obtain the connection inside try/catch and use _wait_for_master_role() after reconnect, as well as using it for the 'heartbeat' part to test dead connections instead of PING (so 1 command is sent in the end instead of 2). * With the redis_get_connection rework not only does it perform an automatic reconnect attempt if it detects a dead connection but it also waits until the server is 'master', which might happen during the db node switchovers, so API requests that happen during the switchover do not end up with errors "READ ONLY ROLE", and unless there is something persistently wrong on the server side, the reconnections/swithovers should be transparent now for the clients, with only probabaly 1-2 second delays on select API requests while the server is becoming the new 'master'. Change-Id: I41bf1f55a07b56e4fceef243f09f316694d62a39	4 months ago
Marco Capetta	079ae19306	MT#64627 Call sip_dispatcher_reload when peer transport is updated ... In case of update of the transport protocol used by the peer, the kamailio dispatcher module has to be reloaded because the probing. if enabled, has to be sent using the new protocol. Change-Id: Iab5fe2c63547068c3aca0e46e8862b025475d8f0	4 months ago
Sipwise Jenkins Builder	d152830633	TT#4166 I18N dump: snapshot 2026.04.02-22.20.09 ... Change-Id: I8fc1376c573054080cbfa2b04c862628b564c721	5 months ago
Sipwise Jenkins Builder	d302f95404	TT#4166 I18N dump: snapshot 2026.04.01-22.20.05 ... Change-Id: Ic01c9e43eb3cb5749e9a641a72334bdd35f719ec	5 months ago
Rene Krenn	a040dc4b46	MT#64788 mitigate CVE-2024-28344 ... check the target url host when redirecting after pressing a "back" form button. Change-Id: I03b424ec71f3ed985faf42087d1bf1dc6f2e4ff6	5 months ago
Kirill Solomko	8b288081f8	MT#62339 RedisLocationResultSet fix $filter assignment typo ... * fix $filter =// typo, should have been $filter =. Change-Id: I33e742cefc530406b736c72f3c9e325be9b84106	5 months ago
Kirill Solomko	d1280015c4	MT#62339 /api/subscriberregistrations add total_count support ... * Panel::Utils::RedisLocationResultSet: - add total_count() that returns total count of all entries without pagination - add total count aggregation during _find(), _row_from_mapkey(), _scan() that aggregates total entries that can be shown without pagination * SubscriberRegistrations: - return correct total_count of all possible entries that can be shown (without pagination) - fix a 500 error when 'subscriber_id' contains a non-existing subscriber Change-Id: I914356a809a005c21bb662498ca78dd35affc0ee	5 months ago
Sipwise Jenkins Builder	6194119c47	TT#4166 I18N dump: snapshot 2026.03.19-23.20.28 ... Change-Id: I4b9cdb356e3976ef483521d1f6a700fe4fafbf7a	5 months ago
Rene Krenn	8481c5adb7	MT#64761 prov templates: support contract-only mode ... provisioning templates basically work on subscriber level. this change introduces support for processing files with contract data only. Change-Id: I2f75aaf01e70b1348549c957ab68faf0d786bca9	5 months ago
Rene Krenn	47b5cc7b7b	MT#64594 prov templates: fraud preferences support ... this change introduces support to set contract fraud preferences via provisioning template, ie: fraud_preferences: fraud_interval_limit: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_limit : 10000; }" fraud_interval_lock: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_lock : 2; }" fraud_interval_notify: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_notify : 'jdoe@sipwise.com'; }" fraud_daily_limit: 500 fraud_daily_lock: 2 fraud_daily_notify: "jdoe@sipwise.com" Change-Id: Id7e67fd71e0b1d291ee5e2ea9e2ea9b6bae64781	5 months ago
Rene Krenn	03fec29b38	MT#64584 prov templates: contract_balance support ... this change introduces support to set balances via provisioning template, ie: contract_balance: cash_balance_code: function ( return 123; } free_time_balance: 456 Change-Id: I85d444b26c8f4d50ace39518f7c33c292b4afa0b	5 months ago
Rene Krenn	14caac386c	MT#62342 encode XMLRPC request body, decode XMLRPC response body ... prevent api 500 errors ie. from LibXML parsing because of invalid chars. Change-Id: I2630ba285e1da7bcbfe5558bad1b7c30fa86bebe	6 months ago
Kirill Solomko	81a4a2ff03	MT#64434 /api/platforminfo add multisite support ... * return multisite data if multi site is enabled, otherwise an empty hash. Change-Id: I46f4aa30fe7b31949cd471079d749d75d2f70f01	6 months ago
Sipwise Jenkins Builder	c5372820ee	TT#4166 I18N dump: snapshot 2026.02.10-23.20.18 ... Change-Id: Ic14fa0ae5d31ac634a79895b310e8aa0c43ab080	6 months ago
Guillem Jover	324279c850	MT#62763 Do not return undef, just return ... Rework return statements to be standalone instead of using high-precedence boolean operators. And just «return» which handles the call sites correctly depending on the context, instead of «return undef». Warned-by: perlcritic Fixes: Subroutines::ProhibitExplicitReturnUndef Change-Id: I05f9b6e26f0369448a6536ea2ef48b650ff56ad8	6 months ago
Kirill Solomko	12e8992a78	MT#64115 add peer multi site support ... * add peering server field 'site_id' that uses $c->config->{multisite} for a list of available sites, if multi site is enabled, otherwise the column is not visible via the UI but available regardless via the API Change-Id: I5e9ec64bcc80531022b6067b0c50b197ee25b952	6 months ago
Kirill Solomko	00b960814d	MT#64346 skip email dispatch without a dest email ... * when during email template sending invokation there is no target email, the process is correctly skipped. Change-Id: I810b258c9e623b75598fb5da9b98ff499a419c44	7 months ago
Kirill Solomko	224aec5fc8	MT#64232 improve check_subscriberadmin_write_access ... * subscriberadmin can now edit own data in scenarios where it's a SIP customer subscriber * add a check to that the edited subscriber belongs to the same customer Change-Id: I69a84c481be413ac5604c74856e760eee648b637	7 months ago
Kirill Solomko	c417cc622d	MT#64295 better handling of via_route empty string ... * transform via_route empty string into undef and store it as undef without validating it against SIP-URI Change-Id: Iefae7b26910201183ae3d049b3785a68dc81ce64	7 months ago
Kirill Solomko	a97490e97d	MT#64297 /api/platforminfo expose sip.external_sbc config ... * sip.external_sbc options are exposed to authenticated admin users in /api/platforminfo Change-Id: Ifea5eb43b8638299d1ef916c65a17fa18f833f82	7 months ago
Kirill Solomko	638b2f20ae	MT#64295 fix /api/peeringservers via_route validation ... * NGCP::Form::Peering::Server rework via_route URI check from a comma separated list to a single value as well as improve value transformation and validation logic * /api/peeringservers add via_route value transformation as pre_proccess_form_resource() Change-Id: I742a40534a4861dd30e0ccbc6684c02d2386f642	7 months ago
Kirill Solomko	c48355ca03	MT#64282 replace redirect with ajax_logout separation ... * a better way is to leave /logout as is and instead separate ajax_logout so that it's not chained from /logout anymore, resulting in 200 OK with empty application/json response, and without redirects by default Change-Id: Ide4f3845532e176e6866ebe61155e04d02aa3fbd	7 months ago
Kirill Solomko	4a1f5f4b28	MT#64282 add redirect=0 option to /ajax_logout ... * ajax_logout can now return 200 without further redirect when redirect=0 query param is provided Change-Id: I03f499e1090895c2fb382494dd4cc872427692f1	7 months ago
Kirill Solomko	41fb2d22cc	MT#64280 add ngcp_admin_ui_jwt realm and X-NGCP-Admin-UI header ... * ngcp_admin_ui_jwt is a copy of api_admin_jwt realm but with use_session: 1 * ngcp_admin_ui_jwt is used when X-NGCP-Admin-UI header is provided Change-Id: Ia82f97df922a69866f7c7d63ad1566ff0fc4bc2a	7 months ago
Rene Krenn	10df50468b	MT#64142 do not translate CF dropdown items ... names of CF destinationsets, sourcesets etc. are provided by the user and can therefore contain patterns that are then unintentionally interpreted by the perl Maketext Module, causing 500 errors as a consequence. translations are better disabled for the dropdown option items. Change-Id: I20fa5c5ad79f78f8d2f682ea54984e92997ec34c	7 months ago