When the reseller has a wrong contract assigned to
him, this contract is not shown because it has already
been filtered out in the Contract controller. In favor
of usability now show it anyway.
Also only present correct contracts on edit/create
resellers in the first place.
See (Mantis:3855#c25797)
Postcodes can be alphanumeric in certain countries.
Avoid fault when editing a contact without reseller
(e.g. reseller/peer contact). You still can't save it without
setting a reseller (which might not be what we want).
Now also handle alias numbers with the outsourced subroutine
update_subscriber_numbers.
Plus remove some leftovers which are already handled by
this sub.
Cherry-picked from master
Conflicts:
lib/NGCP/Panel/Controller/Subscriber.pm
lib/NGCP/Panel/Utils/Subscriber.pm
Actually use update_subscriber_numbers when updating a subscriber
and not only when creating one. Also handle all neccessary side effects.
Now we can switch our primary number to a number which has been
inactive (that is: did not belong to a subscriber) without an update error.
Cherry-picked from master
Conflicts:
lib/NGCP/Panel/Controller/Subscriber.pm
Outsource the handling of the primary number from
the subscriber controller to a util sub called
update_subscriber_numbers.
It also takes care to reuse a number that has
subscriber_id set to NULL which caused the original
problem in the ticket.
Cherry-picked from master
Conflicts:
lib/NGCP/Panel/Utils/Subscriber.pm
The preferences rewrite_rule_sets, ncos_levels, and sound_sets
on a domain should be restricted to ones, that have the same reseller
as the domain itself.
In addition we have to make sure, the preference view does not die,
if an invalid preference had already been selected, for example when
the respective *set/*level had been deleted or had been one, with a wrong
reseller, because of this bug, we just fixed.
Mantis: 4127
and provide a Modal showing the Detail of each.
Except the case when thedestination_set.name is called "quickset_*" and
it only has one entry.
In that case show the particular destinations of this destination set,
in order to not confuse a user who just configured a trivial cf via the simple view.
under Subscriber Preferences -> Call Forwards
Mantis: 3803, 3801
Our forms use a fixed width per default, for nice alignment of multiple
form field. This is not neccessary on single-field preference forms.
Mantis: 3827
when a preference with empty value is saved, this row was just
deleted from the db. This is not true for enums, because an empty string
is not always the default value. Therefore we only delete enum preferences
when their value matches the one of the enum, configured as default.
This can be checked, by setting the domain preference outbound_pai_user
to None, which resulted in wrong behaviour before.
Mantis: 3769
Andreas Granig
Gerhard Jungwirth
Andrew Pogrebennyk
Lars Dieckow