From fec56340b52523fe1fa81858883f1b3134ebb57d Mon Sep 17 00:00:00 2001
From: Andreas Granig <agranig@sipwise.com>
Date: Mon, 18 Nov 2013 23:02:49 +0100
Subject: [PATCH] MT#4967 Filter system information for subs-roles

Don't display internal information to subscribers and subscriberadmins.

WIP, as subscriberadmins can now add/change numbers, set lock/status.
---
 share/templates/customer/details.tt  |  6 ++++-
 share/templates/subscriber/master.tt | 36 +++++++++++++++-------------
 2 files changed, 25 insertions(+), 17 deletions(-)

diff --git a/share/templates/customer/details.tt b/share/templates/customer/details.tt
index 705eb0f1ca..d234c37779 100644
--- a/share/templates/customer/details.tt
+++ b/share/templates/customer/details.tt
@@ -1,4 +1,8 @@
-[% site_config.title = 'Customer Details for #' _ contract.id _ " (" _ product.name _ ")" -%]
+[% IF c.user.roles == "subscriber" || c.user.roles == "subscriberadmin" -%]
+    [% site_config.title = 'Customer Details' -%]
+[% ELSE -%]
+    [% site_config.title = 'Customer Details for #' _ contract.id _ " (" _ product.name _ ")" -%]
+[% END -%]
 
 [%
     lock_levels = [
diff --git a/share/templates/subscriber/master.tt b/share/templates/subscriber/master.tt
index 8ed3d72110..843930f185 100644
--- a/share/templates/subscriber/master.tt
+++ b/share/templates/subscriber/master.tt
@@ -44,25 +44,33 @@
                         </tr>
                     </thead>
                     <tbody>
+                        [% IF c.user.roles == "admin" || c.user.roles == "reseller" -%]
                         <tr class="sw_action_row">
                             <td>Customer #</td>
                             <td>[% subscriber.contract.id %]</td>
                         </tr>
+                        [% END -%]
                         [% 
-                            elements = [
-                                { value = subscriber.status, desc = 'Status'},
-                                { value = subscriber.provisioning_voip_subscriber.webusername, desc = 'Web Username'},
-                                { value = subscriber.provisioning_voip_subscriber.webpassword, desc = 'Web Password'},
-                                { value = subscriber.username _ '@' _ subscriber.domain.domain, desc = 'SIP URI'},
-                                { value = subscriber.primary_number.cc _ ' ' _ subscriber.primary_number.ac _ ' ' _ subscriber.primary_number.sn, desc = 'Primary Number'},
-                                { value = subscriber.provisioning_voip_subscriber.admin ? 'yes' : 'no', desc = 'Administrative'},
-                                { value = subscriber.external_id, desc = 'External #'},
-                            ];
+                            elements = [];
+
+                            elements.push({ value = subscriber.status, desc = 'Status'});
+                            elements.push({ value = subscriber.provisioning_voip_subscriber.webusername, desc = 'Web Username'});
+                            IF (c.user.roles == "admin" || c.user.roles == "reseller") && c.user.show_passwords;
+                            elements.push({ value = subscriber.provisioning_voip_subscriber.webpassword, desc = 'Web Password'});
+                            END;
+                            elements.push({ value = subscriber.username _ '@' _ subscriber.domain.domain, desc = 'SIP URI'});
+                            IF (c.user.roles == "admin" || c.user.roles == "reseller") && c.user.show_passwords;
+                            elements.push({ value = subscriber.provisioning_voip_subscriber.webpassword, desc = 'SIP Password'});
+                            END;
                             IF subscriber.provisioning_voip_subscriber.voip_pbx_group.defined;
-                                elements.push(
-                                    { value = subscriber.provisioning_voip_subscriber.voip_pbx_group.name, desc = 'PBX Group' },
-                                );
+                            elements.push({ value = subscriber.provisioning_voip_subscriber.voip_pbx_group.name, desc = 'PBX Group' });
                             END;
+                            IF c.user.roles == "admin" || c.user.roles == "reseller";
+                            elements.push({ value = subscriber.provisioning_voip_subscriber.admin ? 'yes' : 'no', desc = 'Administrative'});
+                            elements.push({ value = subscriber.external_id, desc = 'External #'});
+                            elements.push({ value = subscriber.uuid, desc = 'UUID'});
+                            END;
+                            elements.push({ value = subscriber.primary_number.cc _ ' ' _ subscriber.primary_number.ac _ ' ' _ subscriber.primary_number.sn, desc = 'Primary Number'});
 
                         -%]
                         [% FOR elem IN elements -%]
@@ -71,10 +79,6 @@
                                 <td>[% elem.value %]</td>
                             </tr>
                         [% END -%]
-                        <tr>
-                            <td>UUID</td>
-                            <td>[% subscriber.uuid %]</td>
-                        </tr>
                         <tr>
                             <td>Alias Numbers</td>
                             <td>